From 77490477382926fd1e704e0ee414e22e59560183 Mon Sep 17 00:00:00 2001 From: Emmanuel Date: Mon, 28 Aug 2017 18:17:39 -0300 Subject: [PATCH 1/3] Moved AppConfig to utils.application --- app/src/main/AndroidManifest.xml | 2 +- .../java/com/amaze/filemanager/activities/BasicActivity.java | 2 +- .../main/java/com/amaze/filemanager/filesystem/FileUtil.java | 2 +- .../java/com/amaze/filemanager/fragments/MainFragment.java | 3 +-- .../fragments/preference_fragments/FoldersPref.java | 2 +- .../java/com/amaze/filemanager/services/ExtractService.java | 2 +- .../com/amaze/filemanager/services/asynctasks/MoveFiles.java | 2 +- app/src/main/java/com/amaze/filemanager/utils/DataUtils.java | 1 + .../amaze/filemanager/utils/{ => application}/AppConfig.java | 3 ++- .../main/java/com/amaze/filemanager/utils/files/CryptUtil.java | 3 --- .../com/amaze/filemanager/utils/files/GenericCopyUtil.java | 3 +-- .../java/com/amaze/filemanager/activities/MainActivity.java | 2 +- 12 files changed, 12 insertions(+), 15 deletions(-) rename app/src/main/java/com/amaze/filemanager/utils/{ => application}/AppConfig.java (98%) diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index 9145cfdbc..974e49f2c 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -45,7 +45,7 @@ android:required="false" /> Date: Mon, 28 Aug 2017 18:18:48 -0300 Subject: [PATCH 2/3] Added LeakCanary to track memory leaks --- app/build.gradle | 4 +++ .../utils/application/AppConfig.java | 4 +-- .../application/LeakCanaryApplication.java | 25 +++++++++++++++++++ 3 files changed, 31 insertions(+), 2 deletions(-) create mode 100644 app/src/main/java/com/amaze/filemanager/utils/application/LeakCanaryApplication.java diff --git a/app/build.gradle b/app/build.gradle index 4edad9d98..c4309bd03 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -68,6 +68,10 @@ dependencies { compile 'com.android.support:palette-v7:25.3.1' compile 'com.android.support:cardview-v7:25.3.1' + //Detect memory leaks + debugCompile 'com.squareup.leakcanary:leakcanary-android:1.5.1' + releaseCompile 'com.squareup.leakcanary:leakcanary-android-no-op:1.5.1' + compile 'org.apache.commons:commons-compress:1.10' // Google Play Services diff --git a/app/src/main/java/com/amaze/filemanager/utils/application/AppConfig.java b/app/src/main/java/com/amaze/filemanager/utils/application/AppConfig.java index 038920a51..2976692f1 100644 --- a/app/src/main/java/com/amaze/filemanager/utils/application/AppConfig.java +++ b/app/src/main/java/com/amaze/filemanager/utils/application/AppConfig.java @@ -18,10 +18,10 @@ import com.android.volley.toolbox.ImageLoader; import com.android.volley.toolbox.Volley; /** - * Created by vishal on 7/12/16. + * Created by vishal on 7/12/16 edited by Emmanuel Messulam */ -public class AppConfig extends Application { +public class AppConfig extends LeakCanaryApplication { public static final String TAG = AppConfig.class.getSimpleName(); diff --git a/app/src/main/java/com/amaze/filemanager/utils/application/LeakCanaryApplication.java b/app/src/main/java/com/amaze/filemanager/utils/application/LeakCanaryApplication.java new file mode 100644 index 000000000..97034e69e --- /dev/null +++ b/app/src/main/java/com/amaze/filemanager/utils/application/LeakCanaryApplication.java @@ -0,0 +1,25 @@ +package com.amaze.filemanager.utils.application; + +import android.app.Application; + +import com.squareup.leakcanary.LeakCanary; + +/** + * @author Emmanuel + * on 28/8/2017, at 18:12. + */ + +public class LeakCanaryApplication extends Application { + + @Override + public void onCreate() { + super.onCreate(); + if (LeakCanary.isInAnalyzerProcess(this)) { + // This process is dedicated to LeakCanary for heap analysis. + // You should not init your app in this process. + return; + } + LeakCanary.install(this); + } + +} \ No newline at end of file From 5d4b5788b805631fe5d63868a6417863187de753 Mon Sep 17 00:00:00 2001 From: Emmanuel Date: Mon, 28 Aug 2017 23:00:24 -0300 Subject: [PATCH 3/3] Travis jumbo crash solution --- app/build.gradle | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/build.gradle b/app/build.gradle index c4309bd03..130372414 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -4,6 +4,10 @@ android { compileSdkVersion 25 buildToolsVersion '25.0.3' + dexOptions { + jumboMode = true + } + packagingOptions { exclude 'proguard-project.txt' exclude 'project.properties'