mirror of
https://github.com/Evil0ctal/Douyin_TikTok_Download_API.git
synced 2026-10-22 00:17:53 +08:00
Evil0ctal
33a02ba71d
CI caught the default flip: test_dangerous_defaults_are_off asserted system.check_updates is False, alongside the SSRF allowlist, the task webhook and the CORS origins. Those three belong together and this one never did. They decide what *this server* will connect to or accept on a caller's behalf, and off is the only safe default for each. The update check is a fetch the operator's own browser makes to github.com while they have the console open — it is not server-side attack surface, and no amount of turning it on makes the server talk to anyone. So rather than deleting the line, the property it was standing in for is now asserted directly: no Python in src/dtk reaches GitHub through an HTTP client. That is the thing that made "off by default" feel necessary, it is what keeps the check defensible now that it is on, and a server-side release check will fail this test before anyone has to catch it in review. Verified by injecting one: the test names the file and the marker.