From 628367e63cdfb4d0bfd045da7225388b247bed78 Mon Sep 17 00:00:00 2001 From: pollyzhang Date: Mon, 20 Feb 2023 09:30:43 +0800 Subject: [PATCH] feat(core): remove default HeapLimitSlowGrowthStrategy --- android/sdk/src/main/jni/src/bridge/entry.cc | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/android/sdk/src/main/jni/src/bridge/entry.cc b/android/sdk/src/main/jni/src/bridge/entry.cc index 5b166d753..afe57b0c9 100644 --- a/android/sdk/src/main/jni/src/bridge/entry.cc +++ b/android/sdk/src/main/jni/src/bridge/entry.cc @@ -94,13 +94,6 @@ using V8VMInitParam = hippy::napi::V8VMInitParam; using V8InspectorClientImpl = hippy::inspector::V8InspectorClientImpl; #endif -#ifndef DEFAULT_INITIAL_HEAP_SIZE_IN_BYTES -#define DEFAULT_INITIAL_HEAP_SIZE_IN_BYTES 0 -#endif -#ifndef DEFAULT_MAX_HEAP_SIZE_IN_BYTES -#define DEFAULT_MAX_HEAP_SIZE_IN_BYTES (10 * hippy::base::MB); -#endif - constexpr char kLogTag[] = "native"; static std::unordered_map, uint32_t>> @@ -542,17 +535,6 @@ jlong InitInstance(JNIEnv* j_env, param->maximum_heap_size_in_bytes = hippy::base::checked_numeric_cast(maximum_heap_size_in_bytes); TDF_BASE_CHECK(param->initial_heap_size_in_bytes <= param->maximum_heap_size_in_bytes); -#ifndef V8_WITHOUT_INSPECTOR - } else if (!runtime->IsDebug()) { - // When V8 inspector enable the js debugger, `near_heap_limit_callback` will be overridden, - // so if in debug mode, should not set heap limit via `V8VMInitParam` -#else - } else { -#endif - param = std::make_shared(); - param->initial_heap_size_in_bytes = DEFAULT_INITIAL_HEAP_SIZE_IN_BYTES; - param->maximum_heap_size_in_bytes = DEFAULT_MAX_HEAP_SIZE_IN_BYTES; - param->near_heap_limit_callback = V8VMInitParam::HeapLimitSlowGrowthStrategy; } } while (false);