From c095855b10dd94bf6bcefa0200d736e6d20552af Mon Sep 17 00:00:00 2001 From: maxli Date: Tue, 26 Nov 2024 17:08:14 +0800 Subject: [PATCH] fix(android): update custom createVirtualNode arguments --- .../com/tencent/mtt/hippy/uimanager/ControllerManager.java | 5 +++-- .../com/tencent/mtt/hippy/uimanager/HippyViewController.java | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/renderer/native/android/src/main/java/com/tencent/mtt/hippy/uimanager/ControllerManager.java b/renderer/native/android/src/main/java/com/tencent/mtt/hippy/uimanager/ControllerManager.java index 7f42e845d..c30123a17 100644 --- a/renderer/native/android/src/main/java/com/tencent/mtt/hippy/uimanager/ControllerManager.java +++ b/renderer/native/android/src/main/java/com/tencent/mtt/hippy/uimanager/ControllerManager.java @@ -442,8 +442,9 @@ public class ControllerManager { @NonNull String className, @Nullable Map props) { HippyViewController controller = mControllerRegistry.getViewController(className); - if (controller != null) { - return controller.createVirtualNode(rootId, id, pid, index, props); + Renderer renderer = mRendererWeakRef.get(); + if (controller != null && renderer instanceof NativeRender) { + return controller.createVirtualNode(rootId, id, pid, index, props, (NativeRender) renderer); } return null; } diff --git a/renderer/native/android/src/main/java/com/tencent/mtt/hippy/uimanager/HippyViewController.java b/renderer/native/android/src/main/java/com/tencent/mtt/hippy/uimanager/HippyViewController.java index be449deac..505647035 100644 --- a/renderer/native/android/src/main/java/com/tencent/mtt/hippy/uimanager/HippyViewController.java +++ b/renderer/native/android/src/main/java/com/tencent/mtt/hippy/uimanager/HippyViewController.java @@ -400,7 +400,7 @@ public abstract class HippyViewController implem @SuppressWarnings("unused") @Nullable public VirtualNode createVirtualNode(int rootId, int id, int pid, int index, - @Nullable Map props) { + @Nullable Map props, @NonNull NativeRender nativeRender) { // The host can create customize virtual node in a derived class. return null; }