2 Commits

Author	SHA1	Message	Date
Marc Schier	a81d981755	dotnet format sweep (whitespace, IDE, RCS) + code-style enforcer agent fix (#3865) ... # Description Pure code-style sweep across the repo — no behavioral changes. Drives `dotnet format` info-level diagnostics down on a large slice of the codebase (Stack, Libraries, Tests, Tools). Six commits, applied bottom-up in safety order so each batch leaves the build green: 1. **`style: fix whitespace and final-newline formatting (WHITESPACE, FINALNEWLINE)`** 197 hits across ~30 files; pure mechanical cleanup. 2. **`style: apply dotnet format style fixes (IDE rules)`** IDE-rule batch via `dotnet format style --severity info` — `var`/explicit type, simplify names, collection expressions, expression bodies, unused usings, etc. 3. **`style: apply dotnet format analyzers fixes (RCS blank-line formatting)`** Roslynator formatting (RCS0xxx) blank-line and punctuation rules. 4. **`style: convert comments to doc comments and inline local vars (RCS1181, RCS1124)`** 24 files. RCS1181 promotes `// summary`-style comments above public/internal members to `/// <summary>` doc comments; RCS1124 inlines locals used exactly once. Generated `Tools/` files were reverted to keep the source-generator outputs deterministic. 5. **`docs(agent): correct --diagnostics flag form and verify Roslynator 4.x code fixers`** Updates `.github/agents/opc-ua-codestyle-enforcer.agent.md` with two corrections discovered while running this sweep: - `dotnet format --diagnostics "RULE1 RULE2"` (single quoted, space-separated) silently fixes nothing on `dotnet format` 10.x — it parses as one unknown ID and exits 0. The correct form is `--diagnostics RULE1 --diagnostics RULE2 …`, repeated per rule. - Roslynator 4.15.0 **does** ship code fixers for RCS1078/1118/1124/1140/1142/1181/1221/1260 (the previous "no auto-fixer" list was outdated). RCS1140/1142 default to `Hidden` so need `--severity info` to surface and fire; RCS1078 requires `roslynator_empty_string_style = field` (already set in `.editorconfig`). Only NUnit4002/2046/2010 genuinely lack auto-fixers in this stack. 6. **`style: format new code from master merge (dotnet format sweep)`** After merging master into the branch (commit `e3ebc8742`), re-ran the same three-phase format sweep on the 151 .cs files brought in by the merge, scoped per project via repeated `--include`. 81 files changed; same rule families as commits 1–4. - Hand-fixed `Tests/Opc.Ua.MigrationAnalyzer.Tests/AnalyzerHarness.cs` for `RCS1174` (redundant `async`/`await` removal) because the auto-fixer didn't apply for that specific case. - Reverted files that the formatter would break: - `Libraries/Opc.Ua.Server/Server/ServerInternalData.cs` — multi-TFM analysis disagreement injected `<<<<<<<` / `=======` / `>>>>>>>` markers. - `Tools/Opc.Ua.MigrationAnalyzer.Core/{Core/Stack/Client/ChannelBase.cs, Core/Stack/Types/IUserIdentityTokenHandler.cs, Client/Session/Session.cs}` — IDE0005 removed `using Opc.Ua.Security.Certificates` that IS used (the files are 1.5.378 reference fixtures for the analyzer). - `Tests/Opc.Ua.Gds.Tests/PushTest.cs` — IDE0002 over-simplified `OpcUa.ObjectTypeIds` to `ObjectTypeIds`, which then resolves to a conflicting type. ### What this PR does **not** touch - No behavioral or semantic logic changes. - No `.editorconfig` rule promotions (rules stay at their current severities; this is a backlog-burndown pass, not a rule tightening). - Generated source under `Tools/` is intentionally excluded. - Higher-risk rule families (`RCS1090`/`CA2007` `ConfigureAwait`, `RCS1249` null-forgiving cleanup, `IDE0270`/`IDE0059`) are left for follow-up sweeps because they need per-TFM build verification or semantic review. ## Related Issues _No tracking issue — this is a non-functional style sweep and the agent-doc correction is a follow-up to the same work. Happy to open one if the maintainers prefer._ ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [x] I have added tests that prove my fix is effective or that my feature works and increased code coverage. _(N/A — style-only, no behavioral change)_ - [x] I have added all necessary documentation. _(agent doc updated with the two corrections)_ - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. _(verified clean on `net10.0` and `net48`; only pre-existing `NETSDK1005`/`NETSDK1207` failures on Tools/AOT projects)_ - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. _(build verified on net10 and net48 per batch; full test suite not yet run locally — relying on CI)_ - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. --------- Co-authored-by: agent <agent@local>	2026-06-10 08:35:44 +02:00
Marc Schier	49305d9085	V2 subscription engine close gap for test and feature parity with classic engine (#3824) ... # Description V2 subscription engine feature parity round to make the classic engine eligible for deprecation. Splits the test surface so the classic and V2 engines can evolve independently, ports the gaps the classic-engine integration tests had been exercising, and lands the public V2 API additions needed to close them. - Splits `Tests/Opc.Ua.Subscriptions.Tests` into a classic (`Opc.Ua.Subscriptions.Classic.Tests`) and a V2 (`Opc.Ua.Subscriptions.Tests`) project to shrink CI time and let the two engines diverge cleanly. - Adds the V2 public-surface gaps required by the test ports (`Subscription.ServerId` on the class, `SetSubscriptionDurableAsync`, `SendInitialValuesOnTransfer`, unified `OnSubscriptionStateChangedAsync` handler callback, per-item `ConditionRefreshAsync`, fluent `LoadSubscriptionsAsync(Stream, …)` and `Subscription.Snapshot()` / `RestoreAsync()` for save/load + transfer). - Lands handler-centric design (no `PublishingStopped` property handlers maintain derived state); always-sequential per-subscription delivery documented + tested. - **Adds short and long haul stability tests for the V2 `ManagedSession` + subscription engine. Closes #3744** (see "Issue #3744 Haul tests" below). - **Migrates SubscriptionStateSnapshot / MonitoredItemStateSnapshot to `[DataType]` source-generator codecs**. - `SubscriptionDurableV2Tests.cs` 5 V2 ports of the classic durable test patterns. - `V2FollowUpCoverageTests.cs` handler state-change callback, fluent stream-based `LoadSubscriptionsAsync`, `SendInitialValuesOnTransfer`, snapshot edge cases (empty / `DataChangeFilter` round-trip / concurrent mutation). - `SubscriptionFailoverV2Tests.cs` forced channel-break with and without `WithTransferSubscriptionsOnRecreate`. - `MonitoredItemConditionRefreshLiveV2Tests.cs` — live `ConditionRefresh` against the reference server's event source; asserts `RefreshStart` / `RefreshEnd` events flow through the handler. ## Fixes - #3744 Haul tests (V2 ManagedSession + subscription engine) `Tests/Opc.Ua.Sessions.Tests/ManagedSessionStabilityTest.cs` adds the short/long haul coverage requested by [#3744](https://github.com/OPCFoundation/UA-.NETStandard/issues/3744) plus the bonus fault-injection variant: | Test | Duration | Category | Purpose | |---|---|---|---| | `ShortHaulManagedSessionV2Async` | 2 minutes | `ManagedSessionHaul` (`[Explicit]`) | Quick local sanity check of the V2 monotonicity contract. | | `LongHaulManagedSessionV2Async` | 90 minutes (configurable via `TEST_DURATION_MINUTES`) | `ManagedSessionHaul` (`[Explicit]`) | Long-running V2 stability + monotonicity. | | `LongHaulManagedSessionWithFaultInjectionV2Async` | 90 minutes (configurable) + fault every `FAULT_INJECTION_INTERVAL_SECONDS` (default 60s) | `ManagedSessionHaul` (`[Explicit]`) | **Bonus** — force-closes the subscriber transport channel periodically; verifies V2 manager transfers/recreates the subscription and continues monotonic delivery across reconnects. | **Pattern.** A writer `ManagedSession` increments a `uint32` counter and writes it into `Scalar_Static_Mass_UInt32_UInt32_00` every 250ms. A subscriber `ManagedSession` runs a V2 subscription with a single monitored item on the same node. `MonotonicCounterHandler` asserts each received sample is *strictly greater than* the previous one. V2 `ISubscriptionNotificationHandler` per-subscription ordering guarantee. Skipped values (sampling rate < write rate) are tolerated; duplicates and reorderings are violations.	2026-06-03 04:39:08 +02:00