2 Commits

Include renames

Author	SHA1	Message	Date
Marc Schier	cf6bd37360	Address PR feedback: small-scope cleanup ... Applies the safe / minor review feedback on PR #3852. Larger refactors are scoped into a separate plan posted on the PR for explicit approval before starting (merge ClientChannelManager partials, merge Channels.Stress into Opc.Ua.Stress.Tests, move ClientChannelManagerManagedTests out of Core.Tests, implement the ignored exhaustion-recovery integration test, fix remaining CA2007 / CA1861 / CA5394 / CA2025 warnings without NoWarn). Changes in this commit: - .github/workflows/buildandtest.yml: drop "legacy" wording from the EXCLUDE comment (Stress suite is opt-in, not legacy). - Applications/ConsoleReferenceClient/UAClient.cs + Applications/ConsoleReferenceClient/ClientSamples.cs: replace Action<IList, IList>? validateResponse with Action<Array, Array>? to (1) remove the System.Collections import that 36d67b3d had dropped and (2) match what the call sites already pass (T[] arrays). - Stack/Opc.Ua.Core/Stack/Client/ClientBase.cs: remove the pragma warning disable CS0809 around AttachChannel/DetachChannel (both interface and impl are [Obsolete] so the warning does not fire). - Tests/Opc.Ua.Channels.Stress.Tests/*/.gitkeep: delete the seven per-folder .gitkeep marker files; every folder now has content. - Tests/Opc.Ua.Channels.Stress.Tests/Opc.Ua.Channels.Stress.Tests.csproj: drop SuppressTfmSupportBuildWarnings and per-ProjectReference AdditionalProperties=SuppressTfmSupportBuildWarnings=true (TFMs restricted to net8/net9/net10 which fully support all Microsoft.Extensions.* packages). Drop project-specific NoWarn extras (CA2007;CA2000;CA2016;CA2025;CA5394;CA1861;CS1591), keep only the common test-project NoWarn that matches Opc.Ua.Stress.Tests etc. Restore Nullable=annotations to match the established test convention. - Tests/Opc.Ua.Channels.Stress.Tests/Helpers/WaitForQuiescence.cs: add ! null-forgiving on the TryFindDiagnostic out parameter. - 17 test files (Channels.Stress, Client.Tests, Core.Tests/Stack/Client, Sessions.Tests): move pragma warning disable directives below the using statements per the convention noted in the review. Verified locally: Channels.Stress.Tests, Sessions.Tests, Client.Tests, Core.Tests all build with 0 errors on net10.0.	2026-06-06 12:32:41 +02:00
Marc Schier	36d67b3d3a	[Client] Central channel manager with shared, ref-counted transport channels (#3288) ... Introduces `IClientChannelManager` as the central registry for client-side transport channels. Sessions and discovery clients now share ref-counted managed channels per (endpoint, reverse-connect identity); reconnect is coalesced and notified to attached participants via a new `IReconnectParticipant` callback interface; service calls are gated by a three-state lifecycle (`TransportReconnecting` -> `TransportConnectedSessionReactivating` -> `Ready`) until reactivation completes. New types in `Stack/Opc.Ua.Core/Stack/Client/`: - `ManagedChannelKey`, `ChannelState`, `ChannelStateChange`, `ParticipantReconnectResult` - `IReconnectParticipant`, `IManagedTransportChannel`, `IClientChannelManager` - `IChannelReconnectPolicy` + `ExponentialBackoffChannelReconnectPolicy` - `IRetryBudget` + `RetryBudget` (shared retry deadline across the two layers) - `ClientChannelManager.Managed/Entry/Lease/Metrics/Diagnostics/CertRotation.cs` partials with refcount, coalesced reconnect, IMeter instruments, ActivitySource + EventSource, and automatic ReconnectAllAsync on certificate rotation. Session integration (Libraries/Opc.Ua.Client): - `Session.CreateAsync(IClientChannelManager, ...)` overload constructs a Session that shares its channel with co-located participants. - `Session` implements `IReconnectParticipant`; reactivation handler distinguishes Reactivated / RequiresSessionRecreate / TransientFailure / FatalForParticipant / FatalForChannel. - `Session.ReconnectAsync(ct)` automatically delegates to the channel manager when wired. - `Session.RecreateInPlaceAsync` swaps managed-channel leases for failover-to-different-endpoint; same-key recreates delegate to manager reconnect; explicit channel/connection callers retain legacy behavior. - KA failure routes through `IClientChannelManager.ReconnectAsync(channel)`. ManagedSession integration: - `WithChannelManager(...)` builder + ctor param. - Two-level retry: channel-mgr handles transparent reconnect; outer `ConnectionStateMachine` + `IReconnectPolicy` only triggers on terminal channel `Faulted`. Outer-state churn suppressed during channel-mgr cycles via `_channelReconnectInProgress` flag wired through `IManagedTransportChannel.StateChanged`. - New `ManagedSession.ChannelStateChanged` event surfaces transparent reconnects to UI / health dashboards. - `ConnectionStateChangedEventArgs.UnderlyingChannelState` populated when outer reconnect was triggered by a channel fault. - Shared `IRetryBudget` propagated to channel-mgr so the two layers enforce a single max-total-time instead of compounding multiplicatively. Discovery/Registration/GDS: - Channel-manager-aware `CreateAsync` overloads on `DiscoveryClient`, `RegistrationClient`, `ServerPushConfigurationClient`, `LocalDiscoveryServerClient`, `GlobalDiscoveryServerClient`. Each registers a minimal `IReconnectParticipant`; co-located sessions and discovery probes targeting the same endpoint share a channel. HTTPS transport (`Stack/Opc.Ua.Bindings.Https/`): - New `IOpcUaHttpClientFactory` abstraction. - HTTPS / OPC-HTTPS channels migrated to `IHttpClientFactory` + `Microsoft.Extensions.Http.Resilience` (10.6.0, AOT-compatible on net10 via source generators; legacy direct-HTTP path retained for older TFMs / no-DI consumers). DI: - `AddOpcUa().AddClient(...)` registers `IClientChannelManager` and the named HTTPS HttpClient + standard resilience handler automatically. - `ManagedSessionBuilder` resolves the manager from DI when present. Obsoletions (functional, `[Obsolete]` with guidance): - `IClientBase.AttachChannel`/`DetachChannel` - `SessionReconnectHandler` - `SessionExtensions.ReconnectAsync(connection, ct)` and `(channel, ct)` legacy overloads Tests (~70 new unit + 4 live-server integration fixtures): - Core: `ClientChannelManagerManagedTests`, `ClientChannelManagerCertRotationTests`, `RetryBudgetTests`, `OpcUaHttpClientFactoryTests` (56/56 pass). - Client: `ManagedSession*Tests` updated (129/129 pass) + back-compat suites pass with `#pragma warning disable CS0618`. - Sessions integration: `ChannelManagerSharing/TransparentReconnect/SessionLifecycle/CertRotation` (6 pass, 2 skipped with documented blockers for faulted-entry reset and RequiresSessionRecreate end-to-end plumbing). Builds clean (0 warnings / 0 errors) across all six TFMs (net472, net48, netstandard2.1, net8.0, net9.0, net10.0). Docs: - `Docs/Sessions.md` new section 4 documents the channel manager, three-state gating, two-level retry with shared `IRetryBudget`, and HTTPS resilience layering. - `Docs/MigrationGuide.md` migration recipes for the four obsoleted API groups. - `Docs/DependencyInjection.md` channel-manager and HTTPS factory registration.	2026-06-05 15:37:23 +02:00