2 Commits

Author	SHA1	Message	Date
Marc Schier	a81d981755	dotnet format sweep (whitespace, IDE, RCS) + code-style enforcer agent fix (#3865) ... # Description Pure code-style sweep across the repo — no behavioral changes. Drives `dotnet format` info-level diagnostics down on a large slice of the codebase (Stack, Libraries, Tests, Tools). Six commits, applied bottom-up in safety order so each batch leaves the build green: 1. **`style: fix whitespace and final-newline formatting (WHITESPACE, FINALNEWLINE)`** 197 hits across ~30 files; pure mechanical cleanup. 2. **`style: apply dotnet format style fixes (IDE rules)`** IDE-rule batch via `dotnet format style --severity info` — `var`/explicit type, simplify names, collection expressions, expression bodies, unused usings, etc. 3. **`style: apply dotnet format analyzers fixes (RCS blank-line formatting)`** Roslynator formatting (RCS0xxx) blank-line and punctuation rules. 4. **`style: convert comments to doc comments and inline local vars (RCS1181, RCS1124)`** 24 files. RCS1181 promotes `// summary`-style comments above public/internal members to `/// <summary>` doc comments; RCS1124 inlines locals used exactly once. Generated `Tools/` files were reverted to keep the source-generator outputs deterministic. 5. **`docs(agent): correct --diagnostics flag form and verify Roslynator 4.x code fixers`** Updates `.github/agents/opc-ua-codestyle-enforcer.agent.md` with two corrections discovered while running this sweep: - `dotnet format --diagnostics "RULE1 RULE2"` (single quoted, space-separated) silently fixes nothing on `dotnet format` 10.x — it parses as one unknown ID and exits 0. The correct form is `--diagnostics RULE1 --diagnostics RULE2 …`, repeated per rule. - Roslynator 4.15.0 **does** ship code fixers for RCS1078/1118/1124/1140/1142/1181/1221/1260 (the previous "no auto-fixer" list was outdated). RCS1140/1142 default to `Hidden` so need `--severity info` to surface and fire; RCS1078 requires `roslynator_empty_string_style = field` (already set in `.editorconfig`). Only NUnit4002/2046/2010 genuinely lack auto-fixers in this stack. 6. **`style: format new code from master merge (dotnet format sweep)`** After merging master into the branch (commit `e3ebc8742`), re-ran the same three-phase format sweep on the 151 .cs files brought in by the merge, scoped per project via repeated `--include`. 81 files changed; same rule families as commits 1–4. - Hand-fixed `Tests/Opc.Ua.MigrationAnalyzer.Tests/AnalyzerHarness.cs` for `RCS1174` (redundant `async`/`await` removal) because the auto-fixer didn't apply for that specific case. - Reverted files that the formatter would break: - `Libraries/Opc.Ua.Server/Server/ServerInternalData.cs` — multi-TFM analysis disagreement injected `<<<<<<<` / `=======` / `>>>>>>>` markers. - `Tools/Opc.Ua.MigrationAnalyzer.Core/{Core/Stack/Client/ChannelBase.cs, Core/Stack/Types/IUserIdentityTokenHandler.cs, Client/Session/Session.cs}` — IDE0005 removed `using Opc.Ua.Security.Certificates` that IS used (the files are 1.5.378 reference fixtures for the analyzer). - `Tests/Opc.Ua.Gds.Tests/PushTest.cs` — IDE0002 over-simplified `OpcUa.ObjectTypeIds` to `ObjectTypeIds`, which then resolves to a conflicting type. ### What this PR does **not** touch - No behavioral or semantic logic changes. - No `.editorconfig` rule promotions (rules stay at their current severities; this is a backlog-burndown pass, not a rule tightening). - Generated source under `Tools/` is intentionally excluded. - Higher-risk rule families (`RCS1090`/`CA2007` `ConfigureAwait`, `RCS1249` null-forgiving cleanup, `IDE0270`/`IDE0059`) are left for follow-up sweeps because they need per-TFM build verification or semantic review. ## Related Issues _No tracking issue — this is a non-functional style sweep and the agent-doc correction is a follow-up to the same work. Happy to open one if the maintainers prefer._ ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [x] I have added tests that prove my fix is effective or that my feature works and increased code coverage. _(N/A — style-only, no behavioral change)_ - [x] I have added all necessary documentation. _(agent doc updated with the two corrections)_ - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. _(verified clean on `net10.0` and `net48`; only pre-existing `NETSDK1005`/`NETSDK1207` failures on Tools/AOT projects)_ - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. _(build verified on net10 and net48 per batch; full test suite not yet run locally — relying on CI)_ - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. --------- Co-authored-by: agent <agent@local>	2026-06-10 08:35:44 +02:00
Marc Schier	81b3c9b371	[Server] Implement NodeManagement service set and fix DeleteAddressSpace (#3839) ... # Description Adds the OPC UA NodeManagement service set (AddNodes / DeleteNodes / AddReferences / DeleteReferences) to the server SDK and fixes a long-standing shutdown bug where `NodeState.Delete` callbacks never fired on address-space teardown. ### NodeManagement service set (#3736) - New optional `INodeManagementAsyncNodeManager` facet interface (added to `INodeManager.cs` alongside other facets, discovered via `as`, **not** part of the `IAsyncNodeManager` composite). Opt-in per NodeManager via `AllowNodeManagement` — default is `false` so existing NodeManagers preserve binary compatibility. - Dispatcher in `MasterNodeManager` routes: - **AddNodes** by `RequestedNewNodeId.NamespaceIndex` when supplied, otherwise to the parent's owning NodeManager. When the parent's owner is read-only (e.g. `ObjectsFolder` owned by `CoreNodeManager`), the dispatcher falls back to the first opted-in NodeManager so conformance flows work out of the box. - **DeleteNodes** / **AddReferences** / **DeleteReferences** to the owning NodeManager of the target or source node, returning `BadUserAccessDenied` when that NodeManager has not opted in. Cross-NodeManager `AddReference` / `DeleteReference` best-effort mirrors the inverse edge on the target's NodeManager. - `AsyncCustomNodeManager` provides a default implementation: per-item validation, `RequestedNewNodeId` honored, browse-name dedup for both local and cross-NodeManager parents, `DeleteTargetReferences` semantics, and a NodeId allocator fallback when an `INodeIdFactory.New` override returns a null `NodeId` (e.g. parent-based hierarchical naming with no parent attached). - `StandardServer` adds the four service overrides plumbed through `OperationLimits.MaxNodesPerNodeManagement`, audit events, and `OnRequestComplete`; new `ReportAuditAddReferencesEvent` / `ReportAuditDeleteReferencesEvent` helpers in `AuditEvents`. - Quickstarts `ReferenceNodeManager` opts in via `AllowNodeManagement => true`; the legacy partial-class override in `ReferenceServer.NodeManagement.cs` is removed. ### `NodeState.Delete` on shutdown (#3762) - `CustomNodeManager.DeleteAddressSpace` and `AsyncCustomNodeManager.DeleteAddressSpaceAsync` now snapshot root `PredefinedNodes` (skipping children whose parent is in the snapshot to prevent double-fire), invoke `NodeState.Delete(SystemContext)` on each root (which recurses into children and raises `OnBeforeDelete` / `OnAfterDelete` / `NodeStateChangeMasks.Deleted`), and then clear the map. - Derived overrides in Quickstarts `ReferenceNodeManager`, `SampleNodeManager`, and `FileSystemNodeManager` chain to `base` so the callback fires for their nodes too. ### Tests - **21 new dispatcher unit tests** in `Tests/Opc.Ua.Server.Tests/NodeManager/AsyncCustomNodeManagerNodeManagementTests.cs` covering `AllowNodeManagement` default/opt-in, AddNode validation (`BadBrowseNameInvalid`, `BadParentNodeIdInvalid`, `BadNodeIdRejected`, `BadNodeIdExists`, `BadBrowseNameDuplicated`, `BadNodeClassInvalid`), RequestedNewNodeId paths, DeleteNode + `DeleteTargetReferences`, AddReference duplicate detection (`BadDuplicateReferenceNotAllowed`), and DeleteReference (`BadNoMatch`). - **2 new DeleteAddressSpaceAsync tests** in `AsyncCustomNodeManagerTests` verifying `NodeState.Delete` invocation and no double-fire on children. - Updated InformationModel `NodeManagementAddRefTests.AddReferenceBetweenExistingNodesSucceedsAsync` to accept `BadUserAccessDenied` / `BadNotSupported` when the source NM has opted out. - **Full `Opc.Ua.Server.Tests` on net10.0: 1709 passed, 0 failed.** - **All 26 InformationModel `Category=NodeManagement` conformance tests pass** against the reference server (1 skipped where source NM opts out). ### Docs - New [`Docs/NodeManagement.md`](Docs/NodeManagement.md) with architecture, opt-in pattern, dispatch and routing rules, request-handling table, error-code table, audit events, and custom-behavior examples. - `Docs/MigrationGuide.md` gets two new sections — *NodeManagement service set* (downstream migration steps) and *DeleteAddressSpace invokes NodeState.Delete (#3762)* (shutdown behavior change) — with TOC entries. - `Docs/README.md` links the new `NodeManagement.md`. ## Related Issues - Fixes #3736 - Fixes #3762 ## Checklist _Put an `x` in the boxes that apply. You can complete these step by step after opening the PR._ - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [x] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received.	2026-06-04 13:02:32 +02:00