## Description
Server-side `MonitoredItem` sampling interval revision is based on the
per-node `BaseVariableState.MinimumSamplingInterval` attribute, not on
any global server setting —
`ServerConfiguration.MinMetadataSamplingInterval` was dead configuration
that was never read by any code path. Per maintainer feedback, this PR
removes it instead of wiring it into revision logic that was never meant
to consume it.
Separately, the concern that `Subscription.MaxNotificationsPerPublish`
isn't revised by the server was verified against existing coverage:
`CreateSubscriptionWithNotificationLimitsUsesEffectiveLimitAsync` /
`ModifySubscriptionWithNotificationLimitsUsesEffectiveLimitAsync` in
`SubscriptionTests.cs` already assert the server clamps a
client-requested value down to the configured server limit (e.g.
requested `25` vs. server limit `10` → revised `10`).
### Removed `MinMetadataSamplingInterval`
- Dropped the `ServerConfiguration.MinMetadataSamplingInterval` property
(`ApplicationConfiguration.cs`) and its XSD element
- Dropped `SetMinMetadataSamplingInterval` from
`IApplicationConfigurationBuilder` / `ApplicationConfigurationBuilder`
- Removed the element from sample and test server configuration XML
files (`Ctt.ReferenceServer.Config.xml`,
`Quickstarts.ReferenceServer.Config.xml`, GDS test configs,
`test-server-full.xml`)
- Updated `ApplicationConfigurationBuilderTests` and
`ConfigurationRoundTripTests` to drop assertions on the removed property
## Related Issues
## Checklist
- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [ ] I have added all necessary documentation.
- [ ] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.
<!-- START COPILOT CODING AGENT SUFFIX -->
- Fixes#4191
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: marcschier <11168470+marcschier@users.noreply.github.com>
Copilot