Commit Graph

399 Commits

Author SHA1 Message Date
Martin Regen f53f71f8a4 Complex types fixes (#978)
fix #940 and #975 
- add namespace qualifier to complex type name
- improve handling of known subtypes
- fix Pss detection on .Net 462
- stronger check of valid DataTypeDefinition for servers which expose invalid structure (nodejs)
2020-05-15 12:54:20 +02:00
AlinMoldovean 7278f70025 Revert ExtensionObject changes for TypeId 2020-05-15 12:09:30 +03:00
AlinMoldovean 74247e4e8d Revert TypeId fix for ExtensionObject 2020-05-15 12:01:58 +03:00
Alin Moldovean ed4cc1331f Implement support for AccessRestrictions and RolePermissions attributes (#977)
* Implement Server support for AccessRestrictions and RolePermissions attributes

* Add nodes with AccessRestrictions and RolePermissions in ReferenceServer
Add example for assigning roles to users.
2020-05-14 17:20:40 +03:00
Martin Regen aaf4c9ab87 Opc.Ua.Core/Types content formatting - no bugfixes (#963)
- Simplify future maintenance by formatting all source code in types according to editorconfig style
2020-05-04 13:55:41 +02:00
Alexander Köpke 3e61a85901 Update from .NET 4.6 to .NET 4.6.2 (#959)
Upgraded all project from .NET 4.6 to .NET 4.6.2 that also .NET framework applications can use latest version of Kestrel

* Updated Kestrel to 2.2.0 (for Opc.Ua.Core)
* Simplified csproj (removed ItemGroup Condition="'$(TargetFramework)' == 'netstandard1.3'") because currently we don't build netstandard1.x anymore
* Removed Kestrel 1.1.3 code from Stack/Opc.Ua.Core/Stack/Https/HttpsListener.cs 
* add conditions to Stack/Opc.Ua.Core/Stack/Https/HttpsTransportChannel.cs 
  * [HttpClientHandler.ServerCertificateCustomValidationCallback](https://docs.microsoft.com/en-us/dotnet/api/system.net.http.httpclienthandler.servercertificatecustomvalidationcallback?view=netcore-3.1&viewFallbackFrom=netframework-4.6.2) should not be available in .NET 4.6.X
* Updated travis.ci to use latest mono version (original version causes build errors)
* Added nuget reference .NET Standard Library to mono projects to be compatible with latest Kestrel version

Own Travis.ci and Azure Pipeline builds run sucessfully.
2020-05-01 09:57:15 +02:00
Martin Regen 689f4f3068 Unit tests for IEncodeables, badges and fixes for build pipeline (#952)
- add encode/decode tests for all IEncodeables in Opc.Ua.Core. 
- *Breaking change*: ExtensionObject now returns the proper TypeId on decode for known encodeables. 
- remove Nuget.Config, it may have caused some intermittent build problems in Azure pipelines
- Code coverage now 39.5%
- Add a few badges for project info
- fix travis build, it only supports .Net Core 2 projects.
- *Breaking change*: SessionlessMessage uses the same TypeId as SessionlessInvokeRequestType which can cause problems in type factory, demoted the structure as not being IEncodeable as it is only used as a helper class in encoders/decoders.
- restructure AzPipeline builds to avoid imtermittent build issues,
2020-04-24 12:45:58 +02:00
Martin Regen 20aeb22989 Fix bytestring JSON array encoding, add code coverage (#943)
- more random Variant encoding tests, incl. arrays
- fix bytestring JSON array encoding, null or empty bytestring difference is now preserved
- add solution builds to Azure pipeline build, appveyor can be retired after a brief test period
- add code coverage to linux tests, artifact is published in pipeline build results
2020-04-14 15:55:22 +02:00
Alin Moldovean 9af68e0da8 Fix for writing RolePermissions and AccessRestrictions attributes (#939)
* Fix for writing RolePermissions and AccessRestrictions attributes in Server.

* Allow also UInt32 type when writing AccessRestrictions attribute.
2020-04-08 12:36:27 +03:00
AlinMoldovean b74cca1b35 Fixes #929 - duplicate entries in GetEndpoint response. 2020-03-27 17:56:50 +02:00
Martin Regen 8b201f7fb9 Add public key for build (#927)
- signed assemblies need a public key if 'InternalsVisibleTo' is being used. Add a define in such a case to provide a key. .Net Core 3.0 doesn't accept the dummy key, here is the real thing.
2020-03-24 10:00:44 +01:00
AlinMoldovean 971d2c7f53 Add dummy PublicKey in Core.InternalsVisibleTo for Nuget build test 2020-03-20 15:44:01 +02:00
Alin Moldovean 81832f71a3 Update UA-Nodesets and generated code (#925)
* Update generated code and UA-nodeset files for 1.04.5 Errata

* Update UA-Nodeset files and generated code of Sample projects with latest version of ModelCompiler
2020-03-20 14:43:25 +02:00
Martin Regen 1ff1ae7e52 IOP 2020: Workshop fixes (#916)
- fix to validate structuredefinition if servers do not fill out the DataTypeDefinition correctly
- The GDS creates the CRL cert with its own CA serial number, invalidating the CA by default on some stacks
- complex structuretype must be virtual, non reversible union encoding could not be detected 
- fix binary schema validation, allow the \" character in a qualified name
- support use of simple subtypes in a complex type. For custom and standard subtypes.
- only support structure objects with valuerank scalar or onedimension
2020-03-18 18:49:53 +01:00
AlinMoldovean 926b5915da Fix for CertificateUpdate during application runtime. 2020-03-11 17:55:05 +02:00
Martin Regen 0d01fbba64 Fix Variant init with enum array (#912)
* fix variant constructor for enum
* fix behaviour change for guid, can cause cast error
* minor warnings
2020-03-07 06:36:58 -06:00
Alin Moldovean 970593beb0 Compliance fixes for latest CTT (#913) 2020-03-06 16:36:17 +02:00
Martin Regen b6e8aaaedb Fix Test cases with DateTime which fail in US timezone
Implement a common way to convert DateTime to Universaltime and keep boundary values as they are
2020-03-05 10:42:43 -06:00
Martin Regen e908555216 Add schema tests for well known dictionaries (#909)
* add schema validation tests for well known type dictionaries
* comment duplicate test runs
2020-03-04 09:31:41 -06:00
Martin Regen 32e0660a7a Enable Azurepipelines build (#907)
-Starter for Azure pipelin builds, a bunch of tests in appveyor and travis can be disabled once this is working
-fix Opc.Ua.Core rootnamespace
-a few minor changes due to Ctrl-K,D refactoring, removal of dead code
2020-02-28 07:51:48 +01:00
Martin Regen e606f3aa8c Stabilize TCP receive (#904)
- Various issues found during server testing with ref server
- Take a different approach on the nesting issue
- Fix a duplicate buffer free issue 
- stabilize binary decoder
2020-02-19 13:34:55 +01:00
Martin Regen 9f015128f0 Fix for non reversible encoding of Unions/Structures (#905)
* fix for non reversible encoding of Unions and structures
* handle exception when server returns null terminated dictionary bytestring
2020-02-18 17:11:11 +01:00
Martin Regen c39b1e3623 Tests and fixes for encoders and decoders (#897)
- Unit test project for Core, so far only types and cert validator
- CertValidator test moved to Core.Tests
- ComplexTypes client tests for encode / decode
- bug fixes for issues found in encoders/decoders and complex types tests

** breaking change for JSON encoding of NodeId **

encoding was not according to spec. see #874.

#874, #892 fixed
2020-02-06 17:38:00 +01:00
Alin Moldovean 3e640bf702 Update UA NodeSets and generated code (#895)
* Update UA NodeSets and generated code with the latest updates for 1.04.04 Errata Release.

* Revert error in generated code.
2020-01-30 16:08:19 +02:00
Alin Moldovean 636f5c03f9 Implement validation for duplicate nonces (#893)
* - Add Server nonce validation for duplicate nonces.
- Add configuration flag to bypass validation exceptions

* Add ITransportChannel.CurrentToken interface for nonce validation.
2020-01-30 15:06:13 +02:00
Martin Regen a1faa0f7a1 Remove netstandard1.3 (#887)
* remove netstandard1.3 and unify csproj settings
* switch tests to silent mode
2020-01-23 07:22:26 +01:00
AlinMoldovean bcccd718a4 Fix for handling of AccessLevel and AccessLevelEx attributes. 2020-01-14 18:00:23 +02:00
Wadjet-Informatics e9ebd49350 Prevent deep recursion and excessive thread creation in TcpMessageSocket (#845)
- instead of creating task or nested calls to get message packets uses a loop which is more efficent and stack safe.
2020-01-13 13:27:54 +01:00
Martin Regen f7ab80d304 Update kestrel nuget version (#882)
* update kestrel nuget version
* update nuspec
2020-01-10 12:28:23 +01:00
Kurt 300d9ffd62 Minor analyzer (roslynator) fixes (#880)
* Use nameof() where applicable

Category: Maintainability
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1015.md

* Rethrow original exception

Preserves original stack trace of the exception, easier to diagnose
Category: Maintainability
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1044.md
https://stackoverflow.com/a/178464

Remove variable from the catch if not logged (compiler warning).

* Combine Where->FirstOrDefault, use Find if applicable

Category: Performance
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1077.md

In ApplicationConfiguration:
ServerSecurityPolicyCollection inherits from List<T>, so use List.Find (better performance than FirstOrDefault)

* Use List.Count rather than LINQ Any()

Category: Performance
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1080.md
refsToRemove is a List<T>, which we know the count of (no need to iterate).

* Add [Flags] Attribute for OpenFileMode

Each enum is a bitflag here
Just noticed this is in the "Generated" folder... some prior commits had touched other "Generated" files -- see nameof commit.

* Minor performance behavior

- EventArgs.Empty instead of allocating a new blank EventArgs

It only really happens on Connect/Disconnect so it's not like a single allocation really matters

- Use array[0] instead of First()
https://stackoverflow.com/a/25607951
- Use !Any() instead of Count() == 0
If a dependent field is found, it will stop evaluating the rest and Add instead of Insert. Count() == 0 required evaluation of all

- Use All() instead of FirstOrDefault(any) == null
Clearer intent (all are not matching the group BrowseName => clear default)
Slightly faster as the first match found doesn't have to be compared against null

* Revert changes to generated files

* Fix mistake

fixes compile error
2020-01-09 09:28:37 +02:00
Martin Regen 368049d188 Improvements to complex types client (#879)
- allow for loading of single types with dependencies from DataTypeDefinitions only
- introduce a type dictionary to match xml qualified names with type ids.
breaking change (internally):
- simplify JSON encoding by providing a UseReversibleEncoding flag 
- add also JSON and XML encoding ids to type factory if supported
- follow coding conventions for test sample, add single type loading use case (before/after)
- fix a bug when a JSON extension object cannot be decoded when the namespace uri is encoded
2020-01-08 16:29:22 +01:00
AlinMoldovean ba620f2a08 Implement import of DataTypeDefinition attribute from NodeSet files. 2019-12-06 10:24:32 +02:00
AlinMoldovean 77a183ec6b Nonce validation fix in Client Session. The minimum nonce length should be 32 in CreateSession and ActivateSession responses. 2019-11-28 19:10:07 +02:00
AlinMoldovean 2d2c108a68 Fixes #847 - Fix in DiscoveryClient.Create() 2019-11-21 15:35:51 +02:00
Alin Moldovean 131f53811f Merge pull request #851 from MilosKonecny/master
Stability in BinaryDecoder improved.
2019-11-21 13:40:42 +02:00
Martin Regen 39dca2c103 Complex Types client library (#849)
Adds a complex type system client library extension for custom enumerations and structure types based on a server dictionary or DataTypeDefinition using emitted classes at runtime. 

- Custom types are added to the session factory, not to the global factory. Types are loaded when the session connects by adding 
`                var complexTypeSystem = new ComplexTypeSystem(session);
                await complexTypeSystem.Load();
`
- Custom type properties can be accessed with an accessor [propertyname] or [index]. Direct access through the properties is possible, but some cases do not update the optional or union flags correctly.
- Support includes V1.03 dictionaries and V1.04 DataTypeDefinitions (--> known issues).
- NetCoreComplexClient can be used for quick testing servers. It prints out all custom types with content and subscribes to all. Also includes sample how to write back complex type variables and how to output JSON.
- The UA Sample Client and the Quickstart Data Type client can be used for testing with UI. Many issues were adressed to be able to read and write complex types, however some support is limited, e.g. only editing simple fields is currently working (help wanted).
- Caveat: The complex type libaries for .Net Core must be built for .netcoreapp, so it needs a seperate nuget package for the complex type client extension.
- Support for a factory type builder class to allow to plugin other type builder methods (e.g. Codedom etc...)
- Added JSON test case and include the complex types client in the testing shell script, so the complex types lib is tested on mac/linux too.
- Few fixes in the JSON encoder.

Finding enough servers with custom types is an issue, so if you find servers with unsupported custom types please provide feedback.

Known limitations:
- Only V1.03 OPC binary dictionaries are supported (no XML Schema dictionaries).
- V1.03 dictionary structure definitions are only supported if they can be mapped to a V1.04 DataTypeDefinition. Nested types and cross dictionary refs should work.
- OptionSet is only partially implemented. Only shows the byte arrays, not the flags.
- Opaque Types in dictionaries are ignored.
2019-11-20 16:05:24 +01:00
AlinMoldovean 13cba2baf7 Length validation in user token decryption. 2019-11-19 16:01:28 +02:00
Miloš Konečný 110ab6b5c0 BinaryDecoder: Stability improved, exception ArgumentOutOfRangeException is avoided. 2019-11-18 21:22:09 +01:00
AlinMoldovean 8504055a83 Add server nonce validation in Client session. 2019-11-12 17:00:07 +02:00
Sebastian Bäumler c9a20988e5 Removed duplicated code. (#844)
Same Code will be called by static function "RequireEncryption()"
2019-11-11 16:44:23 +02:00
Alin Moldovean dc9fa85a38 Fixes #822 - Certificate Validation fix. (#843)
* Remove BadCertificateUriInvalid from list of certificate validation errors that may be suppressed.
2019-11-06 09:49:08 +02:00
Andrew Field d7130a97d4 Spelling (#840) 2019-11-05 10:07:52 +02:00
Alin Moldovean f015ece891 Fixes #832 - Avoid deep recursion in TcpMessageSocket.ReadNextBlock() (#836)
* Fixes #832 - Avoid deep recursion in TcpMessageSocket.ReadNextBlock()
2019-10-30 09:52:46 +02:00
Martin Regen ef06464776 fix schema validator and dictionary loader (only binary) (#833)
* fix schema validator and dictionary loader (only binary scheme)
# include some .bsd files for validation
* add check for some configuration fields, to return a meaningful error.
2019-10-29 18:16:37 +01:00
AlinMoldovean 089bcd0e6f Fixes #780. ExpandedNodeId.CompareTo() fix. 2019-10-29 10:11:44 +02:00
AlinMoldovean df0cc4287d #791 - Update UA NodeSets and generated code with the latest updates for V1.04.3 Errata. 2019-10-02 17:44:53 +03:00
Sebastian Bäumler f6a70031e1 Improvements to enable UANodeSet to import/export AccessLevelEx as uint32 (#815) 2019-10-02 16:39:04 +03:00
Alin Moldovean a1e26bf849 Interoperability fixes for HTTPS (#814)
* Fixes #709 - Allow HTTPS clients to send the certificate for servers that require TLS client authentication

* Fixes #692 - HTTPS Server listener - Use the first configured policy for HTTPS
2019-10-02 15:38:59 +03:00
AlinMoldovean 099a003144 Fixes #805 2019-09-27 16:11:33 +03:00
AlinMoldovean f10151507b Fix #751 - possible handle leak in stress test 2019-09-26 10:55:41 +03:00