Commit Graph
186 Commits
Author SHA1 Message Date
Martin Regen 1ff1ae7e52 IOP 2020: Workshop fixes (#916)
- fix to validate structuredefinition if servers do not fill out the DataTypeDefinition correctly
- The GDS creates the CRL cert with its own CA serial number, invalidating the CA by default on some stacks
- complex structuretype must be virtual, non reversible union encoding could not be detected 
- fix binary schema validation, allow the \" character in a qualified name
- support use of simple subtypes in a complex type. For custom and standard subtypes.
- only support structure objects with valuerank scalar or onedimension
2020-03-18 18:49:53 +01:00
AlinMoldovean ab5d93fa60 CTT compliance fixes for Audit events. 2020-03-10 16:47:05 +02:00
Alin Moldovean 970593beb0 Compliance fixes for latest CTT (#913) 2020-03-06 16:36:17 +02:00
Martin Regen 32e0660a7a Enable Azurepipelines build (#907)
-Starter for Azure pipelin builds, a bunch of tests in appveyor and travis can be disabled once this is working
-fix Opc.Ua.Core rootnamespace
-a few minor changes due to Ctrl-K,D refactoring, removal of dead code
2020-02-28 07:51:48 +01:00
Martin Regen e606f3aa8c Stabilize TCP receive (#904)
- Various issues found during server testing with ref server
- Take a different approach on the nesting issue
- Fix a duplicate buffer free issue 
- stabilize binary decoder
2020-02-19 13:34:55 +01:00
Martin Regen 9f015128f0 Fix for non reversible encoding of Unions/Structures (#905)
* fix for non reversible encoding of Unions and structures
* handle exception when server returns null terminated dictionary bytestring
2020-02-18 17:11:11 +01:00
Martin Regen c39b1e3623 Tests and fixes for encoders and decoders (#897)
- Unit test project for Core, so far only types and cert validator
- CertValidator test moved to Core.Tests
- ComplexTypes client tests for encode / decode
- bug fixes for issues found in encoders/decoders and complex types tests

** breaking change for JSON encoding of NodeId **

encoding was not according to spec. see #874.

#874, #892 fixed
2020-02-06 17:38:00 +01:00
Martin Regen f56a810f74 Validate for spec compliant subscription defaults (#898)
Fix #894.
2020-02-06 08:21:08 +01:00
Alin Moldovean 636f5c03f9 Implement validation for duplicate nonces (#893)
* - Add Server nonce validation for duplicate nonces.
- Add configuration flag to bypass validation exceptions

* Add ITransportChannel.CurrentToken interface for nonce validation.
2020-01-30 15:06:13 +02:00
Martin Regen a1faa0f7a1 Remove netstandard1.3 (#887)
* remove netstandard1.3 and unify csproj settings
* switch tests to silent mode
2020-01-23 07:22:26 +01:00
ondraco 3f0bb8c83c Allow relative URI as module name and fix nested load issue (#884)
* Allow relative URI as module name
* If a complex type contains another complex type which was not loaded yet add it to the 'retry list' instead of not loading it at all.
2020-01-13 13:25:00 +01:00
Kurt 300d9ffd62 Minor analyzer (roslynator) fixes (#880)
* Use nameof() where applicable

Category: Maintainability
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1015.md

* Rethrow original exception

Preserves original stack trace of the exception, easier to diagnose
Category: Maintainability
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1044.md
https://stackoverflow.com/a/178464

Remove variable from the catch if not logged (compiler warning).

* Combine Where->FirstOrDefault, use Find if applicable

Category: Performance
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1077.md

In ApplicationConfiguration:
ServerSecurityPolicyCollection inherits from List<T>, so use List.Find (better performance than FirstOrDefault)

* Use List.Count rather than LINQ Any()

Category: Performance
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1080.md
refsToRemove is a List<T>, which we know the count of (no need to iterate).

* Add [Flags] Attribute for OpenFileMode

Each enum is a bitflag here
Just noticed this is in the "Generated" folder... some prior commits had touched other "Generated" files -- see nameof commit.

* Minor performance behavior

- EventArgs.Empty instead of allocating a new blank EventArgs

It only really happens on Connect/Disconnect so it's not like a single allocation really matters

- Use array[0] instead of First()
https://stackoverflow.com/a/25607951
- Use !Any() instead of Count() == 0
If a dependent field is found, it will stop evaluating the rest and Add instead of Insert. Count() == 0 required evaluation of all

- Use All() instead of FirstOrDefault(any) == null
Clearer intent (all are not matching the group BrowseName => clear default)
Slightly faster as the first match found doesn't have to be compared against null

* Revert changes to generated files

* Fix mistake

fixes compile error
2020-01-09 09:28:37 +02:00
Martin Regen 368049d188 Improvements to complex types client (#879)
- allow for loading of single types with dependencies from DataTypeDefinitions only
- introduce a type dictionary to match xml qualified names with type ids.
breaking change (internally):
- simplify JSON encoding by providing a UseReversibleEncoding flag 
- add also JSON and XML encoding ids to type factory if supported
- follow coding conventions for test sample, add single type loading use case (before/after)
- fix a bug when a JSON extension object cannot be decoded when the namespace uri is encoded
2020-01-08 16:29:22 +01:00
AlinMoldovean f87ea2839d Skip server nonce validation in ClientSession if the nonce is not used for encryption. 2019-12-18 17:01:21 +02:00
Martin Regen d31c8cc6e4 - implement a few TODO (#859)
- bugfixes found in testing
2019-12-02 16:29:25 +01:00
AlinMoldovean 77a183ec6b Nonce validation fix in Client Session. The minimum nonce length should be 32 in CreateSession and ActivateSession responses. 2019-11-28 19:10:07 +02:00
Martin Regen 39dca2c103 Complex Types client library (#849)
Adds a complex type system client library extension for custom enumerations and structure types based on a server dictionary or DataTypeDefinition using emitted classes at runtime. 

- Custom types are added to the session factory, not to the global factory. Types are loaded when the session connects by adding 
`                var complexTypeSystem = new ComplexTypeSystem(session);
                await complexTypeSystem.Load();
`
- Custom type properties can be accessed with an accessor [propertyname] or [index]. Direct access through the properties is possible, but some cases do not update the optional or union flags correctly.
- Support includes V1.03 dictionaries and V1.04 DataTypeDefinitions (--> known issues).
- NetCoreComplexClient can be used for quick testing servers. It prints out all custom types with content and subscribes to all. Also includes sample how to write back complex type variables and how to output JSON.
- The UA Sample Client and the Quickstart Data Type client can be used for testing with UI. Many issues were adressed to be able to read and write complex types, however some support is limited, e.g. only editing simple fields is currently working (help wanted).
- Caveat: The complex type libaries for .Net Core must be built for .netcoreapp, so it needs a seperate nuget package for the complex type client extension.
- Support for a factory type builder class to allow to plugin other type builder methods (e.g. Codedom etc...)
- Added JSON test case and include the complex types client in the testing shell script, so the complex types lib is tested on mac/linux too.
- Few fixes in the JSON encoder.

Finding enough servers with custom types is an issue, so if you find servers with unsupported custom types please provide feedback.

Known limitations:
- Only V1.03 OPC binary dictionaries are supported (no XML Schema dictionaries).
- V1.03 dictionary structure definitions are only supported if they can be mapped to a V1.04 DataTypeDefinition. Nested types and cross dictionary refs should work.
- OptionSet is only partially implemented. Only shows the byte arrays, not the flags.
- Opaque Types in dictionaries are ignored.
2019-11-20 16:05:24 +01:00
AlinMoldovean 8504055a83 Add server nonce validation in Client session. 2019-11-12 17:00:07 +02:00
Andrew Field d7130a97d4 Spelling (#840) 2019-11-05 10:07:52 +02:00
Martin Regen ef06464776 fix schema validator and dictionary loader (only binary) (#833)
* fix schema validator and dictionary loader (only binary scheme)
# include some .bsd files for validation
* add check for some configuration fields, to return a meaningful error.
2019-10-29 18:16:37 +01:00
AlinMoldovean 14869582e4 Client Session KeepAlive fix - outstanding publish requests should not stop keep alive reads. 2019-10-03 16:55:44 +03:00
AlinMoldovean df0cc4287d #791 - Update UA NodeSets and generated code with the latest updates for V1.04.3 Errata. 2019-10-02 17:44:53 +03:00
Alin Moldovean efd66a2acb Save server certificate in ClientSession if no encryption is required. (#813)
* Fix build order in UA Quickstart Applications.sln

* Fixes #800. Save server certificate in client Session even if no encryption is required.
2019-10-01 06:47:51 +03:00
AlinMoldovean b1c0293fb4 Fixes #796 2019-09-19 17:55:07 +03:00
ejoseca de838b727a Fixes saving client session to XML. (#757)
Fixed bug in Opc.Ua.Client.Save method.
2019-07-22 16:08:50 +03:00
AlinMoldovean e257ba07df Fix to avoid timer interval higher than Int32.MaxValue in ClientSubscription.StartKeepAliveTimer() 2019-06-19 16:19:02 +03:00
Chris Law 92fa5182ae Change to catch error from validating the server certificate. Fixing #710 and #678. (#739) 2019-06-10 15:58:24 +03:00
Alin Moldovean 40db29f3a2 Fixes #703.
Fix regression caused by #656. Add a MonitoredItem constructor to allow keeping the ClientHandle of the template. (#704)
2019-04-17 10:03:19 +03:00
Alin Moldovean 0a6b1cb3e3 CTT compliance fixes. (#702) 2019-04-15 11:58:23 +03:00
Bilge Kaan KAZAZ ef4c918494 Fixes the wrong DisplayName issue of a MonitoredItem after reconnect 2019-03-22 21:50:11 +03:00
Alin Moldovean cbeb24eb5e Merge pull request #652 from jh-isw/master
correct indentation
2019-02-28 13:45:52 +02:00
julien 593aefd3b3 Fix Wrong clientHandle when reconnecting a session ; the clone / template procedures where not keeping this precious unique identifier. 2019-02-19 10:28:15 +01:00
Jan Hecht 8af6c278c5 correct indentation 2019-02-17 18:07:48 +01:00
AlinMoldovean 8b374a7448 Copyright year set to 2019 in license notices. 2019-02-14 12:34:33 +02:00
Ahmed Ashour 0203717182 Update Session.cs (#622)
Fix typos
2019-01-14 15:19:17 +02:00
Alin Moldovean b8d911c569 Updates for V1.04 attributes in Client and Server (#614)
* Update for 1.04 attributes in ClientSession.ReadNode()

* Fix in ClientSession.ReadNode()

* Updates for 1.04 Attributes in server.

* Discard inner value for attributes with bad status codes in ClientSession.ReadNode().

* Remove unused attribute from AttributeWriteMask
2018-12-17 12:53:19 +02:00
Camille Guérin 3546e56e05 Fixed GetServiceResult null checks
Fixed wrong null checks for Notification message in GetServiceResult(IEncodeable notification) and GetServiceResult(IEncodeable notification, int index)
2018-11-14 09:57:19 +01:00
Alin Moldovean d87df993f3 Merge pull request #576 from AlinMoldovean/master
Allow access to node managers from MasterNodeManager + IOP issue fix
2018-10-29 12:39:00 +02:00
Martin Regen d007a41d15 Add Aes profile support (#574)
* add the Aes128 and Aes256 profiles
* Aes profies were tested on IoP workshop against Ascolab, Softing, Matrikon, Milo, ProSys and others
* Pss padding is not supported on all platforms, so autodetect if it is supported and filter out Aes256 if not
* not a breaking change: not specifying the SecurityProfileUri in the config xml will automatically add all supported profiles but not deprecated profiles (e.g. Basic256Sha256, Aes128, Aes256). Aes256 is only added if the platform supports Pss padding. This will simplify the maintenance of config xml, since automatically all supported and secure profiles are exposed.
2018-10-29 09:58:45 +01:00
AlinMoldovean 8e5b34a91b fixes issue #533 allow access to NodeManagers of MasterNodeManager. 2018-10-26 11:04:32 +02:00
AlinMoldovean 9e74131f3b Do not discard ClientSession in case FetchNamespaceTables() goes in error. 2018-10-26 10:45:58 +02:00
Martin Regen ced33e1957 Improvements for cloud based Gds and V1.04 nodes (#508)
- all changes for cloud based GDS
 - build version of .net standard libs is now set in version.props, it may require updates for the official builds.
  - add new stuff for v1.04 nodeset, e.g. QueryApplications Api
  - gds.client/gds.server common dll changes to support a cloud based GDS.
2018-07-31 13:32:21 +02:00
Alin Moldovean 92bef97e51 Fix for Mantix #4321 + deprecated security polices removed from config.xml files (#505)
* Fix for Mantis #4231. Refuse to use untrusted certificates to encrypt user identity tokens sent to servers.

* Deprecated security policies removed from default server config.xml files.
2018-07-18 08:28:07 +03:00
Pierre-Alain GALTIER 30cb2cf7fe Add lifeTimeInMonths capability to CheckApplicationInstanceCertificate. 2018-06-11 17:38:49 +02:00
Oyvind Landsnes 79f4da032c AddReferences method returns too early
The AddRefrences method exists in similar versions in several of the sample node manager classes. The method loops through a list of (external) references and adds them to the designated objects. When obtaining node handles it also checks that the node is valid in the current context. The problem was that it skipped the rest of  the nodes in the list as soon as it found one node that wass not valid. This change ensures that all nodes in the references list are processed.
2018-05-24 19:38:53 +02:00
Oyvind Landsnes d15e38212f fix(CustomNodemanager): AddReferences method returns too early
The AddRefrences method loops through a list of (external) references and adds them to the designated objects. When obtaining node handles it also checks that the node belongs to one of the namspaces for the  current node manager. The problem was that it skipped the rest of  the nodes in the list as soon as it found one node that did not belong to the currennt node manager.
2018-05-21 15:54:56 +02:00
AlinMoldovean 49fb32fdce Assembly version set to 1.04.353 2018-05-03 15:11:48 +03:00
AlinMoldovean 27ff681320 Assembly version set to 1.03.352 2018-03-29 16:23:01 +03:00
Martin Regen e2a4020984 Fix V103 nohttps build (#401)
- Fix the NO_HTTPS build to reduce publish size if HTTPS is not needed
e.g. `dotnet build /p:NoHttps=true`
- Limit language Version to C#6 for VS 2015 compat
- add travis & appveyor cases for nohttps build
- enable GDS Https transport
- update nuspec
2018-03-16 10:21:32 +01:00
AlinMoldovean b5b2d54971 Fixes after CR. 2018-03-08 12:23:20 +02:00