mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-22 01:26:20 +08:00
16c54e52d9
# Description `SecurityConfiguration.ApplicationCertificates`'s setter removed every identifier whose certificate type is not supported, and `CertificateIdentifier.CertificateType` defaults to unset. An otherwise correct identifier passed to the recommended `AddSecurityConfiguration(ArrayOf<CertificateIdentifier> certIdList, ...)` overload was therefore dropped silently, and validation then failed with `ApplicationCertificate must be specified.` — pointing at the wrong cause. The obsolete `AddSecurityConfiguration(string subjectName, ...)` overload escaped this because it assigns the legacy singular `ApplicationCertificate` property, whose setter fills in `RsaSha256ApplicationCertificateType` itself. The result: the replacement advertised by the `[Obsolete]` message could not be used without also setting `CertificateType`, which that message does not mention. **Changes:** - `SecurityConfiguration.ApplicationCertificates` (`src/Opc.Ua.Core/Schema/ApplicationConfiguration.cs`) now treats an unset `CertificateType` as the default RSA-SHA256 application certificate type instead of dropping the entry — the same assumption the legacy single `ApplicationCertificate` element carries, so both paths agree on what a valid `CertificateIdentifier` is. Fixing the setter also covers callers that assign `ApplicationCertificates` directly, not just the builder overload. - Identifiers dropped for a genuinely unsupported type are no longer discarded without a trace. They are remembered and reported by `SecurityConfiguration.Validate`, which has an `ITelemetryContext` — this replaces the `// TODO: Log when ITelemetry instance is available` that was exactly this bug: - a warning naming the rejected certificate types is logged whenever any were filtered out; - when the collection ends up empty *because* of the filtering, the error now reads `No supported application certificate configured: N certificate identifier(s) were rejected because their CertificateType is not supported (...)` instead of `ApplicationCertificate must be specified.`. The original message is kept for the genuinely-empty case. **Notes for reviewers:** - Behaviour is unchanged for every configuration that already names a certificate type; all shipped and test config XMLs set `CertificateTypeString`. - `FindApplicationCertificateAsync` already had a fallback treating a null certificate type as RsaSha256, and `ApplicationInstance` fills in the type from the created/validated certificate when it is null — defaulting in the setter is consistent with both and yields the same RSA certificate. - The unsupported-type filter itself is untouched; only unset types are now kept. ## Related Issues - Fixes #4315 ## Checklist - [x] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [x] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - `SecurityConfigurationTests`: an untyped identifier survives as RsaSha256 and contributes `Basic256Sha256` to `SupportedSecurityPolicies`; an unsupported type (`EccCurve25519ApplicationCertificateType`) is removed and reported by `Validate` with `BadConfigurationError`; a supported entry survives alongside an unsupported sibling without failing validation. - `ApplicationConfigurationBuilderTests`: end-to-end reproduction from the issue, building a client through `AddSecurityConfiguration(ArrayOf<CertificateIdentifier>, pkiRoot)` + `CreateAsync()`. - [ ] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - Ran on net10.0: `Opc.Ua.Configuration.Tests` 225/225 passed, `Opc.Ua.Core.Tests` 4368 passed / 86 skipped / 0 failed. The full solution across .NET Framework was not run locally — relying on CI for that. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
646 lines
29 KiB
C#
646 lines
29 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
// CA2000: test code; many disposables are ownership-transferred to test fixtures or short-lived,
|
|
// making CA2000 noisy without a real leak risk. Disabled file-level for the suite.
|
|
#pragma warning disable CA2000
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.IO;
|
|
using System.Linq;
|
|
using System.Text;
|
|
using System.Threading.Tasks;
|
|
using System.Xml;
|
|
using System.Xml.Linq;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Security.Certificates;
|
|
using Opc.Ua.Tests;
|
|
|
|
namespace Opc.Ua.Configuration.Tests
|
|
{
|
|
/// <summary>
|
|
/// Tests for the security configuration class.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("SecurityConfiguration")]
|
|
[SetCulture("en-us")]
|
|
public class SecurityConfigurationTests
|
|
{
|
|
[Test]
|
|
public void ValidConfgurationPasses()
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
|
|
var configuration = new SecurityConfiguration
|
|
{
|
|
ApplicationCertificate = new CertificateIdentifier { RawData = [] },
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedIssuerCertificates = new CertificateTrustList { StorePath = "Test" }
|
|
};
|
|
|
|
configuration.Validate(telemetry);
|
|
}
|
|
|
|
[TestCaseSource(nameof(GetInvalidConfigurations))]
|
|
public void InvalidConfigurationThrows(SecurityConfiguration configuration)
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
Assert.Throws<ServiceResultException>(() => configuration.Validate(telemetry));
|
|
}
|
|
|
|
[Test]
|
|
public void ApplicationCertificateWithoutCertificateTypeIsKeptAsRsaSha256()
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
|
|
var configuration = new SecurityConfiguration
|
|
{
|
|
ApplicationCertificates =
|
|
[
|
|
new CertificateIdentifier
|
|
{
|
|
StoreType = CertificateStoreType.Directory,
|
|
StorePath = "pki/own",
|
|
SubjectName = "CN=Test"
|
|
// CertificateType deliberately not set
|
|
}
|
|
],
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedIssuerCertificates = new CertificateTrustList { StorePath = "Test" }
|
|
};
|
|
|
|
Assert.That(configuration.ApplicationCertificates, Has.Count.EqualTo(1));
|
|
Assert.That(
|
|
configuration.ApplicationCertificates[0].CertificateType,
|
|
Is.EqualTo(ObjectTypeIds.RsaSha256ApplicationCertificateType));
|
|
Assert.That(
|
|
configuration.SupportedSecurityPolicies.ToArray(),
|
|
Contains.Item(SecurityPolicies.Basic256Sha256));
|
|
|
|
configuration.Validate(telemetry);
|
|
}
|
|
|
|
[Test]
|
|
public void UnsupportedApplicationCertificateTypeIsRemovedAndReportedByValidate()
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
|
|
var configuration = new SecurityConfiguration
|
|
{
|
|
ApplicationCertificates =
|
|
[
|
|
new CertificateIdentifier
|
|
{
|
|
StoreType = CertificateStoreType.Directory,
|
|
StorePath = "pki/own",
|
|
SubjectName = "CN=Test",
|
|
CertificateType = ObjectTypeIds.EccCurve25519ApplicationCertificateType
|
|
}
|
|
],
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedIssuerCertificates = new CertificateTrustList { StorePath = "Test" }
|
|
};
|
|
|
|
Assert.That(configuration.ApplicationCertificates, Is.Empty);
|
|
|
|
ServiceResultException sre = Assert.Throws<ServiceResultException>(
|
|
() => configuration.Validate(telemetry));
|
|
|
|
Assert.That(sre.Code, Is.EqualTo(StatusCodes.BadConfigurationError));
|
|
Assert.That(sre.Message, Does.Contain("CertificateType is not supported"));
|
|
Assert.That(
|
|
sre.Message,
|
|
Does.Contain(ObjectTypeIds.EccCurve25519ApplicationCertificateType.ToString()));
|
|
}
|
|
|
|
[Test]
|
|
public void SupportedApplicationCertificateSurvivesAnUnsupportedSibling()
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
|
|
var configuration = new SecurityConfiguration
|
|
{
|
|
ApplicationCertificates =
|
|
[
|
|
new CertificateIdentifier
|
|
{
|
|
StoreType = CertificateStoreType.Directory,
|
|
StorePath = "pki/own",
|
|
SubjectName = "CN=Test",
|
|
CertificateType = ObjectTypeIds.EccCurve25519ApplicationCertificateType
|
|
},
|
|
new CertificateIdentifier
|
|
{
|
|
StoreType = CertificateStoreType.Directory,
|
|
StorePath = "pki/own",
|
|
SubjectName = "CN=Test"
|
|
}
|
|
],
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedIssuerCertificates = new CertificateTrustList { StorePath = "Test" }
|
|
};
|
|
|
|
Assert.That(configuration.ApplicationCertificates, Has.Count.EqualTo(1));
|
|
Assert.That(
|
|
configuration.ApplicationCertificates[0].CertificateType,
|
|
Is.EqualTo(ObjectTypeIds.RsaSha256ApplicationCertificateType));
|
|
|
|
// the unsupported sibling is only logged, it must not fail validation
|
|
configuration.Validate(telemetry);
|
|
}
|
|
|
|
[Test]
|
|
public void EmptyApplicationCertificatesStillReportsTheClassicError()
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
|
|
var configuration = new SecurityConfiguration
|
|
{
|
|
ApplicationCertificates = [],
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedIssuerCertificates = new CertificateTrustList { StorePath = "Test" }
|
|
};
|
|
|
|
ServiceResultException sre = Assert.Throws<ServiceResultException>(
|
|
() => configuration.Validate(telemetry));
|
|
|
|
Assert.That(sre.Code, Is.EqualTo(StatusCodes.BadConfigurationError));
|
|
Assert.That(sre.Message, Does.Contain("ApplicationCertificate must be specified."));
|
|
}
|
|
|
|
[Test]
|
|
public void ClearingApplicationCertificatesRebuildsSupportedSecurityPolicies()
|
|
{
|
|
var configuration = new SecurityConfiguration
|
|
{
|
|
ApplicationCertificates =
|
|
[
|
|
new CertificateIdentifier
|
|
{
|
|
StoreType = CertificateStoreType.Directory,
|
|
StorePath = "pki/own",
|
|
SubjectName = "CN=Test",
|
|
CertificateType = ObjectTypeIds.RsaSha256ApplicationCertificateType
|
|
}
|
|
]
|
|
};
|
|
|
|
Assert.That(
|
|
configuration.SupportedSecurityPolicies.ToArray(),
|
|
Contains.Item(SecurityPolicies.Basic256Sha256));
|
|
|
|
configuration.ApplicationCertificates = [];
|
|
|
|
Assert.That(configuration.ApplicationCertificates, Is.Empty);
|
|
Assert.That(
|
|
configuration.SupportedSecurityPolicies.ToArray(),
|
|
Is.EqualTo(new[] { SecurityPolicies.None }));
|
|
}
|
|
|
|
[Test]
|
|
public void LoadingConfigurationWithApplicationCertificateShouldMarkItDeprecated()
|
|
{
|
|
string file = Path.Combine(TestContext.CurrentContext.WorkDirectory, "testlegacyconfig.xml");
|
|
|
|
using var stream = new FileStream(file, FileMode.Open, FileAccess.Read);
|
|
ApplicationConfiguration reloadedConfiguration = DecodeApplicationConfiguration(stream);
|
|
|
|
Assert.That(
|
|
reloadedConfiguration.SecurityConfiguration.IsDeprecatedConfiguration,
|
|
Is.True);
|
|
}
|
|
|
|
[Test]
|
|
public void LoadingConfigurationWithApplicationCertificateAndApplicationCertificatesShouldNotMarkItDeprecated()
|
|
{
|
|
string file = Path.Combine(TestContext.CurrentContext.WorkDirectory, "testhybridconfig.xml");
|
|
|
|
using var stream = new FileStream(file, FileMode.Open, FileAccess.Read);
|
|
ApplicationConfiguration reloadedConfiguration = DecodeApplicationConfiguration(stream);
|
|
|
|
Assert.That(
|
|
reloadedConfiguration.SecurityConfiguration.IsDeprecatedConfiguration,
|
|
Is.False);
|
|
}
|
|
|
|
[Test]
|
|
public async Task FindApplicationCertificateUsesAbstractApplicationCertificateAsFallbackAsync()
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
using Certificate certificate = CertificateFactory
|
|
.CreateCertificate("CN=Abstract Application Certificate")
|
|
.CreateForRSA();
|
|
var certificateIdentifier = new CertificateIdentifier
|
|
{
|
|
RawData = certificate.RawData,
|
|
CertificateType = ObjectTypeIds.ApplicationCertificateType
|
|
};
|
|
var securityConfiguration = new SecurityConfiguration
|
|
{
|
|
ApplicationCertificates = [certificateIdentifier]
|
|
};
|
|
|
|
using Certificate result = await securityConfiguration.FindApplicationCertificateAsync(
|
|
SecurityPolicies.Basic256Sha256,
|
|
privateKey: false,
|
|
telemetry: telemetry).ConfigureAwait(false);
|
|
|
|
Assert.That(result, Is.Not.Null);
|
|
Assert.That(result.Thumbprint, Is.EqualTo(certificate.Thumbprint));
|
|
Assert.That(
|
|
certificateIdentifier.CertificateType,
|
|
Is.EqualTo(ObjectTypeIds.ApplicationCertificateType));
|
|
}
|
|
|
|
[Test]
|
|
public void SavingConfigurationShouldNotMarkItDeprecated()
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
|
|
var securityConfiguration = new SecurityConfiguration
|
|
{
|
|
ApplicationCertificates =
|
|
[
|
|
new CertificateIdentifier
|
|
{
|
|
StoreType = CertificateStoreType.Directory,
|
|
StorePath = "pki/own",
|
|
CertificateType = ObjectTypeIds.RsaSha256ApplicationCertificateType
|
|
}
|
|
],
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedIssuerCertificates = new CertificateTrustList { StorePath = "Test" }
|
|
};
|
|
|
|
var configuration = new ApplicationConfiguration(telemetry)
|
|
{
|
|
ApplicationName = "DeprecatedConfigurationTest",
|
|
ApplicationUri = "urn:localhost:DeprecatedConfigurationTest",
|
|
ApplicationType = ApplicationType.Server,
|
|
SecurityConfiguration = securityConfiguration
|
|
};
|
|
|
|
string xml = EncodeApplicationConfiguration(configuration);
|
|
|
|
using var readStream = new MemoryStream(Encoding.UTF8.GetBytes(xml));
|
|
ApplicationConfiguration reloadedConfiguration = DecodeApplicationConfiguration(readStream);
|
|
|
|
Assert.That(
|
|
reloadedConfiguration.SecurityConfiguration.IsDeprecatedConfiguration,
|
|
Is.False,
|
|
"Deserializing a configuration that uses ApplicationCertificates should not mark it deprecated via the legacy ApplicationCertificate setter.");
|
|
}
|
|
|
|
[Test]
|
|
public void DeprecatedConfigurationRoundTripsWithLegacyElement()
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
|
|
var configuration = new ApplicationConfiguration(telemetry)
|
|
{
|
|
ApplicationName = "DeprecatedConfigurationTest",
|
|
ApplicationUri = "urn:localhost:DeprecatedConfigurationTest",
|
|
ApplicationType = ApplicationType.Server,
|
|
SecurityConfiguration = new SecurityConfiguration
|
|
{
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedIssuerCertificates = new CertificateTrustList { StorePath = "Test" }
|
|
}
|
|
};
|
|
|
|
configuration.SecurityConfiguration.ApplicationCertificate = new CertificateIdentifier
|
|
{
|
|
StoreType = CertificateStoreType.Directory,
|
|
StorePath = "pki/own",
|
|
CertificateType = ObjectTypeIds.RsaSha256ApplicationCertificateType
|
|
};
|
|
|
|
string xml = EncodeApplicationConfiguration(configuration);
|
|
|
|
var document = XDocument.Parse(xml);
|
|
using var readStream = new MemoryStream(Encoding.UTF8.GetBytes(xml));
|
|
ApplicationConfiguration roundTripped = DecodeApplicationConfiguration(readStream);
|
|
|
|
Assert.That(roundTripped, Is.Not.Null);
|
|
Assert.That(configuration.SecurityConfiguration.IsDeprecatedConfiguration, Is.True);
|
|
Assert.That(
|
|
document.Descendants(XName.Get("ApplicationCertificate", Namespaces.OpcUaConfig)).Any(),
|
|
Is.True,
|
|
"Legacy ApplicationCertificate element should be present for deprecated configurations.");
|
|
}
|
|
|
|
[Test]
|
|
public void ModernConfigurationOmitsLegacyElement()
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
|
|
var configuration = new ApplicationConfiguration(telemetry)
|
|
{
|
|
ApplicationName = "ModernConfigurationTest",
|
|
ApplicationUri = "urn:localhost:ModernConfigurationTest",
|
|
ApplicationType = ApplicationType.Server,
|
|
SecurityConfiguration = new SecurityConfiguration
|
|
{
|
|
ApplicationCertificates =
|
|
[
|
|
new CertificateIdentifier
|
|
{
|
|
StoreType = CertificateStoreType.Directory,
|
|
StorePath = "pki/own",
|
|
CertificateType = ObjectTypeIds.RsaSha256ApplicationCertificateType
|
|
}
|
|
],
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedIssuerCertificates = new CertificateTrustList { StorePath = "Test" }
|
|
}
|
|
};
|
|
|
|
string xml = EncodeApplicationConfiguration(configuration);
|
|
|
|
var document = XDocument.Parse(xml);
|
|
using var readStream = new MemoryStream(Encoding.UTF8.GetBytes(xml));
|
|
ApplicationConfiguration roundTripped = DecodeApplicationConfiguration(readStream);
|
|
|
|
Assert.That(roundTripped, Is.Not.Null);
|
|
Assert.That(configuration.SecurityConfiguration.IsDeprecatedConfiguration, Is.False);
|
|
Assert.That(
|
|
document.Descendants(XName.Get("ApplicationCertificate", Namespaces.OpcUaConfig)).Any(),
|
|
Is.False,
|
|
"Modern configurations should not emit the legacy ApplicationCertificate element.");
|
|
Assert.That(
|
|
document.Descendants(XName.Get("ApplicationCertificates", Namespaces.OpcUaConfig)).Any(),
|
|
Is.True,
|
|
"Modern configurations should emit the ApplicationCertificates element.");
|
|
}
|
|
|
|
[Test]
|
|
public void DeprecatedConfigurationAlsoEmitsApplicationCertificatesElement()
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
|
|
var configuration = new ApplicationConfiguration(telemetry)
|
|
{
|
|
ApplicationName = "DeprecatedNoListConfig",
|
|
ApplicationUri = "urn:localhost:DeprecatedNoListConfig",
|
|
ApplicationType = ApplicationType.Server,
|
|
SecurityConfiguration = new SecurityConfiguration
|
|
{
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedIssuerCertificates = new CertificateTrustList { StorePath = "Test" }
|
|
}
|
|
};
|
|
|
|
configuration.SecurityConfiguration.ApplicationCertificate = new CertificateIdentifier
|
|
{
|
|
StoreType = CertificateStoreType.Directory,
|
|
StorePath = "pki/own",
|
|
CertificateType = ObjectTypeIds.RsaSha256ApplicationCertificateType
|
|
};
|
|
|
|
string xml = EncodeApplicationConfiguration(configuration);
|
|
|
|
var document = XDocument.Parse(xml);
|
|
|
|
Assert.That(configuration.SecurityConfiguration.IsDeprecatedConfiguration, Is.True);
|
|
Assert.That(
|
|
document.Descendants(XName.Get("ApplicationCertificate", Namespaces.OpcUaConfig)).Any(),
|
|
Is.True,
|
|
"Legacy ApplicationCertificate element should be present for deprecated configurations.");
|
|
Assert.That(
|
|
document.Descendants(XName.Get("ApplicationCertificates", Namespaces.OpcUaConfig)).Any(),
|
|
Is.True,
|
|
"The IEncodeable encoder always emits ApplicationCertificates when the collection is populated.");
|
|
}
|
|
|
|
[Test]
|
|
public void HybridConfigurationPrefersModernElementOnSave()
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
|
|
var legacyCert = new CertificateIdentifier
|
|
{
|
|
StoreType = CertificateStoreType.Directory,
|
|
StorePath = "pki/own",
|
|
CertificateType = ObjectTypeIds.RsaSha256ApplicationCertificateType
|
|
};
|
|
|
|
var modernCert = new CertificateIdentifier
|
|
{
|
|
StoreType = CertificateStoreType.Directory,
|
|
StorePath = "pki/own-modern",
|
|
CertificateType = ObjectTypeIds.RsaSha256ApplicationCertificateType
|
|
};
|
|
|
|
var configuration = new ApplicationConfiguration(telemetry)
|
|
{
|
|
ApplicationName = "HybridConfiguration",
|
|
ApplicationUri = "urn:localhost:HybridConfiguration",
|
|
ApplicationType = ApplicationType.Server,
|
|
SecurityConfiguration = new SecurityConfiguration
|
|
{
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedIssuerCertificates = new CertificateTrustList { StorePath = "Test" }
|
|
}
|
|
};
|
|
|
|
// First set legacy to mark deprecated, then set the modern collection.
|
|
configuration.SecurityConfiguration.ApplicationCertificate = legacyCert;
|
|
configuration.SecurityConfiguration.ApplicationCertificates = [modernCert];
|
|
|
|
string xml = EncodeApplicationConfiguration(configuration);
|
|
|
|
var document = XDocument.Parse(xml);
|
|
using var readStream = new MemoryStream(Encoding.UTF8.GetBytes(xml));
|
|
ApplicationConfiguration roundTripped = DecodeApplicationConfiguration(readStream);
|
|
|
|
Assert.That(configuration.SecurityConfiguration.IsDeprecatedConfiguration, Is.False);
|
|
Assert.That(roundTripped.SecurityConfiguration.IsDeprecatedConfiguration, Is.False);
|
|
Assert.That(
|
|
document.Descendants(XName.Get("ApplicationCertificate", Namespaces.OpcUaConfig)).Any(),
|
|
Is.False,
|
|
"Hybrid configurations should serialize as modern and omit the legacy element.");
|
|
Assert.That(
|
|
document.Descendants(XName.Get("ApplicationCertificates", Namespaces.OpcUaConfig)).Any(),
|
|
Is.True,
|
|
"Hybrid configurations should serialize the modern ApplicationCertificates element.");
|
|
Assert.That(roundTripped.SecurityConfiguration.ApplicationCertificates, Has.Count.EqualTo(1));
|
|
}
|
|
|
|
private static IEnumerable<TestCaseData> GetInvalidConfigurations()
|
|
{
|
|
yield return new TestCaseData(
|
|
new SecurityConfiguration
|
|
{
|
|
ApplicationCertificate = new CertificateIdentifier { RawData = [] }
|
|
}
|
|
).SetName("NoStores");
|
|
|
|
yield return new TestCaseData(
|
|
new SecurityConfiguration
|
|
{
|
|
ApplicationCertificate = new CertificateIdentifier { RawData = [] },
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = string.Empty },
|
|
TrustedIssuerCertificates = new CertificateTrustList { StorePath = "Test" }
|
|
}
|
|
).SetName("InvalidTrustedStore");
|
|
|
|
yield return new TestCaseData(
|
|
new SecurityConfiguration
|
|
{
|
|
ApplicationCertificate = new CertificateIdentifier { RawData = [] },
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedIssuerCertificates = new CertificateTrustList
|
|
{
|
|
StorePath = string.Empty
|
|
}
|
|
}
|
|
).SetName("InvalidIssuerStore");
|
|
|
|
yield return new TestCaseData(
|
|
new SecurityConfiguration
|
|
{
|
|
ApplicationCertificate = new CertificateIdentifier { RawData = [] },
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedIssuerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedHttpsCertificates = new CertificateTrustList { StorePath = "Test" }
|
|
}
|
|
).SetName("OnlyTrustedHttps");
|
|
|
|
yield return new TestCaseData(
|
|
new SecurityConfiguration
|
|
{
|
|
ApplicationCertificate = new CertificateIdentifier { RawData = [] },
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedIssuerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
HttpsIssuerCertificates = new CertificateTrustList { StorePath = "Test" }
|
|
}
|
|
).SetName("OnlyIssuerHttps");
|
|
|
|
yield return new TestCaseData(
|
|
new SecurityConfiguration
|
|
{
|
|
ApplicationCertificate = new CertificateIdentifier { RawData = [] },
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedIssuerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
HttpsIssuerCertificates = new CertificateTrustList { StorePath = string.Empty },
|
|
TrustedHttpsCertificates = new CertificateTrustList { StorePath = "Test" }
|
|
}
|
|
).SetName("InvalidHttpsIssuer");
|
|
|
|
yield return new TestCaseData(
|
|
new SecurityConfiguration
|
|
{
|
|
ApplicationCertificate = new CertificateIdentifier { RawData = [] },
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedIssuerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
HttpsIssuerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedHttpsCertificates = new CertificateTrustList { StorePath = string.Empty }
|
|
}
|
|
).SetName("InvalidHttpsTrusted");
|
|
|
|
yield return new TestCaseData(
|
|
new SecurityConfiguration
|
|
{
|
|
ApplicationCertificate = new CertificateIdentifier { RawData = [] },
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedIssuerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedUserCertificates = new CertificateTrustList { StorePath = "Test" }
|
|
}
|
|
).SetName("OnlyTrustedUser");
|
|
|
|
yield return new TestCaseData(
|
|
new SecurityConfiguration
|
|
{
|
|
ApplicationCertificate = new CertificateIdentifier { RawData = [] },
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedIssuerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
UserIssuerCertificates = new CertificateTrustList { StorePath = "Test" }
|
|
}
|
|
).SetName("OnlyIssuerUser");
|
|
|
|
yield return new TestCaseData(
|
|
new SecurityConfiguration
|
|
{
|
|
ApplicationCertificate = new CertificateIdentifier { RawData = [] },
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedIssuerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
UserIssuerCertificates = new CertificateTrustList { StorePath = string.Empty },
|
|
TrustedUserCertificates = new CertificateTrustList { StorePath = "Test" }
|
|
}
|
|
).SetName("InvalidUserIssuer");
|
|
|
|
yield return new TestCaseData(
|
|
new SecurityConfiguration
|
|
{
|
|
ApplicationCertificate = new CertificateIdentifier { RawData = [] },
|
|
TrustedPeerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedIssuerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
UserIssuerCertificates = new CertificateTrustList { StorePath = "Test" },
|
|
TrustedUserCertificates = new CertificateTrustList { StorePath = string.Empty }
|
|
}
|
|
).SetName("InvalidUserTrusted");
|
|
}
|
|
|
|
private static IServiceMessageContext CreateMessageContext()
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
using IDisposable scope = AmbientMessageContext.SetScopedContext(telemetry);
|
|
return AmbientMessageContext.CurrentContext
|
|
?? ServiceMessageContext.CreateEmpty(telemetry);
|
|
}
|
|
|
|
private static ApplicationConfiguration DecodeApplicationConfiguration(Stream stream)
|
|
{
|
|
IServiceMessageContext ctx = CreateMessageContext();
|
|
var parser = new XmlParser(typeof(ApplicationConfiguration), stream, ctx);
|
|
var config = new ApplicationConfiguration();
|
|
config.Decode(parser);
|
|
return config;
|
|
}
|
|
|
|
private static string EncodeApplicationConfiguration(
|
|
ApplicationConfiguration configuration)
|
|
{
|
|
IServiceMessageContext ctx = CreateMessageContext();
|
|
using var stream = new MemoryStream();
|
|
XmlWriterSettings settings = Utils.DefaultXmlWriterSettings();
|
|
settings.Encoding = new UTF8Encoding(false);
|
|
using (var writer = XmlWriter.Create(stream, settings))
|
|
{
|
|
var encoder = new XmlEncoder(
|
|
typeof(ApplicationConfiguration), writer, ctx);
|
|
configuration.Encode(encoder);
|
|
encoder.Close();
|
|
}
|
|
|
|
return Encoding.UTF8.GetString(stream.ToArray());
|
|
}
|
|
}
|
|
}
|