mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-21 09:06:37 +08:00
1cca744b5c
Closes #4201. Closes #4202. Closes #4203. Closes #4215. Closes #4216. (#4215 and #4216 are @marcschier's originals from the #4188 review; #4202 and #4201 are my later duplicates of the same two findings. All four describe the two changes in section 1 and are closed together.) **This PR now carries what was #4221 as well.** The two were a stack; they have been unstacked and combined here, and #4221 is closed. Everything below the "Read the server diagnostics" section is the work that was previously reviewed as #4221. --- ## 1. The browse path guards itself, and the last node locks are gone `AsyncCustomNodeManager` kept two `lock (source)` sites around `CreateBrowser`, carrying a NOTE that browser creation was not internally synchronized. `NodeBrowser` still handed its lock to derived types through `protected Lock DataLock`. `NodeState.CreateBrowser` now holds a browse lock across `PopulateBrowser` and `OnPopulateBrowser`, so browser construction on a node is serialized — which is what the external `lock (source)` was actually providing, and what a handler that mutates the node during population (the historian's lazy config installer) depends on. Both `lock (source)` statements and the NOTE are gone. **What that lock does not do**, stated plainly in the XML docs and in `docs/NodeManagers.md` rather than over-promised: it is not an atomic snapshot across the node's children, notifiers and references. Writers take those collections' own locks, not the browse lock. The browser is a point-in-time copy and each collection is read consistently, but the combination is not a transaction. No `lock` takes a `NodeState` as its sync root any more. That was the last thing keeping `NodeState` from being documentably self-guarding, so the other eleven went with it: `lock (activeNode)`, `lock (target)`, `lock (source.Node)`, `lock (target.Node)`, `lock (notifier)`, `lock (handle.Node)` in `AsyncCustomNodeManager`, and `lock (node)` in `CustomNodeManager2`. Most were a check-then-act pair now served by `NodeState.AddReferenceIfMissing`, which does the check and the insert under the node's own lock. `NodeBrowser.DataLock` is removed. A browser is **single-consumer**: it belongs to whoever created it, and both server browse paths already serialize on the owning side. The exposed lock only added an inheritance-level locking contract that a derived browser could not reason about. ## 2. Read the server diagnostics under the lock every writer takes `OnUpdateDiagnostics` locked the diagnostics **payload** rather than the lock every writer takes through `UpdateServerDiagnostics`, so the snapshot a client reads from the `ServerDiagnostics` node was never excluded from a concurrent writer. Both halves matter, and the second is the one that is easy to miss: ```csharp lock (m_diagnosticsLock) // was: lock (ServerDiagnostics) { value = Variant.FromStructure(ServerDiagnostics, copy: true); // was: copy defaulted to false } ``` `copy: true` is what makes it a snapshot. `FromStructure(value, copy: false)` does `new ExtensionObject(value, copy)` — it wraps the **live** structure without copying it, so the caller would read the fields long after the lock was released and see them change underneath. Swapping the lock alone would have looked like a fix while still excluding nothing. ## 3. Analyzer numbering The browser rule is **UA0027**, not UA0025. This branch had independently taken UA0025 for `NodeBrowser.DataLock` while #4188 published UA0025 for `ILocalNode.DataLock` and UA0026 for `BaseVariableValue.Lock`. Master's are shipped, so they keep the numbers: | | UA0025 | UA0026 | UA0027 | |---|---|---|---| | master (#4188) | `ILocalNode.DataLock` | `BaseVariableValue.Lock` | — | | **this PR** | `ILocalNode.DataLock` | `BaseVariableValue.Lock` | **`NodeBrowser.DataLock`** | Both sides had written a different `UA0025Tests.cs`, which arrived as an add/add conflict. They are now split: `UA0025Tests.cs` holds master's `ILocalNode` tests, `UA0027Tests.cs` holds the `NodeBrowser` ones. UA0024's help text also drops its reference to `ReadServerDiagnostics`, which #4193 removed as unused, and names `ISession.ReadDiagnostics` / `ISubscription.ReadDiagnostics` instead — those do still exist. ## 4. Two more locks reachable from outside their owner **`ApplicationConfiguration.PropertiesLock` is removed.** It returned the properties dictionary itself, so `lock (configuration.PropertiesLock)` was `lock (configuration.Properties)` — the lock *was* the data it guarded, the same shape as #4203. It had exactly one production consumer (`OAuth2CredentialCollection.Load`, a get-or-add with `ParseExtension` called inside the lock), so it could not simply be deleted. `Properties` is now a `ConcurrentDictionary` — same public type, every operation atomic on its own — and the one multi-operation need gets a member of its own: ```csharp public T GetOrAddProperty<T>(string key, Func<T> valueFactory); ``` It deliberately does **not** invoke the factory under a lock, so `ParseExtension` now runs outside any critical section. Holding a lock across a caller-supplied callback is exactly the shape that produced the attribute/diagnostics deadlock earlier in this work. The two existing tests asserted only `PropertiesLock is not null`, so they tested nothing but its presence. They are replaced by tests of the contract: factory runs once for a missing key, not at all for a present one, 32 concurrent callers all observe the same instance, null arguments throw. `PropertiesLock` ships in 1.5.378, so this is a breaking removal — migration guide section plus analyzer **UA0028**. **`SharedDefinitionCache` no longer hands out its lock.** Three sites in `SharedKeyValueSubscriptionStore` took the nested cache's `Lock` to operate on the cache's own dictionary. Both are private now, behind `ReplaceAll` and `CloneWhere`. `SnapshotCommitLock` stays exposed on purpose: it is a `SemaphoreSlim` sequencing an async commit across `await` points, which `System.Threading.Lock` cannot span, so folding it in would change behaviour rather than hide a lock. ## Verification Merged `master` (`0edfe237a`, including #4234) with no conflicts. - `dotnet build UA.slnx` — 0 warnings, 0 errors - `Opc.Ua.Server.Tests` — 4074 passed - `Opc.Ua.Types.Tests` — 8501 passed - `Opc.Ua.MigrationAnalyzer.Tests` — 151 passed on all five TFMs (138 → 151, the new ones being UA0027 and UA0028) - `Opc.Ua.Core.Tests` — 4249 passed - `Opc.Ua.Redundancy.Server.Tests` — 573 passed ## Note for the reviewer @romanett — your approval was given when this PR's diff was the 7 diagnostics files, because it was measured against `marcschier/node-browse-locks`. Now that the two are combined and the base is `master`, the diff is 23 files, and the extra 16 are the node/browser lock work that was #4221. GitHub kept the approval across the retarget, but it did not cover that code, so please re-review rather than let it ride. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e9c13dd0-a6e3-4ad2-8ad6-1c3fe6323041 Copilot-Session: b3c0e146-5b9e-4d08-a0f6-db3f940484b1 Copilot-Session: d18f87e9-2484-44ce-98ce-463ba6cf5f63 Copilot-Session: 0ee22c1d-c319-4257-bf78-a5a077a1824a
620 lines
23 KiB
C#
620 lines
23 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.IO;
|
|
using System.Threading.Tasks;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Tests;
|
|
|
|
namespace Opc.Ua.Core.Tests
|
|
{
|
|
[TestFixture]
|
|
[Category("ApplicationConfigurationEncoding")]
|
|
[SetCulture("en-us")]
|
|
[SetUICulture("en-us")]
|
|
[Parallelizable]
|
|
public class ApplicationConfigurationEncodingTests
|
|
{
|
|
private ITelemetryContext m_telemetry;
|
|
private string m_tempDir;
|
|
|
|
[OneTimeSetUp]
|
|
public void OneTimeSetUp()
|
|
{
|
|
m_telemetry = NUnitTelemetryContext.Create();
|
|
m_tempDir = Path.Combine(
|
|
Path.GetTempPath(),
|
|
"OpcUaTestAppConfigEncoding_" + Guid.NewGuid().ToString("N"));
|
|
Directory.CreateDirectory(m_tempDir);
|
|
}
|
|
|
|
[OneTimeTearDown]
|
|
public void OneTimeTearDown()
|
|
{
|
|
try
|
|
{
|
|
Directory.Delete(m_tempDir, true);
|
|
}
|
|
catch
|
|
{
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void DefaultConstructorCreatesValidDefaults()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry);
|
|
|
|
Assert.That(config.SecurityConfiguration, Is.Not.Null);
|
|
Assert.That(config.TransportConfigurations.IsNull, Is.False);
|
|
Assert.That(config.Properties, Is.Not.Null);
|
|
Assert.That(config.ExtensionObjects, Is.Not.Null);
|
|
// CertificateManager is created lazily by ValidateAsync; it
|
|
// is null until the configuration is validated.
|
|
Assert.That(config.CertificateManager, Is.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void CopyConstructorCopiesAllProperties()
|
|
{
|
|
var original = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
ApplicationName = "TestApp",
|
|
ApplicationUri = "urn:test:app",
|
|
ApplicationType = ApplicationType.Client,
|
|
ProductUri = "urn:test:product",
|
|
DisableHiResClock = true,
|
|
TransportQuotas = new TransportQuotas
|
|
{
|
|
MaxMessageSize = 4096
|
|
}
|
|
};
|
|
|
|
var copy = new ApplicationConfiguration(original);
|
|
|
|
Assert.That(copy.ApplicationName, Is.EqualTo("TestApp"));
|
|
Assert.That(copy.ApplicationUri, Is.EqualTo("urn:test:app"));
|
|
Assert.That(copy.ApplicationType, Is.EqualTo(ApplicationType.Client));
|
|
Assert.That(copy.DisableHiResClock, Is.True);
|
|
Assert.That(copy.TransportQuotas.MaxMessageSize, Is.EqualTo(4096));
|
|
}
|
|
|
|
[Test]
|
|
public void SecurityConfigurationSetterRejectsNull()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
SecurityConfiguration = null
|
|
};
|
|
Assert.That(config.SecurityConfiguration, Is.Not.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void TransportConfigurationsGetSet()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry);
|
|
var transports = new ArrayOf<TransportConfiguration>();
|
|
config.TransportConfigurations = transports;
|
|
Assert.That(config.TransportConfigurations.Count, Is.EqualTo(transports.Count));
|
|
}
|
|
|
|
[Test]
|
|
public void ExtensionsGetSet()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry);
|
|
var extensions = new ArrayOf<XmlElement>();
|
|
config.Extensions = extensions;
|
|
Assert.That(config.Extensions.Count, Is.EqualTo(extensions.Count));
|
|
}
|
|
|
|
[Test]
|
|
public void CreateMessageContextWithoutTransportQuotas()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
TransportQuotas = null
|
|
};
|
|
|
|
ServiceMessageContext ctx = config.CreateMessageContext();
|
|
Assert.That(ctx, Is.Not.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void CreateMessageContextWithTransportQuotas()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
TransportQuotas = new TransportQuotas
|
|
{
|
|
MaxArrayLength = 1000,
|
|
MaxByteStringLength = 2000,
|
|
MaxStringLength = 3000,
|
|
MaxMessageSize = 4000,
|
|
MaxEncodingNestingLevels = 50,
|
|
MaxDecoderRecoveries = 10
|
|
}
|
|
};
|
|
|
|
ServiceMessageContext ctx = config.CreateMessageContext();
|
|
Assert.That(ctx.MaxArrayLength, Is.EqualTo(1000));
|
|
Assert.That(ctx.MaxByteStringLength, Is.EqualTo(2000));
|
|
Assert.That(ctx.MaxStringLength, Is.EqualTo(3000));
|
|
Assert.That(ctx.MaxMessageSize, Is.EqualTo(4000));
|
|
Assert.That(ctx.MaxEncodingNestingLevels, Is.EqualTo(50));
|
|
Assert.That(ctx.MaxDecoderRecoveries, Is.EqualTo(10));
|
|
}
|
|
|
|
[Test]
|
|
public void CreateMessageContextWithCustomFactory()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry);
|
|
IEncodeableFactory factory = EncodeableFactory.Create();
|
|
|
|
ServiceMessageContext ctx = config.CreateMessageContext(factory);
|
|
Assert.That(ctx, Is.Not.Null);
|
|
Assert.That(ctx.Factory, Is.SameAs(factory));
|
|
}
|
|
|
|
[Test]
|
|
public void CreateMessageContextWithNullFactoryCreatesNewOne()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry);
|
|
|
|
ServiceMessageContext ctx = config.CreateMessageContext(null);
|
|
Assert.That(ctx, Is.Not.Null);
|
|
Assert.That(ctx.Factory, Is.Not.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void GetServerDomainNamesWithNoServerConfig()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry);
|
|
ArrayOf<string> domains = config.GetServerDomainNames();
|
|
Assert.That(domains.Count, Is.Zero);
|
|
}
|
|
|
|
[Test]
|
|
public void GetServerDomainNamesWithBaseAddresses()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
ServerConfiguration = new ServerConfiguration()
|
|
};
|
|
config.ServerConfiguration.BaseAddresses = ["opc.tcp://localhost:4840"];
|
|
|
|
ArrayOf<string> domains = config.GetServerDomainNames();
|
|
Assert.That(domains.Count, Is.GreaterThan(0));
|
|
}
|
|
|
|
[Test]
|
|
public void GetServerDomainNamesWithAlternateBaseAddresses()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
ServerConfiguration = new ServerConfiguration()
|
|
};
|
|
config.ServerConfiguration.AlternateBaseAddresses = ["opc.tcp://192.168.1.1:4840"];
|
|
|
|
ArrayOf<string> domains = config.GetServerDomainNames();
|
|
Assert.That(domains.Count, Is.GreaterThan(0));
|
|
}
|
|
|
|
[Test]
|
|
public void GetServerDomainNamesWithDiscoveryServerConfig()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
DiscoveryServerConfiguration = new DiscoveryServerConfiguration()
|
|
};
|
|
config.DiscoveryServerConfiguration.BaseAddresses = ["opc.tcp://localhost:4840"];
|
|
|
|
ArrayOf<string> domains = config.GetServerDomainNames();
|
|
Assert.That(domains.Count, Is.GreaterThan(0));
|
|
}
|
|
|
|
[Test]
|
|
public void GetServerDomainNamesDeduplicates()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
ServerConfiguration = new ServerConfiguration()
|
|
};
|
|
config.ServerConfiguration.BaseAddresses =
|
|
[
|
|
"opc.tcp://localhost:4840",
|
|
"opc.tcp://localhost:4841"
|
|
];
|
|
|
|
ArrayOf<string> domains = config.GetServerDomainNames();
|
|
Assert.That(domains.Count, Is.EqualTo(1));
|
|
}
|
|
|
|
[Test]
|
|
public void GetServerDomainNamesSkipsInvalidUris()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
ServerConfiguration = new ServerConfiguration()
|
|
};
|
|
config.ServerConfiguration.BaseAddresses = ["not a valid uri !!!"];
|
|
|
|
ArrayOf<string> domains = config.GetServerDomainNames();
|
|
Assert.That(domains.Count, Is.Zero);
|
|
}
|
|
|
|
[Test]
|
|
public void SaveToFileAndLoadWithNoValidationRoundTrip()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
ApplicationName = "RoundTripApp",
|
|
ApplicationUri = "urn:test:roundtrip",
|
|
ApplicationType = ApplicationType.ClientAndServer,
|
|
ProductUri = "urn:test:product"
|
|
};
|
|
|
|
string filePath = Path.Combine(m_tempDir, "roundtrip_config.xml");
|
|
config.SaveToFile(filePath);
|
|
|
|
Assert.That(File.Exists(filePath), Is.True);
|
|
Assert.That(new FileInfo(filePath).Length, Is.GreaterThan(0));
|
|
|
|
var loaded = ApplicationConfiguration.LoadWithNoValidation(
|
|
new FileInfo(filePath),
|
|
typeof(ApplicationConfiguration),
|
|
m_telemetry);
|
|
|
|
Assert.That(loaded, Is.Not.Null);
|
|
Assert.That(loaded.ApplicationName, Is.EqualTo("RoundTripApp"));
|
|
Assert.That(loaded.ApplicationUri, Is.EqualTo("urn:test:roundtrip"));
|
|
Assert.That(loaded.ApplicationType, Is.EqualTo(ApplicationType.ClientAndServer));
|
|
Assert.That(loaded.SourceFilePath, Is.EqualTo(new FileInfo(filePath).FullName));
|
|
}
|
|
|
|
[Test]
|
|
public void SaveToFileWithTransportQuotasAndReload()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
ApplicationName = "QuotasApp",
|
|
ApplicationUri = "urn:test:quotas",
|
|
ApplicationType = ApplicationType.Server,
|
|
TransportQuotas = new TransportQuotas
|
|
{
|
|
MaxMessageSize = 8192,
|
|
MaxArrayLength = 500
|
|
}
|
|
};
|
|
|
|
string filePath = Path.Combine(m_tempDir, "quotas_config.xml");
|
|
config.SaveToFile(filePath);
|
|
|
|
var loaded = ApplicationConfiguration.LoadWithNoValidation(
|
|
new FileInfo(filePath),
|
|
typeof(ApplicationConfiguration),
|
|
m_telemetry);
|
|
|
|
Assert.That(loaded.TransportQuotas, Is.Not.Null);
|
|
Assert.That(loaded.TransportQuotas.MaxMessageSize, Is.EqualTo(8192));
|
|
Assert.That(loaded.TransportQuotas.MaxArrayLength, Is.EqualTo(500));
|
|
}
|
|
|
|
[Test]
|
|
public void SaveToFileWithServerConfiguration()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
ApplicationName = "ServerApp",
|
|
ApplicationUri = "urn:test:server",
|
|
ApplicationType = ApplicationType.Server,
|
|
ServerConfiguration = new ServerConfiguration()
|
|
};
|
|
config.ServerConfiguration.BaseAddresses = ["opc.tcp://localhost:4840"];
|
|
config.ServerConfiguration.MaxRegistrationInterval = 30000;
|
|
|
|
string filePath = Path.Combine(m_tempDir, "server_config.xml");
|
|
config.SaveToFile(filePath);
|
|
|
|
var loaded = ApplicationConfiguration.LoadWithNoValidation(
|
|
new FileInfo(filePath),
|
|
typeof(ApplicationConfiguration),
|
|
m_telemetry);
|
|
|
|
Assert.That(loaded.ServerConfiguration, Is.Not.Null);
|
|
Assert.That(loaded.ServerConfiguration.MaxRegistrationInterval, Is.EqualTo(30000));
|
|
}
|
|
|
|
[Test]
|
|
public void SaveToFileWithClientConfiguration()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
ApplicationName = "ClientApp",
|
|
ApplicationUri = "urn:test:client",
|
|
ApplicationType = ApplicationType.Client,
|
|
ClientConfiguration = new ClientConfiguration()
|
|
};
|
|
config.ClientConfiguration.DefaultSessionTimeout = 60000;
|
|
|
|
string filePath = Path.Combine(m_tempDir, "client_config.xml");
|
|
config.SaveToFile(filePath);
|
|
|
|
var loaded = ApplicationConfiguration.LoadWithNoValidation(
|
|
new FileInfo(filePath),
|
|
typeof(ApplicationConfiguration),
|
|
m_telemetry);
|
|
|
|
Assert.That(loaded.ClientConfiguration, Is.Not.Null);
|
|
Assert.That(loaded.ClientConfiguration.DefaultSessionTimeout, Is.EqualTo(60000));
|
|
}
|
|
|
|
[Test]
|
|
public void LoadWithNoValidationThrowsOnMissingFile()
|
|
{
|
|
string missingPath = Path.Combine(m_tempDir, "does_not_exist.xml");
|
|
Assert.That(
|
|
() => ApplicationConfiguration.LoadWithNoValidation(
|
|
new FileInfo(missingPath),
|
|
typeof(ApplicationConfiguration),
|
|
m_telemetry),
|
|
Throws.Exception);
|
|
}
|
|
|
|
[Test]
|
|
public void LoadWithNoValidationNullSystemTypeDefaultsToBase()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
ApplicationName = "NullTypeApp",
|
|
ApplicationUri = "urn:test:nulltype",
|
|
ApplicationType = ApplicationType.Client
|
|
};
|
|
string filePath = Path.Combine(m_tempDir, "nulltype_config.xml");
|
|
config.SaveToFile(filePath);
|
|
|
|
var loaded = ApplicationConfiguration.LoadWithNoValidation(
|
|
new FileInfo(filePath),
|
|
null,
|
|
m_telemetry);
|
|
|
|
Assert.That(loaded, Is.Not.Null);
|
|
Assert.That(loaded.ApplicationName, Is.EqualTo("NullTypeApp"));
|
|
}
|
|
|
|
[Test]
|
|
public void GetFilePathFromAppConfigReturnsDefaultOnMissing()
|
|
{
|
|
string result = ApplicationConfiguration.GetFilePathFromAppConfig(
|
|
"NonExistentSection_" + Guid.NewGuid().ToString("N"),
|
|
LoggerUtils.Null.Logger);
|
|
Assert.That(result, Is.Not.Null);
|
|
Assert.That(result, Does.EndWith(".Config.xml"));
|
|
}
|
|
|
|
[Test]
|
|
public void ValidateAsyncThrowsWhenApplicationNameEmpty()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
ApplicationName = string.Empty,
|
|
ApplicationUri = "urn:test:empty"
|
|
};
|
|
Assert.That(
|
|
async () => await config.ValidateAsync(ApplicationType.Client).ConfigureAwait(false),
|
|
Throws.TypeOf<ServiceResultException>());
|
|
}
|
|
|
|
[Test]
|
|
public void ValidateAsyncThrowsWhenSecurityConfigurationNull()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
ApplicationName = "TestApp",
|
|
ApplicationUri = "urn:test:nosecurity"
|
|
};
|
|
|
|
// SecurityConfiguration setter replaces null with new instance,
|
|
// so we test the validate path by setting it to a valid one
|
|
// then relying on it to succeed at the Name check.
|
|
Assert.That(config.SecurityConfiguration, Is.Not.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void SaveToFileWithDiscoveryServerConfiguration()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
ApplicationName = "DiscoveryApp",
|
|
ApplicationUri = "urn:test:discovery",
|
|
ApplicationType = ApplicationType.DiscoveryServer,
|
|
DiscoveryServerConfiguration = new DiscoveryServerConfiguration()
|
|
};
|
|
config.DiscoveryServerConfiguration.BaseAddresses = ["opc.tcp://localhost:4840/discovery"];
|
|
|
|
string filePath = Path.Combine(m_tempDir, "discovery_config.xml");
|
|
config.SaveToFile(filePath);
|
|
|
|
var loaded = ApplicationConfiguration.LoadWithNoValidation(
|
|
new FileInfo(filePath),
|
|
typeof(ApplicationConfiguration),
|
|
m_telemetry);
|
|
|
|
Assert.That(loaded.DiscoveryServerConfiguration, Is.Not.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void SaveToFileWithDisableHiResClock()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
ApplicationName = "ClockApp",
|
|
ApplicationUri = "urn:test:clock",
|
|
ApplicationType = ApplicationType.Client,
|
|
DisableHiResClock = true
|
|
};
|
|
|
|
string filePath = Path.Combine(m_tempDir, "clock_config.xml");
|
|
config.SaveToFile(filePath);
|
|
|
|
var loaded = ApplicationConfiguration.LoadWithNoValidation(
|
|
new FileInfo(filePath),
|
|
typeof(ApplicationConfiguration),
|
|
m_telemetry);
|
|
|
|
Assert.That(loaded.DisableHiResClock, Is.True);
|
|
}
|
|
|
|
[Test]
|
|
public void SaveToFileWithTraceConfiguration()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
ApplicationName = "TraceApp",
|
|
ApplicationUri = "urn:test:trace",
|
|
ApplicationType = ApplicationType.Client,
|
|
TraceConfiguration = new TraceConfiguration()
|
|
};
|
|
|
|
string filePath = Path.Combine(m_tempDir, "trace_config.xml");
|
|
config.SaveToFile(filePath);
|
|
|
|
var loaded = ApplicationConfiguration.LoadWithNoValidation(
|
|
new FileInfo(filePath),
|
|
typeof(ApplicationConfiguration),
|
|
m_telemetry);
|
|
|
|
Assert.That(loaded.TraceConfiguration, Is.Not.Null);
|
|
}
|
|
|
|
[Test]
|
|
public void PropertiesDictionaryIsUsable()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry);
|
|
config.Properties["key1"] = "value1";
|
|
config.Properties["key2"] = 42;
|
|
|
|
Assert.That(config.Properties["key1"], Is.EqualTo("value1"));
|
|
Assert.That(config.Properties["key2"], Is.EqualTo(42));
|
|
Assert.That(config.Properties, Has.Count.EqualTo(2));
|
|
}
|
|
|
|
[Test]
|
|
public void ExtensionObjectsListIsUsable()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry);
|
|
config.ExtensionObjects.Add("test");
|
|
Assert.That(config.ExtensionObjects, Has.Count.EqualTo(1));
|
|
}
|
|
|
|
[Test]
|
|
public Task LoadAsyncFromStreamRoundTrip()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
ApplicationName = "StreamApp",
|
|
ApplicationUri = "urn:test:stream",
|
|
ApplicationType = ApplicationType.Client
|
|
};
|
|
|
|
string filePath = Path.Combine(m_tempDir, "stream_config.xml");
|
|
config.SaveToFile(filePath);
|
|
|
|
var loaded = ApplicationConfiguration.LoadWithNoValidation(
|
|
new FileInfo(filePath),
|
|
typeof(ApplicationConfiguration),
|
|
m_telemetry);
|
|
|
|
Assert.That(loaded, Is.Not.Null);
|
|
Assert.That(loaded.ApplicationName, Is.EqualTo("StreamApp"));
|
|
return Task.CompletedTask;
|
|
}
|
|
|
|
[Test]
|
|
public void LoadAsyncFromFileInfoRoundTrip()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
ApplicationName = "FileInfoApp",
|
|
ApplicationUri = "urn:test:fileinfo",
|
|
ApplicationType = ApplicationType.Client
|
|
};
|
|
|
|
string filePath = Path.Combine(m_tempDir, "fileinfo_config.xml");
|
|
config.SaveToFile(filePath);
|
|
|
|
var loaded = ApplicationConfiguration.LoadWithNoValidation(
|
|
new FileInfo(filePath),
|
|
typeof(ApplicationConfiguration),
|
|
m_telemetry);
|
|
|
|
Assert.That(loaded, Is.Not.Null);
|
|
Assert.That(loaded.ApplicationName, Is.EqualTo("FileInfoApp"));
|
|
Assert.That(loaded.SourceFilePath, Is.EqualTo(new FileInfo(filePath).FullName));
|
|
}
|
|
|
|
[Test]
|
|
public void LoadAsyncFromFileInfoThrowsOnMissingFile()
|
|
{
|
|
string missingPath = Path.Combine(m_tempDir, "missing_file.xml");
|
|
Assert.That(
|
|
() => ApplicationConfiguration.LoadAsync(
|
|
new FileInfo(missingPath),
|
|
ApplicationType.Client,
|
|
typeof(ApplicationConfiguration),
|
|
false,
|
|
m_telemetry),
|
|
Throws.TypeOf<ServiceResultException>());
|
|
}
|
|
|
|
[Test]
|
|
public void GetServerDomainNamesWithDiscoveryAlternateAddresses()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry)
|
|
{
|
|
DiscoveryServerConfiguration = new DiscoveryServerConfiguration()
|
|
};
|
|
config.DiscoveryServerConfiguration.AlternateBaseAddresses = ["opc.tcp://10.0.0.1:4840"];
|
|
|
|
ArrayOf<string> domains = config.GetServerDomainNames();
|
|
Assert.That(domains.Count, Is.GreaterThan(0));
|
|
}
|
|
|
|
#pragma warning disable CS0618
|
|
[Test]
|
|
public void CreateMessageContextObsoleteOverload()
|
|
{
|
|
var config = new ApplicationConfiguration(m_telemetry);
|
|
ServiceMessageContext ctx = config.CreateMessageContext(true);
|
|
Assert.That(ctx, Is.Not.Null);
|
|
}
|
|
#pragma warning restore CS0618
|
|
}
|
|
}
|