Files
UA-.NETStandard/tests/Opc.Ua.Server.Tests/Identity/KeyCredentialBridgeAuthenticatorTests.cs
afbd10e3e3 Expose runtime capability probes to fix TFM-skew test failures (#4282) (#4295)
# Description

The nightly `Test .NETStandard 2.1 Tests (net8.0)` leg compiles the
stack as `netstandard2.1` but runs the test assemblies as `net8.0`.
Features gated with `#if NET8_0_OR_GREATER` / `#if NET5_0_OR_GREATER` in
the stack are therefore absent at runtime, while the tests assume they
exist because a `#if` in a test reflects the *test's* TFM (always net8.0
on this leg), not the stack's compiled TFM. This causes the affected
tests to fail on that leg.

This PR fixes it by exposing stack-side runtime capability probes. Each
probe lives in the same assembly as the feature it gates, so its `#if`
reflects that assembly's actual compilation. Affected tests now
`Assert.Ignore(...)` or branch based on the probe instead of relying on
their own compile-time `#if`.

## Approach

New public probes:

- `DtlsRecordProtection.IsAeadSupported` (+ `IsAeadCipherSuite` made
public) - Opc.Ua.PubSub.Udp, net8 gate
- `DtlsEcdheKeyExchange.IsRawSharedSecretSupported` - Opc.Ua.PubSub.Udp,
net8 gate
-
`AdditionalEntropyCertificateKeyGenerator.IsEccKeyRegenerationSupported`
- Opc.Ua.Server, net5 gate
- `HttpsTransportListener.IsWssTransportSupported` -
Opc.Ua.Bindings.Https, `NET5_0_OR_GREATER || NETFRAMEWORK` gate (false
only for the netstandard2.1 build)

Test updates:

- DTLS record/handshake/ECDHE tests skip AEAD/raw-shared-secret cases
when unsupported, preserving HMAC-suite coverage in parametrized tests.
- Server ECC key-regeneration tests skip when unsupported.
- The GDS push tests now *validate* the `BadNotSupported` result at
runtime via the probe rather than compiling out the assertion, which
also preserves the prior net48 behavior.
- The ExperimentalAttribute test probes the stack assembly's
`TargetFrameworkAttribute` at runtime instead of a meaningless
compile-time flag.
- The three WSS integration fixtures skip when WSS is unavailable on the
loaded runtime.

## Notes for reviewers

- On netstandard2.1 the `DtlsRecordProtection` constructor does not
throw for AEAD suites; the `NotSupportedException` surfaces later in
Seal/Open, so the skip is keyed on the cipher suite being AEAD *and*
`!IsAeadSupported`.
- The WSS probe gate returns false only for the netstandard2.1 build
(which defines neither `NET5_0_OR_GREATER` nor `NETFRAMEWORK`),
precisely isolating the build whose legacy Kestrel hosting cannot accept
WebSocket connections on a modern runtime.

Validated with clean builds (0 warnings, 0 errors) for the changed
source projects and for PubSub.Udp.Tests, Server.Tests, Sessions.Tests
and Gds.Tests on both net8.0 and net48.

## Related Issues

- Fixes #4282

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [ ] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: romanett <7413710+romanett@users.noreply.github.com>
2026-08-21 06:24:46 -07:00

265 lines
12 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
#pragma warning disable OPCUA_EXPERIMENTAL_KC_BRIDGE
using System;
using System.Collections.Generic;
using System.Linq;
using System.Reflection;
using System.Runtime.Versioning;
using System.Text;
using System.Threading;
using System.Threading.Tasks;
using NUnit.Framework;
using Opc.Ua.Identity;
using Opc.Ua.Tests;
namespace Opc.Ua.Server.Tests.Identity
{
[TestFixture]
[Category("Identity")]
[Category("KeyCredential")]
public class KeyCredentialBridgeAuthenticatorTests
{
private const string CredentialId = "credential-1";
private static readonly byte[] s_secret = [11, 22, 33, 44, 55, 66];
private static readonly string[] s_groups = ["engineering"];
private static readonly string[] s_roles = ["operator"];
private static readonly string[] s_scopes = ["ua.session"];
[Test]
public async Task AuthenticateAsyncValidProofAcceptedAndClaimsReturned()
{
using InMemoryKeyCredentialStore store = await CreateStoreAsync(DateTime.UtcNow.AddMinutes(10))
.ConfigureAwait(false);
var authenticator = new KeyCredentialBridgeAuthenticator(store);
AuthenticationResult result = await authenticator.AuthenticateAsync(
CreateContext(CreateTokenData(CredentialId, s_secret)))
.ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Accepted));
var claims = result.Identity as IIdentityClaims;
Assert.That(claims, Is.Not.Null);
Assert.That(claims.Subject, Is.EqualTo("subject-1"));
Assert.That(claims.Groups, Does.Contain("engineering"));
Assert.That(claims.Roles, Does.Contain("operator"));
Assert.That(claims.Claims["email"], Is.EqualTo("operator@example.test"));
}
[Test]
public async Task AuthenticateAsyncBadProofRejected()
{
using InMemoryKeyCredentialStore store = await CreateStoreAsync(DateTime.UtcNow.AddMinutes(10))
.ConfigureAwait(false);
var authenticator = new KeyCredentialBridgeAuthenticator(store);
byte[] tokenData = Encoding.UTF8.GetBytes(
"{\"credentialId\":\"credential-1\",\"nonce\":\"nonce\",\"issuedAt\":" +
DateTimeOffset.UtcNow.ToUnixTimeSeconds() +
",\"proof\":\"bad\"}");
AuthenticationResult result = await authenticator.AuthenticateAsync(CreateContext(tokenData))
.ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenRejected));
}
[Test]
public async Task RejectsTokenWithMalformedBase64UrlProof()
{
using InMemoryKeyCredentialStore store = await CreateStoreAsync(DateTime.UtcNow.AddMinutes(10))
.ConfigureAwait(false);
var authenticator = new KeyCredentialBridgeAuthenticator(store);
byte[] tokenData = Encoding.UTF8.GetBytes(
"{\"credentialId\":\"credential-1\",\"nonce\":\"nonce\",\"issuedAt\":" +
DateTimeOffset.UtcNow.ToUnixTimeSeconds() +
",\"proof\":\"not-base64!@#\"}");
AuthenticationResult result = await authenticator.AuthenticateAsync(CreateContext(tokenData))
.ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenInvalid));
}
[Test]
public async Task AuthenticateAsyncExpiredCredentialRejected()
{
using InMemoryKeyCredentialStore store = await CreateStoreAsync(DateTime.UtcNow.AddMinutes(-1))
.ConfigureAwait(false);
var authenticator = new KeyCredentialBridgeAuthenticator(store);
AuthenticationResult result = await authenticator.AuthenticateAsync(
CreateContext(CreateTokenData(CredentialId, s_secret)))
.ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenRejected));
}
[Test]
public async Task AuthenticateAsyncUnknownCredentialRejected()
{
using var store = new InMemoryKeyCredentialStore();
var authenticator = new KeyCredentialBridgeAuthenticator(store);
AuthenticationResult result = await authenticator.AuthenticateAsync(
CreateContext(CreateTokenData(CredentialId, s_secret)))
.ConfigureAwait(false);
Assert.That(result.Outcome, Is.EqualTo(AuthenticationOutcome.Rejected));
Assert.That(result.Error.Code, Is.EqualTo((uint)StatusCodes.BadIdentityTokenRejected));
}
[Test]
public void ConstructorAndMetadataExposeConfiguredIssuedTokenProfile()
{
using var store = new InMemoryKeyCredentialStore();
var options = new KeyCredentialBridgeOptions
{
ProfileUri = "urn:test:profile"
};
var authenticator = new KeyCredentialBridgeAuthenticator(store, options);
Assert.Multiple(() =>
{
Assert.That(authenticator.TokenType, Is.EqualTo(UserTokenType.IssuedToken));
Assert.That(authenticator.IssuedTokenProfileUri, Is.EqualTo("urn:test:profile"));
Assert.Throws<ArgumentNullException>(() => new KeyCredentialBridgeAuthenticator(null));
});
}
[Test]
public void CreateProofValidatesSecretAndReturnsBase64UrlProof()
{
string proof = KeyCredentialBridgeAuthenticator.CreateProof(
s_secret,
CredentialId,
"nonce",
DateTimeOffset.UtcNow.ToUnixTimeSeconds());
Assert.Multiple(() =>
{
Assert.That(proof, Is.Not.Empty);
Assert.That(proof, Does.Not.Contain("+"));
Assert.That(proof, Does.Not.Contain("/"));
Assert.Throws<ArgumentNullException>(() =>
KeyCredentialBridgeAuthenticator.CreateProof(null, CredentialId, "nonce", 1));
});
}
[Test]
public void ExperimentalAttributeIsPresent()
{
// The [Experimental] attribute is only emitted when Opc.Ua.Server is
// compiled for .NET 8 or later (the attribute type does not exist in
// the netstandard2.1 / .NET Framework BCL). This test assembly is
// always compiled for net8.0, so a compile-time #if would reflect the
// TEST target framework, not the STACK's. Probe the actual compiled
// target framework of the Opc.Ua.Server assembly under test instead.
string frameworkName = typeof(KeyCredentialBridgeAuthenticator).Assembly
.GetCustomAttribute<TargetFrameworkAttribute>()?.FrameworkName;
// frameworkName looks like ".NETCoreApp,Version=v8.0",
// ".NETStandard,Version=v2.1" or ".NETFramework,Version=v4.8".
bool stackIsNet8OrGreater = false;
if (frameworkName != null &&
frameworkName.StartsWith(".NETCoreApp", StringComparison.Ordinal))
{
string[] parts = frameworkName.Split('=');
string versionText = parts.Length > 1
? parts[parts.Length - 1].TrimStart('v', 'V')
: string.Empty;
stackIsNet8OrGreater =
Version.TryParse(versionText, out Version version) && version.Major >= 8;
}
if (!stackIsNet8OrGreater)
{
Assert.Ignore(
"ExperimentalAttribute is only emitted when Opc.Ua.Server is compiled for " +
".NET 8 or later.");
}
object attribute = typeof(KeyCredentialBridgeAuthenticator)
.GetCustomAttributes(false)
.SingleOrDefault(a => a.GetType().FullName ==
"System.Diagnostics.CodeAnalysis.ExperimentalAttribute");
Assert.That(attribute, Is.Not.Null);
}
private static async Task<InMemoryKeyCredentialStore> CreateStoreAsync(DateTime expiration)
{
var store = new InMemoryKeyCredentialStore();
var claims = new Dictionary<string, object>
{
["iss"] = "urn:test:issuer",
["sub"] = "subject-1",
["email"] = "operator@example.test",
["groups"] = s_groups,
["roles"] = s_roles
};
await store.UpdateAsync(
CredentialId,
new Server.KeyCredential(s_secret, expiration, claims, s_scopes),
CancellationToken.None)
.ConfigureAwait(false);
return store;
}
private static AuthenticationContext CreateContext(byte[] tokenData)
{
return new AuthenticationContext(
new IssuedIdentityTokenHandler(KeyCredentialBridgeOptions.DefaultProfileUri, tokenData),
new UserTokenPolicy
{
TokenType = UserTokenType.IssuedToken,
PolicyId = "keycredential",
IssuedTokenType = KeyCredentialBridgeOptions.DefaultProfileUri
},
new EndpointDescription { SecurityMode = MessageSecurityMode.SignAndEncrypt },
ServiceMessageContext.CreateEmpty(NUnitTelemetryContext.Create()));
}
private static byte[] CreateTokenData(string credentialId, byte[] secret)
{
return KeyCredentialBridgeAuthenticator.CreateTokenData(
credentialId,
secret,
"nonce-" + Guid.NewGuid().ToString("N"),
DateTime.UtcNow);
}
}
}
#pragma warning restore OPCUA_EXPERIMENTAL_KC_BRIDGE