mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-21 17:16:16 +08:00
0357380335
**Stack 2/5** — base #4123. Part of the #4096 split; see #4096 for the overall picture. > Review after #4123. The diff shown against `master` will include #4123 until that merges. ## What this is Source generator only; no runtime library changes. ## Contents - **Typed NodeSet method signatures.** A method imported from a NodeSet now gets a typed signature. Methods that share a declared signature are grouped onto one generated `MethodType`, named after its owner when the plain name would collide, so two unrelated `Execute` methods no longer share a class. - **An override that keeps the signature it inherits keeps the declaration it overrides.** Pointing `MethodDeclarationNode` at the override itself made `MethodDeclarationId` self-referential. OPC 10000-4 lets a caller invoke a method with the NodeId of its declaration in the ObjectType *or any supertype*, and `MethodState.MethodDeclarationId` is what the server matches on, so `Call` stopped resolving and returned `Bad_MethodInvalid` for every alarm subtype. An override that genuinely changes its signature still becomes its own declaration. - **`StateNumbers` / `TransitionNumbers` were emitted empty for every NodeSet-sourced model**, because such children arrive as `VariableDesign` rather than `PropertyDesign` and were filtered out. Any companion model built from a NodeSet was writing `StateNumber = 0` on the wire — a Part 16 defect well beyond the models in this stack. The ModelDesign path is unchanged. - **Referenced models can contribute fluent accessors**, carried by a model dependency payload so a downstream model can extend an upstream one. ## Notes for the reviewer - `tests/Opc.Ua.SourceGeneration.Tests` is left at its `master` content here. Its new vendor-subtype test uses the Robotics NodeSet as its fixture, so it can only land with the Robotics change at the top of the stack (5/5). - `PumpInstanceNodeIdRegressionTests` gains six `InputArguments`/`OutputArguments` entries for argument-less standard condition methods. Typed method signatures materialise those properties from the `ConditionType` declaration even where the method takes none. That is a real deviation, pinned rather than hidden so it stays visible; it is worth a follow-up. ## Validation `dotnet build UA.slnx` — 0 errors. | Suite | Result | | --- | --- | | Opc.Ua.SourceGeneration.Core.Tests | 3739 / 0 | | Opc.Ua.SourceGeneration.Tests | 81 / 0 | | Opc.Ua.Di.Tests | 304 / 0 | | Opc.Ua.History.Tests | 506 / 0 | | Opc.Ua.Gds.Tests | 1095 / 0 | History and GDS are listed because they are what the method-declaration fix above is load-bearing for: without it they fail with 10 and 370 errors respectively. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8cbb8cd0-f0cb-4ab0-bea2-6202fbf69485
383 lines
14 KiB
C#
383 lines
14 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Reflection;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
|
|
namespace Opc.Ua.SourceGeneration.Generator.Tests
|
|
{
|
|
/// <summary>
|
|
/// Unit tests for the Generators.GenerateCode method
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Api")]
|
|
[SetCulture("en-us")]
|
|
[SetUICulture("en-us")]
|
|
[Parallelizable]
|
|
public class GeneratorsTests
|
|
{
|
|
/// <summary>
|
|
/// Tests that GenerateCode returns early when DesignFiles collection is empty.
|
|
/// Input: Empty DesignFiles collection
|
|
/// Expected: Method returns without processing, no file system or telemetry calls
|
|
/// </summary>
|
|
[Test]
|
|
public void GenerateCode_EmptyDesignFilesCollection_ReturnsEarlyWithoutProcessing()
|
|
{
|
|
// Arrange
|
|
var designFiles = new DesignFileCollection
|
|
{
|
|
Targets = []
|
|
};
|
|
var mockFileSystem = new Mock<IFileSystem>(MockBehavior.Strict);
|
|
var mockTelemetry = new Mock<ITelemetryContext>(MockBehavior.Strict);
|
|
const string outputDir = "output";
|
|
|
|
// Act
|
|
designFiles.GenerateCode(mockFileSystem.Object, outputDir, mockTelemetry.Object);
|
|
|
|
// Assert - No calls should be made to mocks (MockBehavior.Strict would throw if they were)
|
|
mockFileSystem.VerifyNoOtherCalls();
|
|
mockTelemetry.VerifyNoOtherCalls();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Tests that GenerateCode returns early when the nodesets Files collection is empty.
|
|
/// Condition: nodesets.Files.Count == 0
|
|
/// Expected: Method returns immediately without processing
|
|
/// </summary>
|
|
[Test]
|
|
public void GenerateCode_EmptyFilesCollection_ReturnsEarly()
|
|
{
|
|
// Arrange
|
|
var mockFileSystem = new Mock<IFileSystem>();
|
|
var mockTelemetry = new Mock<ITelemetryContext>();
|
|
var nodesets = new NodesetFileCollection(
|
|
[],
|
|
[],
|
|
mockFileSystem.Object,
|
|
mockTelemetry.Object);
|
|
|
|
// Act
|
|
nodesets.GenerateCode(
|
|
mockFileSystem.Object,
|
|
"output",
|
|
mockTelemetry.Object);
|
|
|
|
// Assert
|
|
Assert.That(nodesets.Files, Is.Empty);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Tests that GenerateCode handles null outputDir parameter.
|
|
/// Condition: outputDir is null
|
|
/// Expected: Method executes without throwing exception
|
|
/// </summary>
|
|
[Test]
|
|
public void GenerateCode_NullOutputDir_DoesNotThrow()
|
|
{
|
|
// Arrange
|
|
var mockFileSystem = new Mock<IFileSystem>();
|
|
var mockTelemetry = new Mock<ITelemetryContext>();
|
|
var nodesets = new NodesetFileCollection(
|
|
[],
|
|
[],
|
|
mockFileSystem.Object,
|
|
mockTelemetry.Object);
|
|
|
|
// Act & Assert
|
|
Assert.DoesNotThrow(() => nodesets.GenerateCode(
|
|
mockFileSystem.Object,
|
|
null,
|
|
mockTelemetry.Object));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Tests that GenerateCode handles empty string outputDir parameter.
|
|
/// Condition: outputDir is empty string
|
|
/// Expected: Method executes without throwing exception
|
|
/// </summary>
|
|
[Test]
|
|
public void GenerateCode_EmptyOutputDir_DoesNotThrow()
|
|
{
|
|
// Arrange
|
|
var mockFileSystem = new Mock<IFileSystem>();
|
|
var mockTelemetry = new Mock<ITelemetryContext>();
|
|
var nodesets = new NodesetFileCollection(
|
|
[],
|
|
[],
|
|
mockFileSystem.Object,
|
|
mockTelemetry.Object);
|
|
|
|
// Act & Assert
|
|
Assert.DoesNotThrow(() => nodesets.GenerateCode(
|
|
mockFileSystem.Object,
|
|
string.Empty,
|
|
mockTelemetry.Object));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Tests that GenerateCode handles whitespace outputDir parameter.
|
|
/// Condition: outputDir contains only whitespace
|
|
/// Expected: Method executes without throwing exception
|
|
/// </summary>
|
|
[Test]
|
|
public void GenerateCode_WhitespaceOutputDir_DoesNotThrow()
|
|
{
|
|
// Arrange
|
|
var mockFileSystem = new Mock<IFileSystem>();
|
|
var mockTelemetry = new Mock<ITelemetryContext>();
|
|
var nodesets = new NodesetFileCollection(
|
|
[],
|
|
[],
|
|
mockFileSystem.Object,
|
|
mockTelemetry.Object);
|
|
|
|
// Act & Assert
|
|
Assert.DoesNotThrow(() => nodesets.GenerateCode(
|
|
mockFileSystem.Object,
|
|
" ",
|
|
mockTelemetry.Object));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Tests that GenerateCode handles outputDir with special characters.
|
|
/// Condition: outputDir contains special characters
|
|
/// Expected: Method executes without throwing exception
|
|
/// </summary>
|
|
[Test]
|
|
public void GenerateCode_OutputDirWithSpecialCharacters_DoesNotThrow()
|
|
{
|
|
// Arrange
|
|
var mockFileSystem = new Mock<IFileSystem>();
|
|
var mockTelemetry = new Mock<ITelemetryContext>();
|
|
var nodesets = new NodesetFileCollection(
|
|
[],
|
|
[],
|
|
mockFileSystem.Object,
|
|
mockTelemetry.Object);
|
|
|
|
// Act & Assert
|
|
Assert.DoesNotThrow(() => nodesets.GenerateCode(
|
|
mockFileSystem.Object,
|
|
"C:\\Special@#$%Folder\\Output",
|
|
mockTelemetry.Object));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Tests that GenerateCode handles null options parameter by creating default options.
|
|
/// Condition: options parameter is null
|
|
/// Expected: Method creates new GeneratorOptions instance internally
|
|
/// </summary>
|
|
[Test]
|
|
public void GenerateCode_NullOptions_DoesNotThrow()
|
|
{
|
|
// Arrange
|
|
var mockFileSystem = new Mock<IFileSystem>();
|
|
var mockTelemetry = new Mock<ITelemetryContext>();
|
|
var nodesets = new NodesetFileCollection(
|
|
[],
|
|
[],
|
|
mockFileSystem.Object,
|
|
mockTelemetry.Object);
|
|
|
|
// Act & Assert
|
|
Assert.DoesNotThrow(() => nodesets.GenerateCode(
|
|
mockFileSystem.Object,
|
|
"output",
|
|
mockTelemetry.Object,
|
|
options: null));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Tests that GenerateCode uses provided options when not null.
|
|
/// Condition: options parameter is provided
|
|
/// Expected: Method uses the provided options
|
|
/// </summary>
|
|
[Test]
|
|
public void GenerateCode_WithOptions_DoesNotThrow()
|
|
{
|
|
// Arrange
|
|
var mockFileSystem = new Mock<IFileSystem>();
|
|
var mockTelemetry = new Mock<ITelemetryContext>();
|
|
var nodesets = new NodesetFileCollection(
|
|
[],
|
|
[],
|
|
mockFileSystem.Object,
|
|
mockTelemetry.Object);
|
|
var options = new GeneratorOptions();
|
|
|
|
// Act & Assert
|
|
Assert.DoesNotThrow(() => nodesets.GenerateCode(
|
|
mockFileSystem.Object,
|
|
"output",
|
|
mockTelemetry.Object,
|
|
options: options));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Tests that GenerateCode handles useAllowSubtypes set to false.
|
|
/// Condition: useAllowSubtypes is false
|
|
/// Expected: Method executes with useAllowSubtypes false
|
|
/// </summary>
|
|
[Test]
|
|
public void GenerateCode_UseAllowSubtypesFalse_DoesNotThrow()
|
|
{
|
|
// Arrange
|
|
var mockFileSystem = new Mock<IFileSystem>();
|
|
var mockTelemetry = new Mock<ITelemetryContext>();
|
|
var nodesets = new NodesetFileCollection(
|
|
[],
|
|
[],
|
|
mockFileSystem.Object,
|
|
mockTelemetry.Object);
|
|
|
|
// Act & Assert
|
|
Assert.DoesNotThrow(() => nodesets.GenerateCode(
|
|
mockFileSystem.Object,
|
|
"output",
|
|
mockTelemetry.Object,
|
|
useAllowSubtypes: false));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Tests that GenerateCode handles useAllowSubtypes set to true.
|
|
/// Condition: useAllowSubtypes is true
|
|
/// Expected: Method executes with useAllowSubtypes true
|
|
/// </summary>
|
|
[Test]
|
|
public void GenerateCode_UseAllowSubtypesTrue_DoesNotThrow()
|
|
{
|
|
// Arrange
|
|
var mockFileSystem = new Mock<IFileSystem>();
|
|
var mockTelemetry = new Mock<ITelemetryContext>();
|
|
var nodesets = new NodesetFileCollection(
|
|
[],
|
|
[],
|
|
mockFileSystem.Object,
|
|
mockTelemetry.Object);
|
|
|
|
// Act & Assert
|
|
Assert.DoesNotThrow(() => nodesets.GenerateCode(
|
|
mockFileSystem.Object,
|
|
"output",
|
|
mockTelemetry.Object,
|
|
useAllowSubtypes: true));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Tests that GenerateCode handles all boolean parameter combinations.
|
|
/// </summary>
|
|
[Theory]
|
|
public void GenerateCode_BooleanParameterCombinations_DoesNotThrow(
|
|
bool useAllowSubtypes)
|
|
{
|
|
// Arrange
|
|
var mockFileSystem = new Mock<IFileSystem>();
|
|
var mockTelemetry = new Mock<ITelemetryContext>();
|
|
var nodesets = new NodesetFileCollection(
|
|
[],
|
|
[],
|
|
mockFileSystem.Object,
|
|
mockTelemetry.Object);
|
|
|
|
// Act & Assert
|
|
Assert.DoesNotThrow(() => nodesets.GenerateCode(
|
|
mockFileSystem.Object,
|
|
"output",
|
|
mockTelemetry.Object,
|
|
useAllowSubtypes: useAllowSubtypes));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that the original public GenerateCode signatures remain available.
|
|
/// </summary>
|
|
[Test]
|
|
public void GenerateCodeOriginalPublicSignaturesArePreserved()
|
|
{
|
|
AssertPublicGenerateCodeSignature(
|
|
[
|
|
typeof(DesignFileCollection),
|
|
typeof(IFileSystem),
|
|
typeof(string),
|
|
typeof(ITelemetryContext),
|
|
typeof(GeneratorOptions),
|
|
typeof(bool),
|
|
typeof(List<string>),
|
|
typeof(IReadOnlyDictionary<string, ModelDependencyReference>),
|
|
typeof(IReadOnlyList<NodeManagerAttributeBinding>),
|
|
typeof(Action<NodeManagerAttributeBinding, string>),
|
|
typeof(HashSet<NodeManagerAttributeBinding>),
|
|
typeof(int)
|
|
]);
|
|
AssertPublicGenerateCodeSignature(
|
|
[
|
|
typeof(NodesetFileCollection),
|
|
typeof(IFileSystem),
|
|
typeof(string),
|
|
typeof(ITelemetryContext),
|
|
typeof(GeneratorOptions),
|
|
typeof(bool),
|
|
typeof(IReadOnlyDictionary<string, ModelDependencyReference>),
|
|
typeof(IReadOnlyList<NodeManagerAttributeBinding>),
|
|
typeof(Action<NodeManagerAttributeBinding, string>),
|
|
typeof(IReadOnlyDictionary<string, Dependency.ModelDependencyV1>),
|
|
typeof(HashSet<NodeManagerAttributeBinding>),
|
|
typeof(int)
|
|
]);
|
|
}
|
|
|
|
private static void AssertPublicGenerateCodeSignature(Type[] parameterTypes)
|
|
{
|
|
MethodInfo method = typeof(Generators).GetMethod(
|
|
nameof(Generators.GenerateCode),
|
|
parameterTypes) ?? throw new AssertionException("GenerateCode signature not found.");
|
|
|
|
Assert.Multiple(() =>
|
|
{
|
|
Assert.That(method.IsPublic, Is.True);
|
|
Assert.That(method.IsStatic, Is.True);
|
|
Assert.That(method.ReturnType, Is.EqualTo(typeof(void)));
|
|
});
|
|
|
|
ParameterInfo[] parameters = method.GetParameters();
|
|
for (int ii = 4; ii < parameters.Length; ii++)
|
|
{
|
|
Assert.That(
|
|
parameters[ii].IsOptional,
|
|
Is.True,
|
|
$"Parameter '{parameters[ii].Name}' must remain optional.");
|
|
}
|
|
}
|
|
}
|
|
}
|