Files
romanett 766c5558e8 Fix structure subtyping across dependency ModelDesign boundaries (#4335)
# Description

The model source generator crashed whenever a `ModelDesign` declared a
structure that subtypes a structure from **another** design file
(`MODELGEN003` with a `NullReferenceException`), and the cross-assembly
`[assembly: ModelDependency]` flow failed even earlier with `The
BaseType reference ... is not the expected type: DataTypeDesign`.
Structure inheritance across model boundaries — the primary use case of
companion-spec layering — could not be source-generated at all.

Three root causes, all in the dependency-loading path of the validator:

1. **Dependency design files were never linked.** They load with
`validateDictionary: false`, so their `DataTypeDesign`s kept
`BasicDataType` at the enum default (`Boolean`) and their fields'
`DataTypeNode` stayed `null`. `BinarySchemaGenerator`'s inherited-field
merge then dereferenced the null `DataTypeNode`, and
`XmlSchemaGenerator` / `DataTypeGenerator` silently emitted `xs:boolean`
/ `bool` from the default classification.
2. **Dependencies that import the target crashed at load.** Each
generation group receives every design file of the compilation as a
dependency, including downstream models that import the group's target —
those loaded *before* the target they import and failed resolving their
`BaseType`. This produced the confusing
`AdditionalFiles`-order-dependent failure modes.
3. **The payload flow never reached ModelDesign targets.**
`ModelCompilation` supplied `referencedDependencies` only to the
NodeSet2 pass, never to the design-file pass, and payload-materialised
data types lacked the classification and field links needed to serve as
base types of local structures.

Changes:

- `ModelDesignValidator.ValidateModel` loads dependencies in two phases
around the target: upstream models first (topological, referenced models
before their referrers), then the target, then models that import the
target.
- A new `LinkDependencyDataTypes` pass classifies dependency data types
(`IsStructure` / `IsEnumeration` / `BasicDataType`) and resolves field
`DataTypeNode` / `Parent` best effort. It runs for payload-imported
declarations and upstream design-file dependencies before target
validation, and for downstream dependencies after they load. NodeSet2
dependencies are excluded — `NodeSetToModelDesign` already links and
classifies them with its own semantics.
- Payloads for models that are backed by a design file in the
compilation are skipped — the explicit file is authoritative
(previously, importing both crashed with duplicate symbolic ids).
- Payload-materialised data types honor the payload's `IsEnumeration`
flag.
- The design-file `GenerateCode` pass now receives the referenced
assemblies' dependency payloads (`ModelCompilation` + new optional
`referencedDependencies` parameter).
- `docs/ModelDependencies.md` updated accordingly.

Tests (all verified to fail with the exact reported errors before the
fix):

- `CrossModelStructureSubtypeTests` (Core, 6 tests): the issue's minimal
repro end to end — asserting the emitted `.bsd` carries inherited fields
with correct types and `SourceType`, the `.xsd` extends the dependency
structure (not `xs:boolean`), and the generated C# derives correctly —
plus the reversed target/dependency order, both payload flows at
generation and validator level, and a three-level chain (target →
payload structure → design-file structure).
- `CrossModelStructureSubtypeGeneratorTests` (Roslyn driver, 3 tests):
both `AdditionalFiles` orderings compiling the generated output, and the
full cross-assembly flow (producer assembly generated from the upstream
design; consumer resolves the base structure from the reference's
payload without re-emitting it).

Verified locally on net10.0: `Opc.Ua.SourceGeneration.Core.Tests` 3786
passed, `Opc.Ua.SourceGeneration.Tests` 135 passed,
`Opc.Ua.SourceGeneration.Stack.Tests` 94 passed; 0-warning Release
builds of `Opc.Ua.SourceGeneration.Core` (all TFMs incl.
netstandard2.0), both Roslyn generator variants, Stack and Tester.

This unblocks the `[NodeManager]` migration of the DataTypes workshop
sample (OPCFoundation/UA-.NETStandard-Samples#757).

## Related Issues

- Fixes #4332

## Checklist

_Put an `x` in the boxes that apply. You can complete these step by step
after opening the PR._

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Marc Schier <marcschier@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: marcschier <11168470+marcschier@users.noreply.github.com>
Co-authored-by: romanett <7413710+romanett@users.noreply.github.com>
2026-08-30 17:22:34 +00:00

482 lines
22 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Collections.Immutable;
using System.Linq;
using System.Text;
using System.Threading;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Opc.Ua.SourceGeneration.Dependency;
namespace Opc.Ua.SourceGeneration
{
/// <summary>
/// Compiles the model. This honors the options of the compile command
/// of the tool. However, it does not generate identifier files and
/// assumes that if identifiers are required they are loaded from a
/// csv file that is side by side with the design files. Also, this
/// does not produce xsd or bsd nor nodeset files, which cannot be
/// added to a compilation using roslyn source generator (yet).
/// </summary>
internal sealed class ModelCompilation
{
/// <summary>
/// Create compilation
/// </summary>
public ModelCompilation(
SourceProductionContext context,
ImmutableArray<(AdditionalText, NodesetFileOptions)> inputFiles,
ImmutableArray<AdditionalText> csvFiles,
ImmutableArray<AdditionalText> identifierFiles,
ModelCompilationOptions options,
CompilationOptions compilationOptions,
ImmutableArray<ModelDependencyReference> referencedModels,
ImmutableArray<ModelFluentAccessorProviderReference> referencedAccessorProviders,
ImmutableArray<NodeManagerAttributeDiscovery> nodeManagerBindings,
ImmutableHashSet<string> availableStateTypeNames)
{
m_context = context;
m_input = inputFiles;
m_csvFiles = csvFiles;
m_identifierFiles = identifierFiles;
m_options = options;
m_compilationOptions = compilationOptions;
m_nodeManagerBindings = nodeManagerBindings;
m_referencedModels = referencedModels;
m_referencedAccessorProviders = referencedAccessorProviders;
m_availableStateTypeNames = availableStateTypeNames;
m_telemetry = SourceGeneratorTelemetry.Create(m_context);
}
/// <summary>
/// Perform the compilation
/// </summary>
public void Emit(CancellationToken cancellationToken)
{
if (!CheckCompilationOptions())
{
return;
}
var sourceFiles = new SourceGeneratorFileSystem(
m_input.Select(i => i.Item1).Concat(m_csvFiles));
using var vfs = new VirtualFileSystem(); // Use a virtual file sytem
try
{
if (m_input.Length == 0)
{
// Nothing to do
return;
}
string[] exclusions = [.. m_options.Exclude
.Append("Draft")
.Distinct()];
var generatorOptions = new GeneratorOptions
{
Cancellation = cancellationToken,
Exclusions = exclusions,
// csharp10 or below does not support utf8 string literals
UseUtf8StringLiterals =
m_compilationOptions.LanguageVersion >= LanguageVersion.CSharp11,
OptimizeForCompileSpeed =
m_compilationOptions.OptimizationLevel == OptimizationLevel.Debug,
OmitObjectTypeProxies = m_options.OmitObjectTypeProxies,
ObjectTypeProxyNamespace =
string.IsNullOrWhiteSpace(m_options.ObjectTypeProxyNamespace)
? null
: m_options.ObjectTypeProxyNamespace,
UseTypeDefinitionModellingRules =
m_options.UseTypeDefinitionModellingRules,
EmitDependencyMetadata = ResolveEmitDependencyMetadata(),
OmitFluentApi = m_options.OmitFluentApi,
FluentAccessorsOnly = m_options.FluentAccessorsOnly,
OmitEventRecords = m_options.OmitEventRecords
};
// Load all available nodeset files from the input
NodesetFileCollection nodesets = m_input.ToNodeSetFileCollection(
m_csvFiles,
sourceFiles, // .WithFallback(vfs),
m_telemetry);
ReportNodesetIdentifierDiagnostics(nodesets.IdentifierValidationErrors);
// Resolve [NodeManager] bindings: validate partial-ness and
// build the binding list to pass into both GenerateCode calls
// (nodeset-derived and design-file-derived).
var bindings = new List<NodeManagerAttributeBinding>();
var bindingByPayload =
new Dictionary<NodeManagerAttributeBinding, NodeManagerAttributeDiscovery>();
foreach (NodeManagerAttributeDiscovery discovery in m_nodeManagerBindings)
{
if (discovery == null)
{
continue;
}
if (!discovery.IsPartial)
{
m_context.ReportDiagnostic(
Diagnostic.Create(
SourceGenerator.NodeManagerNotPartial,
discovery.Location,
discovery.Binding.TargetNamespace +
"." +
discovery.Binding.TargetClassName));
continue;
}
bindings.Add(discovery.Binding);
bindingByPayload[discovery.Binding] = discovery;
}
void reportBinding(NodeManagerAttributeBinding binding, string message)
{
Location loc =
bindingByPayload.TryGetValue(binding, out NodeManagerAttributeDiscovery d) &&
d != null
? d.Location
: Location.None;
m_context.ReportDiagnostic(
Diagnostic.Create(
SourceGenerator.NodeManagerBindingError,
loc,
message));
}
void reportFluentAccessorsOnly(
string modelUri,
string prefix,
string path,
string reason)
{
m_context.ReportDiagnostic(
Diagnostic.Create(
SourceGenerator.FluentAccessorsOnlyModelError,
Location.None,
modelUri,
prefix,
path,
reason));
}
// Reduce referenced model attributes to a single dictionary by
// model URI (with tie-break on highest version+publication date)
// so the downstream generators can apply override resolution
// and decode the carried dependency payloads.
IReadOnlyDictionary<string, ModelDependencyReference>
referencedModels = BuildReferencedModelMap();
// The design files that are not NodeSet2 inputs form the
// ModelDesign pass. Compute them up front so the total model
// count (NodeSet2 models + ModelDesign targets) can be shared
// with both passes: [NodeManager] bindings are resolved across
// both passes, so single-model fallback / ambiguity detection
// must see the global model count, not the per-pass count.
// Use a set for O(1) membership tests instead of an O(n)
// ContainsValue scan per input (Ordinal preserves the previous
// dictionary-value equality semantics exactly).
var nodesetPaths = new HashSet<string>(
nodesets.Files.Values, StringComparer.Ordinal);
List<string> designTargets = [.. m_input
.Where(f => !nodesetPaths.Contains(f.Item1.Path))
.Select(f => f.Item1.Path)];
var designDependencies = new List<string>(nodesets.DesignFileEntries);
designDependencies.AddRange(designTargets);
// A [NodeManager] may bind to a model produced by either pass
// (a NodeSet2 type model or a ModelDesign instance model). The
// "used" set is therefore shared across both passes and the
// unmatched-binding diagnostics are reported once, after both
// passes — reporting per pass would false-positive a binding
// that the other pass matched (issue #3937).
HashSet<NodeManagerAttributeBinding> usedBindings =
bindings.Count > 0 ? [] : null;
int totalModelCount = nodesets.ModelUris.Count() + designTargets.Count;
// Enter the standard method-state fallback scope for the whole
// model-generation pass: a reference to a standard
// global::Opc.Ua.*MethodState class degrades to the base
// MethodState only when the typed class is neither present in
// the compilation nor declared by this pass. The Stack
// generator (which builds Opc.Ua.Core) never enters this scope.
using IDisposable fallbackScope =
StandardMethodStateFallback.Enter(m_availableStateTypeNames);
nodesets.GenerateCode(
sourceFiles.WithFallback(vfs),
string.Empty,
m_telemetry,
generatorOptions,
m_options.UseAllowSubtypes,
referencedModels,
bindings.Count > 0 ? bindings : null,
bindings.Count > 0 ? reportBinding : null,
// Derived from referencedModels, which carries the payloads.
null,
usedBindings,
totalModelCount,
reportFluentAccessorsOnly,
m_referencedModels,
m_referencedAccessorProviders);
// Process the remaining design files. Every NodeSet2 input
// (encoded with the prefix/name computed by the nodeset
// pass) and every other ModelDesign input is supplied as a
// dependency so cross-model references resolve — both
// ModelDesign -> NodeSet2 (e.g. an instance whose
// TypeDefinition is a NodeSet2-defined ObjectType) and
// ModelDesign -> ModelDesign across directories. The
// referenced models carry the upstream dependency payloads,
// so a design file can also subtype a structure of a
// referenced model that is not present in AdditionalFiles.
new DesignFileCollection
{
Targets = designTargets,
Dependencies = designDependencies,
Options = m_options.Options
}.GenerateCode(
sourceFiles.WithFallback(vfs),
string.Empty,
m_telemetry,
generatorOptions,
m_options.UseAllowSubtypes,
[.. m_identifierFiles.Select(i => i.Path)],
referencedModels,
bindings.Count > 0 ? bindings : null,
bindings.Count > 0 ? reportBinding : null,
usedBindings,
totalModelCount,
reportFluentAccessorsOnly,
m_referencedModels,
m_referencedAccessorProviders);
// Report any [NodeManager] bindings that neither pass matched,
// once, against the shared used-set aggregated across passes.
Generators.ReportUnmatchedNodeManagerBindings(
bindings,
usedBindings,
totalModelCount,
reportBinding);
// Collect all generated cs files and produce them into the compilation
foreach (string file in vfs.CreatedFiles
.Where(f => f.EndsWith(".cs", StringComparison.OrdinalIgnoreCase)))
{
string content = Encoding.UTF8.GetString(vfs.Get(file));
m_context.AddSource(file, content);
}
}
catch (Exception ex)
{
m_context.ReportDiagnostic(
Diagnostic.Create(
SourceGenerator.Exception,
Location.None,
ex.Message,
ex.ToString()));
}
}
/// <summary>
/// Tests the compilation options are valid
/// </summary>
/// <returns></returns>
private bool CheckCompilationOptions()
{
if (m_compilationOptions.LanguageVersion < LanguageVersion.CSharp8)
{
m_context.ReportDiagnostic(
Diagnostic.Create(
SourceGenerator.GenericError,
Location.None,
"Minimum required language version is CSharp 8."));
return false;
}
if (m_options.FluentAccessorsOnly && m_options.OmitFluentApi)
{
m_context.ReportDiagnostic(
Diagnostic.Create(
SourceGenerator.FluentAccessorsOnlyOptionsError,
Location.None,
"ModelSourceGeneratorFluentAccessorsOnly and " +
"ModelSourceGeneratorOmitFluentApi cannot both be enabled."));
return false;
}
if (m_options.FluentAccessorsOnly && m_options.Options.GenerateNodeManager)
{
m_context.ReportDiagnostic(
Diagnostic.Create(
SourceGenerator.FluentAccessorsOnlyOptionsError,
Location.None,
"ModelSourceGeneratorFluentAccessorsOnly cannot be combined with " +
"ModelSourceGeneratorGenerateNodeManager."));
return false;
}
return true;
}
private void ReportNodesetIdentifierDiagnostics(
IEnumerable<NodesetIdentifierValidationError> errors)
{
foreach (NodesetIdentifierValidationError error in errors)
{
m_context.ReportDiagnostic(
Diagnostic.Create(
error.Kind switch
{
NodesetIdentifierValidationErrorKind.MissingFile =>
SourceGenerator.NodesetIdentifierFileMissing,
NodesetIdentifierValidationErrorKind.DuplicateSymbolicName =>
SourceGenerator.NodesetIdentifierDuplicateSymbolicName,
NodesetIdentifierValidationErrorKind.DuplicateNumericId =>
SourceGenerator.NodesetIdentifierDuplicateNumericId,
NodesetIdentifierValidationErrorKind.UnknownSymbol =>
SourceGenerator.NodesetIdentifierUnknownSymbol,
NodesetIdentifierValidationErrorKind.NumericIdMismatch =>
SourceGenerator.NodesetIdentifierNumericIdMismatch,
NodesetIdentifierValidationErrorKind.NodeClassMismatch =>
SourceGenerator.NodesetIdentifierNodeClassMismatch,
NodesetIdentifierValidationErrorKind.AssignedToMultipleModels =>
SourceGenerator.NodesetIdentifierAssignedToMultipleModels,
_ => SourceGenerator.NodesetIdentifierInvalidRow
},
Location.None,
error.NodeSetFilePath,
error.IdentifierFilePath,
error.SymbolicName,
error.Value));
}
}
/// <summary>
/// Group the referenced-assembly attributes by model URI; when more
/// than one assembly contributes the same URI, prefer a payload-bearing
/// self producer over payloadless transitive re-exports, then use the
/// highest <c>(Version, PublicationDate)</c> lexicographic tuple per
/// the contract on <see cref="ModelDependencyAttribute"/>.
/// </summary>
private IReadOnlyDictionary<string, ModelDependencyReference>
BuildReferencedModelMap()
{
if (m_referencedModels.IsDefaultOrEmpty)
{
return ImmutableDictionary<string, ModelDependencyReference>.Empty;
}
var map = new Dictionary<string, ModelDependencyReference>(
StringComparer.Ordinal);
foreach (ModelDependencyReference candidate in m_referencedModels)
{
if (!candidate.IsValid)
{
continue;
}
if (!map.TryGetValue(candidate.ModelUri, out ModelDependencyReference existing))
{
map[candidate.ModelUri] = candidate;
continue;
}
bool candidateIsProducer = IsModelProducer(candidate);
bool existingIsProducer = IsModelProducer(existing);
int cmp = candidateIsProducer.CompareTo(existingIsProducer);
if (cmp == 0)
{
cmp = string.CompareOrdinal(candidate.Version, existing.Version);
}
if (cmp == 0)
{
cmp = string.CompareOrdinal(
candidate.PublicationDate, existing.PublicationDate);
}
if (cmp > 0)
{
m_context.ReportDiagnostic(
Diagnostic.Create(
SourceGenerator.ModelDependencyTieBreak,
Location.None,
candidate.ModelUri,
candidate.AssemblyName,
existing.AssemblyName));
map[candidate.ModelUri] = candidate;
}
else if (cmp < 0)
{
m_context.ReportDiagnostic(
Diagnostic.Create(
SourceGenerator.ModelDependencyTieBreak,
Location.None,
existing.ModelUri,
existing.AssemblyName,
candidate.AssemblyName));
}
}
return map;
}
private static bool IsModelProducer(ModelDependencyReference reference)
{
ModelDependencyV1 dependency = reference.GetDependency();
return dependency != null &&
string.Equals(dependency.ModelUri, reference.ModelUri, StringComparison.Ordinal);
}
/// <summary>
/// Resolve whether the model-dependency assembly attribute
/// should be emitted, honouring the compilation's OutputKind
/// in <c>Auto</c> mode.
/// </summary>
private bool ResolveEmitDependencyMetadata()
{
return m_options.EmitDependencyMetadata switch
{
EmitDependencyMetadataMode.Always => true,
EmitDependencyMetadataMode.Never => false,
_ => m_compilationOptions.OutputKind is
OutputKind.DynamicallyLinkedLibrary or
OutputKind.NetModule
};
}
private readonly SourceProductionContext m_context;
private readonly ImmutableArray<(AdditionalText, NodesetFileOptions)> m_input;
private readonly ImmutableArray<AdditionalText> m_csvFiles;
private readonly ImmutableArray<AdditionalText> m_identifierFiles;
private readonly ModelCompilationOptions m_options;
private readonly CompilationOptions m_compilationOptions;
private readonly ImmutableArray<ModelDependencyReference> m_referencedModels;
private readonly ImmutableArray<ModelFluentAccessorProviderReference>
m_referencedAccessorProviders;
private readonly ImmutableArray<NodeManagerAttributeDiscovery> m_nodeManagerBindings;
private readonly ImmutableHashSet<string> m_availableStateTypeNames;
private readonly SourceGeneratorTelemetry m_telemetry;
}
}