mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-29 07:07:24 +08:00
# Description Bound managed-session recovery, preserve Publish workers and recovery ownership, and address the client, server, transport, and certificate audit findings and subsequent concurrency review. Also reduce the memory retained by exhaustive session-test diagnostics. ## Recovery and Publish ownership - Add `ManagedSessionOptions.ChannelReconnectTimeout` through direct construction, the fluent builder, and DI. The automatic duration is `max(3 * KeepAliveInterval, revised SessionTimeout, OperationTimeout)`, sampled at cycle start. Positive overrides are supported; `Timeout.InfiniteTimeSpan` explicitly opts out. Raw sessions retain their unlimited default. - Add `CreateReconnectBudget(TimeProvider)` as a required `IReconnectParticipant` member, as agreed in review. Custom participants implement it and may return null for no participant-specific bound. - Enforce the earliest participant/caller deadline through transport reconnect, activation/recreation, and subscription restoration. Late callers can shorten an active cycle but cannot extend it. - Cancel and unwind recovery, fence late responses, and release channel recovery ownership before the existing `Faulted` event hands control to the outer reconnect/failover policy. Preserve session recreate admission through final Publish cleanup and keepalive suppression until shared recovery is complete. - Treat participant budget creation/evaluation failures, including exceptions at the exact deadline, as terminal shared-recovery failures. Notify participants before exposing `Faulted`, preserve the original diagnostic, and never silently replace a finite budget with unlimited recovery. - Keep caller-supplied replacement channels, managed bindings, wrapper event subscriptions, and recovery-owner identities consistent across success, failure, and cancellation. Reject replacement during active recovery and fence retired callbacks so they cannot clear newer ownership or suppress later keepalive recovery. - Retain eligible Publish workers through temporary subscription-identifier clearing without retaining workers for never-created or removed subscriptions. Preserve cancellation, acknowledgement rollback, and drain-before-replacement ordering. - Coordinate automatic subscription updates with session recovery: cancel admitted updates, keep them paused across a failed-restoration handoff, and retry only after explicit restoration completes. This prevents competing CreateSubscription requests and updates against a retiring session, while preserving manual recreation, transfer fallback, and pending option changes. - Exercise the real ManagedSession, V2 subscription engine, and channel ready gate with scripted transports and an injected clock. Cover transfer fallback, deadline handoff, late completions, and resumed notification delivery. ## Audit and review corrections - Correct certificate/trust-list transactions, change-pump lifetimes, validation, peer revalidation, and reset/resource ownership. - Harden node admission, attribute/range/dimension validation, monitored-item sampling and lifecycle transitions, event fanout, and server shutdown. Run lifecycle readiness and compensation outside shared monitored-item admission, with stale-completion ownership checks. - Close synchronous node-manager admission before teardown and retain resources until admitted service, lifecycle, and asynchronous method work returns. Dispose the monitored-item manager outside both locks, reject late calls before they can reach it, and forward asynchronous disposal through the adapter so the master awaits the same completion. Preserve reentrant shutdown initiation, cancellation/failure unwinding, and shared cleanup-failure reporting. - Bound WSS pending-request retention using connection-local wire handles while preserving caller-visible request handles and translating Cancel targets. Safely ignore retired replies and drain admitted send/close users before resource disposal. - Clarify that the shared `ClientBase` caller-handle sequence is distinct from the non-wrapping WSS wire allocator. Existing exhaustion/reopen, late-reply, and Cancel-translation regressions verify the connection-local contract; no allocator behavior was changed by this clarification. - Preserve virtual-node validation and resolver service errors instead of converting them to cached misses. A mismatched NodeId reports `BadNodeIdInvalid`; callback type mismatches and resolver service errors keep their exact status. Per-item boundaries preserve unaffected reads, writes, history operations, method calls, browse paths, and monitored-item creation/restoration, including permission-validation paths. Caller cancellation still propagates; stored-item validation failures are logged without aborting later restores. - Correct client file/role/state-machine/streaming APIs, node-cache behavior, redundancy/failover ownership, and session configuration/identity handling. - Cancel each owned peer-discovery scope before disposing it, including when the bounded wait wins a cancellation-delivery race. Keep late results out of the endpoint cache and preserve single-flight lookup ownership. - Keep materialized alias Browse results synchronized with the live store by default, preserving explicit startup-only opt-out. Apply HistoryUpdate service results per value while retaining explicit all-or-nothing provider APIs. - Update the directly related feature documentation and add focused positive, negative, concurrency, and ownership regressions. ## Latest review-feedback corrections - Fence stale failed lease observations with a successful-confirmation generation distinct from the revocation epoch. Snapshot it before each store read, including failed-CAS revalidation, so an old failure cannot revoke or reschedule a newer lease while fresh ownership loss still revokes leadership. Preserve independent overlapping acquisitions, expiry, disposal, and late-success protections. - Isolate attributable WSS response-decoding errors to their request, including retired handles. Keep admitted socket sends connection-owned so caller timeout/cancellation cannot abort sibling requests; shutdown still cancels and drains those sends. - Restart keepalive and classic Publish replenishment after successful session reuse. Retire V2 worker demand after intentional deletion/disable without confusing that state with temporary recovery resets. - Browse virtual directories lazily across continuation pages without the 1,024-entry snapshot cap. Preserve active-page cancellation, bounded metadata retention, pushback, and exactly-once asynchronous cursor cleanup. - Apply certificate/CRL staging in last-operation order, preflight required issuer storage before writes, select actual policy-compatible RSA keys for None endpoints, frame certificate chains independently of signature OIDs, and preserve admitted validation results during rejected-writer shutdown. - Preserve base asynchronous disposal when a legacy override omits its base call; avoid double derived disposal in the adapter. Let genuinely admitted nested work finish while rejecting stale captured contexts and returning null from closed lookup APIs. - Re-park recovered monitored items if AddNodes rolls back. Give event compensation a fresh finite deadline, and preserve healthy Browse/Translate siblings at every reference/path boundary while retaining starting-node errors and caller cancellation. - Give final reconnect notifications a live, bounded shutdown-linked lifetime. Synchronize child state before parent lifecycle handlers outside the parent transition lock. - Document the accepted existing policies: direct reverse connections are single-use without a ReverseConnectManager, and multi-node stream capacity is shared rather than reserved per node. The expanded readiness controls also exposed a real generation-handoff race: an old source could finish draining after activation was deferred but before readiness tasks were collected, causing the wanted replacement to be omitted from the wait set. A deterministic test gates that exact interval; the fix keeps the replacement in the readiness wait. The original race passed 200 repetitions after the fix. A separate control now awaits both producer readiness and iterator entry under the same original deadline, rather than treating those independent signals as equivalent. Temporary logging and repetition are removed. ## CI integration contracts The History and Server CI failures exposed integration tests that still asserted the behavior intentionally changed by the audit fixes. A Windows WoT negative test raced its caller deadline against upstream retries. A subsequent Ubuntu Client failure exposed a real automatic-update versus explicit-restoration race: - History insertion collisions now verify exact per-value statuses and all persisted timestamps/values, including preservation of the existing conflicting entry. Explicit atomic-provider rollback controls remain. - Alias materialization tests wait for actual publication and verify the added node plus forward/inverse `AliasFor` references, instead of racing a startup-only snapshot expectation. Explicit refresh opt-out controls remain. - The unavailable-upstream WoT test uses an explicit finite retry policy through existing DI configuration, preserving its original four-minute guard and requiring a mapped-value service error before caller cancellation. Production retry defaults remain unchanged. - The Client fix retains the exact one-create and late-response assertions. Three deterministic real-subscription/real-manager cases cover paused creation, disposal while paused, and cancellation of an admitted create followed by explicit restoration and a pending option update. Both composed restoration-deadline cases also prove automatic updates stay blocked at the outer handoff and resume after restoration. - The merged-head net48 correction prevents lost peer-resolver cancellation and distinguishes the harness's delayed initial `Connected` event from actual outer recovery completion. A deterministic timer-order test covers both cooperative and cancellation-ignoring resolvers, cancellation before return, rejection of late cached results, and a fresh subsequent lookup. - The remaining CodeQL alert was a false content flow through `ArrayOf.Count` into an integer-only trust-list summary. Projecting the same count through `Span.Length` keeps cardinality distinct from serialized contents without allocating, dropping diagnostics, suppressing the rule, or dismissing the alert. Five log-contract cases cover null/empty/nonempty results and mixed chain-capable/fallback listeners, asserting the exact count, message, and structured properties. - Classic transfer acknowledges messages selected for asynchronous Republish only after their responses arrive. The existing locked replay-selection decision returns the immediate-acknowledgement subset to Session, preserving the public transfer API, advertised availability, and immediate acknowledgement of older gapped messages not selected for replay. A callback changing `RepublishAfterTransfer` cannot change the already-selected acknowledgement ownership. - Transfer integration tests explicitly control acknowledged versus retained origin messages. Exact assertions distinguish retained replay from requested fresh initial values by sequence number, client handles, values, status, and source timestamp. Atomic counters, observed delivery/keepalive progress, and failure-safe session/file cleanup replace timing assumptions and racy resets. - Server lifecycle tests verify the documented independent five-second compensation deadline rather than requiring a non-cancellable token. They cancel the actual request, prove compensation and unrelated monitored-item creation still proceed one tick before the deadline, preserve the original failure and ownership assertions, and verify the completed deadline is retired. - Synchronous and asynchronous directory-browser tests require the exact provider exception instead of an empty-directory success, then verify the failed cursor is not enumerated again. These correct expectations left behind by the intentional, documented provider-error propagation change; production behavior is unchanged. No tests were disabled, assertions loosened, coverage thresholds lowered, or CI checks made optional. Existing platform exclusions and Explicit debug variants remain. ## Related Issues - Fixes #4514 - Fixes #4515 - Builds on merged #4503 and retains the #4508 publishing-drain behavior. ## Validation **Lease-election review correction (`a13afa641182c70983e16bbcfebf507e666a45a5`):** The correction is based on the existing upstream merge `43079e2b851fe338a4082066f8d14abfdafb6e32`. Three deterministic stale-verdict cases fail on the original source and pass with separate confirmation fencing. Six new cases cover the initial foreign-owner verdict, failed-CAS revalidation in both invocation orders, and fresh ownership loss through both read paths, including revalidation begun after another successful confirmation. | Target and configuration | Passed | Failed | Skipped | | --- | ---: | ---: | ---: | | net10.0 Debug | 120 | 0 | 0 | | net48 Debug | 120 | 0 | 0 | The selection is the full `Opc.Ua.Core.Tests.Redundancy` namespace, including all 38 `SharedStoreLeaseElectionTests` cases and the existing expiry, clock rollback, disposal, and overlapping-success regressions. New witnesses are `StaleForeignLeaseReadDoesNotRevokeNewerAcquisitionAsync`, `StaleFailedRevalidationDoesNotRevokeNewerAcquisitionAsync`, and `FreshForeignLeaseObservationRevokesLeadershipAsync`. They assert resulting leadership, exact transitions, independent progress, and the unchanged expiry boundary. Retaining the initial generation for the fallback read independently makes the fresh-loss-after-confirmation control fail; that mutation was removed before the final rebuilt runs. The successful scoped command is `dotnet test tests\Opc.Ua.Core.Tests\Opc.Ua.Core.Tests.csproj -c Debug --no-restore --filter "FullyQualifiedName~Opc.Ua.Core.Tests.Redundancy"`, with `CustomTestTarget` and `-f` matching each row and that framework's assets restored. Both changed C# files pass formatting and analyzers through informational severity on both frameworks. These are scoped results, not a full-solution test or measured coverage-delta claim. CI monitoring is paused for this feedback-only operation; no current-head CI success is claimed. **Latest CI contract correction (`1cd1f2047bb5b50c9bf300b1ff710b0b2e935a29`):** All four failing Server shard 23 jobs in [run 36120946740](https://github.com/OPCFoundation/UA-.NETStandard/actions/runs/36120946740) reported the same six cases. Two local replays reproduced all six failures. The source changes and documentation from `cd43b831a` establish both intentional contracts: independent bounded event compensation and surfaced provider errors. Only the two test files are corrected; production code and CI policy are unchanged. | Target and configuration | Passed | Failed | Skipped | | --- | ---: | ---: | ---: | | net48 Debug | 113 | 0 | 0 | | net10.0 Release, CI Coverlet settings | 113 | 0 | 0 | The selection contains `MonitoredItemManagerLifecycleTests`, `DirectoryObjectStateTests`, `DirectoryBrowserBoundedEnumerationTests`, and `EventCompensationReadinessHasFiniteDeadlineWithInfiniteSourceTimeoutAsync`. Both changed files pass formatting and analyzers through informational severity on both frameworks. Independent mutations restoring a non-cancellable compensation token and swallowing provider errors fail all four lifecycle cases and both browser cases, respectively. Both mutations were removed before the final passing runs and commit. The scoped command is `dotnet test tests\Opc.Ua.Server.Tests\Opc.Ua.Server.Tests.csproj` with `CustomTestTarget` and `-f` set to the selected framework, `--no-restore`, and `--filter "FullyQualifiedName~MonitoredItemManagerLifecycleTests|FullyQualifiedName~DirectoryObjectStateTests|FullyQualifiedName~DirectoryBrowserBoundedEnumerationTests|FullyQualifiedName~EventCompensationReadinessHasFiniteDeadlineWithInfiniteSourceTimeoutAsync"`. The modern run additionally uses `-c Release /p:CollectCoverage=true --collect "XPlat Code Coverage" --settings tests\coverlet.runsettings.xml`. These are scoped results, not a full-solution test or measured coverage-delta claim. Hosted checks for that commit were pending at publication. The fail-fast CI watch was stopped when the requested operation switched to review feedback; no current-head CI success is claimed. **Earlier master merge (`8b15ea6ef9fc2214ac8ec886f373bb3846dd6d6f`, base `b4136d8e9bab0df680f41d9ef985f519160534b1`):** The `TcpListenerChannel` conflict preserves both lifetime responsibilities: disposal clears the retained peer-certificate chain and unregisters the quota-scoped message-assembly scheduler. Both fields and all upstream deadline handling remain intact. The only additional manual source adjustment adds the parentheses required by the existing analyzer around the session-count fallback. Master advanced during validation. The initial transport merge `80303c434ce813cf75aa7fe54a6a32fe2aeafc30` was retained, and the newer base was merged normally in `8b15ea6ef9fc2214ac8ec886f373bb3846dd6d6f`, without rewriting history. The additional recovery, fluent-pipeline, and test-framework overlaps were inspected; the branch's cancellation, validation-error, and acknowledgement ownership fixes remain alongside the upstream changes. Full `UA.slnx` builds passed on net10.0 and net48 with **0 warnings and 0 errors**. The final scoped tests rebuilt against the committed tree `2074f8efcb61d8d9c6106e7d6f76ee941940e358`: | Target | Passed | Failed | Skipped | | --- | ---: | ---: | ---: | | net10.0 | 2,653 | 0 | 0 | | net48 | 2,529 | 0 | 7 | The net48 skips are existing platform exclusions: six RSA_DH_AesGcm nonce cases and one ClientWebSocket certificate-validation case requiring .NET 7 or later. The selection covers transport cleanup, reassembly budgets/deadlines/admission, peer-chain ownership, server session binding, fluent lifecycles and source generation, reconnect and keepalive, transfer acknowledgements, Publish queues, and JSON encoding. Modern-.NET WSS transport and real-server integration cases also pass. The resolved file passed solution-relative formatting and analyzer verification through informational severity on both frameworks. These are scoped test results, not unfiltered full-suite or measured-coverage claims. Hosted CI was not monitored or repaired as part of this merge-only operation. Selected local results below are overlapping validation runs, not distinct-test totals. **Earlier review-feedback batch (`cd43b831a8f11de3f7d65c3681712a61e3c669a5`):** The final net10.0 scoped selection passed **471 tests, with no failures or skips**. The final net48 solution-root selection passed **439 tests, with no failures and one unchanged platform skip** (`ValidateServerCertificateFallsBackToTlsPolicyErrors`, which requires newer ClientWebSocket certificate-validation support). Both full nonincremental solution builds completed with **0 warnings and 0 errors**, and all **40 changed C# files** passed informational-level formatting/analyzer verification. Both frameworks validated the identical final tracked diff. The focused matrix covers every one of the 20 current review threads, including real mid-frame WSS cancellation, stale admission contexts, directory continuation ownership, multi-element Browse/Translate failures, and the readiness drain race. The net10.0 solution-root test command has a separate pre-existing runner conflict: three unrelated AOT projects reject the VSTest target under Microsoft.Testing.Platform 2.4.0 and SDK 10. Per-project net10.0 results are recorded separately; no runner migration, test exclusion, assertion relaxation, or CI-policy change is included. These are bounded selections, not unfiltered full-suite or measured coverage claims. At publication of `cd43b831a`, hosted CI was not green: the `OPCFoundation.UA-.NETStandard` check reported `ACTION_REQUIRED`, AppVeyor reported `FAILURE`, and the two signed-build jobs were in progress. No CI jobs were rerun, cancelled, approved, or repaired as part of that feedback-only operation. **Classic transfer correction (`f425376fca045794122e19aaf9cafebc4a717d91`):** The preceding head's [macOS net10.0 shard 25/30](https://github.com/OPCFoundation/UA-.NETStandard/actions/runs/35980326299/job/107570512458) failed `TransferSubscriptionTest(DisconnectedRepublish).TransferSubscriptionAsync(True,False)` at the static-node count assertion: expected 10, received 20. The trace contains a successful, explicitly requested republish of retained sequence 1 and a fresh initial-value batch at sequence 3, not duplicate dispatch of one response. Controlled lost origin acknowledgements reproduced that incorrect test expectation on both the preceding PR head and exact master base `a2539cb53dd1666cef856f33812d7a8830d68909`. The maintainer explicitly authorized correcting this existing issue in the PR. Retained replay and requested initial values are independent, as specified by [OPC UA Part 4, TransferSubscriptions](https://reference.opcfoundation.org/specs/OPC-10000-4/5.14.7). The reason that the original hosted run retained its particular origin message remains unproved. The expanded full-suite run then exposed a **real production race**, not just a count assertion: Session queued acknowledgements for all transferred available messages before the asynchronous Republish responses arrived. Publish could delete those messages first, causing `BadMessageNotAvailable`. A gated real-Session/classic-engine regression failed both replay-enabled cases on the original implementation while both no-replay controls passed. The ownership fix passes all 24 combinations of empty/consecutive/unsorted-gapped queues, replay preference, sequential delivery, and a reentrant preference change. All 40 normal real-server transfer cases pass on both frameworks. Independent mutations suppressing actual replay and duplicating observed sequence records each fail the intended assertion; both mutations were removed. The full classic suite passes on both frameworks. Hosted CI was pending when that correction was published; the earlier failed hosted job was not rerun for a lucky pass. **Local net48 caveat:** the full Client run timed out in the pre-existing fake-clock test `ReconnectAsyncSwapsFaultedLeaseEntryAsync`, which does not exercise subscription transfer. Its unchanged isolated replay passed, but that does not resolve the full-suite timeout. No unrelated code or assertions were changed, and a clean full Client net48 run is not claimed. | Scope | net10.0 | net48 | | --- | --- | --- | | Full Client.Tests after transfer acknowledgement correction | 2,549 passed | 2,552 passed, 1 timeout failure noted above, 1 existing platform skip | | Full classic-subscription project after transfer correction | 57 passed, including all 40 normal transfer cases | 57 passed, including all 40 normal transfer cases | | Gated transferred-message acknowledgement ownership | 24 passed, included above | 24 passed, included above | | Saved-session consumer of the shared subscription helper | 40 passed | 16 passed, 24 existing unsupported-security-policy skips | | Audit regression matrix | 2,339 passed | 1,934 passed, 34 existing skips | | Full Client.Tests after review follow-ups | 2,520 passed | Focused selections only | | Full Client.Tests after CI recovery correction | 2,523 passed, CI coverage collector | 2,527 passed, 1 existing platform skip | | Latest merged-head recovery/redundancy selection | 139 passed | 139 passed | | Full Client.Tests after merged-head net48 correction | Focused selection above | 2,529 passed, 1 existing platform skip | | Lifecycle and actual-dimension regressions | 146 passed | 146 passed | | Focused recovery follow-ups | 7 passed | 7 passed | | WSS-related fixtures | 93 passed | Not applicable | | CI History integration corrections | 28 passed | 28 passed | | CI alias, dispatcher, and explicit-atomic controls | 63 passed | 63 passed | | Full WoT sample project with CI coverage collector | 29 passed | Not applicable | | Trust-list effects and count-only summary contract | 22 passed | 22 passed | | Virtual-node feedback, node-manager, dispatcher, and lifecycle selections | 661 passed, 63 existing not-executed cases; all 48 virtual-node cases passed | 661 passed, 63 existing not-executed cases; all 48 virtual-node cases passed | | WSS wire-handle exhaustion, late replies, and Cancel translation | 9 passed | Not applicable | | Synchronous node-manager disposal and related service/lifecycle suites | 1,037 passed, 64 not-executed cases from existing fixture assumptions; all 93 sampling/disposal cases passed | 1,037 passed, 64 not-executed cases from existing fixture assumptions; all 93 sampling/disposal cases passed | - Full solution builds passed on net10.0 and net48 during the audit work. The subsequent full non-incremental net10.0 build also completed with zero warnings/errors. - Modified source/test formatting and analyzer checks passed through informational severity. - Original composed recovery regressions passed repeated runs on both frameworks. Independent mutations removing Publish cancellation, bypassing the recreate drain call, or ignoring ready-gate cancellation each failed the intended assertion; all mutations were restored before passing runs. - The latest recovery correction passed 100 executions of each original restoration-deadline scenario with unchanged assertions. Restoring premature update admission independently made both strengthened handoff cases fail; the correct retention behavior was restored afterward. - Startup-event and cancellation-delivery timing probes reproduced the subsequent net48 failures, then passed 100 executions of each of the three scenarios with the fixes. All timing probes and repetition were removed. The permanent timeout-order regression also went RED on the original cancellation cleanup without sleeps or scheduling amplification. - Final post-format recovery/subscription/engine checks passed all 151 selected cases on net10.0. The first local full net48 attempt aborted in `clr.dll` with native access violation `0xc0000005`; an unchanged-assembly full diagnostic rerun passed as recorded above. That native host crash has not been attributed or claimed fixed. - A minimal replay with the same CodeQL CLI and query-pack versions reproduced the custom-count alert and confirmed that the standard span-length projection is clean while direct sensitive-value and raw-identifier logging controls remain flagged. The source was already logging only a count; no identifier or certificate disclosure was established at the reported location. - The virtual-node feedback regressions first reproduced five error-preservation/cache failures; expanded service-dispatch cases exposed two additional whole-batch failures before the operation-boundary fixes. The final selections pass on both frameworks. Genuine misses remain cached, successful results remain reusable, failed validation allows same-cache retry, and request cancellation still stops the batch. - Three deterministic synchronous-manager disposal regressions reproduced early resource release and lifecycle calls reaching a manager during disposal. The fix passes direct and adapted calls, a sampling-worker join after the last operation exits, reentrant shutdown, cancellation and failure paths, repeated disposal, and exact rejection across 39 service/lifecycle entry points both during drain and after cleanup. The original outside-node-lock disposal regression remains and now requires the worker to observe closed admission. - Prior-head CI on `c985f8bded77a60449d9cd381c8a004d8590ccf6` completed with **168 passing checks, one expected release-package-publication skip, and no failures or pending checks**. All test shards, signed builds, container builds, the coverage check, and the CodeQL PR check passed. Hosted CodeQL analysis `1829262912` completed successfully and marks count-flow alert 385 fixed. This is evidence for that head, not a claim that subsequent review follow-ups have completed hosted CI. ### Session-test diagnostic memory Complete browse listings are streamed to unique NUnit attachments rather than retained in inline NUnit/VSTest output. Detached regression-test results are cleaned up without deleting runner-collected attachments. - Two covered session-suite runs each completed with 782 passed and 379 existing skips. Peak working set fell from 4.86 GiB to 2.44-2.78 GiB. - TRX output shrank from 303.1 MiB to approximately 40.7 MiB, retaining all 46 complete browse attachments. - Seven output regressions cover exact content, empty/single/large listings, disabled/enabled output, bounded inline summaries, and unique filenames. The separate Azure build-18452 VM deprovisioning cause remains unproved without provider logs. The memory measurements do not establish its cause. Unfiltered local `UA.slnx` tests, including the long stress/soak suites, have not been run on both frameworks. A local coverage delta was not collected; builds and focused tests are not substitutes for those claims. ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] All checks on the latest review-follow-up head have completed successfully; prior-head CI passed as recorded above. - [x] I have addressed **all** PR feedback received. Tests have been added and pass as recorded above; the hosted coverage check passed on the prior head identified above. The combined tests/coverage-increase checkbox remains open because no local coverage delta was measured. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 68f26810-22b8-476f-abcd-0a8c82d6e208
1220 lines
55 KiB
C#
1220 lines
55 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using Microsoft.Extensions.Time.Testing;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
|
|
namespace Opc.Ua.Client.Tests.ManagedSession
|
|
{
|
|
/// <summary>
|
|
/// Unit tests for <see cref="DefaultServerRedundancyHandler"/>.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Client")]
|
|
[Category("ServerRedundancy")]
|
|
public sealed class ServerRedundancyHandlerTests
|
|
{
|
|
private static readonly DateTime s_now = new(2026, 6, 27, 4, 0, 0, DateTimeKind.Utc);
|
|
private Mock<IRedundantServerEndpointResolver> m_resolver = null!;
|
|
private DefaultServerRedundancyHandler m_handler = null!;
|
|
|
|
/// <summary>
|
|
/// Creates a strict endpoint resolver mock and a redundancy handler with a fixed clock for each scenario.
|
|
/// </summary>
|
|
[SetUp]
|
|
public void SetUp()
|
|
{
|
|
m_resolver = new Mock<IRedundantServerEndpointResolver>(MockBehavior.Strict);
|
|
m_handler = new DefaultServerRedundancyHandler(m_resolver.Object, new FixedTimeProvider(s_now));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that server redundancy support values map to the corresponding redundancy modes.
|
|
/// </summary>
|
|
[TestCase(0, RedundancySupport.None)]
|
|
[TestCase(1, RedundancySupport.Cold)]
|
|
[TestCase(2, RedundancySupport.Warm)]
|
|
[TestCase(3, RedundancySupport.Hot)]
|
|
[TestCase(4, RedundancySupport.Transparent)]
|
|
[TestCase(5, RedundancySupport.HotAndMirrored)]
|
|
public async Task FetchRedundancyInfoMapsRedundancySupportAsync(
|
|
int value,
|
|
RedundancySupport expected)
|
|
{
|
|
Mock<ISession> mockSession = CreateMockSession(
|
|
redundancySupport: value,
|
|
serviceLevel: ServiceLevels.HealthyMinimum);
|
|
|
|
ServerRedundancyInfo info = await m_handler.FetchRedundancyInfoAsync(
|
|
mockSession.Object).ConfigureAwait(false);
|
|
|
|
Assert.That(info.Mode, Is.EqualTo(expected));
|
|
}
|
|
|
|
[TestCase(RedundancySupport.Cold)]
|
|
[TestCase(RedundancySupport.Warm)]
|
|
public async Task BasicRedundancyReadRetainsUnresolvedPeersWithoutDiscoveryAsync(RedundancySupport mode)
|
|
{
|
|
Mock<ISession> session = CreateMockSession(
|
|
(int)mode, ServiceLevels.Maximum, serverUris: ["urn:offline"]);
|
|
|
|
ServerRedundancyInfo snapshot = await ((IServerRedundancyEndpointCache)m_handler)
|
|
.ReadRedundancyInfoAsync(session.Object, CancellationToken.None).ConfigureAwait(false);
|
|
|
|
Assert.That(snapshot.Mode, Is.EqualTo(mode));
|
|
Assert.That(snapshot.ServiceLevel, Is.EqualTo(ServiceLevels.Maximum));
|
|
Assert.That(snapshot.RedundantServers.Count, Is.EqualTo(1));
|
|
Assert.That(snapshot.RedundantServers[0].ServerUri, Is.EqualTo("urn:offline"));
|
|
Assert.That(snapshot.RedundantServers[0].Endpoint, Is.Null);
|
|
m_resolver.VerifyNoOtherCalls();
|
|
VerifyBatchedRedundancyRead(session);
|
|
}
|
|
|
|
[TestCase(false)]
|
|
[TestCase(true)]
|
|
public async Task PeerTimeoutPreservesOtherEndpointsAndCoalescesPendingDiscoveryAsync(bool ignoreCancellation)
|
|
{
|
|
var time = new FakeTimeProvider();
|
|
var handler = new DefaultServerRedundancyHandler(m_resolver.Object, time);
|
|
ConfiguredEndpoint available = CreateEndpoint("urn:available", "opc.tcp://available:4840");
|
|
var blocked = new TaskCompletionSource<ConfiguredEndpoint?>(
|
|
TaskCreationOptions.RunContinuationsAsynchronously);
|
|
var secondLookup = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
|
|
int lookups = 0;
|
|
m_resolver.Setup(resolver => resolver.ResolveAsync(
|
|
"urn:offline", It.IsAny<ConfiguredEndpoint>(), It.IsAny<CancellationToken>()))
|
|
.Returns((string _, ConfiguredEndpoint _, CancellationToken ct) =>
|
|
{
|
|
if (Interlocked.Increment(ref lookups) == 2)
|
|
{
|
|
secondLookup.TrySetResult(true);
|
|
}
|
|
return new ValueTask<ConfiguredEndpoint?>(ignoreCancellation
|
|
? blocked.Task
|
|
: blocked.Task.WaitAsync(ct));
|
|
});
|
|
m_resolver.Setup(resolver => resolver.ResolveAsync(
|
|
"urn:available", It.IsAny<ConfiguredEndpoint>(), It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(available);
|
|
Mock<ISession> session = CreateMockSession(
|
|
(int)RedundancySupport.Cold, ServiceLevels.Maximum, serverUris: ["urn:offline", "urn:available"]);
|
|
var cache = (IServerRedundancyEndpointCache)handler;
|
|
ServerRedundancyInfo basic = await cache.ReadRedundancyInfoAsync(session.Object, CancellationToken.None)
|
|
.ConfigureAwait(false);
|
|
try
|
|
{
|
|
Task<ServerRedundancyInfo> resolving = cache.ResolveCachedEndpointsAsync(
|
|
basic, session.Object.ConfiguredEndpoint, CancellationToken.None).AsTask();
|
|
m_resolver.Verify(resolver => resolver.ResolveAsync(
|
|
"urn:available", It.IsAny<ConfiguredEndpoint>(), It.IsAny<CancellationToken>()), Times.Once);
|
|
Assert.That(resolving.IsCompleted, Is.False);
|
|
time.Advance(TimeSpan.FromSeconds(2));
|
|
|
|
ServerRedundancyInfo resolved = await resolving.WaitAsync(TimeSpan.FromSeconds(10))
|
|
.ConfigureAwait(false);
|
|
|
|
Assert.That(resolved.Mode, Is.EqualTo(RedundancySupport.Cold));
|
|
Assert.That(resolved.RedundantServers[0].Endpoint, Is.Null);
|
|
Assert.That(resolved.RedundantServers[1].Endpoint, Is.SameAs(available));
|
|
Assert.That(handler.SelectFailoverTarget(resolved, session.Object.ConfiguredEndpoint),
|
|
Is.SameAs(available));
|
|
|
|
Task<ServerRedundancyInfo> retry = cache.ResolveCachedEndpointsAsync(
|
|
resolved, session.Object.ConfiguredEndpoint, CancellationToken.None).AsTask();
|
|
if (!ignoreCancellation)
|
|
{
|
|
// The timed-out lookup drains on the thread pool, so the retry may first join it and only
|
|
// start its own lookup once it has drained. Advancing the clock before then would expire
|
|
// the retry's bound too, so wait for the fresh lookup.
|
|
await secondLookup.Task.WaitAsync(TimeSpan.FromSeconds(10)).ConfigureAwait(false);
|
|
}
|
|
time.Advance(TimeSpan.FromSeconds(2));
|
|
await retry.WaitAsync(TimeSpan.FromSeconds(10)).ConfigureAwait(false);
|
|
m_resolver.Verify(resolver => resolver.ResolveAsync(
|
|
"urn:offline", It.IsAny<ConfiguredEndpoint>(), It.IsAny<CancellationToken>()),
|
|
Times.Exactly(ignoreCancellation ? 1 : 2));
|
|
m_resolver.Verify(resolver => resolver.ResolveAsync(
|
|
"urn:available", It.IsAny<ConfiguredEndpoint>(), It.IsAny<CancellationToken>()), Times.Once);
|
|
}
|
|
finally
|
|
{
|
|
blocked.TrySetResult(null);
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public async Task ConfiguredPeerDiscoveryTimeoutReplacesTheDefaultBoundAsync()
|
|
{
|
|
var time = new FakeTimeProvider();
|
|
var handler = new DefaultServerRedundancyHandler(
|
|
m_resolver.Object,
|
|
time,
|
|
new ServerRedundancyOptions { PeerDiscoveryTimeout = TimeSpan.FromSeconds(30) });
|
|
var blocked = new TaskCompletionSource<ConfiguredEndpoint?>(
|
|
TaskCreationOptions.RunContinuationsAsynchronously);
|
|
m_resolver.Setup(resolver => resolver.ResolveAsync(
|
|
"urn:offline", It.IsAny<ConfiguredEndpoint>(), It.IsAny<CancellationToken>()))
|
|
.Returns((string _, ConfiguredEndpoint _, CancellationToken ct) =>
|
|
new ValueTask<ConfiguredEndpoint?>(blocked.Task.WaitAsync(ct)));
|
|
Mock<ISession> session = CreateMockSession(
|
|
(int)RedundancySupport.Cold, ServiceLevels.Maximum, serverUris: ["urn:offline"]);
|
|
var cache = (IServerRedundancyEndpointCache)handler;
|
|
ServerRedundancyInfo basic = await cache.ReadRedundancyInfoAsync(session.Object, CancellationToken.None)
|
|
.ConfigureAwait(false);
|
|
try
|
|
{
|
|
Task<ServerRedundancyInfo> resolving = cache.ResolveCachedEndpointsAsync(
|
|
basic, session.Object.ConfiguredEndpoint, CancellationToken.None).AsTask();
|
|
|
|
time.Advance(TimeSpan.FromSeconds(2));
|
|
await Task.Yield();
|
|
Assert.That(resolving.IsCompleted, Is.False);
|
|
|
|
time.Advance(TimeSpan.FromSeconds(28));
|
|
ServerRedundancyInfo resolved = await resolving.WaitAsync(TimeSpan.FromSeconds(10))
|
|
.ConfigureAwait(false);
|
|
|
|
Assert.That(resolved.RedundantServers[0].Endpoint, Is.Null);
|
|
}
|
|
finally
|
|
{
|
|
blocked.TrySetResult(null);
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void ServerRedundancyOptionsRejectNonPositiveBounds()
|
|
{
|
|
Assert.Multiple(() =>
|
|
{
|
|
Assert.That(
|
|
() => new ServerRedundancyOptions { RefreshTimeout = TimeSpan.Zero }.Validate(),
|
|
Throws.InstanceOf<ArgumentOutOfRangeException>());
|
|
Assert.That(
|
|
() => new ServerRedundancyOptions
|
|
{
|
|
PeerDiscoveryTimeout = TimeSpan.FromSeconds(-5)
|
|
}.Validate(),
|
|
Throws.InstanceOf<ArgumentOutOfRangeException>());
|
|
Assert.That(
|
|
() => new ServerRedundancyOptions
|
|
{
|
|
RefreshTimeout = Timeout.InfiniteTimeSpan,
|
|
PeerDiscoveryTimeout = Timeout.InfiniteTimeSpan
|
|
}.Validate(),
|
|
Throws.Nothing);
|
|
Assert.That(new ServerRedundancyOptions().RefreshTimeout,
|
|
Is.EqualTo(ServerRedundancyOptions.DefaultTimeout));
|
|
});
|
|
}
|
|
|
|
[TestCase(false)]
|
|
[TestCase(true)]
|
|
public async Task PeerDiscoveryTimeoutCancelsResolverBeforeOwnedTimerFiresAsync(bool ignoreCancellation)
|
|
{
|
|
var clock = new FakeTimeProvider();
|
|
var timeProvider = new Mock<TimeProvider> { CallBase = true };
|
|
timeProvider.Setup(provider => provider.GetUtcNow()).Returns(clock.GetUtcNow);
|
|
timeProvider.Setup(provider => provider.GetTimestamp()).Returns(clock.GetTimestamp);
|
|
timeProvider.SetupGet(provider => provider.TimestampFrequency).Returns(clock.TimestampFrequency);
|
|
int timerCount = 0;
|
|
timeProvider.Setup(provider => provider.CreateTimer(
|
|
It.IsAny<TimerCallback>(), It.IsAny<object?>(),
|
|
It.IsAny<TimeSpan>(), It.IsAny<TimeSpan>()))
|
|
.Returns((TimerCallback callback, object? state, TimeSpan dueTime, TimeSpan period) =>
|
|
{
|
|
if (Interlocked.Increment(ref timerCount) == 1)
|
|
{
|
|
// Deliver the outer wait's deadline before the owned cancellation timer.
|
|
dueTime += TimeSpan.FromSeconds(1);
|
|
}
|
|
return clock.CreateTimer(callback, state, dueTime, period);
|
|
});
|
|
var timeout = TimeSpan.FromSeconds(1);
|
|
var handler = new DefaultServerRedundancyHandler(
|
|
m_resolver.Object, timeProvider.Object,
|
|
new ServerRedundancyOptions { PeerDiscoveryTimeout = timeout });
|
|
var blocked = new TaskCompletionSource<ConfiguredEndpoint?>(
|
|
TaskCreationOptions.RunContinuationsAsynchronously);
|
|
CancellationToken discoveryToken = default;
|
|
int resolverCalls = 0;
|
|
ConfiguredEndpoint freshEndpoint = CreateEndpoint("urn:offline", "opc.tcp://fresh:4840");
|
|
m_resolver.Setup(resolver => resolver.ResolveAsync(
|
|
"urn:offline", It.IsAny<ConfiguredEndpoint>(), It.IsAny<CancellationToken>()))
|
|
.Returns((string _, ConfiguredEndpoint _, CancellationToken ct) =>
|
|
{
|
|
if (Interlocked.Increment(ref resolverCalls) == 1)
|
|
{
|
|
discoveryToken = ct;
|
|
return new ValueTask<ConfiguredEndpoint?>(
|
|
ignoreCancellation ? blocked.Task : blocked.Task.WaitAsync(ct));
|
|
}
|
|
return new ValueTask<ConfiguredEndpoint?>(freshEndpoint);
|
|
});
|
|
Mock<ISession> session = CreateMockSession(
|
|
(int)RedundancySupport.Cold, ServiceLevels.Maximum, serverUris: ["urn:offline"]);
|
|
var cache = (IServerRedundancyEndpointCache)handler;
|
|
ServerRedundancyInfo basic = await cache.ReadRedundancyInfoAsync(
|
|
session.Object, CancellationToken.None).ConfigureAwait(false);
|
|
try
|
|
{
|
|
Task<ServerRedundancyInfo> resolving = cache.ResolveCachedEndpointsAsync(
|
|
basic, session.Object.ConfiguredEndpoint, CancellationToken.None).AsTask();
|
|
Assert.That(timerCount, Is.EqualTo(2));
|
|
Assert.That(discoveryToken.CanBeCanceled, Is.True);
|
|
|
|
clock.Advance(timeout);
|
|
ServerRedundancyInfo resolved = await resolving.WaitAsync(TimeSpan.FromSeconds(5))
|
|
.ConfigureAwait(false);
|
|
|
|
Assert.That(resolved.RedundantServers[0].Endpoint, Is.Null);
|
|
Assert.That(discoveryToken.IsCancellationRequested, Is.True);
|
|
m_resolver.Verify(resolver => resolver.ResolveAsync(
|
|
"urn:offline", It.IsAny<ConfiguredEndpoint>(), It.IsAny<CancellationToken>()), Times.Once);
|
|
|
|
blocked.TrySetResult(CreateEndpoint("urn:offline", "opc.tcp://late:4840"));
|
|
ServerRedundancyInfo retried = await cache.ResolveCachedEndpointsAsync(
|
|
basic, session.Object.ConfiguredEndpoint, CancellationToken.None).AsTask()
|
|
.WaitAsync(TimeSpan.FromSeconds(5)).ConfigureAwait(false);
|
|
Assert.That(retried.RedundantServers[0].Endpoint, Is.SameAs(freshEndpoint));
|
|
m_resolver.Verify(resolver => resolver.ResolveAsync(
|
|
"urn:offline", It.IsAny<ConfiguredEndpoint>(), It.IsAny<CancellationToken>()), Times.Exactly(2));
|
|
}
|
|
finally
|
|
{
|
|
blocked.TrySetResult(null);
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public async Task PeerDiscoveryPropagatesCallerCancellationAsync()
|
|
{
|
|
using var cancellation = new CancellationTokenSource();
|
|
var resolverEntered = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
|
|
var blocked = new TaskCompletionSource<ConfiguredEndpoint?>(
|
|
TaskCreationOptions.RunContinuationsAsynchronously);
|
|
CancellationToken discoveryToken = default;
|
|
m_resolver.Setup(resolver => resolver.ResolveAsync(
|
|
"urn:offline", It.IsAny<ConfiguredEndpoint>(), It.IsAny<CancellationToken>()))
|
|
.Returns((string _, ConfiguredEndpoint _, CancellationToken ct) =>
|
|
{
|
|
discoveryToken = ct;
|
|
resolverEntered.TrySetResult(true);
|
|
return new ValueTask<ConfiguredEndpoint?>(blocked.Task.WaitAsync(ct));
|
|
});
|
|
Mock<ISession> session = CreateMockSession(
|
|
(int)RedundancySupport.Cold, ServiceLevels.Maximum, serverUris: ["urn:offline"]);
|
|
var cache = (IServerRedundancyEndpointCache)m_handler;
|
|
ServerRedundancyInfo basic = await cache.ReadRedundancyInfoAsync(session.Object, cancellation.Token)
|
|
.ConfigureAwait(false);
|
|
Task<ServerRedundancyInfo> resolving = cache.ResolveCachedEndpointsAsync(
|
|
basic, session.Object.ConfiguredEndpoint, cancellation.Token).AsTask();
|
|
|
|
await resolverEntered.Task.WaitAsync(TimeSpan.FromSeconds(5)).ConfigureAwait(false);
|
|
cancellation.Cancel();
|
|
|
|
await Assert.ThatAsync(
|
|
() => resolving,
|
|
Throws.InstanceOf<OperationCanceledException>()).ConfigureAwait(false);
|
|
Assert.That(discoveryToken.IsCancellationRequested, Is.True);
|
|
Assert.That(basic.RedundantServers[0].Endpoint, Is.Null);
|
|
}
|
|
|
|
[Test]
|
|
public async Task CancelledMetadataReadDoesNotStartPeerDiscoveryAsync()
|
|
{
|
|
using var cancellation = new CancellationTokenSource();
|
|
cancellation.Cancel();
|
|
Mock<ISession> session = CreateMockSession(
|
|
(int)RedundancySupport.Cold, ServiceLevels.Maximum, serverUris: ["urn:offline"]);
|
|
|
|
await Assert.ThatAsync(
|
|
async () => await m_handler.FetchRedundancyInfoAsync(session.Object, cancellation.Token)
|
|
.ConfigureAwait(false),
|
|
Throws.InstanceOf<OperationCanceledException>()).ConfigureAwait(false);
|
|
|
|
session.VerifyNoOtherCalls();
|
|
m_resolver.VerifyNoOtherCalls();
|
|
}
|
|
|
|
[Test]
|
|
public async Task CachedResolutionDoesNotCrossEndpointSecurityProfilesAsync()
|
|
{
|
|
Mock<ISession> session = CreateMockSession(
|
|
(int)RedundancySupport.Cold, ServiceLevels.Maximum, serverUris: ["urn:peer"]);
|
|
ConfiguredEndpoint unsecured = CreateEndpoint("urn:peer", "opc.tcp://peer:4840");
|
|
ConfiguredEndpoint secured = CreateEndpoint("urn:peer", "opc.tcp://peer:4840");
|
|
secured.Description.SecurityMode = MessageSecurityMode.Sign;
|
|
secured.Description.SecurityPolicyUri = SecurityPolicies.Basic256Sha256;
|
|
m_resolver.Setup(resolver => resolver.ResolveAsync(
|
|
"urn:peer", It.Is<ConfiguredEndpoint>(endpoint =>
|
|
endpoint.Description.SecurityMode == MessageSecurityMode.None),
|
|
It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(unsecured);
|
|
m_resolver.Setup(resolver => resolver.ResolveAsync(
|
|
"urn:peer", It.Is<ConfiguredEndpoint>(endpoint =>
|
|
endpoint.Description.SecurityMode == MessageSecurityMode.Sign),
|
|
It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(secured);
|
|
ServerRedundancyInfo first = await m_handler.FetchRedundancyInfoAsync(session.Object)
|
|
.ConfigureAwait(false);
|
|
Assert.That(first.RedundantServers[0].Endpoint, Is.SameAs(unsecured));
|
|
session.Object.ConfiguredEndpoint.Description.SecurityMode = MessageSecurityMode.Sign;
|
|
session.Object.ConfiguredEndpoint.Description.SecurityPolicyUri = SecurityPolicies.Basic256Sha256;
|
|
|
|
ServerRedundancyInfo second = await m_handler.FetchRedundancyInfoAsync(session.Object)
|
|
.ConfigureAwait(false);
|
|
|
|
Assert.That(second.RedundantServers[0].Endpoint, Is.SameAs(secured));
|
|
m_resolver.Verify(resolver => resolver.ResolveAsync(
|
|
"urn:peer", It.IsAny<ConfiguredEndpoint>(), It.IsAny<CancellationToken>()), Times.Exactly(2));
|
|
}
|
|
|
|
[Test]
|
|
public async Task RetriedPeerDiscoveryRejectsLateCancelledResultAsync()
|
|
{
|
|
var time = new FakeTimeProvider();
|
|
var handler = new DefaultServerRedundancyHandler(m_resolver.Object, time);
|
|
ConfiguredEndpoint stale = CreateEndpoint("urn:peer", "opc.tcp://peer:4840");
|
|
ConfiguredEndpoint current = CreateEndpoint("urn:peer", "opc.tcp://peer:4841");
|
|
var blocked = new TaskCompletionSource<ConfiguredEndpoint?>(
|
|
TaskCreationOptions.RunContinuationsAsynchronously);
|
|
m_resolver.SetupSequence(resolver => resolver.ResolveAsync(
|
|
"urn:peer", It.IsAny<ConfiguredEndpoint>(), It.IsAny<CancellationToken>()))
|
|
.Returns(new ValueTask<ConfiguredEndpoint?>(blocked.Task))
|
|
.ReturnsAsync(current);
|
|
Mock<ISession> session = CreateMockSession(
|
|
(int)RedundancySupport.Cold, ServiceLevels.Maximum, serverUris: ["urn:peer"]);
|
|
var cache = (IServerRedundancyEndpointCache)handler;
|
|
ServerRedundancyInfo basic = await cache.ReadRedundancyInfoAsync(session.Object, CancellationToken.None)
|
|
.ConfigureAwait(false);
|
|
Task<ServerRedundancyInfo> first = cache.ResolveCachedEndpointsAsync(
|
|
basic, session.Object.ConfiguredEndpoint, CancellationToken.None).AsTask();
|
|
time.Advance(TimeSpan.FromSeconds(2));
|
|
ServerRedundancyInfo unresolved = await first.WaitAsync(TimeSpan.FromSeconds(10)).ConfigureAwait(false);
|
|
Assert.That(unresolved.RedundantServers[0].Endpoint, Is.Null);
|
|
Task<ServerRedundancyInfo> retry = cache.ResolveCachedEndpointsAsync(
|
|
unresolved, session.Object.ConfiguredEndpoint, CancellationToken.None).AsTask();
|
|
m_resolver.Verify(resolver => resolver.ResolveAsync(
|
|
"urn:peer", It.IsAny<ConfiguredEndpoint>(), It.IsAny<CancellationToken>()), Times.Once);
|
|
|
|
blocked.TrySetResult(stale);
|
|
ServerRedundancyInfo resolved = await retry.WaitAsync(TimeSpan.FromSeconds(10)).ConfigureAwait(false);
|
|
|
|
Assert.That(resolved.RedundantServers[0].Endpoint, Is.SameAs(current));
|
|
ServerRedundancyInfo cached = await cache.ReadRedundancyInfoAsync(session.Object, CancellationToken.None)
|
|
.ConfigureAwait(false);
|
|
Assert.That(cached.RedundantServers[0].Endpoint, Is.SameAs(current));
|
|
m_resolver.Verify(resolver => resolver.ResolveAsync(
|
|
"urn:peer", It.IsAny<ConfiguredEndpoint>(), It.IsAny<CancellationToken>()), Times.Exactly(2));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that a healthy server avoids proactive failover while retaining a recovery target.
|
|
/// </summary>
|
|
[Test]
|
|
public void HealthyServerDoesNotProactivelyFailOverButRetainsRecoveryTarget()
|
|
{
|
|
var info = new ServerRedundancyInfo
|
|
{
|
|
Mode = RedundancySupport.Hot,
|
|
ServiceLevel = ServiceLevels.HealthyMinimum,
|
|
ServiceLevelAccessible = true,
|
|
ServiceLevelSubrange = ServiceLevelSubrange.Healthy,
|
|
RedundantServers =
|
|
[
|
|
CreateServerInfo("urn:backup", ServiceLevels.Maximum, ServerState.Running)
|
|
]
|
|
};
|
|
|
|
ServerFailoverDecision decision = m_handler.ShouldFailover(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
ConfiguredEndpoint? target = m_handler.SelectFailoverTarget(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
|
|
Assert.That(decision.IsFailoverWarranted, Is.False);
|
|
Assert.That(target, Is.Not.Null);
|
|
Assert.That(
|
|
target!.Description.Server.ApplicationUri,
|
|
Is.EqualTo("urn:backup"));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that a degraded server fails over to a healthy peer.
|
|
/// </summary>
|
|
[Test]
|
|
public void ShouldFailoverSwitchesFromDegradedToHealthyPeer()
|
|
{
|
|
var info = new ServerRedundancyInfo
|
|
{
|
|
Mode = RedundancySupport.Hot,
|
|
ServiceLevel = ServiceLevels.DegradedMaximum,
|
|
ServiceLevelAccessible = true,
|
|
ServiceLevelSubrange = ServiceLevelSubrange.Degraded,
|
|
RedundantServers =
|
|
[
|
|
CreateServerInfo("urn:degraded", 150, ServerState.Running),
|
|
CreateServerInfo("urn:healthy", 230, ServerState.Running)
|
|
]
|
|
};
|
|
|
|
ServerFailoverDecision decision = m_handler.ShouldFailover(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
ConfiguredEndpoint? target = m_handler.SelectFailoverTarget(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
|
|
Assert.That(decision.IsFailoverWarranted, Is.True);
|
|
Assert.That(target, Is.Not.Null);
|
|
Assert.That(target!.Description.Server.ApplicationUri, Is.EqualTo("urn:healthy"));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that a degraded server does not fail over when no healthy peer is available.
|
|
/// </summary>
|
|
[Test]
|
|
public void ShouldFailoverDoesNotSwitchFromDegradedWithoutHealthyPeer()
|
|
{
|
|
var info = new ServerRedundancyInfo
|
|
{
|
|
Mode = RedundancySupport.Hot,
|
|
ServiceLevel = 100,
|
|
ServiceLevelAccessible = true,
|
|
ServiceLevelSubrange = ServiceLevelSubrange.Degraded,
|
|
RedundantServers =
|
|
[
|
|
CreateServerInfo("urn:degraded", 150, ServerState.Running)
|
|
]
|
|
};
|
|
|
|
ServerFailoverDecision decision = m_handler.ShouldFailover(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
|
|
Assert.That(decision.IsFailoverWarranted, Is.False);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that a server in maintenance fails over to an operational peer.
|
|
/// </summary>
|
|
[Test]
|
|
public void ShouldFailoverSwitchesFromMaintenanceToOperationalPeer()
|
|
{
|
|
var info = new ServerRedundancyInfo
|
|
{
|
|
Mode = RedundancySupport.Hot,
|
|
ServiceLevel = ServiceLevels.Maintenance,
|
|
ServiceLevelAccessible = true,
|
|
ServiceLevelSubrange = ServiceLevelSubrange.Maintenance,
|
|
EstimatedReturnTime = s_now.AddMinutes(10),
|
|
RedundantServers =
|
|
[
|
|
CreateServerInfo("urn:healthy", 230, ServerState.Running)
|
|
]
|
|
};
|
|
|
|
ServerFailoverDecision decision = m_handler.ShouldFailover(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
ConfiguredEndpoint? target = m_handler.SelectFailoverTarget(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
|
|
Assert.That(decision.IsFailoverWarranted, Is.True);
|
|
Assert.That(target, Is.Not.Null);
|
|
Assert.That(target!.Description.Server.ApplicationUri, Is.EqualTo("urn:healthy"));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that failover timing honors a maintenance server's estimated return time.
|
|
/// </summary>
|
|
[Test]
|
|
public void ShouldFailoverHonorsMaintenanceEstimatedReturnTime()
|
|
{
|
|
DateTime estimatedReturnTime = s_now.AddMinutes(10);
|
|
var info = new ServerRedundancyInfo
|
|
{
|
|
Mode = RedundancySupport.Hot,
|
|
ServiceLevel = ServiceLevels.Maintenance,
|
|
ServiceLevelAccessible = true,
|
|
ServiceLevelSubrange = ServiceLevelSubrange.Maintenance,
|
|
EstimatedReturnTime = estimatedReturnTime,
|
|
RedundantServers =
|
|
[
|
|
CreateServerInfo("urn:shutdown", 230, ServerState.Shutdown)
|
|
]
|
|
};
|
|
|
|
ServerFailoverDecision decision = m_handler.ShouldFailover(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
|
|
Assert.That(decision.IsFailoverWarranted, Is.False);
|
|
Assert.That(decision.RetryAfter, Is.EqualTo(estimatedReturnTime));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that failover uses backoff after the maintenance return estimate has elapsed.
|
|
/// </summary>
|
|
[Test]
|
|
public void ShouldFailoverUsesBackoffWhenMaintenanceReturnTimeLapsed()
|
|
{
|
|
var info = new ServerRedundancyInfo
|
|
{
|
|
Mode = RedundancySupport.Hot,
|
|
ServiceLevel = ServiceLevels.Maintenance,
|
|
ServiceLevelAccessible = true,
|
|
ServiceLevelSubrange = ServiceLevelSubrange.Maintenance,
|
|
EstimatedReturnTime = s_now.AddMinutes(-1),
|
|
RedundantServers =
|
|
[
|
|
CreateServerInfo("urn:shutdown", 230, ServerState.Shutdown)
|
|
]
|
|
};
|
|
|
|
ServerFailoverDecision decision = m_handler.ShouldFailover(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
|
|
Assert.That(decision.IsFailoverWarranted, Is.False);
|
|
Assert.That(
|
|
decision.RetryAfter,
|
|
Is.EqualTo(s_now.Add(DefaultServerRedundancyHandler.DefaultMaintenanceBackoff)));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that failover uses backoff when no maintenance return estimate is available.
|
|
/// </summary>
|
|
[Test]
|
|
public void ShouldFailoverUsesBackoffWhenMaintenanceReturnTimeIsAbsent()
|
|
{
|
|
var info = new ServerRedundancyInfo
|
|
{
|
|
Mode = RedundancySupport.Hot,
|
|
ServiceLevel = ServiceLevels.Maintenance,
|
|
ServiceLevelAccessible = true,
|
|
ServiceLevelSubrange = ServiceLevelSubrange.Maintenance,
|
|
EstimatedReturnTime = DateTime.MinValue,
|
|
RedundantServers =
|
|
[
|
|
CreateServerInfo("urn:shutdown", 230, ServerState.Shutdown)
|
|
]
|
|
};
|
|
|
|
ServerFailoverDecision decision = m_handler.ShouldFailover(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
|
|
Assert.That(decision.IsFailoverWarranted, Is.False);
|
|
Assert.That(
|
|
decision.RetryAfter,
|
|
Is.EqualTo(s_now.Add(DefaultServerRedundancyHandler.DefaultMaintenanceBackoff)));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that no failover is requested when all peers are down.
|
|
/// </summary>
|
|
[Test]
|
|
public void ShouldFailoverReturnsNoFailoverWhenAllPeersAreDown()
|
|
{
|
|
var info = new ServerRedundancyInfo
|
|
{
|
|
Mode = RedundancySupport.Hot,
|
|
ServiceLevel = ServiceLevels.NoData,
|
|
ServiceLevelAccessible = true,
|
|
ServiceLevelSubrange = ServiceLevelSubrange.NoData,
|
|
RedundantServers =
|
|
[
|
|
CreateServerInfo("urn:shutdown", ServiceLevels.Maximum, ServerState.Shutdown),
|
|
CreateServerInfo("urn:suspended", ServiceLevels.Maximum, ServerState.Suspended)
|
|
]
|
|
};
|
|
|
|
ServerFailoverDecision decision = m_handler.ShouldFailover(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
ConfiguredEndpoint? target = m_handler.SelectFailoverTarget(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
|
|
Assert.That(decision.IsFailoverWarranted, Is.False);
|
|
Assert.That(target, Is.Null);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that transparent redundancy does not select a client-side failover target.
|
|
/// </summary>
|
|
[Test]
|
|
public void SelectFailoverTargetReturnsNullForTransparentMode()
|
|
{
|
|
var info = new ServerRedundancyInfo
|
|
{
|
|
Mode = RedundancySupport.Transparent,
|
|
ServiceLevel = ServiceLevels.NoData,
|
|
ServiceLevelAccessible = true,
|
|
ServiceLevelSubrange = ServiceLevelSubrange.NoData,
|
|
RedundantServers =
|
|
[
|
|
CreateServerInfo("urn:backup", 230, ServerState.Running)
|
|
]
|
|
};
|
|
|
|
ConfiguredEndpoint? result = m_handler.SelectFailoverTarget(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
|
|
Assert.That(result, Is.Null);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that disabled redundancy does not select a failover target.
|
|
/// </summary>
|
|
[Test]
|
|
public void SelectFailoverTargetReturnsNullForNoneMode()
|
|
{
|
|
var info = new ServerRedundancyInfo
|
|
{
|
|
Mode = RedundancySupport.None,
|
|
ServiceLevel = ServiceLevels.NoData,
|
|
ServiceLevelAccessible = false,
|
|
ServiceLevelSubrange = ServiceLevelSubrange.NoData,
|
|
RedundantServers =
|
|
[
|
|
CreateServerInfo("urn:backup", 230, ServerState.Running)
|
|
]
|
|
};
|
|
|
|
ConfiguredEndpoint? result = m_handler.SelectFailoverTarget(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
|
|
Assert.That(result, Is.Null);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that failover target selection excludes the current endpoint.
|
|
/// </summary>
|
|
[Test]
|
|
public void SelectFailoverTargetSkipsCurrentEndpoint()
|
|
{
|
|
var info = new ServerRedundancyInfo
|
|
{
|
|
Mode = RedundancySupport.Hot,
|
|
ServiceLevel = ServiceLevels.NoData,
|
|
ServiceLevelAccessible = true,
|
|
ServiceLevelSubrange = ServiceLevelSubrange.NoData,
|
|
RedundantServers =
|
|
[
|
|
CreateServerInfo("urn:current", ServiceLevels.Maximum, ServerState.Running),
|
|
CreateServerInfo("urn:backup", 230, ServerState.Running)
|
|
]
|
|
};
|
|
|
|
ConfiguredEndpoint? result = m_handler.SelectFailoverTarget(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
|
|
Assert.That(result, Is.Not.Null);
|
|
Assert.That(result!.Description.Server.ApplicationUri, Is.EqualTo("urn:backup"));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that failover target selection excludes servers that are not running.
|
|
/// </summary>
|
|
[Test]
|
|
public void SelectFailoverTargetSkipsNonRunningServers()
|
|
{
|
|
var info = new ServerRedundancyInfo
|
|
{
|
|
Mode = RedundancySupport.Hot,
|
|
ServiceLevel = ServiceLevels.NoData,
|
|
ServiceLevelAccessible = true,
|
|
ServiceLevelSubrange = ServiceLevelSubrange.NoData,
|
|
RedundantServers =
|
|
[
|
|
CreateServerInfo("urn:suspended", ServiceLevels.Maximum, ServerState.Suspended),
|
|
CreateServerInfo("urn:shutdown", 240, ServerState.Shutdown),
|
|
CreateServerInfo("urn:running", 230, ServerState.Running)
|
|
]
|
|
};
|
|
|
|
ConfiguredEndpoint? result = m_handler.SelectFailoverTarget(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
|
|
Assert.That(result, Is.Not.Null);
|
|
Assert.That(result!.Description.Server.ApplicationUri, Is.EqualTo("urn:running"));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that target selection returns null when no viable server remains.
|
|
/// </summary>
|
|
[Test]
|
|
public void SelectFailoverTargetReturnsNullWhenNoViableServers()
|
|
{
|
|
var info = new ServerRedundancyInfo
|
|
{
|
|
Mode = RedundancySupport.Hot,
|
|
ServiceLevel = ServiceLevels.NoData,
|
|
ServiceLevelAccessible = true,
|
|
ServiceLevelSubrange = ServiceLevelSubrange.NoData,
|
|
RedundantServers =
|
|
[
|
|
CreateServerInfo("urn:current", 230, ServerState.Running),
|
|
CreateServerInfo("urn:down", 230, ServerState.Shutdown)
|
|
]
|
|
};
|
|
|
|
ConfiguredEndpoint? result = m_handler.SelectFailoverTarget(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
|
|
Assert.That(result, Is.Null);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that redundancy discovery reads the redundant server array.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task FetchRedundancyInfoReadsRedundantServerArrayAsync()
|
|
{
|
|
var serverData = new RedundantServerDataType
|
|
{
|
|
ServerId = "urn:server1",
|
|
ServiceLevel = 230,
|
|
ServerState = ServerState.Running
|
|
};
|
|
ConfiguredEndpoint resolvedEndpoint = CreateEndpoint("urn:server1", "opc.tcp://server1:4840");
|
|
m_resolver.Setup(r => r.ResolveAsync(
|
|
"urn:server1",
|
|
It.IsAny<ConfiguredEndpoint>(),
|
|
It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(resolvedEndpoint);
|
|
|
|
Mock<ISession> mockSession = CreateMockSession(
|
|
redundancySupport: (int)RedundancySupport.Hot,
|
|
serviceLevel: 100,
|
|
redundantServers: [serverData]);
|
|
|
|
ServerRedundancyInfo info = await m_handler.FetchRedundancyInfoAsync(
|
|
mockSession.Object).ConfigureAwait(false);
|
|
|
|
Assert.That(info.Mode, Is.EqualTo(RedundancySupport.Hot));
|
|
Assert.That(info.ServiceLevelSubrange, Is.EqualTo(ServiceLevelSubrange.Degraded));
|
|
Assert.That(info.RedundantServers, Has.Count.EqualTo(1));
|
|
Assert.That(info.RedundantServers[0].ServerUri, Is.EqualTo("urn:server1"));
|
|
Assert.That(info.RedundantServers[0].Endpoint, Is.SameAs(resolvedEndpoint));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that redundancy discovery resolves server application URIs to endpoints.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task FetchRedundancyInfoResolvesServerUriArrayToEndpointsAsync()
|
|
{
|
|
ConfiguredEndpoint resolvedEndpoint = CreateEndpoint("urn:server-uri", "opc.tcp://server-uri:4840");
|
|
m_resolver.Setup(r => r.ResolveAsync(
|
|
"urn:server-uri",
|
|
It.IsAny<ConfiguredEndpoint>(),
|
|
It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(resolvedEndpoint);
|
|
|
|
Mock<ISession> mockSession = CreateMockSession(
|
|
redundancySupport: (int)RedundancySupport.Hot,
|
|
serviceLevel: ServiceLevels.NoData,
|
|
serverUris: ["urn:server-uri"]);
|
|
|
|
ServerRedundancyInfo info = await m_handler.FetchRedundancyInfoAsync(
|
|
mockSession.Object).ConfigureAwait(false);
|
|
|
|
Assert.That(info.RedundantServers, Has.Count.EqualTo(1));
|
|
Assert.That(info.RedundantServers[0].ServerUri, Is.EqualTo("urn:server-uri"));
|
|
Assert.That(info.RedundantServers[0].Endpoint, Is.SameAs(resolvedEndpoint));
|
|
Assert.That(
|
|
info.RedundantServers[0].Endpoint!.Description.EndpointUrl,
|
|
Is.EqualTo("opc.tcp://server-uri:4840"));
|
|
VerifyBatchedRedundancyRead(mockSession);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that peers with unresolved server URIs are excluded from failover selection.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task FetchRedundancyInfoExcludesUnresolvedServerUriFromSelectionAsync()
|
|
{
|
|
m_resolver.Setup(r => r.ResolveAsync(
|
|
"urn:unresolved",
|
|
It.IsAny<ConfiguredEndpoint>(),
|
|
It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync((ConfiguredEndpoint?)null);
|
|
Mock<ISession> mockSession = CreateMockSession(
|
|
redundancySupport: (int)RedundancySupport.Hot,
|
|
serviceLevel: ServiceLevels.NoData,
|
|
serverUris: ["urn:unresolved"]);
|
|
|
|
ServerRedundancyInfo info = await m_handler.FetchRedundancyInfoAsync(
|
|
mockSession.Object).ConfigureAwait(false);
|
|
ConfiguredEndpoint? target = m_handler.SelectFailoverTarget(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
|
|
Assert.That(info.RedundantServers, Has.Count.EqualTo(1));
|
|
Assert.That(info.RedundantServers[0].Endpoint, Is.Null);
|
|
Assert.That(target, Is.Null);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that a URI-only peer can be selected when its service level is unknown.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task FetchRedundancyInfoSelectsServerUriOnlyPeerWithUnknownServiceLevelAsync()
|
|
{
|
|
ConfiguredEndpoint resolvedEndpoint = CreateEndpoint("urn:server-uri", "opc.tcp://server-uri:4840");
|
|
m_resolver.Setup(r => r.ResolveAsync(
|
|
"urn:server-uri",
|
|
It.IsAny<ConfiguredEndpoint>(),
|
|
It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(resolvedEndpoint);
|
|
Mock<ISession> mockSession = CreateMockSession(
|
|
redundancySupport: (int)RedundancySupport.Hot,
|
|
serviceLevel: ServiceLevels.NoData,
|
|
serverUris: ["urn:server-uri"]);
|
|
|
|
ServerRedundancyInfo info = await m_handler.FetchRedundancyInfoAsync(
|
|
mockSession.Object).ConfigureAwait(false);
|
|
ConfiguredEndpoint? target = m_handler.SelectFailoverTarget(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
|
|
Assert.That(info.RedundantServers[0].ServiceLevel, Is.EqualTo(ServiceLevels.NoData));
|
|
Assert.That(target, Is.SameAs(resolvedEndpoint));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that discovery can fall back to a URI-only peer with unknown service level.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task FetchRedundancyInfoFallsBackToUnknownServerUriOnlyPeerAsync()
|
|
{
|
|
var serverData = new RedundantServerDataType
|
|
{
|
|
ServerId = "urn:nodata",
|
|
ServiceLevel = ServiceLevels.NoData,
|
|
ServerState = ServerState.Running
|
|
};
|
|
ConfiguredEndpoint noDataEndpoint = CreateEndpoint("urn:nodata", "opc.tcp://nodata:4840");
|
|
ConfiguredEndpoint unknownEndpoint = CreateEndpoint("urn:server-uri", "opc.tcp://server-uri:4840");
|
|
m_resolver.Setup(r => r.ResolveAsync(
|
|
"urn:nodata",
|
|
It.IsAny<ConfiguredEndpoint>(),
|
|
It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(noDataEndpoint);
|
|
m_resolver.Setup(r => r.ResolveAsync(
|
|
"urn:server-uri",
|
|
It.IsAny<ConfiguredEndpoint>(),
|
|
It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(unknownEndpoint);
|
|
Mock<ISession> mockSession = CreateMockSession(
|
|
redundancySupport: (int)RedundancySupport.Hot,
|
|
serviceLevel: ServiceLevels.DegradedMaximum,
|
|
redundantServers: [serverData],
|
|
serverUris: ["urn:nodata", "urn:server-uri"]);
|
|
|
|
ServerRedundancyInfo info = await m_handler.FetchRedundancyInfoAsync(
|
|
mockSession.Object).ConfigureAwait(false);
|
|
ConfiguredEndpoint? target = m_handler.SelectFailoverTarget(
|
|
info, CreateCurrentEndpoint("urn:current"));
|
|
|
|
Assert.That(info.RedundantServers, Has.Count.EqualTo(2));
|
|
Assert.That(target, Is.SameAs(unknownEndpoint));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that redundancy discovery caches resolved peer endpoints.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task FetchRedundancyInfoCachesResolvedEndpointsAsync()
|
|
{
|
|
var serverData = new RedundantServerDataType
|
|
{
|
|
ServerId = "urn:server1",
|
|
ServiceLevel = 230,
|
|
ServerState = ServerState.Running
|
|
};
|
|
ConfiguredEndpoint resolvedEndpoint = CreateEndpoint("urn:server1", "opc.tcp://server1:4840");
|
|
m_resolver.Setup(r => r.ResolveAsync(
|
|
"urn:server1",
|
|
It.IsAny<ConfiguredEndpoint>(),
|
|
It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(resolvedEndpoint);
|
|
Mock<ISession> mockSession = CreateMockSession(
|
|
redundancySupport: (int)RedundancySupport.Hot,
|
|
serviceLevel: 100,
|
|
redundantServers: [serverData]);
|
|
|
|
await m_handler.FetchRedundancyInfoAsync(mockSession.Object).ConfigureAwait(false);
|
|
await m_handler.FetchRedundancyInfoAsync(mockSession.Object).ConfigureAwait(false);
|
|
|
|
m_resolver.Verify(r => r.ResolveAsync(
|
|
"urn:server1",
|
|
It.IsAny<ConfiguredEndpoint>(),
|
|
It.IsAny<CancellationToken>()), Times.Once);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that transparent redundancy discovery reads the current server identifier.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task FetchRedundancyInfoReadsTransparentCurrentServerIdAsync()
|
|
{
|
|
Mock<ISession> mockSession = CreateMockSession(
|
|
redundancySupport: (int)RedundancySupport.Transparent,
|
|
serviceLevel: ServiceLevels.HealthyMinimum,
|
|
currentServerId: "server-a");
|
|
|
|
ServerRedundancyInfo info = await m_handler.FetchRedundancyInfoAsync(
|
|
mockSession.Object).ConfigureAwait(false);
|
|
|
|
Assert.That(info.CurrentServerId, Is.EqualTo("server-a"));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that failed redundancy reads report no redundancy, an inaccessible service level, and no peers.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task FetchRedundancyInfoHandlesReadErrorsAsync()
|
|
{
|
|
Mock<ISession> mockSession = CreateMockSessionWithBadStatus();
|
|
|
|
ServerRedundancyInfo info = await m_handler.FetchRedundancyInfoAsync(
|
|
mockSession.Object).ConfigureAwait(false);
|
|
|
|
Assert.That(info.Mode, Is.EqualTo(RedundancySupport.None));
|
|
Assert.That(info.ServiceLevel, Is.Zero);
|
|
Assert.That(info.ServiceLevelAccessible, Is.False);
|
|
Assert.That(info.RedundantServers, Is.Empty);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that malformed optional redundancy nodes preserve the discovered mode without inventing peers.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task FetchRedundancyInfoHandlesMalformedOptionalNodesAsync()
|
|
{
|
|
Mock<ISession> mockSession = CreateMockSessionWithThrowingOptionalReads();
|
|
|
|
ServerRedundancyInfo info = await m_handler.FetchRedundancyInfoAsync(
|
|
mockSession.Object).ConfigureAwait(false);
|
|
|
|
Assert.That(info.Mode, Is.EqualTo(RedundancySupport.Hot));
|
|
Assert.That(info.RedundantServers, Is.Empty);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verifies that discovery and failover APIs reject null sessions, redundancy information, and endpoints.
|
|
/// </summary>
|
|
[Test]
|
|
public void NullArgumentsThrow()
|
|
{
|
|
var info = new ServerRedundancyInfo();
|
|
ConfiguredEndpoint endpoint = CreateCurrentEndpoint("urn:current");
|
|
|
|
Assert.That(
|
|
async () => await m_handler.FetchRedundancyInfoAsync(null!).ConfigureAwait(false),
|
|
Throws.ArgumentNullException);
|
|
Assert.That(() => m_handler.ShouldFailover(null!, endpoint), Throws.ArgumentNullException);
|
|
Assert.That(() => m_handler.ShouldFailover(info, null!), Throws.ArgumentNullException);
|
|
Assert.That(() => m_handler.SelectFailoverTarget(null!, endpoint), Throws.ArgumentNullException);
|
|
Assert.That(() => m_handler.SelectFailoverTarget(info, null!), Throws.ArgumentNullException);
|
|
}
|
|
|
|
private static RedundantServer CreateServerInfo(
|
|
string uri,
|
|
byte serviceLevel,
|
|
ServerState state)
|
|
{
|
|
return new RedundantServer
|
|
{
|
|
ServerUri = uri,
|
|
ServiceLevel = serviceLevel,
|
|
ServerState = state,
|
|
Endpoint = CreateEndpoint(uri, $"opc.tcp://{uri[4..]}:4840")
|
|
};
|
|
}
|
|
|
|
private static ConfiguredEndpoint CreateCurrentEndpoint(string applicationUri)
|
|
{
|
|
return CreateEndpoint(applicationUri, "opc.tcp://current:4840");
|
|
}
|
|
|
|
private static ConfiguredEndpoint CreateEndpoint(string applicationUri, string endpointUrl)
|
|
{
|
|
var description = new EndpointDescription
|
|
{
|
|
EndpointUrl = endpointUrl,
|
|
SecurityMode = MessageSecurityMode.None,
|
|
SecurityPolicyUri = SecurityPolicies.None,
|
|
Server = new ApplicationDescription
|
|
{
|
|
ApplicationUri = applicationUri,
|
|
DiscoveryUrls = new ArrayOf<string>(new[] { endpointUrl })
|
|
}
|
|
};
|
|
|
|
return new ConfiguredEndpoint(null, description, configuration: null);
|
|
}
|
|
|
|
private static Mock<ISession> CreateMockSession(
|
|
int redundancySupport,
|
|
byte serviceLevel,
|
|
RedundantServerDataType[]? redundantServers = null,
|
|
string[]? serverUris = null,
|
|
string currentServerId = "")
|
|
{
|
|
var mock = new Mock<ISession>();
|
|
mock.SetupGet(s => s.ConfiguredEndpoint)
|
|
.Returns(CreateCurrentEndpoint("urn:current"));
|
|
|
|
mock.Setup(s => s.ReadAsync(
|
|
It.IsAny<RequestHeader>(),
|
|
It.IsAny<double>(),
|
|
It.IsAny<TimestampsToReturn>(),
|
|
It.Is<ArrayOf<ReadValueId>>(r => r.Count == 5),
|
|
It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(new ReadResponse
|
|
{
|
|
Results =
|
|
[
|
|
new DataValue(new Variant(redundancySupport), StatusCodes.Good),
|
|
new DataValue(new Variant(serviceLevel), StatusCodes.Good),
|
|
redundantServers == null
|
|
? new DataValue(Variant.Null, StatusCodes.BadNodeIdUnknown)
|
|
: CreateRedundantServerArrayValue(redundantServers),
|
|
serverUris == null
|
|
? new DataValue(Variant.Null, StatusCodes.BadNodeIdUnknown)
|
|
: new DataValue(new Variant(new ArrayOf<string>(serverUris)), StatusCodes.Good),
|
|
new DataValue(new Variant(DateTime.MinValue), StatusCodes.Good)
|
|
],
|
|
DiagnosticInfos = []
|
|
});
|
|
|
|
SetupSingleNodeRead(
|
|
mock,
|
|
VariableIds.Server_ServerRedundancy_CurrentServerId,
|
|
string.IsNullOrEmpty(currentServerId)
|
|
? new DataValue(Variant.Null, StatusCodes.BadNodeIdUnknown)
|
|
: new DataValue(new Variant(currentServerId), StatusCodes.Good));
|
|
|
|
return mock;
|
|
}
|
|
|
|
private static void SetupSingleNodeRead(
|
|
Mock<ISession> mock,
|
|
NodeId nodeId,
|
|
DataValue result)
|
|
{
|
|
mock.Setup(s => s.ReadAsync(
|
|
It.IsAny<RequestHeader>(),
|
|
It.IsAny<double>(),
|
|
It.IsAny<TimestampsToReturn>(),
|
|
It.Is<ArrayOf<ReadValueId>>(r => r.Count == 1 && r[0].NodeId == nodeId),
|
|
It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(new ReadResponse
|
|
{
|
|
Results = [result],
|
|
DiagnosticInfos = []
|
|
});
|
|
}
|
|
|
|
private static void VerifyBatchedRedundancyRead(Mock<ISession> mock)
|
|
{
|
|
mock.Verify(s => s.ReadAsync(
|
|
It.IsAny<RequestHeader>(),
|
|
It.IsAny<double>(),
|
|
It.IsAny<TimestampsToReturn>(),
|
|
It.Is<ArrayOf<ReadValueId>>(r => r.Count == 5),
|
|
It.IsAny<CancellationToken>()), Times.Once);
|
|
mock.Verify(s => s.ReadAsync(
|
|
It.IsAny<RequestHeader>(),
|
|
It.IsAny<double>(),
|
|
It.IsAny<TimestampsToReturn>(),
|
|
It.Is<ArrayOf<ReadValueId>>(r =>
|
|
r.Count == 1 &&
|
|
(r[0].NodeId == VariableIds.Server_ServerRedundancy_RedundantServerArray ||
|
|
r[0].NodeId == VariableIds.Server_ServerRedundancy_ServerUriArray)),
|
|
It.IsAny<CancellationToken>()), Times.Never);
|
|
}
|
|
|
|
private static DataValue CreateRedundantServerArrayValue(
|
|
RedundantServerDataType[] redundantServers)
|
|
{
|
|
ArrayOf<ExtensionObject> extensionObjects =
|
|
Array.ConvertAll(redundantServers, s => new ExtensionObject(s));
|
|
|
|
return new DataValue(new Variant(extensionObjects), StatusCodes.Good);
|
|
}
|
|
|
|
private static Mock<ISession> CreateMockSessionWithBadStatus()
|
|
{
|
|
var mock = new Mock<ISession>();
|
|
|
|
mock.Setup(s => s.ReadAsync(
|
|
It.IsAny<RequestHeader>(),
|
|
It.IsAny<double>(),
|
|
It.IsAny<TimestampsToReturn>(),
|
|
It.Is<ArrayOf<ReadValueId>>(r => r.Count == 5),
|
|
It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(new ReadResponse
|
|
{
|
|
Results =
|
|
[
|
|
new DataValue(Variant.Null, StatusCodes.BadNodeIdUnknown),
|
|
new DataValue(Variant.Null, StatusCodes.BadNodeIdUnknown),
|
|
new DataValue(Variant.Null, StatusCodes.BadNodeIdUnknown),
|
|
new DataValue(Variant.Null, StatusCodes.BadNodeIdUnknown),
|
|
new DataValue(Variant.Null, StatusCodes.BadNodeIdUnknown)
|
|
],
|
|
DiagnosticInfos = []
|
|
});
|
|
|
|
return mock;
|
|
}
|
|
|
|
private static Mock<ISession> CreateMockSessionWithThrowingOptionalReads()
|
|
{
|
|
return CreateMockSession(
|
|
redundancySupport: (int)RedundancySupport.Hot,
|
|
serviceLevel: ServiceLevels.NoData);
|
|
}
|
|
|
|
private sealed class FixedTimeProvider : TimeProvider
|
|
{
|
|
public FixedTimeProvider(DateTime utcNow)
|
|
{
|
|
m_utcNow = utcNow;
|
|
}
|
|
|
|
public override DateTimeOffset GetUtcNow()
|
|
{
|
|
return m_utcNow;
|
|
}
|
|
|
|
private readonly DateTimeOffset m_utcNow;
|
|
}
|
|
}
|
|
}
|