Files
UA-.NETStandard/tests/Opc.Ua.Core.Tests/Stack/State/ProgramStateMachineStateTests.cs
romanettandClaude Opus 5 3543d7cf6c Report Executable/UserExecutable for state machine causes (#4368)
# Description

A Part 16 cause is a Method, and whether it may fire depends on the
state the machine is in. Part 3 defines `Executable` / `UserExecutable`
as exactly that question, and Part 4 has `Call` refuse a non-executable
Method with `Bad_NotExecutable`. `FiniteStateMachineState` already knows
the answer — `IsCausePermitted(context, causeId, checkUserAccessRights)`
— but nothing outside alarm shelving connected the two. Across the
library, `OnReadExecutable` was assigned in exactly three places, all in
`AlarmConditionState`. Everywhere else a cause method kept the `true`
its node was constructed with, so a client could not tell which causes
currently apply and found out only by calling one and being refused with
`Bad_NotSupported` from `DoCause`.

## What changed

**`StateMachineBuilder.WithCause`** now answers both attributes from
`IsCausePermitted` alongside installing the call handler — on the
unified builder (via the dispatcher's `InstallCauseMethod`) and on the
`Opc.Ua.Server.Fluent` surface reached through
`INodeBuilder.AsStateMachine()`, which had the identical gap.
`Executable` ignores user rights; `UserExecutable` also runs the
machine's `OnCheckUserPermission` callback.

Per the issue's note about servers that deliberately keep methods
executable and answer at call time, both overloads take
`reportExecutable: false` to opt out.

**`ProgramStateMachineState`** wires its own `Start` / `Suspend` /
`Resume` / `Halt` / `Reset` in `OnAfterCreate`, so a Program server no
longer repeats the boilerplate the class already shipped handlers for.
The Boiler quickstart's copy of it is deleted rather than left as an
example.

**Generator-emitted `*StateMachineState` subclasses** are left alone.
The generator emits no Part 16 `StateTable` / `TransitionTable` /
`CauseMappings` overrides — the same gap that makes the DI
software-update dispatcher write `CurrentState` directly instead of
going through `SetState` (see `docs/SoftwareUpdate.md`) — so there is
nothing to derive executability from. A vendor machine from a NodeSet
gets its causes through `StateMachineBuilder.For(...).WithCause(...)`,
which the first change covers. Worth revisiting if the generator gains
table emission.

## Notes for reviewers

Two details behind the `ProgramStateMachineState` change:

- The five methods are `OptionalPlaceholder` on
`ProgramStateMachineType`, so the generated class has no typed
properties for them. They are matched on browse name **without** the
namespace index, because a subtype that redeclares them puts them in its
own namespace — the Boiler model uses `1:Start`, not `0:Start`.
- `NodeState.Create` rebuilds the child list from the type template, so
a method added by hand before it is gone by the time `OnAfterCreate`
runs. `WireCauseMethods(ISystemContext)` is public for that case.

**Behaviour change worth flagging:** a `WithCause` against a machine
whose `CauseMappings` lack that cause now reports the method
non-executable where it previously reported executable. Such a call was
already failing with `Bad_NotSupported` inside `DoCause`, so it fails
earlier with the code Part 4 specifies rather than newly failing — but
it is visible to clients that read the attribute.

## Related Issues

- Fixes #4363

## Checklist

- [x] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

### Tests

New: `StateMachineBuilderCauseExecutableTests` (definition mode, the
opt-out, `OnCheckUserPermission` affecting `UserExecutable` only,
suspended machines) and `ProgramStateMachineStateTests`, plus two cases
added to the existing fluent-builder fixture. All read through
`MethodState.ReadAttribute`, so a handler that is installed but never
consulted fails the test.

Run locally on **net10.0**: `Opc.Ua.Server.Tests` (4797),
`Opc.Ua.Core.Tests` (4374), `Opc.Ua.Di.Tests`, `Opc.Ua.Features.Tests`,
`Opc.Ua.Robotics.Intent.Tests` and the Boiler AOT tests all pass;
`UA.slnx` builds with no new warnings. The .NET Framework legs were not
run locally — leaving that checklist box to CI.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
2026-09-01 18:31:36 +02:00

241 lines
9.4 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
// CA2000: test code; many disposables are ownership-transferred to test fixtures or short-lived,
// making CA2000 noisy without a real leak risk. Disabled file-level for the suite.
#pragma warning disable CA2000
using System;
using NUnit.Framework;
using Opc.Ua.Tests;
namespace Opc.Ua.Core.Tests.Stack.State
{
/// <summary>
/// Tests that <see cref="ProgramStateMachineState"/> wires the cause
/// methods it ships handlers for. Part 3 §5.7 defines
/// <c>Executable</c> / <c>UserExecutable</c> as "may this Method be
/// called right now", which for a Part 16 cause is
/// <see cref="FiniteStateMachineState.IsCausePermitted"/>; left
/// unwired the attributes stay at the <c>true</c> the node was
/// constructed with and a client can only discover which causes
/// apply by calling one and being refused.
/// </summary>
[TestFixture]
[Category("ProgramStateMachineState")]
[SetCulture("en-us")]
[SetUICulture("en-us")]
[Parallelizable]
public class ProgramStateMachineStateTests
{
private const ushort kNs = 2;
private ISystemContext m_context;
private ITelemetryContext m_telemetry;
[OneTimeSetUp]
protected void OneTimeSetUp()
{
m_telemetry = NUnitTelemetryContext.Create();
var messageContext = ServiceMessageContext.Create(m_telemetry);
messageContext.NamespaceUris.GetIndexOrAppend(Namespaces.OpcUa);
m_context = new SystemContext(m_telemetry)
{
NamespaceUris = messageContext.NamespaceUris
};
}
[OneTimeTearDown]
protected void OneTimeTearDown()
{
(m_context as IDisposable)?.Dispose();
}
[Test]
public void CauseMethodsReportExecutableFromTheCurrentState()
{
ProgramStateMachineState machine = CreateMachine(
out MethodState start, out MethodState halt);
// The machine starts in Ready: Start applies, Halt applies,
// Reset (Halted only) does not.
Assert.Multiple(() =>
{
Assert.That(ReadAttribute(start, Attributes.Executable), Is.True);
Assert.That(ReadAttribute(start, Attributes.UserExecutable), Is.True);
Assert.That(ReadAttribute(halt, Attributes.Executable), Is.True);
});
machine.SetState(m_context, Objects.ProgramStateMachineType_Halted);
Assert.Multiple(() =>
{
Assert.That(ReadAttribute(start, Attributes.Executable), Is.False);
Assert.That(ReadAttribute(start, Attributes.UserExecutable), Is.False);
Assert.That(ReadAttribute(halt, Attributes.Executable), Is.False);
});
}
[Test]
public void CauseMethodsAreBoundToTheMatchingCause()
{
ProgramStateMachineState machine = CreateMachine(
out MethodState start, out _);
Assert.That(start.OnCallMethod, Is.Not.Null);
ServiceResult result = start.OnCallMethod!(
m_context, start, inputArguments: default, outputArguments: []);
Assert.That(ServiceResult.IsGood(result), Is.True, $"Start must succeed: {result}");
Assert.That(CurrentStateId(machine),
Is.EqualTo(Objects.ProgramStateMachineType_Running));
}
[Test]
public void MethodsAddedAfterCreateAreWiredOnDemand()
{
ProgramStateMachineState machine = CreateMachine(out _, out _);
// Create rebuilds the child list from the type template, so
// a method materialized afterwards has to be wired by the
// server — the public entry point exists for exactly that.
MethodState reset = AddMethod(machine, BrowseNames.Reset, "Machine_Reset");
Assert.That(reset.OnReadExecutable, Is.Null);
machine.WireCauseMethods(m_context);
// The machine is in Ready, and Reset is a cause of Halted.
Assert.Multiple(() =>
{
Assert.That(reset.OnCallMethod, Is.Not.Null);
Assert.That(ReadAttribute(reset, Attributes.Executable), Is.False);
});
machine.SetState(m_context, Objects.ProgramStateMachineType_Halted);
Assert.That(ReadAttribute(reset, Attributes.Executable), Is.True);
}
/// <summary>
/// Builds a machine with two of the five optional cause methods
/// declared, so the test also covers the "only the materialized
/// ones are wired" half.
/// </summary>
private TestProgramStateMachineState CreateMachine(
out MethodState start,
out MethodState halt)
{
var machine = new TestProgramStateMachineState
{
NodeId = new NodeId("Machine", kNs),
BrowseName = new QualifiedName("Machine", kNs),
DisplayName = new LocalizedText("Machine")
};
machine.Create(
m_context,
machine.NodeId,
machine.BrowseName,
displayName: machine.DisplayName,
assignNodeIds: false);
start = machine.Start;
halt = machine.Halt;
return machine;
}
private static MethodState AddMethod(
ProgramStateMachineState machine,
string browseName,
string nodeIdentifier)
{
// Executable / UserExecutable default to true on a freshly
// constructed node — the very value the fix has to replace.
var method = new MethodState(machine)
{
ReferenceTypeId = ReferenceTypeIds.HasComponent,
NodeId = new NodeId(nodeIdentifier, kNs),
BrowseName = new QualifiedName(browseName, kNs),
DisplayName = new LocalizedText(browseName),
Executable = true,
UserExecutable = true
};
machine.AddChild(method);
return method;
}
/// <summary>
/// Stands in for a generator-emitted subclass whose model
/// declares two of the optional cause methods. They have to be
/// materialized in <see cref="InitializeOptionalChildren"/>
/// because <see cref="NodeState.Create(ISystemContext, NodeId,
/// QualifiedName, LocalizedText, bool)"/> rebuilds the child
/// list from the type template.
/// </summary>
private sealed class TestProgramStateMachineState : ProgramStateMachineState
{
public TestProgramStateMachineState()
: base(parent: null)
{
}
public MethodState Start { get; private set; }
public MethodState Halt { get; private set; }
protected override void InitializeOptionalChildren(ISystemContext context)
{
base.InitializeOptionalChildren(context);
Start = AddMethod(this, BrowseNames.Start, "Machine_Start");
Halt = AddMethod(this, BrowseNames.Halt, "Machine_Halt");
}
}
private bool ReadAttribute(MethodState method, uint attributeId)
{
var value = new DataValue();
ServiceResult result = method.ReadAttribute(
m_context, attributeId, default, default, ref value);
Assert.That(ServiceResult.IsGood(result), Is.True,
$"read of {Attributes.GetBrowseName(attributeId)} failed: {result}");
Assert.That(value.WrappedValue.TryGetValue(out bool flag), Is.True,
$"{Attributes.GetBrowseName(attributeId)} must read as a Boolean.");
return flag;
}
private static uint CurrentStateId(ProgramStateMachineState machine)
{
NodeId stateNodeId = machine.CurrentState.Id.Value;
return stateNodeId.TryGetValue(out uint id) ? id : 0;
}
}
}