mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-24 11:01:55 +08:00
# Description SubscriptionManager.RestoreSubscriptionsAsync logged and swallowed every restore failure: a subscription store that threw, a store that reported an unsuccessful restore, and a stored subscription that could not be recreated. The server then started without those subscriptions, the store was told the restore had completed (so it cleaned up what it held), and nothing but a log line showed that subscriptions had been lost. A failed restore now fails the restore, and with it the startup: - a store that throws fails with BadInternalError and the store's exception as the inner exception; - a store that reports Success = false fails with BadInternalError; - stored subscriptions that cannot be recreated are collected and reported as an AggregateException, before the store is told that the restore completed, so the store keeps what it holds. SubscriptionManager.ContinueOnRestoreFailure (default false) restores the previous behaviour for applications that prefer to start without the subscriptions. Cancellation is no longer swallowed unless that option is set. The Quickstarts durable subscription store reported Success = false when it had nothing stored; it now reports a successful restore of no subscriptions, and keeps reporting a failure when its file cannot be read. ## Related Issues None. ## Checklist - [x] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [x] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [x] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [x] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [x] I have addressed **all** PR feedback received. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Marc Schier <marcschier@users.noreply.github.com>
7.3 KiB
7.3 KiB
Durable Subscription
Overview
Durable subscriptions let servers retain subscriptions for longer periods and use large notification queues. If a client disconnects, the server continues sampling values. After reconnecting, the client can use the TransferSubscriptions service to retrieve missed notifications.
Contents
- Overview
- Fix an existing server with minimal changes
- Enabling durable subscriptions on an existing server
- Known limitations and issues
Fix an existing server with minimal changes
- If you implement a custom
INodeManageror overrideCreateMonitoredItems, add thecreateDurableparameter. You can ignore it while durable subscriptions are disabled in the server configuration. - Implement
INodeManager.RestoreMonitoredItems. The server calls this method only when durable subscriptions are enabled. - If you implement a custom
IMonitoredItem, setIsDurabletofalseand implementDispose.
Enabling durable subscriptions on an existing server
Typically the following porting steps are necessary:
- Implement
IMonitoredItemQueueFactoryand setSupportsDurableQueuestotrue. Return anIMonitoredItemQueuethat persists values and supports large queue sizes. See the sample DurableMonitoredItemQueueFactory. - Register the queue factory by overriding
StandardServer.CreateMonitoredItemQueueFactory. - Implement
ISubscriptionStoreto persist and restore subscriptions across server restarts. After restoring a subscription, the store must also provide persistent queues to its monitored items. Register the store by overridingStandardServer.CreateSubscriptionStore. - Report a store that cannot read its subscriptions from
RestoreSubscriptionsAsync, either by throwing or by returningRestoreSubscriptionResult.Success = false; returnSuccess = truewith no subscriptions when nothing was stored. Keep the stored subscriptions and the queue snapshots of their monitored items untilOnSubscriptionRestoreCompleteAsyncis called: the server calls it only after it has recreated every stored subscription, so a store that deletes its data while reading it loses the subscriptions when the restore fails. - A failed restore fails
SubscriptionManager.RestoreSubscriptionsAsyncand with it the server startup: a store failure surfaces as aServiceResultException(BadInternalError), stored subscriptions that cannot be recreated as anAggregateException. To start anyway, setSubscriptionManager.ContinueOnRestoreFailuretotruein an override ofStandardServer.CreateSubscriptionManager; failures are then logged as errors and warnings, and the subscriptions concerned are lost. A restore that fails or is cancelled deletes the subscriptions it already recreated without storing them; it keeps the stored contents of their monitored item queues and resets what it set on the stored subscriptions and monitored items the store returned, so the store may return the same objects to a retry. A server startup that fails releases its session and subscription managers, so the restore can be retried by starting again. - A queue whose contents are kept in storage while the server runs, and which
disposing removes from that storage, should implement
IRestorableMonitoredItemQueue. WhileSubscriptionManager.RestoreSubscriptionsAsyncrestores the subscriptions it callsBeginRestorebefore it changes such a queue of a restored monitored item; the queue must then not write to its storage. When every stored subscription was restored and the store was told so, the server callsCommitRestore, and the queue writes its current contents once and resumes writing. The restore can no longer be rolled back then, soCommitRestoremust not throw: a queue that cannot write handles the failure itself, e.g. logs it and writes on its next change; the server logs an exception it throws and commits the other queues. When the restore fails or is cancelled the server callsAbortRestoreand disposes the queue; the queue must drop every write it has not started, never start a write again, and not remove its stored contents on dispose, because the retry reads them again. A write already in progress whenAbortRestoreis called cannot be recalled and may complete; a queue staged byBeginRestorestarts no write beforeCommitRestore, so its stored contents stay exactly as they were. A queue disposed afterBeginRestorebut beforeCommitRestore, e.g. because a node manager failed to create its monitored item, must keep its stored contents as well. The mirrored queues ofSharedKeyValueMonitoredItemQueueFactoryimplement it. Only the baseSubscriptionManager.RestoreSubscriptionsAsyncstages queues: a monitored item restored outside of it, e.g. by callingSubscription.RestoreAsyncor the restoringMonitoredItemconstructor directly, writes its queue to storage at once, as before. - If you implement a custom
INodeManageror overrideCreateMonitoredItems, add thecreateDurableparameter and pass it to theMonitoredItemconstructor. When you check queue length for a durable subscription, compare it with the durable queue limit inServerConfiguration. - If you implement a custom
IMonitoredItem, add thecreateDurableconstructor parameter, implementIsDurable, and implementDispose. - In a custom
MonitoredItem, useIServerInternal.MonitoredItemQueueFactoryto get the registered durable queues for events and value changes instead of using internal queues. - To test custom queues, adapt the monitored-item tests in the server test
project. Provide your
IMonitoredItemQueueFactoryin the test constructor.
Configure durable subscriptions in ServerConfiguration:
- Set
DurableSubscriptionsEnabledto true - Set
MaxDurableNotificationQueueSizeto the desired value - Set
MaxDurableEventQueueSizeto the desired value - Set
MaxDurableSubscriptionLifetimeto the desired value
Known limitations and issues
- The Quickstarts queues return
falsefromDequeuewhile a batch is being persisted or cannot be restored within the bounded wait. The queue retains the item count for a later attempt. A failed restore does not mean the batch data is resident. The store deletes restored batch files after their readers close. - The server persists subscriptions only during a graceful shutdown. A crash or forced shutdown loses all subscriptions and monitored items.
- The Quickstarts durable-subscription store writes format version 3. It can
read version 1 records, which enable publishing but do not persist the
owning application URI. The store rejects retired version 2 records.
Current records persist publishing state and the owning client
ApplicationUri, allowing anonymous durable subscriptions to transfer after restart. The store removes user-name passwords before persistence. It does not persist issued-token subscriptions because their bearer token is their identity. - Breaking change: The
INodeManagerandIMonitoredIteminterfaces were extended to support durable subscriptions.