mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-29 07:07:24 +08:00
# Description Remove stock phrasing and correct misleading or inconsistent technical documentation. The initial two passes covered 367 Markdown files, followed by an interactive review of 169 editorial flags. The U5 interpretation originally deferred in that review has since received the upstream Mantis answer recorded by #4843; remaining server/spec follow-ups stay explicit in the CTT log. - Correct package responsibilities, migration steps, API names, ownership, protocol descriptions and links. Keep bundled migration guides synchronized. Preserve historical conclusions as historical records with separate re-check notes. - Provide at least two rendered TOC levels throughout `docs/`. Convert appropriate architecture figures to Mermaid without changing code examples, transcripts or historical quotations. - Address the October 19 feedback with concrete setup/migration instructions, corrected certificate paths and PubSub names, shorter repeated caveats, consistent XML comments, and a full review of the Concepts guide. Retain #4839's API corrections. - Integrate #4841's runtime/performance guidance and review incoming/recent prose. Preserve dated measurements rather than claiming new benchmark runs; clarify allocation ratios, startup-only processor settings, JIT warm-up and the benchmark commit's scope. Missing raw measurement artifacts and repeat ranges remain tracked by #4842. - Merge master through `e8c5d800a` in `32c6394b7`. Resolve the CTT log conflict using the updated Mantis states and OPC answers, retaining historical framing and re-checks for C28/C32/C43. - Address the latest naming/index feedback in `adb5bf693`: rename the guides to `docs/WotCon.md` and `docs/WotNodeSetConversion.md`; move the provider and DataType-declaration contracts into the conversion guide and remove `docs/WoT.md`. Rename `samples/DI` to `samples/Di` and `samples/Isa95` to `samples/ISA95`. Add content-index READMEs to Di, FluentApi, ISA95, Lds and PubSub; update solution entries, project references, Docker/CI paths, test fixture paths and documentation links with exact casing. **WoT guide scope.** This branch retains the detailed conversion guide that #4758 had replaced with an anchor stub. Conversion limits, verified document sets, preservation rules and provider ownership now live together in `WotNodeSetConversion.md`; binding/runtime guidance remains in `WotBindings.md` and `WotCon.md`. The design-rationale/test-ledger prose was shortened, the oversized argument-table cell moved into its section, and existing anchors preserved. **SDK policy is a separate, explicit user-directed change.** `global.json` sets a stable minimum of `10.0.400`, `rollForward: latestMajor`, and `allowPrerelease: false`. Newer major SDKs are permitted; CI's explicit SDK pins are unchanged. README, GettingStarted, DeveloperGuide and Recycling instructions reflect the possible analyzer differences. The image-contract regression fix accepts compatible stable SDK images instead of requiring exact equality with the floor. The latest four rename/index threads are resolved after publication. Three older threads remain open: universal obsolete-removal timing, unconditional nonce-strength wording, and a blanket Vision NativeAOT claim. Existing implementation/evidence constraints are explained in their inline replies. The two-level TOCs remain as requested. ## Validation - `git diff --check` and staged diff checks: passed. The untouched upstream AutoID NodeSet retains its provenance bytes, including two existing license-header trailing spaces. - `.\.azurepipelines\validate-migration-plugin.ps1`: passed; 15 bundled migration documents and manifests synchronized. - Documentation/path validation: **101** documents retain two rendered TOC levels (**2,228** entries), with idempotent formatting. **52** new relative links and their anchors passed exact-case checks. No tracked references to the old guide/sample paths remain. Both relocated provider-contract sections are preserved in the destination. - `dotnet sln UA.slnx list`: passed; shows the renamed Di/ISA95 projects and the existing FluentApi/Lds/PubSub projects. Updated solution and pump ProjectReference paths also passed exact-case existence checks. - Latest focused commands, run from the repository root: ```powershell # Passed: 61 channel send-order and reconnect tests. dotnet test tests\Opc.Ua.Core.Tests\Opc.Ua.Core.Tests.csproj -p:CustomTestTarget=net10.0 --filter 'FullyQualifiedName~UaSCBinaryChannelSendOrderTests|FullyQualifiedName~TcpReconnectKeyAgreementTests' --verbosity minimal # Passed: 5 pump datasheet tests; builds the renamed pump sample. dotnet test tests\Opc.Ua.Di.Tests\Opc.Ua.Di.Tests.csproj -p:CustomTestTarget=net10.0 --filter 'FullyQualifiedName~PumpDatasheetConformanceTests' --verbosity minimal # Passed: 4 repository NodeSet path/round-trip tests, including the moved pump models. dotnet test tests\Opc.Ua.Types.Tests\Opc.Ua.Types.Tests.csproj -p:CustomTestTarget=net10.0 --filter 'FullyQualifiedName~RepositorySourceSurvivesSerializedLinkedPartitionsAsync' --verbosity minimal # Passed: build, zero warnings/errors. dotnet build samples\ISA95\MinimalIsa95Server\MinimalIsa95Server.csproj -p:CustomTestTarget=net10.0 -f net10.0 --verbosity minimal # Passed: dependent sample-test project build, zero warnings/errors. dotnet build tests\Opc.Ua.WotCon.Samples.Tests\Opc.Ua.WotCon.Samples.Tests.csproj -p:CustomTestTarget=net10.0 -f net10.0 --verbosity minimal ``` Earlier focused integration checks passed 2,620 tests across AutoID, event queues/scheduling, source generation, MCP/package profiles and WoT. Both reviewed Mermaid diagrams rendered locally without network access. These checks are not a full solution run. The full solution has **not** been rerun for this review. Earlier `dotnet test UA.slnx -p:CustomTestTarget=net10.0 --verbosity quiet` did not pass: three AOT projects rejected VSTest and 20 Vision tests failed during graphics initialization with `OutOfMemoryException`. Remaining long-running tests were stopped at the user's request. A focused Vision rerun passed 558 tests and reproduced those 20 failures. The earlier `dotnet test UA.slnx -p:CustomTestTarget=net48 --verbosity quiet` was blocked by the former SDK pin and was not retried after the policy change. The user approved proceeding with those limitations documented; current remote CI is not claimed green. ## Related Issues - Follow-up #4842 tracks the requested 2.0.2+ benchmark/tuning and diagnostic-tool documentation refresh. #4841 supplies documentation and earlier results, not all newly requested measurements. - #4758 explains the conversion guide's earlier consolidation; the current provider contracts are now consolidated into `WotNodeSetConversion.md`. - #4839 supplies the reviewed API corrections; #4843 supplies the updated CTT issue record. - The original prose cleanup and SDK policy were user-requested without a source issue. No new runtime architecture is introduced by these documentation edits. ## Checklist _Put an `x` in the boxes that apply. You can complete these step by step after opening the PR._ - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [ ] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. --------- Co-authored-by: Roman Ettlinger <romanett98@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
233 lines
9.6 KiB
C#
233 lines
9.6 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
namespace Pumps
|
|
{
|
|
/// <summary>
|
|
/// The published characteristics of the simulated SimPump Corp
|
|
/// PumpX-2000, exactly as documented in
|
|
/// <see href="https://github.com/OPCFoundation/UA-.NETStandard/blob/master/samples/Di/PumpDeviceIntegrationServer/DATASHEET.md">DATASHEET.md</see>.
|
|
/// Every value the server publishes - nameplate, engineering ranges,
|
|
/// alarm trip points and simulated process values - is derived from
|
|
/// these constants, so the datasheet and the running address space
|
|
/// cannot drift apart.
|
|
/// </summary>
|
|
internal static class PumpDatasheet
|
|
{
|
|
/// <summary>
|
|
/// Nameplate data shared by every unit of the product.
|
|
/// </summary>
|
|
public static class Nameplate
|
|
{
|
|
public const string Manufacturer = "SimPump Corp";
|
|
public const string ManufacturerUri = "https://simpump.example";
|
|
public const string Model = "PumpX-2000";
|
|
public const string ProductCode = "PX2000-32-160";
|
|
public const string DeviceClass = "Pump";
|
|
public const string HardwareRevision = "1.4";
|
|
public const string SoftwareRevision = "2.5.3";
|
|
public const string ArticleNumber = "PX2000-32-160-CI";
|
|
public const string OrderProductCode = "PX2000-32-160-CI-M30";
|
|
public const string TypeOfProduct = "Centrifugal pump, end-suction";
|
|
public const string Supplier = "SimPump Corp";
|
|
public const string CountryOfOrigin = "DE";
|
|
public const string ProductInstanceUriPrefix =
|
|
"urn:simdevice:SimPump:PumpX-2000:";
|
|
public const ushort YearOfConstruction = 2025;
|
|
public const byte MonthOfConstruction = 4;
|
|
public const int DayOfConstruction = 17;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Hydraulic design point and characteristic curves (section 3 of
|
|
/// the datasheet). Reference liquid is water at 20 °C.
|
|
/// </summary>
|
|
public static class Hydraulics
|
|
{
|
|
/// <summary>
|
|
/// Density of the reference liquid in kg/m³.
|
|
/// </summary>
|
|
public const double FluidDensity = 998.0;
|
|
|
|
/// <summary>
|
|
/// Gravitational acceleration in m/s².
|
|
/// </summary>
|
|
public const double GravitationalAcceleration = 9.81;
|
|
|
|
/// <summary>
|
|
/// Flow at the best efficiency point in m³/h.
|
|
/// </summary>
|
|
public const double RatedFlow = 25.0;
|
|
|
|
/// <summary>
|
|
/// Shut-off head in m, the constant term of the head curve.
|
|
/// </summary>
|
|
public const double ShutoffHead = 32.0;
|
|
|
|
/// <summary>
|
|
/// Quadratic term of the head curve in m/(m³/h)².
|
|
/// </summary>
|
|
public const double HeadCurveCoefficient = 0.0104;
|
|
|
|
/// <summary>
|
|
/// Efficiency at the best efficiency point in percent.
|
|
/// </summary>
|
|
public const double RatedEfficiency = 72.0;
|
|
|
|
/// <summary>
|
|
/// Curvature of the efficiency parabola about the best
|
|
/// efficiency point.
|
|
/// </summary>
|
|
public const double EfficiencyCurveFactor = 0.6;
|
|
|
|
/// <summary>
|
|
/// Head at the best efficiency point in m.
|
|
/// </summary>
|
|
public const double RatedHead =
|
|
ShutoffHead - (HeadCurveCoefficient * RatedFlow * RatedFlow);
|
|
|
|
/// <summary>
|
|
/// Mass flow at the best efficiency point in kg/s.
|
|
/// </summary>
|
|
public const double RatedMassFlow = FluidDensity * RatedFlow / 3600.0;
|
|
|
|
/// <summary>
|
|
/// Rated speed of the pump set in min<sup>-1</sup>. The simulated
|
|
/// shaft turns in proportion to how close the pump runs to its
|
|
/// rated mass flow.
|
|
/// </summary>
|
|
public const double RatedSpeed = 2900.0;
|
|
|
|
/// <summary>
|
|
/// Shaft power at the best efficiency point in W.
|
|
/// </summary>
|
|
public const double RatedShaftPower =
|
|
FluidDensity * GravitationalAcceleration * (RatedFlow / 3600.0) *
|
|
RatedHead / (RatedEfficiency / 100.0);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Engineering ranges published as the <c>EURange</c> property of
|
|
/// each measurement (section 4 of the datasheet).
|
|
/// </summary>
|
|
public static class Ranges
|
|
{
|
|
public const double DifferentialPressureMin = 0.0;
|
|
public const double DifferentialPressureMax = 400_000.0;
|
|
public const double FluidTemperatureMin = 263.15;
|
|
public const double FluidTemperatureMax = 393.15;
|
|
public const double BearingTemperatureMin = 273.15;
|
|
public const double BearingTemperatureMax = 423.15;
|
|
public const double PumpPowerInputMin = 0.0;
|
|
public const double PumpPowerInputMax = 4_000.0;
|
|
public const double MassFlowMin = 0.0;
|
|
public const double MassFlowMax = 10.0;
|
|
public const double PumpEfficiencyMin = 0.0;
|
|
public const double PumpEfficiencyMax = 100.0;
|
|
public const double LevelMin = 0.0;
|
|
public const double LevelMax = 5.0;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Bearing-temperature trip points and supervision thresholds
|
|
/// (section 7 of the datasheet), in K and m.
|
|
/// </summary>
|
|
public static class TripPoints
|
|
{
|
|
public const double BearingTemperatureHighHigh = 373.15;
|
|
public const double BearingTemperatureHigh = 363.15;
|
|
public const double BearingTemperatureLow = 283.15;
|
|
public const double BearingTemperatureLowLow = 278.15;
|
|
public const double MotorOverheatSet = 363.15;
|
|
public const double MotorOverheatClear = 361.15;
|
|
public const double CavitationSetLevel = 2.10;
|
|
public const double CavitationClearLevel = 2.20;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Deterministic simulation profile (section 8 of the datasheet).
|
|
/// Angular rates are expressed in radians per 250 ms tick.
|
|
/// </summary>
|
|
public static class Simulation
|
|
{
|
|
/// <summary>
|
|
/// Relative amplitude of the flow modulation about the rated
|
|
/// flow.
|
|
/// </summary>
|
|
public const double FlowModulation = 0.30;
|
|
|
|
public const double FlowRate = 0.03;
|
|
public const double FluidTemperatureNominal = 313.15;
|
|
public const double FluidTemperatureAmplitude = 5.0;
|
|
public const double FluidTemperatureRate = 0.01;
|
|
public const double LevelNominal = 2.5;
|
|
public const double LevelAmplitude = 0.5;
|
|
public const double LevelRate = 0.02;
|
|
|
|
/// <summary>
|
|
/// Bearing temperature in K at zero load.
|
|
/// </summary>
|
|
public const double BearingTemperatureBase = 323.15;
|
|
|
|
/// <summary>
|
|
/// Bearing temperature rise in K at the rated shaft power.
|
|
/// </summary>
|
|
public const double BearingTemperatureLoadRise = 10.0;
|
|
|
|
/// <summary>
|
|
/// Length of the bearing-cooling fault cycle in ticks.
|
|
/// </summary>
|
|
public const long CoolingFaultPeriodTicks = 64;
|
|
|
|
/// <summary>
|
|
/// Tick within the cycle at which the cooling water is
|
|
/// interrupted.
|
|
/// </summary>
|
|
public const long CoolingFaultOnsetTick = 56;
|
|
|
|
/// <summary>
|
|
/// Maximum bearing temperature rise in K caused by the
|
|
/// cooling fault.
|
|
/// </summary>
|
|
public const double CoolingFaultRise = 50.0;
|
|
|
|
/// <summary>
|
|
/// Number of ticks between two simulated pump starts.
|
|
/// </summary>
|
|
public const long StartIntervalTicks = 3_600;
|
|
|
|
/// <summary>
|
|
/// Phase offset in ticks applied per simulated pump so the
|
|
/// units do not move in lockstep.
|
|
/// </summary>
|
|
public const long PhaseOffsetTicks = 17;
|
|
}
|
|
}
|
|
}
|