mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-29 15:11:53 +08:00
# Description Introduces a central `IClientChannelManager` that owns client-side transport channels with reference counting, sharing, coalesced reconnect, and asynchronous participant notification. Sessions, discovery clients, and registration clients targeting the same `ConfiguredEndpoint` (with the same reverse-connect identity) now share a single underlying `ITransportChannel`; reconnect is transparent to callers; and the previous `AttachChannel`/`DetachChannel` + `SessionReconnectHandler` patterns are obsoleted. ## What lands ### Core types (`Stack/Opc.Ua.Core/Stack/Client/`) - `ManagedChannelKey`, `ChannelState`, `ChannelStateChange`, `ParticipantReconnectResult` - `IReconnectParticipant`, `IManagedTransportChannel`, `IClientChannelManager` - `IChannelReconnectPolicy` + `ExponentialBackoffChannelReconnectPolicy` (default mirrors historical `SessionReconnectHandler`: 500 ms → 30 s exponential) - `IRetryBudget` + `RetryBudget` — shared retry deadline so the two-level retry no longer compounds multiplicatively - `ClientChannelManager` — single non-partial sealed class with SOLID-extracted internal types under `Stack/Opc.Ua.Core/Stack/Client/Channels/Internal/`: `ChannelEntry` (behind `IChannelEntryHost`), `ManagedTransportChannelLease`, `ClientChannel`, `ClientChannelManagerMetrics` (IMeter), `ClientChannelManagerCertRotation` (auto `ReconnectAllAsync` on `CertificateManager` rotation), `ClientChannelManagerDiagnostics` (ActivitySource + EventSource). Refcount, coalesced reconnect, and transparent faulted-entry recovery via `SwapFaultedEntryAsync` (swaps a lease's underlying entry on subsequent `ReconnectAsync` when the prior cycle Faulted/Closed, preserves participant, back-off via policy `GetDelay(SwapCount)`) ### Three-state lifecycle gate `Disconnected` → `TransportConnecting` / `TransportReconnecting` → `TransportConnectedSessionReactivating` → `Ready` (or `Faulted` / `Closed`). Only `Ready` releases the service-call gate; the manager bypasses the gate internally for participant `ActivateSession` traffic during reactivation via an `AsyncLocal` scope. ### Session integration (`Libraries/Opc.Ua.Client/Session/`) - New `Session.CreateAsync(IClientChannelManager, …)` overload - `Session` implements `IReconnectParticipant`; reactivation handler distinguishes `Reactivated` / `RequiresSessionRecreate` / `TransientFailure` / `FatalForParticipant` / `FatalForChannel` - `Session.ReconnectAsync(ct)` automatically delegates to the channel manager when wired - `Session.RecreateInPlaceAsync` swaps managed-channel leases for failover-to-different-endpoint via a new atomic `IClientChannelManager.GetAsync(endpoint, participantFactory, …)` overload; same-key recreates delegate to manager reconnect; explicit-channel/connection callers retain legacy behavior - KA failure routes through `IClientChannelManager.ReconnectAsync(channel)` ### ManagedSession integration - `WithChannelManager(...)` builder + ctor param; DI-resolved automatically - Two-level retry: channel-mgr handles transparent reconnect; outer `ConnectionStateMachine` + `IReconnectPolicy` only triggers on terminal channel `Faulted`. Outer-state churn suppressed during channel-mgr cycles via `_channelReconnectInProgress` flag wired through `IManagedTransportChannel.StateChanged` - New `ManagedSession.ChannelStateChanged` event surfaces transparent reconnects - `ConnectionStateChangedEventArgs.UnderlyingChannelState` populated when outer reconnect was triggered by a channel fault - Shared `IRetryBudget` propagated so the layers enforce a single max-total-time ### Discovery / Registration / GDS Channel-manager-aware `CreateAsync` overloads on `DiscoveryClient`, `RegistrationClient`, `ServerPushConfigurationClient`, `LocalDiscoveryServerClient`, `GlobalDiscoveryServerClient`. Each registers a minimal `IReconnectParticipant`; co-located sessions and discovery probes targeting the same endpoint share a channel. ### HTTPS transport (`Stack/Opc.Ua.Bindings.Https/`) - New `IOpcUaHttpClientFactory` abstraction - HTTPS / OPC-HTTPS channels migrated to `IHttpClientFactory` + `Microsoft.Extensions.Http.Resilience` (10.6.0; AOT-compatible on net10 via source generators; legacy direct-HTTP path retained for older TFMs / no-DI consumers) ### DI `AddOpcUa().AddClient(...)` registers `IClientChannelManager` and the named HTTPS `HttpClient` + standard resilience handler automatically. `ManagedSessionBuilder` resolves the manager from DI when present. ### Obsoletions (functional, `[Obsolete]` with guidance) - `IClientBase.AttachChannel` / `DetachChannel` - `SessionReconnectHandler` - `SessionExtensions.ReconnectAsync(connection, ct)` and `(channel, ct)` legacy overloads ### Tests - Core: `ClientChannelManagerManagedTests`, `ClientChannelManagerCertRotationTests`, `RetryBudgetTests`, `OpcUaHttpClientFactoryTests` — **56 / 56 pass** - Client: `ManagedSession*Tests` updated; legacy `SessionReconnectHandlerTests` + `SessionExtensionsTests` preserved with `#pragma warning disable CS0618` — **129 / 129 pass** - Sessions integration: `ChannelManagerSharing` / `TransparentReconnect` / `SessionLifecycle` / `CertRotation` — **7 pass, 1 skipped** (`ChannelManagerExhaustionEscalatesAndRecoversWhenServerReturns` un-`[Ignore]`d and implemented in this PR via `SwapFaultedEntryAsync`; remaining skip is end-to-end `RequiresSessionRecreate` plumbing — carry-forward) - Stress (consolidated `Tests/Opc.Ua.Stress.Tests/Subscriptions/` + `Channels/`): chaos / contract / soak / lifecycle / leak-accuracy / gap / participant-result-aggregation tests merged from the previously-separate `Opc.Ua.Channels.Stress.Tests` project; nightly run via `.github/workflows/stress-test.yml` Builds clean (0 warnings / 0 errors) across all six TFMs: `net472`, `net48`, `netstandard2.1`, `net8.0`, `net9.0`, `net10.0`. ### Docs - `Docs/Sessions.md` new § 4 documents the channel manager, three-state gating, two-level retry with shared `IRetryBudget`, HTTPS resilience layering - `Docs/MigrationGuide.md` migration recipes for the four obsoleted API groups - `Docs/DependencyInjection.md` channel-manager and HTTPS factory registration ## Carry-forward (separate PRs) - End-to-end `ParticipantReconnectResult.RequiresSessionRecreate` → `Session.RecreateAsync` lifecycle wiring (currently incomplete — flagged in the 1 remaining skipped integration test) ## Related Issues - Fixes #3288 - Builds on #3282 (PR that introduced the initial `ITransportChannelManager` skeleton) ## Checklist - [x] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [x] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. *(Channel-manager-specific tests + ManagedSession/client tests verified across all 6 TFMs; full UA.slnx run is pending CI.)* - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received.
121 lines
8.5 KiB
XML
121 lines
8.5 KiB
XML
<Project>
|
|
<PropertyGroup>
|
|
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
|
|
<!-- Pin transitive package versions so PackageVersion entries below force the
|
|
resolved version everywhere they appear in the dependency graph, even when
|
|
no project declares a direct PackageReference. Used to remediate transitive
|
|
NU1903 vulnerabilities (System.Net.Http 4.3.0, System.Text.RegularExpressions
|
|
4.3.0) pulled in by Microsoft.AspNetCore.* 2.3.x on net8.0/net9.0/netstandard2.1. -->
|
|
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
|
|
</PropertyGroup>
|
|
<ItemGroup>
|
|
<PackageVersion Include="BenchmarkDotNet" Version="0.15.8" />
|
|
<PackageVersion Include="BitFaster.Caching" Version="2.6.0" />
|
|
<PackageVersion Include="BouncyCastle.Cryptography" Version="2.6.2" />
|
|
<PackageVersion Include="coverlet.collector" Version="10.0.1" />
|
|
<PackageVersion Include="DotNext" Version="5.26.3" />
|
|
<PackageVersion Include="EmbedIO" Version="3.5.2" />
|
|
<PackageVersion Include="Makaretu.Dns.Multicast" Version="0.27.0" />
|
|
<PackageVersion Include="Microsoft.AspNetCore.Http" Version="2.3.10" />
|
|
<PackageVersion Include="Microsoft.AspNetCore.Server.Kestrel" Version="2.3.10" />
|
|
<PackageVersion Include="Microsoft.AspNetCore.Server.Kestrel.Core" Version="2.3.10" />
|
|
<PackageVersion Include="Microsoft.AspNetCore.Server.Kestrel.Https" Version="2.3.10" />
|
|
<PackageVersion Include="Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets" Version="2.3.10" />
|
|
<PackageVersion Include="Microsoft.Bcl.HashCode" Version="6.0.0" />
|
|
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="10.0.8" />
|
|
<PackageVersion Include="Microsoft.Bcl.TimeProvider" Version="10.0.8" />
|
|
<PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="4.14.0" />
|
|
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="4.14.0" />
|
|
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.14.0" />
|
|
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.14.0" />
|
|
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.14.0" />
|
|
<PackageVersion Include="Microsoft.Extensions.Configuration" Version="10.0.8" />
|
|
<PackageVersion Include="Microsoft.Extensions.Configuration.Abstractions" Version="10.0.8" />
|
|
<PackageVersion Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="10.0.8" />
|
|
<PackageVersion Include="Microsoft.Extensions.Logging" Version="10.0.8" />
|
|
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.8" />
|
|
<PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="10.0.8" />
|
|
<PackageVersion Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="10.0.8" />
|
|
<PackageVersion Include="Microsoft.Extensions.Diagnostics" Version="10.0.8" />
|
|
<PackageVersion Include="Microsoft.Extensions.Http" Version="10.0.8" />
|
|
<PackageVersion Include="Microsoft.Extensions.Http.Resilience" Version="10.6.0" />
|
|
<PackageVersion Include="Microsoft.Extensions.Hosting" Version="10.0.8" />
|
|
<PackageVersion Include="Microsoft.Extensions.Hosting.Abstractions" Version="10.0.8" />
|
|
<PackageVersion Include="Microsoft.Extensions.Options" Version="10.0.8" />
|
|
<PackageVersion Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="10.0.8" />
|
|
<PackageVersion Include="Microsoft.Extensions.TimeProvider.Testing" Version="10.6.0" />
|
|
<PackageVersion Include="Microsoft.IO.RecyclableMemoryStream" Version="3.0.1" />
|
|
<PackageVersion Include="ModelContextProtocol" Version="1.4.0" />
|
|
<PackageVersion Include="ModelContextProtocol.AspNetCore" Version="1.4.0" />
|
|
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.6.0" />
|
|
<PackageVersion Include="Microsoft.SourceLink.AzureRepos.Git" Version="10.0.102" />
|
|
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="10.0.102" />
|
|
<PackageVersion Include="System.CommandLine" Version="2.0.8" />
|
|
<PackageVersion Include="Microsoft.VisualStudio.DiagnosticsHub.BenchmarkDotNetDiagnosers" Version="18.7.37220.1" />
|
|
<PackageVersion Include="Moq" Version="4.20.72" />
|
|
<PackageVersion Include="TUnit" Version="1.51.0" />
|
|
<PackageVersion Include="Nerdbank.GitVersioning" Version="3.9.50" />
|
|
<PackageVersion Include="Newtonsoft.Json" Version="13.0.4" />
|
|
<!--
|
|
PacketDotNet and SharpPcap are native-code dependencies of
|
|
Opc.Ua.Bindings.Pcap. They dynamically load libpcap on
|
|
Linux/macOS and Npcap on Windows. Per SDL native-code policy:
|
|
- Versions are pinned (no floating range)
|
|
- SBOM tracking is required for every release
|
|
- Subscribe to upstream CVE feeds:
|
|
* https://github.com/dotpcap/sharppcap/security/advisories
|
|
* https://github.com/dotpcap/packetnet/security/advisories
|
|
- Review monthly; bump within 30 days for HIGH/CRITICAL CVEs
|
|
-->
|
|
<PackageVersion Include="PacketDotNet" Version="1.4.8" />
|
|
<PackageVersion Include="SharpPcap" Version="6.3.1" />
|
|
<PackageVersion Include="NUnit" Version="4.6.1" />
|
|
<PackageVersion Include="NUnit.Analyzers" Version="4.14.0" />
|
|
<PackageVersion Include="NUnit.Console" Version="3.22.0" />
|
|
<PackageVersion Include="NUnit3TestAdapter" Version="6.2.0" />
|
|
<PackageVersion Include="ObjectLayoutInspector" Version="0.2.0" />
|
|
<PackageVersion Include="PolySharp" Version="1.16.0" />
|
|
<PackageVersion Include="Roslynator.Analyzers" Version="4.15.0" />
|
|
<PackageVersion Include="Roslynator.Formatting.Analyzers" Version="4.15.0" />
|
|
<PackageVersion Include="SharpFuzz" Version="2.2.0" />
|
|
<PackageVersion Include="Serilog" Version="4.3.1" />
|
|
<PackageVersion Include="Serilog.Expressions" Version="5.0.0" />
|
|
<PackageVersion Include="Serilog.Extensions.Logging" Version="10.0.0" />
|
|
<PackageVersion Include="Serilog.Sinks.Console" Version="6.1.1" />
|
|
<PackageVersion Include="Serilog.Sinks.Debug" Version="3.0.0" />
|
|
<PackageVersion Include="Serilog.Sinks.File" Version="7.0.0" />
|
|
<PackageVersion Include="SourceGenerator.Foundations" Version="2.0.14" />
|
|
<PackageVersion Include="System.Buffers" Version="4.6.1" />
|
|
<PackageVersion Include="System.Composition.AttributedModel" Version="10.0.8" />
|
|
<PackageVersion Include="System.Runtime.CompilerServices.Unsafe" Version="6.1.2" />
|
|
<PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="10.0.8" />
|
|
<PackageVersion Include="System.Memory" Version="4.6.3" />
|
|
<PackageVersion Include="System.Formats.Asn1" Version="10.0.8" />
|
|
<PackageVersion Include="System.IO.Compression" Version="4.3.0" />
|
|
<PackageVersion Include="System.Net.NetworkInformation" Version="4.3.0" />
|
|
<!-- Transitive vulnerability pins (consumed via Microsoft.AspNetCore.* 2.3.x on
|
|
net8.0/net9.0/netstandard2.1 - default transitives are 4.3.0 with NU1903):
|
|
- System.Net.Http 4.3.4 fixes GHSA-7jgj-8wvc-jh57
|
|
- System.Text.RegularExpressions 4.3.1 fixes GHSA-cmhx-cq75-c4mj -->
|
|
<PackageVersion Include="System.Net.Http" Version="4.3.4" />
|
|
<PackageVersion Include="System.Text.RegularExpressions" Version="4.3.1" />
|
|
<PackageVersion Include="System.Collections.Immutable" Version="10.0.8" />
|
|
<PackageVersion Include="System.Reflection.Metadata" Version="10.0.6" />
|
|
<PackageVersion Include="System.Text.Json" Version="10.0.8" />
|
|
<PackageVersion Include="System.Private.Uri" Version="4.3.2" />
|
|
<PackageVersion Include="System.Runtime.InteropServices.RuntimeInformation" Version="4.3.0" />
|
|
<PackageVersion Include="System.Security.Cryptography.Cng" Version="5.0.0" />
|
|
<PackageVersion Include="System.Threading.Channels" Version="10.0.8" />
|
|
<PackageVersion Include="System.Threading.Tasks.Extensions" Version="4.6.3" />
|
|
</ItemGroup>
|
|
<!-- MQTTnet 5.x dropped net48/net472/netstandard2.1 support. Per-TFM pinning is
|
|
required because CentralPackageTransitivePinningEnabled lets the central pin
|
|
win over PubSub's VersionOverride for transitive consumers (e.g. samples
|
|
that ProjectReference Opc.Ua.PubSub). See Libraries/Opc.Ua.PubSub.csproj. -->
|
|
<ItemGroup Condition="'$(TargetFramework)' == 'net472' OR '$(TargetFramework)' == 'net48' OR '$(TargetFramework)' == 'netstandard2.1'">
|
|
<PackageVersion Include="MQTTnet" Version="4.3.7.1207" />
|
|
</ItemGroup>
|
|
<ItemGroup Condition="'$(TargetFramework)' != 'net472' AND '$(TargetFramework)' != 'net48' AND '$(TargetFramework)' != 'netstandard2.1'">
|
|
<PackageVersion Include="MQTTnet" Version="5.1.0.1559" />
|
|
</ItemGroup>
|
|
</Project> |