Files
Marc Schier 49305d9085 V2 subscription engine close gap for test and feature parity with classic engine (#3824)
# Description

V2 subscription engine feature parity round to make the classic engine
eligible for deprecation. Splits the test surface so the classic and V2
engines can evolve independently, ports the gaps the classic-engine
integration tests had been exercising, and lands the public V2 API
additions needed to close them.

- Splits `Tests/Opc.Ua.Subscriptions.Tests` into a classic
(`Opc.Ua.Subscriptions.Classic.Tests`) and a V2
(`Opc.Ua.Subscriptions.Tests`) project to shrink CI time and let the two
engines diverge cleanly.
- Adds the V2 public-surface gaps required by the test ports
(`Subscription.ServerId` on the class, `SetSubscriptionDurableAsync`,
`SendInitialValuesOnTransfer`, unified `OnSubscriptionStateChangedAsync`
handler callback, per-item `ConditionRefreshAsync`, fluent
`LoadSubscriptionsAsync(Stream, …)` and `Subscription.Snapshot()` /
`RestoreAsync()` for save/load + transfer).
- Lands handler-centric design (no `PublishingStopped` property handlers
maintain derived state); always-sequential per-subscription delivery
documented + tested.
- **Adds short and long haul stability tests for the V2 `ManagedSession`
+ subscription engine. Closes #3744** (see "Issue #3744 Haul tests"
below).
- **Migrates SubscriptionStateSnapshot / MonitoredItemStateSnapshot to
`[DataType]` source-generator codecs**.
- `SubscriptionDurableV2Tests.cs` 5 V2 ports of the classic durable test
patterns.
- `V2FollowUpCoverageTests.cs` handler state-change callback, fluent
stream-based `LoadSubscriptionsAsync`, `SendInitialValuesOnTransfer`,
snapshot edge cases (empty / `DataChangeFilter` round-trip / concurrent
  mutation).
- `SubscriptionFailoverV2Tests.cs` forced channel-break with and without
`WithTransferSubscriptionsOnRecreate`.
- `MonitoredItemConditionRefreshLiveV2Tests.cs` ΓÇö live
`ConditionRefresh` against the reference server's event source; asserts
`RefreshStart` / `RefreshEnd` events flow through the handler.

## Fixes

- #3744 Haul tests (V2 ManagedSession + subscription engine)
`Tests/Opc.Ua.Sessions.Tests/ManagedSessionStabilityTest.cs` adds the
short/long haul coverage requested by
[#3744](https://github.com/OPCFoundation/UA-.NETStandard/issues/3744)
plus the bonus fault-injection variant:

| Test | Duration | Category | Purpose |
|---|---|---|---|
| `ShortHaulManagedSessionV2Async` | 2 minutes | `ManagedSessionHaul`
(`[Explicit]`) | Quick local sanity check of the V2 monotonicity
contract. |
| `LongHaulManagedSessionV2Async` | 90 minutes (configurable via
`TEST_DURATION_MINUTES`) | `ManagedSessionHaul` (`[Explicit]`) |
Long-running V2 stability + monotonicity. |
| `LongHaulManagedSessionWithFaultInjectionV2Async` | 90 minutes
(configurable) + fault every `FAULT_INJECTION_INTERVAL_SECONDS` (default
60s) | `ManagedSessionHaul` (`[Explicit]`) | **Bonus** ΓÇö force-closes
the subscriber transport channel periodically; verifies V2 manager
transfers/recreates the subscription and continues monotonic delivery
across reconnects. |

**Pattern.** A writer `ManagedSession` increments a `uint32` counter and
writes it into `Scalar_Static_Mass_UInt32_UInt32_00` every 250ms. A
subscriber `ManagedSession` runs a V2 subscription with a single
monitored item on the same node. `MonotonicCounterHandler` asserts each
received sample is *strictly greater than* the previous one. V2
`ISubscriptionNotificationHandler` per-subscription ordering guarantee.
Skipped values (sampling rate < write rate) are tolerated; duplicates
and reorderings are violations.
2026-06-03 04:39:08 +02:00

265 lines
8.8 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Extensions.Logging;
using Opc.Ua.Client.Subscriptions;
using Opc.Ua.Client.Subscriptions.MonitoredItems;
using Opc.Ua.Client.Subscriptions.Streaming;
using MonitoringOptions = Opc.Ua.Client.Subscriptions.MonitoredItems.MonitoredItemOptions;
namespace Opc.Ua.Client.ModelChange
{
/// <summary>
/// Default <see cref="IModelChangeTracker"/> backed by a
/// streaming subscription on the Server object's
/// <c>GeneralModelChangeEventType</c> notifier.
/// </summary>
public sealed class ModelChangeTracker : IModelChangeTracker
{
private readonly IStreamingSubscription m_streaming;
private readonly INodeCache? m_nodeCache;
private readonly ILogger m_logger;
private CancellationTokenSource? m_cts;
private Task? m_pumpTask;
private bool m_disposed;
/// <inheritdoc/>
public event EventHandler<ModelChangedEventArgs>? ModelChanged;
/// <inheritdoc/>
public bool IsTracking { get; private set; }
/// <summary>
/// Initializes a new model change tracker.
/// </summary>
public ModelChangeTracker(
IStreamingSubscription streaming,
INodeCache? nodeCache = null,
ILogger? logger = null)
{
m_streaming = streaming ?? throw new ArgumentNullException(nameof(streaming));
m_nodeCache = nodeCache;
m_logger = logger ?? Microsoft.Extensions.Logging.Abstractions.NullLogger.Instance;
}
/// <inheritdoc/>
public ValueTask StartTrackingAsync(CancellationToken ct = default)
{
if (IsTracking)
{
return default;
}
m_cts = CancellationTokenSource.CreateLinkedTokenSource(ct);
// Capture the token before launching the pump task so a racing
// StopTrackingAsync (which nulls m_cts) cannot NRE the lambda.
CancellationToken pumpToken = m_cts.Token;
m_pumpTask = Task.Run(() => PumpAsync(pumpToken), pumpToken);
IsTracking = true;
return default;
}
/// <inheritdoc/>
public async ValueTask StopTrackingAsync(CancellationToken ct = default)
{
if (!IsTracking)
{
return;
}
IsTracking = false;
CancellationTokenSource? cts = m_cts;
m_cts = null;
if (cts != null)
{
try
{
cts.Cancel();
}
catch (ObjectDisposedException)
{
// already disposed
}
}
if (m_pumpTask != null)
{
try
{
await m_pumpTask.ConfigureAwait(false);
}
catch (OperationCanceledException)
{
// expected
}
m_pumpTask = null;
}
cts?.Dispose();
}
/// <inheritdoc/>
public async ValueTask DisposeAsync()
{
if (m_disposed)
{
return;
}
m_disposed = true;
await StopTrackingAsync().ConfigureAwait(false);
}
private async Task PumpAsync(CancellationToken ct)
{
try
{
EventFilter filter = BuildModelChangeFilter();
var options = new MonitoringOptions
{
StartNodeId = ObjectIds.Server,
AttributeId = Attributes.EventNotifier,
QueueSize = 50
};
IAsyncEnumerable<EventNotification> source =
m_streaming.SubscribeEventsAsync(ObjectIds.Server, filter, options, ct);
await foreach (EventNotification notification in source.ConfigureAwait(false))
{
HandleNotification(notification);
}
}
catch (OperationCanceledException)
{
// graceful shutdown
}
catch (Exception ex)
{
m_logger.LogError(ex, "ModelChangeTracker pump failed");
}
}
private static EventFilter BuildModelChangeFilter()
{
var filter = new EventFilter();
filter.AddSelectClause(ObjectTypeIds.BaseEventType,
QualifiedName.From(BrowseNames.EventId));
filter.AddSelectClause(ObjectTypeIds.BaseEventType,
QualifiedName.From(BrowseNames.EventType));
filter.AddSelectClause(ObjectTypeIds.GeneralModelChangeEventType,
QualifiedName.From(BrowseNames.Changes));
filter.WhereClause.Push(FilterOperator.OfType,
Variant.From((NodeId)ObjectTypeIds.BaseModelChangeEventType));
return filter;
}
private void HandleNotification(EventNotification notification)
{
Variant[] fields = notification.Fields.ToArray() ?? Array.Empty<Variant>();
if (fields.Length < 3)
{
return;
}
Variant changesVariant = fields[2];
var changes = new List<ModelChange>();
bool requiresFullInvalidation = false;
if (changesVariant.TryGetValue(out ArrayOf<ExtensionObject> extObjs))
{
foreach (ExtensionObject ext in extObjs)
{
if (ext.TryGetValue(out ModelChangeStructureDataType? change) &&
change != null)
{
changes.Add(new ModelChange(
(ModelChangeVerb)change.Verb,
change.Affected,
change.AffectedType));
}
}
}
else
{
requiresFullInvalidation = true;
}
try
{
if (requiresFullInvalidation)
{
m_nodeCache?.Clear();
}
else
{
foreach (ModelChange change in changes)
{
InvalidateCache(change);
}
}
}
catch (Exception ex)
{
m_logger.LogWarning(ex, "ModelChangeTracker failed to invalidate cache");
}
try
{
ModelChanged?.Invoke(this,
new ModelChangedEventArgs(changes, requiresFullInvalidation));
}
catch (Exception ex)
{
m_logger.LogError(ex, "ModelChangeTracker subscriber threw");
}
}
private void InvalidateCache(ModelChange change)
{
if (m_nodeCache == null || change.Verb == ModelChangeVerb.None)
{
return;
}
// Targeted per-node invalidation. Falls back to Clear()
// automatically through the INodeCache default impl when
// an implementation doesn't override per-node eviction.
m_nodeCache.InvalidateNode(change.AffectedNode);
}
}
}