Files
UA-.NETStandard/Libraries/Opc.Ua.Client/Subscription/SubscriptionManagerSerializer.cs
Marc Schier 49305d9085 V2 subscription engine close gap for test and feature parity with classic engine (#3824)
# Description

V2 subscription engine feature parity round to make the classic engine
eligible for deprecation. Splits the test surface so the classic and V2
engines can evolve independently, ports the gaps the classic-engine
integration tests had been exercising, and lands the public V2 API
additions needed to close them.

- Splits `Tests/Opc.Ua.Subscriptions.Tests` into a classic
(`Opc.Ua.Subscriptions.Classic.Tests`) and a V2
(`Opc.Ua.Subscriptions.Tests`) project to shrink CI time and let the two
engines diverge cleanly.
- Adds the V2 public-surface gaps required by the test ports
(`Subscription.ServerId` on the class, `SetSubscriptionDurableAsync`,
`SendInitialValuesOnTransfer`, unified `OnSubscriptionStateChangedAsync`
handler callback, per-item `ConditionRefreshAsync`, fluent
`LoadSubscriptionsAsync(Stream, …)` and `Subscription.Snapshot()` /
`RestoreAsync()` for save/load + transfer).
- Lands handler-centric design (no `PublishingStopped` property handlers
maintain derived state); always-sequential per-subscription delivery
documented + tested.
- **Adds short and long haul stability tests for the V2 `ManagedSession`
+ subscription engine. Closes #3744** (see "Issue #3744 Haul tests"
below).
- **Migrates SubscriptionStateSnapshot / MonitoredItemStateSnapshot to
`[DataType]` source-generator codecs**.
- `SubscriptionDurableV2Tests.cs` 5 V2 ports of the classic durable test
patterns.
- `V2FollowUpCoverageTests.cs` handler state-change callback, fluent
stream-based `LoadSubscriptionsAsync`, `SendInitialValuesOnTransfer`,
snapshot edge cases (empty / `DataChangeFilter` round-trip / concurrent
  mutation).
- `SubscriptionFailoverV2Tests.cs` forced channel-break with and without
`WithTransferSubscriptionsOnRecreate`.
- `MonitoredItemConditionRefreshLiveV2Tests.cs` ΓÇö live
`ConditionRefresh` against the reference server's event source; asserts
`RefreshStart` / `RefreshEnd` events flow through the handler.

## Fixes

- #3744 Haul tests (V2 ManagedSession + subscription engine)
`Tests/Opc.Ua.Sessions.Tests/ManagedSessionStabilityTest.cs` adds the
short/long haul coverage requested by
[#3744](https://github.com/OPCFoundation/UA-.NETStandard/issues/3744)
plus the bonus fault-injection variant:

| Test | Duration | Category | Purpose |
|---|---|---|---|
| `ShortHaulManagedSessionV2Async` | 2 minutes | `ManagedSessionHaul`
(`[Explicit]`) | Quick local sanity check of the V2 monotonicity
contract. |
| `LongHaulManagedSessionV2Async` | 90 minutes (configurable via
`TEST_DURATION_MINUTES`) | `ManagedSessionHaul` (`[Explicit]`) |
Long-running V2 stability + monotonicity. |
| `LongHaulManagedSessionWithFaultInjectionV2Async` | 90 minutes
(configurable) + fault every `FAULT_INJECTION_INTERVAL_SECONDS` (default
60s) | `ManagedSessionHaul` (`[Explicit]`) | **Bonus** ΓÇö force-closes
the subscriber transport channel periodically; verifies V2 manager
transfers/recreates the subscription and continues monotonic delivery
across reconnects. |

**Pattern.** A writer `ManagedSession` increments a `uint32` counter and
writes it into `Scalar_Static_Mass_UInt32_UInt32_00` every 250ms. A
subscriber `ManagedSession` runs a V2 subscription with a single
monitored item on the same node. `MonotonicCounterHandler` asserts each
received sample is *strictly greater than* the previous one. V2
`ISubscriptionNotificationHandler` per-subscription ordering guarantee.
Skipped values (sampling rate < write rate) are tolerated; duplicates
and reorderings are violations.
2026-06-03 04:39:08 +02:00

188 lines
7.9 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Globalization;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
using Opc.Ua.Client.Subscriptions.MonitoredItems;
namespace Opc.Ua.Client.Subscriptions
{
/// <summary>
/// Save / Load support for the V2 <see cref="SubscriptionManager"/>.
/// </summary>
/// <remarks>
/// <para>
/// The on-wire format is the OPC UA <see cref="BinaryEncoder"/> format.
/// Each subscription is captured as a
/// <see cref="SubscriptionStateSnapshot"/> — an
/// <see cref="IEncodeable"/> emitted by the
/// <see cref="DataTypeAttribute"/> source generator — and written
/// directly via <see cref="IEncoder.WriteEncodeable{T}(string, T)"/>.
/// The reader instantiates <see cref="SubscriptionStateSnapshot"/>
/// statically by type (no <see cref="ExpandedNodeId"/> lookup is
/// required because the wire schema is implicit in the call site).
/// Future schema evolution is handled by adding new optional fields
/// to the snapshot record — they are encoded only when set and
/// recognized via <see cref="IDecoder.HasField(string)"/> by the
/// reader.
/// </para>
/// <para>
/// The stream still preserves the source session's namespace and
/// server URI tables so the snapshot is portable across sessions
/// whose tables index URIs at different positions; the loader
/// remaps those indices into the target session's tables before
/// decoding each snapshot's <c>NodeId</c> fields.
/// </para>
/// </remarks>
internal static class SubscriptionManagerSerializer
{
#pragma warning disable RCS1229 // Use async/await when necessary - this path is synchronous; ValueTask wraps work for future async I/O
public static ValueTask SaveAsync(
SubscriptionManager manager,
Stream stream,
IServiceMessageContext messageContext,
IEnumerable<ISubscription>? subscriptions,
CancellationToken ct = default)
#pragma warning restore RCS1229
{
ct.ThrowIfCancellationRequested();
if (manager == null)
{
throw new ArgumentNullException(nameof(manager));
}
if (stream == null)
{
throw new ArgumentNullException(nameof(stream));
}
if (messageContext == null)
{
throw new ArgumentNullException(nameof(messageContext));
}
// Capture a snapshot per selected subscription. Default =
// all subscriptions managed by this instance. Snapshot is
// taken from the concrete subscription type.
IEnumerable<ISubscription> selected =
subscriptions ?? manager.Items;
var snapshots = new List<SubscriptionStateSnapshot>();
foreach (ISubscription s in selected)
{
if (s is Subscription concrete)
{
snapshots.Add(concrete.Snapshot());
}
}
using var encoder = new BinaryEncoder(stream, messageContext, true);
encoder.WriteStringArray(null, messageContext.NamespaceUris.ToArrayOf());
encoder.WriteStringArray(null, messageContext.ServerUris.ToArrayOf());
encoder.WriteInt32(null, snapshots.Count);
foreach (SubscriptionStateSnapshot snapshot in snapshots)
{
// Write the snapshot directly as an IEncodeable.
// Schema identity is statically encoded by the call site
// (we always read back a SubscriptionStateSnapshot); schema
// evolution is handled by adding new optional fields with
// CanOmitFields-aware encoding.
encoder.WriteEncodeable(null, snapshot);
}
return default;
}
public static async ValueTask<IReadOnlyList<ISubscription>> LoadAsync(
SubscriptionManager manager,
Stream stream,
IServiceMessageContext messageContext,
Func<string, ISubscriptionNotificationHandler> handlerFactory,
bool transferSubscriptions,
CancellationToken ct)
{
if (manager == null)
{
throw new ArgumentNullException(nameof(manager));
}
if (stream == null)
{
throw new ArgumentNullException(nameof(stream));
}
if (messageContext == null)
{
throw new ArgumentNullException(nameof(messageContext));
}
if (handlerFactory == null)
{
throw new ArgumentNullException(nameof(handlerFactory));
}
using var decoder = new BinaryDecoder(stream, messageContext, true);
ArrayOf<string?> nsUris = decoder.ReadStringArray(null);
ArrayOf<string?> serverUris = decoder.ReadStringArray(null);
decoder.SetMappingTables(
nsUris.IsNull
? new NamespaceTable()
: new NamespaceTable(nsUris.Memory.ToArray()!),
serverUris.IsNull
? new StringTable()
: new StringTable(serverUris.Memory.ToArray()!));
int count = decoder.ReadInt32(null);
if (count <= 0)
{
return [];
}
var restored = new List<ISubscription>(count);
for (int i = 0; i < count; i++)
{
ct.ThrowIfCancellationRequested();
// Schema identity is implicit in the call: we always
// read a SubscriptionStateSnapshot. Future schema evolution
// happens by adding optional fields recognized via
// HasField on the decoder side.
SubscriptionStateSnapshot state =
decoder.ReadEncodeable<SubscriptionStateSnapshot>(null);
string syntheticName = i.ToString(CultureInfo.InvariantCulture);
ISubscriptionNotificationHandler handler =
handlerFactory(syntheticName);
ISubscription subscription = await manager.RestoreAsync(
handler,
state,
transferSubscriptions,
ct).ConfigureAwait(false);
restored.Add(subscription);
}
return restored;
}
}
}