mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-20 16:52:07 +08:00
61edaa1ed0
# Description Drops support for **netstandard2.1** and **.NET Framework 4.7.2**. Libraries now target `net48`, `net8.0`, `net9.0` and `net10.0`. `Opc.Ua.Types` and `Opc.Ua.SourceGeneration.Core` still also target `netstandard2.0`, but only because the Roslyn source generators load them. There is no general netstandard2.0 support. **Preprocessor directives** (112 files) - Every `#if`/`#elif` mentioning `NETSTANDARD2_1*`, `NET472*`, `NET_STANDARD_TESTS`, `SKIP_ECC_CERTIFICATE_REQUEST_SIGNING` or `NETSTANDARD*` was evaluated against the remaining TFM set (net48, net8/9/10, plus netstandard2.0 inside `Opc.Ua.Types`/`tools`) and simplified. Dead branches were removed. - Example: `NETSTANDARD2_1 || NET8_0_OR_GREATER` → `NET8_0_OR_GREATER`. - Example: `NET8_0_OR_GREATER || NET472_OR_GREATER` → removed (always true). - Netstandard-only code was removed: `UnixFileModeShim`, the CRDT reflection path in `ReplicatedGossipOptions.CreateReaderOptions`, and the netstandard2.1-only test variants. **Custom test logic** - `targets.props` drops the `net472`, `netstandard2.0` and `netstandard2.1` `CustomTestTarget` profiles, `NetStandardTests` and `SKIP_ECC_CERTIFICATE_REQUEST_SIGNING`. Supported values are now `net48`, `net8.0`, `net9.0`, `net10.0`. - The `NET_STANDARD_TESTS` define is removed from 29 test projects. - The "build netstandard shells as net10.0" overrides are removed from 18 projects. - `RestrictForLegacyTfm` now only applies to `net48`. - `tests/customtest.bat` is updated to the new values. **Build / packaging / CI** - MSBuild TFM conditions are simplified: Kestrel package choice, MQTTnet v4 (net48 only), BouncyCastle, Di/OpenUsd/Vision/Stress test excludes, and `System.IO.FileSystem.AccessControl` (dropped from Core). - The MigrationAnalyzer nuspec drops its net472/netstandard2.1 lib groups. The Azure signing lists are updated. - `get-ci-matrix.ps1` removes the net472/netstandard test profiles (including the PR-gating `linux-netstandard2.1`) and the matching build legs. **Breaking API change (2.0 preview):** removed `HttpsTransportListener.IsWssTransportSupported` and `ReplicatedGossipOptions.IsGossipStateDecodingSupported`. They only returned `false` on netstandard2.1 and are now always `true`. The test guards that used them were removed as well. **Docs** - NuGet READMEs, `README.md`, `DeveloperGuide.md`, `PubSub.md`, the certificate/ECC/identity docs and the 2.0 migration guide (plus its `.agents` skill mirror) are updated. - The migration guide notes that 4.7.2 consumers must move to 4.8 and netstandard2.1 consumers to net8.0+. ### Reviewer notes - The `System.IO.FileSystem.AccessControl` `PackageVersion` pin is left in `Directory.Packages.props`. It has no direct reference any more, but transitive pinning is on, so it was kept to avoid shifting resolved versions. - The `#if` rewrite was done mechanically by a truth-table evaluator. The diff in the `.cs` files is limited to directive lines, removed dead branches, and stale-comment updates. ### Verified locally - `dotnet build UA.slnx -p:CustomTestTarget=net48`: 0 errors. - `dotnet build UA.slnx -p:CustomTestTarget=net10.0`: 0 errors. - Default multi-target builds (no `CustomTestTarget`) of Opc.Ua.Types, Bindings.Https, PubSub.Mqtt and Redundancy.Server succeeded. - net10.0 tests: - Opc.Ua.Redundancy.Server.Tests: 840/840 passed. - Opc.Ua.Types.Tests: 11363 passed, 1 skipped. - ModelDependencyScanner tests: 20/20 passed. - The full test suite was **not** run locally. ## Related Issues - None ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [ ] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
276 lines
10 KiB
C#
276 lines
10 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Buffers;
|
|
using System.IO;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Bindings;
|
|
using Opc.Ua.Tests;
|
|
|
|
namespace Opc.Ua.Types.Buffers.Tests
|
|
{
|
|
/// <summary>
|
|
/// Tests for <see cref="ArrayPoolBufferWriter{T}"/> where T is <see cref="byte"/>.
|
|
/// </summary>
|
|
[Parallelizable(ParallelScope.All)]
|
|
public class ArraySegmentStreamTests
|
|
{
|
|
/// <summary>
|
|
/// Test the default behavior of <see cref="ArrayPoolMemoryStream"/>.
|
|
/// </summary>
|
|
[Test]
|
|
public void ArraySegmentStreamWhenConstructedWithDefaultOptionsShouldNotThrow()
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
|
|
// Arrange
|
|
var bufferManager = new BufferManager(
|
|
nameof(ArraySegmentStreamWhenConstructedWithDefaultOptionsShouldNotThrow),
|
|
0x10000 - 1,
|
|
telemetry);
|
|
var stream = new ArraySegmentStream(bufferManager);
|
|
|
|
// Act
|
|
Action act = stream.Dispose;
|
|
byte[] buffer = [0x55];
|
|
|
|
// Assert
|
|
Assert.That(stream.CanRead, Is.True);
|
|
Assert.That(stream.CanWrite, Is.True);
|
|
Assert.That(stream.CanSeek, Is.True);
|
|
Assert.Throws<NotSupportedException>(() => stream.SetLength(0));
|
|
Assert.Throws<IOException>(() => stream.Seek(-1, SeekOrigin.Begin));
|
|
Assert.Throws<IOException>(() => stream.Seek(0, (SeekOrigin)66));
|
|
|
|
Assert.That(stream.Seek(0, SeekOrigin.Begin), Is.Zero);
|
|
Assert.That(stream.ReadByte(), Is.EqualTo(-1));
|
|
Assert.That(stream.Read(buffer, 0, 1), Is.Zero);
|
|
#if NET5_0_OR_GREATER
|
|
Assert.That(stream.Read(buffer.AsSpan(0, 1)), Is.Zero);
|
|
#endif
|
|
stream.Position = 0;
|
|
Assert.That(stream.Position, Is.Zero);
|
|
|
|
Assert.That(stream.Length, Is.Zero);
|
|
|
|
Assert.That(stream.Seek(0, SeekOrigin.Begin), Is.Zero);
|
|
stream.WriteByte(0xaa);
|
|
stream.Write(buffer, 0, 1);
|
|
#if NET5_0_OR_GREATER
|
|
stream.Write(buffer.AsSpan(0, 1));
|
|
#else
|
|
stream.Write(buffer, 0, 1);
|
|
#endif
|
|
stream.Flush();
|
|
Assert.That(stream.Length, Is.EqualTo(3));
|
|
Assert.That(stream.Position, Is.EqualTo(3));
|
|
Assert.That(stream.Length, Is.EqualTo(3));
|
|
|
|
Assert.That(stream.Seek(-3, SeekOrigin.Current), Is.Zero);
|
|
Assert.That(stream.ReadByte(), Is.EqualTo(0xaa));
|
|
Assert.That(stream.Length, Is.EqualTo(3));
|
|
Assert.That(stream.Position, Is.EqualTo(1));
|
|
Assert.That(stream.Read(buffer, 0, 1), Is.EqualTo(1));
|
|
Assert.That(stream.Position, Is.EqualTo(2));
|
|
Assert.That(stream.Length, Is.EqualTo(3));
|
|
Assert.That(buffer[0], Is.EqualTo(0x55));
|
|
#if NET5_0_OR_GREATER
|
|
Assert.That(stream.Read(buffer.AsSpan(0, 1)), Is.EqualTo(1));
|
|
#else
|
|
Assert.That(stream.Read(buffer, 0, 1), Is.EqualTo(1));
|
|
#endif
|
|
Assert.That(stream.Position, Is.EqualTo(3));
|
|
Assert.That(stream.Length, Is.EqualTo(3));
|
|
Assert.That(buffer[0], Is.EqualTo(0x55));
|
|
Assert.That(stream.ReadByte(), Is.EqualTo(-1));
|
|
Assert.That(stream.Read(buffer, 0, 1), Is.Zero);
|
|
#if NET5_0_OR_GREATER
|
|
Assert.That(stream.Read(buffer.AsSpan(0, 1)), Is.Zero);
|
|
#endif
|
|
|
|
byte[] array = stream.ToArray();
|
|
Assert.That(array, Has.Length.EqualTo(3));
|
|
Assert.That(array[0], Is.EqualTo(0xaa));
|
|
Assert.That(array[1], Is.EqualTo(0x55));
|
|
Assert.That(array[2], Is.EqualTo(0x55));
|
|
|
|
// now buffer sequence owns the buffers
|
|
using (BufferSequence bufferSequence = stream.GetSequence("Test"))
|
|
{
|
|
ReadOnlySequence<byte> sequence = bufferSequence.Sequence;
|
|
Assert.That(sequence.Length, Is.EqualTo(3));
|
|
Assert.That(sequence.Slice(0, 1).First.Span[0], Is.EqualTo(0xaa));
|
|
Assert.That(sequence.Slice(1, 1).First.Span[0], Is.EqualTo(0x55));
|
|
Assert.That(sequence.Slice(2, 1).First.Span[0], Is.EqualTo(0x55));
|
|
}
|
|
|
|
act();
|
|
|
|
Assert.Throws<ObjectDisposedException>(() => stream.ToArray());
|
|
}
|
|
|
|
/// <summary>
|
|
/// Test the default behavior of <see cref="ArraySegmentStream"/>.
|
|
/// </summary>
|
|
[Theory]
|
|
public void ArraySegmentStreamWrite(
|
|
[Values(0, 1, 16, 17, 128, 333, 777, 1024, 4096)] int chunkSize,
|
|
[Values(16, 128, 333, 1024, 4096, 65536)] int defaultBufferSize)
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
|
|
int length;
|
|
byte[] buffer = new byte[chunkSize];
|
|
|
|
// Arrange
|
|
var bufferManager = new BufferManager(
|
|
nameof(ArraySegmentStreamWhenConstructedWithDefaultOptionsShouldNotThrow),
|
|
defaultBufferSize,
|
|
telemetry);
|
|
using var writer = new ArraySegmentStream(bufferManager);
|
|
// Act
|
|
for (int i = 0; i <= byte.MaxValue; i++)
|
|
{
|
|
// fill chunk with a byte
|
|
for (int v = 0; v < chunkSize; v++)
|
|
{
|
|
buffer[v] = (byte)i;
|
|
}
|
|
|
|
// write next chunk
|
|
switch (UnsecureRandom.Shared.Next(3))
|
|
{
|
|
case 0:
|
|
for (int v = 0; v < chunkSize; v++)
|
|
{
|
|
writer.WriteByte((byte)i);
|
|
}
|
|
|
|
break;
|
|
case 1:
|
|
writer.Write(buffer, 0, chunkSize);
|
|
break;
|
|
#if NET5_0_OR_GREATER
|
|
default:
|
|
writer.Write(buffer.AsSpan(0, chunkSize));
|
|
break;
|
|
#else
|
|
default:
|
|
writer.Write(buffer, 0, chunkSize);
|
|
break;
|
|
#endif
|
|
}
|
|
}
|
|
|
|
length = (byte.MaxValue + 1) * chunkSize;
|
|
long result = writer.Seek(0, SeekOrigin.Begin);
|
|
Assert.That(result, Is.Zero);
|
|
|
|
result = writer.Seek(0, SeekOrigin.End);
|
|
Assert.That(result, Is.EqualTo(length));
|
|
|
|
// read back from writer MemoryStream
|
|
result = writer.Seek(0, SeekOrigin.Begin);
|
|
Assert.That(result, Is.Zero);
|
|
|
|
Assert.That(writer.Length, Is.EqualTo(length));
|
|
|
|
long position;
|
|
for (int i = 0; i <= byte.MaxValue; i++)
|
|
{
|
|
if (UnsecureRandom.Shared.Next(2) == 0)
|
|
{
|
|
position = writer.Seek(chunkSize * i, SeekOrigin.Begin);
|
|
Assert.That(position, Is.EqualTo(chunkSize * i));
|
|
}
|
|
|
|
int bytesRead;
|
|
switch (UnsecureRandom.Shared.Next(3))
|
|
{
|
|
case 0:
|
|
for (int v = 0; v < chunkSize; v++)
|
|
{
|
|
Assert.That(writer.ReadByte(), Is.EqualTo((byte)i));
|
|
}
|
|
break;
|
|
case 1:
|
|
bytesRead = writer.Read(buffer, 0, chunkSize);
|
|
Assert.That(chunkSize, Is.EqualTo(bytesRead));
|
|
for (int v = 0; v < chunkSize; v++)
|
|
{
|
|
Assert.That(buffer[v], Is.EqualTo((byte)i));
|
|
}
|
|
break;
|
|
default:
|
|
#if NET5_0_OR_GREATER
|
|
bytesRead = writer.Read(buffer.AsSpan(0, chunkSize));
|
|
Assert.That(chunkSize, Is.EqualTo(bytesRead));
|
|
for (int v = 0; v < chunkSize; v++)
|
|
{
|
|
Assert.That(buffer[v], Is.EqualTo((byte)i));
|
|
}
|
|
break;
|
|
#else
|
|
goto case 1;
|
|
#endif
|
|
}
|
|
}
|
|
|
|
position = writer.Seek(0, SeekOrigin.Begin);
|
|
Assert.That(position, Is.Zero);
|
|
|
|
using BufferSequence bufferSequence = writer.GetSequence("Test");
|
|
ReadOnlySequence<byte> sequence = bufferSequence.Sequence;
|
|
buffer = sequence.ToArray();
|
|
|
|
// Assert sequence properties
|
|
Assert.That(buffer, Has.Length.EqualTo(length));
|
|
Assert.That(sequence.Length, Is.EqualTo(length));
|
|
|
|
for (int i = 0; i < buffer.Length; i++)
|
|
{
|
|
Assert.That(buffer[i], Is.EqualTo((byte)(i / chunkSize)));
|
|
}
|
|
|
|
for (int i = 0; i <= byte.MaxValue; i++)
|
|
{
|
|
ReadOnlySequence<byte> chunkSequence = sequence.Slice(i * chunkSize, chunkSize);
|
|
Assert.That(chunkSequence.Length, Is.EqualTo((long)chunkSize));
|
|
|
|
buffer = chunkSequence.ToArray();
|
|
for (int v = 0; v < chunkSize; v++)
|
|
{
|
|
Assert.That(buffer[v], Is.EqualTo((byte)i));
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|