mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-26 04:19:53 +08:00
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
234 lines
9.1 KiB
C#
234 lines
9.1 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Formats.Asn1;
|
|
using System.IO;
|
|
using System.Security.Cryptography;
|
|
using System.Security.Cryptography.X509Certificates;
|
|
using Opc.Ua.Security.Certificates;
|
|
|
|
namespace Opc.Ua.Fuzzing
|
|
{
|
|
/// <summary>
|
|
/// Fuzzing code for signed CRL decoding and canonical TBS encoding.
|
|
/// </summary>
|
|
public static partial class FuzzableCode
|
|
{
|
|
/// <summary>
|
|
/// The X509 CRL fuzz target for afl-fuzz.
|
|
/// </summary>
|
|
public static void AflfuzzX509CRL(Stream stream)
|
|
{
|
|
_ = FuzzX509CRLCore(ReadAllBytes(stream));
|
|
}
|
|
|
|
/// <summary>
|
|
/// The X509 CRL fuzz target for libFuzzer.
|
|
/// </summary>
|
|
public static void LibfuzzX509CRL(ReadOnlySpan<byte> input)
|
|
{
|
|
_ = FuzzX509CRLCore(input.ToArray());
|
|
}
|
|
|
|
/// <summary>
|
|
/// Re-encodes a decoded signed CRL as TBS data.
|
|
/// </summary>
|
|
public static void AflfuzzCRLEncoder(Stream stream)
|
|
{
|
|
_ = FuzzCRLEncoderCore(ReadAllBytes(stream), roundTrip: false);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Re-encodes a decoded signed CRL as TBS data.
|
|
/// </summary>
|
|
public static void LibfuzzCRLEncoder(ReadOnlySpan<byte> input)
|
|
{
|
|
_ = FuzzCRLEncoderCore(input.ToArray(), roundTrip: false);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Requires byte-exact and field-exact canonical CRL TBS round trips.
|
|
/// </summary>
|
|
public static void AflfuzzCRLEncoderIndempotent(Stream stream)
|
|
{
|
|
_ = FuzzCRLEncoderCore(ReadAllBytes(stream), roundTrip: true);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Requires byte-exact and field-exact canonical CRL TBS round trips.
|
|
/// </summary>
|
|
public static void LibfuzzCRLEncoderIndempotent(ReadOnlySpan<byte> input)
|
|
{
|
|
_ = FuzzCRLEncoderCore(input.ToArray(), roundTrip: true);
|
|
}
|
|
|
|
internal static bool FuzzX509CRLCore(byte[] input)
|
|
{
|
|
return DecodeCrlInput(input) != null;
|
|
}
|
|
|
|
internal static bool FuzzCRLEncoderCore(byte[] input, bool roundTrip)
|
|
{
|
|
X509CRL crl = DecodeCrlInput(input);
|
|
if (crl == null)
|
|
{
|
|
return false;
|
|
}
|
|
|
|
byte[] algorithmIdentifier = ReadCrlAlgorithmIdentifier(input);
|
|
byte[] canonical = CrlBuilder.Create(crl).Encode(algorithmIdentifier);
|
|
AssertCrlAlgorithmIdentifier(algorithmIdentifier, canonical);
|
|
if (roundTrip)
|
|
{
|
|
var decoded = new X509CRL();
|
|
decoded.DecodeCrl(canonical);
|
|
AssertCrlFieldsEqual(crl, decoded);
|
|
|
|
byte[] reencoded = CrlBuilder.Create(decoded).Encode(algorithmIdentifier);
|
|
if (!canonical.AsSpan().SequenceEqual(reencoded))
|
|
{
|
|
throw new InvalidOperationException("Canonical CRL TBS bytes changed after re-encoding.");
|
|
}
|
|
|
|
var decodedAgain = new X509CRL();
|
|
decodedAgain.DecodeCrl(reencoded);
|
|
AssertCrlFieldsEqual(decoded, decodedAgain);
|
|
}
|
|
return true;
|
|
}
|
|
|
|
internal static void AssertCrlAlgorithmIdentifier(ReadOnlySpan<byte> expected, byte[] tbs)
|
|
{
|
|
if (!expected.SequenceEqual(ReadCrlTbsAlgorithmIdentifier(tbs)))
|
|
{
|
|
throw new InvalidOperationException("Canonical CRL signature algorithm identifier changed.");
|
|
}
|
|
}
|
|
|
|
internal static void AssertCrlFieldsEqual(IX509CRL expected, IX509CRL actual)
|
|
{
|
|
if (!expected.IssuerName.RawData.AsSpan().SequenceEqual(actual.IssuerName.RawData) ||
|
|
expected.Issuer != actual.Issuer ||
|
|
expected.HashAlgorithmName != actual.HashAlgorithmName ||
|
|
expected.ThisUpdate != actual.ThisUpdate ||
|
|
expected.NextUpdate != actual.NextUpdate ||
|
|
expected.RevokedCertificates.Count != actual.RevokedCertificates.Count)
|
|
{
|
|
throw new InvalidOperationException("Canonical CRL fields changed after re-encoding.");
|
|
}
|
|
|
|
for (int index = 0; index < expected.RevokedCertificates.Count; index++)
|
|
{
|
|
RevokedCertificate expectedEntry = expected.RevokedCertificates[index];
|
|
RevokedCertificate actualEntry = actual.RevokedCertificates[index];
|
|
if (!expectedEntry.UserCertificate.AsSpan().SequenceEqual(actualEntry.UserCertificate) ||
|
|
expectedEntry.SerialNumber != actualEntry.SerialNumber ||
|
|
expectedEntry.RevocationDate != actualEntry.RevocationDate)
|
|
{
|
|
throw new InvalidOperationException("Canonical CRL revoked entries changed after re-encoding.");
|
|
}
|
|
AssertCrlExtensionsEqual(expectedEntry.CrlEntryExtensions, actualEntry.CrlEntryExtensions);
|
|
}
|
|
|
|
AssertCrlExtensionsEqual(expected.CrlExtensions, actual.CrlExtensions);
|
|
}
|
|
|
|
private static void AssertCrlExtensionsEqual(
|
|
X509ExtensionCollection expected,
|
|
X509ExtensionCollection actual)
|
|
{
|
|
if (expected.Count != actual.Count)
|
|
{
|
|
throw new InvalidOperationException("Canonical CRL extension count changed after re-encoding.");
|
|
}
|
|
for (int index = 0; index < expected.Count; index++)
|
|
{
|
|
if (expected[index].Oid?.Value != actual[index].Oid?.Value ||
|
|
expected[index].Critical != actual[index].Critical ||
|
|
!expected[index].RawData.AsSpan().SequenceEqual(actual[index].RawData))
|
|
{
|
|
throw new InvalidOperationException("Canonical CRL extensions changed after re-encoding.");
|
|
}
|
|
}
|
|
}
|
|
|
|
private static byte[] ReadCrlAlgorithmIdentifier(byte[] input)
|
|
{
|
|
var signature = new X509Signature(input);
|
|
return ReadCrlTbsAlgorithmIdentifier(signature.Tbs);
|
|
}
|
|
|
|
private static byte[] ReadCrlTbsAlgorithmIdentifier(byte[] input)
|
|
{
|
|
var reader = new AsnReader(input, AsnEncodingRules.DER);
|
|
AsnReader tbs = reader.ReadSequence();
|
|
reader.ThrowIfNotEmpty();
|
|
if (tbs.PeekTag() == Asn1Tag.Integer)
|
|
{
|
|
_ = tbs.ReadInteger();
|
|
}
|
|
return tbs.ReadEncodedValue().ToArray();
|
|
}
|
|
|
|
private static X509CRL DecodeCrlInput(byte[] input)
|
|
{
|
|
try
|
|
{
|
|
var crl = new X509CRL(input);
|
|
_ = crl.Issuer;
|
|
_ = crl.IssuerName;
|
|
_ = crl.ThisUpdate;
|
|
_ = crl.NextUpdate;
|
|
_ = crl.HashAlgorithmName;
|
|
_ = crl.RawData;
|
|
foreach (RevokedCertificate revokedCertificate in crl.RevokedCertificates)
|
|
{
|
|
_ = revokedCertificate.SerialNumber;
|
|
_ = revokedCertificate.RevocationDate;
|
|
foreach (X509Extension extension in revokedCertificate.CrlEntryExtensions)
|
|
{
|
|
_ = extension.Format(false);
|
|
}
|
|
}
|
|
foreach (X509Extension extension in crl.CrlExtensions)
|
|
{
|
|
_ = extension.Format(false);
|
|
}
|
|
_ = crl.ToString();
|
|
return crl;
|
|
}
|
|
catch (CryptographicException exception) when (IsExpectedCertificateInputException(exception))
|
|
{
|
|
return null!;
|
|
}
|
|
}
|
|
}
|
|
}
|