Files
UA-.NETStandard/fuzzing/Opc.Ua.PubSub.Fuzz.Tests/PubSubDecoderRejectionTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

161 lines
7.6 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.IO;
using System.Text;
using System.Text.Json;
using System.Text.Json.Nodes;
using System.Threading.Tasks;
using NUnit.Framework;
using Opc.Ua.PubSub.Encoding;
using PubSubJsonDecoder = Opc.Ua.PubSub.Encoding.Json.JsonDecoder;
namespace Opc.Ua.Fuzzing
{
/// <summary>
/// Soft rejections are observed at the production core and both retained adapters.
/// No test catches unexpected decoder or oracle failures.
/// </summary>
[TestFixture]
[Category("Fuzzing")]
public sealed class PubSubDecoderRejectionTests
{
[TestCase("", 0)]
[TestCase("{", 0)]
[TestCase("null", 0)]
[TestCase("42", 0)]
[TestCase("[42,true]", 1)]
[TestCase("{\"MessageId\":\"missing-type\",\"PublisherId\":\"300\"}", 0)]
[TestCase("{\"MessageType\":42,\"Messages\":[]}", 0)]
[TestCase("{\"MessageType\":\"unknown\"}", 1)]
public async Task MalformedJsonAndInvalidRootsAreSoftRejectedAsync(string text, int received)
{
await AssertJsonRejectedAsync(Encoding.UTF8.GetBytes(text), received).ConfigureAwait(false);
}
[TestCase("PublisherId", "301")]
[TestCase("DataSetClassId", "aabbccdd-1122-3344-5566-778899aabbcd")]
public async Task NestedIdentityConflictRejectsTheEntireStoredJsonMessageAsync(
string propertyName,
string conflictingValue)
{
byte[] seed = PubSubSeedAssertions.LoadSeed("Json", "metadata-keyframe-verbose.json");
JsonObject envelope = JsonNode.Parse(seed)!.AsObject();
JsonObject dataSet = envelope["Messages"]!.AsArray()[0]!.AsObject();
dataSet[propertyName] = conflictingValue;
byte[] conflicting = JsonSerializer.SerializeToUtf8Bytes(envelope);
await AssertJsonRejectedAsync(conflicting, received: 1).ConfigureAwait(false);
// Removing only the conflicting nested identity restores all four valid fields.
Assert.That(dataSet.Remove(propertyName), Is.True);
PubSubNetworkMessageContext context = FuzzableCode.NewContext();
PubSubNetworkMessage recovered = FuzzableCode.DecodePubSubJson(
JsonSerializer.SerializeToUtf8Bytes(envelope), context);
PubSubSeedAssertions.AssertJsonSeed(recovered, "retained-Verbose-Variant", PubSubFieldEncoding.Variant);
PubSubSeedAssertions.AssertDiagnostics(context, received: 1, dataSets: 1);
}
[TestCase("metadata-keyframe-variant.uadp", PubSubFieldEncoding.Variant)]
[TestCase("metadata-keyframe-datavalue.uadp", PubSubFieldEncoding.DataValue)]
[TestCase("metadata-keyframe-raw.uadp", PubSubFieldEncoding.RawData)]
public void EveryTruncatedSeedHeaderAndFinalFieldAreRejected(string name, PubSubFieldEncoding encoding)
{
byte[] seed = PubSubSeedAssertions.LoadSeed("Uadp", name);
// The fixed seed has a 36-byte network prefix and a 20-byte DataSetMessage header.
const int headerSize = 56;
Assert.That(seed.Length, Is.GreaterThan(headerSize));
for (int length = 0; length < headerSize; length++)
{
byte[] truncated = seed.AsSpan(0, length).ToArray();
PubSubNetworkMessageContext context = FuzzableCode.NewContext();
Assert.That(FuzzableCode.DecodeUadp(truncated, context), Is.Null, $"Header prefix length: {length}");
PubSubSeedAssertions.AssertDiagnostics(context, invalid: length == 0 ? 0 : 1);
PubSubSeedAssertions.ReplayUadpAdapters(truncated);
}
PubSubNetworkMessageContext tailContext = FuzzableCode.NewContext();
byte[] missingFinalByte = seed[..^1];
Assert.That(FuzzableCode.DecodeUadp(missingFinalByte, tailContext), Is.Null);
PubSubSeedAssertions.AssertDiagnostics(tailContext, invalid: 1);
PubSubSeedAssertions.ReplayUadpAdapters(missingFinalByte);
PubSubNetworkMessageContext completeContext = FuzzableCode.NewContext();
PubSubSeedAssertions.AssertUadpSeed(FuzzableCode.DecodeUadp(seed, completeContext), encoding);
PubSubSeedAssertions.AssertDiagnostics(completeContext, received: 1, dataSets: 1);
}
[Test]
public void StreamAdapterReadFailuresAreNotSwallowedOrConvertedIntoSoftRejections()
{
Action<Stream>[] callbacks =
[
FuzzableCode.AflfuzzPubSubJsonDecode,
FuzzableCode.AflfuzzUadpNetworkMessageDecode,
FuzzableCode.AflfuzzUadpChunkReassembly
];
foreach (Action<Stream> callback in callbacks)
{
var failure = new InvalidOperationException("Injected input-reader failure.");
using var stream = new FailingReadStream(failure);
Assert.That(
() => callback(stream),
Throws.TypeOf<InvalidOperationException>().And.SameAs(failure), callback.Method.Name);
Assert.That(stream.CanRead, Is.True, "A failed adapter must not dispose the caller's stream.");
}
}
private static async Task AssertJsonRejectedAsync(byte[] frame, int received)
{
PubSubNetworkMessageContext coreContext = FuzzableCode.NewContext();
PubSubNetworkMessageContext publicContext = FuzzableCode.NewContext();
PubSubNetworkMessage coreResult = FuzzableCode.DecodePubSubJson(frame, coreContext);
PubSubNetworkMessage publicResult = (await new PubSubJsonDecoder()
.TryDecodeAsync(frame, publicContext).ConfigureAwait(false))!;
Assert.That(coreResult, Is.Null);
Assert.That(publicResult, Is.Null);
PubSubSeedAssertions.AssertDiagnostics(coreContext, received: received, invalid: 1);
PubSubSeedAssertions.AssertDiagnostics(publicContext, received: received, invalid: 1);
PubSubSeedAssertions.ReplayJsonAdapters(frame);
}
private sealed class FailingReadStream(InvalidOperationException failure) : MemoryStream
{
public override int Read(byte[] buffer, int offset, int count)
{
throw failure;
}
}
}
}