mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-25 11:50:03 +08:00
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
338 lines
14 KiB
C#
338 lines
14 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System.Text.Json;
|
|
using Microsoft.Extensions.Logging;
|
|
using Opc.Ua.Redundancy;
|
|
using Opc.Ua.Redundancy.Kubernetes;
|
|
using Opc.Ua.Redundancy.Server;
|
|
using Opc.Ua.Server;
|
|
|
|
// CA2007: AOT tests run without a SynchronizationContext.
|
|
#pragma warning disable CA2007
|
|
|
|
namespace Opc.Ua.Aot.Tests
|
|
{
|
|
/// <summary>
|
|
/// NativeAOT exercises for distributed redundancy serialization paths.
|
|
/// </summary>
|
|
public class DistributedRedundancyAotTests
|
|
{
|
|
[Test]
|
|
public async Task KubernetesSourceGeneratedJsonRoundTripsLeaseAndEndpointSliceAsync()
|
|
{
|
|
var lease = new KubernetesLease
|
|
{
|
|
Metadata = new KubernetesObjectMetadata
|
|
{
|
|
Name = "opcua-leader",
|
|
Namespace = "default",
|
|
ResourceVersion = "12"
|
|
},
|
|
Spec = new KubernetesLeaseSpec
|
|
{
|
|
HolderIdentity = "replica-a",
|
|
LeaseDurationSeconds = 30,
|
|
AcquireTime = "2026-06-27T08:00:00Z",
|
|
RenewTime = "2026-06-27T08:00:10Z",
|
|
LeaseTransitions = 2
|
|
}
|
|
};
|
|
string leaseJson = JsonSerializer.Serialize(
|
|
lease,
|
|
KubernetesJsonContext.Default.KubernetesLease);
|
|
KubernetesLease? decodedLease = JsonSerializer.Deserialize(
|
|
leaseJson,
|
|
KubernetesJsonContext.Default.KubernetesLease);
|
|
|
|
await Assert.That(decodedLease).IsNotNull();
|
|
await Assert.That(decodedLease!.Spec.HolderIdentity).IsEqualTo("replica-a");
|
|
|
|
var slices = new KubernetesEndpointSliceList
|
|
{
|
|
Items =
|
|
[
|
|
new KubernetesEndpointSlice
|
|
{
|
|
Endpoints =
|
|
[
|
|
new KubernetesEndpoint
|
|
{
|
|
Addresses = ["10.0.0.11"],
|
|
Conditions = new KubernetesEndpointConditions { Ready = true }
|
|
}
|
|
],
|
|
Ports = [new KubernetesEndpointPort { Name = "opcua-tcp", Port = 4840 }]
|
|
}
|
|
]
|
|
};
|
|
string sliceJson = JsonSerializer.Serialize(
|
|
slices,
|
|
KubernetesJsonContext.Default.KubernetesEndpointSliceList);
|
|
KubernetesEndpointSliceList? decodedSlices = JsonSerializer.Deserialize(
|
|
sliceJson,
|
|
KubernetesJsonContext.Default.KubernetesEndpointSliceList);
|
|
|
|
await Assert.That(decodedSlices).IsNotNull();
|
|
await Assert.That(decodedSlices!.Items[0].Endpoints[0].Addresses[0]).IsEqualTo("10.0.0.11");
|
|
}
|
|
|
|
[Test]
|
|
public async Task KubernetesLeaseAndPeerDiscoveryUseMockedInClusterClientAsync()
|
|
{
|
|
var client = new FakeKubernetesApiClient();
|
|
var leaderOptions = new KubernetesLeaderElectionOptions();
|
|
leaderOptions.Kubernetes.Namespace = "default";
|
|
leaderOptions.Kubernetes.NodeId = "replica-a";
|
|
leaderOptions.LeaseName = "opcua-leader";
|
|
await using var election = new KubernetesLeaseLeaderElection(client, leaderOptions);
|
|
|
|
bool acquired = await election.TryAcquireOrRenewAsync().ConfigureAwait(false);
|
|
|
|
await Assert.That(acquired).IsTrue();
|
|
await Assert.That(client.Lease).IsNotNull();
|
|
await Assert.That(client.Lease!.Spec.HolderIdentity).IsEqualTo("replica-a");
|
|
|
|
var discoveryOptions = new KubernetesPeerDiscoveryOptions();
|
|
discoveryOptions.Kubernetes.Namespace = "default";
|
|
discoveryOptions.ServiceName = "opcua";
|
|
discoveryOptions.LocalAddress = "10.0.0.10";
|
|
client.EndpointSlices = new KubernetesEndpointSliceList
|
|
{
|
|
Items =
|
|
[
|
|
new KubernetesEndpointSlice
|
|
{
|
|
Endpoints =
|
|
[
|
|
new KubernetesEndpoint
|
|
{
|
|
Addresses = ["10.0.0.10", "10.0.0.11"],
|
|
Conditions = new KubernetesEndpointConditions { Ready = true }
|
|
},
|
|
new KubernetesEndpoint
|
|
{
|
|
Addresses = ["10.0.0.12"],
|
|
Conditions = new KubernetesEndpointConditions { Ready = false }
|
|
}
|
|
],
|
|
Ports = [new KubernetesEndpointPort { Name = "opcua-tcp", Port = 4840 }]
|
|
}
|
|
]
|
|
};
|
|
var discovery = new KubernetesPeerDiscovery(client, discoveryOptions);
|
|
|
|
ArrayOf<string> peers = await discovery.RefreshAsync().ConfigureAwait(false);
|
|
|
|
await Assert.That(peers.Count).IsEqualTo(1);
|
|
await Assert.That(peers[0]).IsEqualTo("opc.tcp://10.0.0.11:4840");
|
|
}
|
|
|
|
[Test]
|
|
public async Task BaseMirrorStoresRoundTripProtectedSessionAndSubscriptionAsync()
|
|
{
|
|
using var kv = new InMemorySharedKeyValueStore();
|
|
using var protector = new AesCbcHmacRecordProtector(MakeKey(31));
|
|
ITelemetryContext telemetry = DefaultTelemetry.Create(builder =>
|
|
builder.SetMinimumLevel(LogLevel.Warning));
|
|
var context = ServiceMessageContext.CreateEmpty(telemetry);
|
|
var sessionStore = new SharedKeyValueSessionStore(kv, context, protector);
|
|
var token = new NodeId(Guid.NewGuid(), 1);
|
|
var entry = new SharedSessionEntry
|
|
{
|
|
SessionId = new NodeId(Guid.NewGuid(), 1),
|
|
AuthenticationToken = token,
|
|
SessionName = "aot-session",
|
|
CreatedAt = DateTime.UtcNow,
|
|
LastActivatedAt = DateTime.UtcNow,
|
|
ServerNonce = ByteString.From(new byte[] { 1, 2, 3 }),
|
|
ClientNonce = ByteString.From(new byte[] { 4, 5, 6 }),
|
|
SecurityPolicyUri = SecurityPolicies.None,
|
|
SecurityMode = (int)MessageSecurityMode.None,
|
|
EndpointUrl = "opc.tcp://localhost:4840",
|
|
SessionTimeout = 60000,
|
|
ClientDescription = new ApplicationDescription
|
|
{
|
|
ApplicationUri = "urn:aot-client",
|
|
ApplicationType = ApplicationType.Client
|
|
},
|
|
SecretMaterial = ByteString.From(new byte[] { 7, 8, 9 })
|
|
};
|
|
|
|
await sessionStore.PutAsync(entry).ConfigureAwait(false);
|
|
SharedSessionEntry? restored = await sessionStore.TryGetAsync(token).ConfigureAwait(false);
|
|
|
|
await Assert.That(restored).IsNotNull();
|
|
await Assert.That(restored!.SessionName).IsEqualTo("aot-session");
|
|
|
|
await using var subscriptionStore = new SharedKeyValueSubscriptionStore(kv, context, protector);
|
|
var subscription = new StoredSubscription
|
|
{
|
|
Id = 42,
|
|
IsDurable = true,
|
|
MaxLifetimeCount = 120,
|
|
MaxKeepaliveCount = 12,
|
|
MaxMessageCount = 8,
|
|
MaxNotificationsPerPublish = 16,
|
|
PublishingInterval = 250,
|
|
Priority = 7,
|
|
SentMessages = [],
|
|
UserIdentityToken = new AnonymousIdentityToken(),
|
|
MonitoredItems =
|
|
[
|
|
new StoredMonitoredItem
|
|
{
|
|
AttributeId = Attributes.Value,
|
|
ClientHandle = 100,
|
|
Id = 500,
|
|
NodeId = new NodeId("Temperature", 2),
|
|
MonitoringMode = MonitoringMode.Reporting,
|
|
QueueSize = 10,
|
|
SamplingInterval = 100,
|
|
SubscriptionId = 42,
|
|
TimestampsToReturn = TimestampsToReturn.Both,
|
|
FilterToUse = new DataChangeFilter
|
|
{
|
|
Trigger = DataChangeTrigger.StatusValue,
|
|
DeadbandType = (uint)DeadbandType.Absolute,
|
|
DeadbandValue = 1
|
|
}
|
|
}
|
|
]
|
|
};
|
|
|
|
await subscriptionStore.StoreSubscriptionsAsync([subscription]).ConfigureAwait(false);
|
|
RestoreSubscriptionResult result = await subscriptionStore.RestoreSubscriptionsAsync().ConfigureAwait(false);
|
|
List<IStoredSubscription> subscriptions = [.. result.Subscriptions!];
|
|
|
|
await Assert.That(result.Success).IsTrue();
|
|
await Assert.That(subscriptions.Count).IsEqualTo(1);
|
|
await Assert.That(subscriptions[0].Id).IsEqualTo(42u);
|
|
}
|
|
|
|
private static byte[] MakeKey(byte seed)
|
|
{
|
|
byte[] key = new byte[32];
|
|
for (int ii = 0; ii < key.Length; ii++)
|
|
{
|
|
key[ii] = (byte)(seed + ii);
|
|
}
|
|
return key;
|
|
}
|
|
|
|
[Test]
|
|
public async Task MonitoredItemQueueMirrorRoundTripsUnderAotAsync()
|
|
{
|
|
using var kv = new InMemorySharedKeyValueStore();
|
|
using var protector = new AesCbcHmacRecordProtector(MakeKey(47));
|
|
ITelemetryContext telemetry = DefaultTelemetry.Create(builder =>
|
|
builder.SetMinimumLevel(LogLevel.Warning));
|
|
var context = ServiceMessageContext.CreateEmpty(telemetry);
|
|
|
|
await using (var factory = new SharedKeyValueMonitoredItemQueueFactory(
|
|
kv, context, protector, telemetry))
|
|
{
|
|
IDataChangeMonitoredItemQueue dataQueue = factory.CreateDataChangeQueue(false, 77);
|
|
dataQueue.ResetQueue(4, false);
|
|
dataQueue.Enqueue(new DataValue(new Variant(101)), ServiceResult.Good);
|
|
|
|
IEventMonitoredItemQueue eventQueue = factory.CreateEventQueue(false, 78);
|
|
eventQueue.SetQueueSize(4, true);
|
|
eventQueue.Enqueue(new EventFieldList { ClientHandle = 9, EventFields = [new Variant(true)] });
|
|
|
|
await factory.FlushAsync().ConfigureAwait(false);
|
|
}
|
|
|
|
await using var restoreFactory = new SharedKeyValueMonitoredItemQueueFactory(
|
|
kv, context, protector, telemetry);
|
|
IDataChangeMonitoredItemQueue? restoredData = await restoreFactory
|
|
.RestoreDataChangeQueueAsync(77)
|
|
.ConfigureAwait(false);
|
|
IEventMonitoredItemQueue? restoredEvent = await restoreFactory
|
|
.RestoreEventQueueAsync(78)
|
|
.ConfigureAwait(false);
|
|
|
|
await Assert.That(restoredData).IsNotNull();
|
|
await Assert.That(restoredData!.ItemsInQueue).IsEqualTo(1);
|
|
await Assert.That(restoredEvent).IsNotNull();
|
|
await Assert.That(restoredEvent!.ItemsInQueue).IsEqualTo(1);
|
|
}
|
|
|
|
private sealed class FakeKubernetesApiClient : IKubernetesApiClient
|
|
{
|
|
public bool IsInCluster => true;
|
|
|
|
public KubernetesLease? Lease { get; set; }
|
|
|
|
public KubernetesEndpointSliceList EndpointSlices { get; set; } = new();
|
|
|
|
public ValueTask<KubernetesLease?> GetLeaseAsync(
|
|
string namespaceName,
|
|
string name,
|
|
CancellationToken ct)
|
|
{
|
|
return new ValueTask<KubernetesLease?>(Lease);
|
|
}
|
|
|
|
public ValueTask<KubernetesLease> CreateLeaseAsync(
|
|
string namespaceName,
|
|
KubernetesLease lease,
|
|
CancellationToken ct)
|
|
{
|
|
Lease = lease;
|
|
return new ValueTask<KubernetesLease>(lease);
|
|
}
|
|
|
|
public ValueTask<KubernetesLease> ReplaceLeaseAsync(
|
|
string namespaceName,
|
|
string name,
|
|
KubernetesLease lease,
|
|
CancellationToken ct)
|
|
{
|
|
Lease = lease;
|
|
return new ValueTask<KubernetesLease>(lease);
|
|
}
|
|
|
|
public ValueTask DeleteLeaseAsync(string namespaceName, string name, CancellationToken ct)
|
|
{
|
|
Lease = null;
|
|
return default;
|
|
}
|
|
|
|
public ValueTask<KubernetesEndpointSliceList> ListEndpointSlicesAsync(
|
|
string namespaceName,
|
|
string serviceName,
|
|
CancellationToken ct)
|
|
{
|
|
return new ValueTask<KubernetesEndpointSliceList>(EndpointSlices);
|
|
}
|
|
}
|
|
}
|
|
}
|