Files
UA-.NETStandard/tests/Opc.Ua.Client.Tests/ClientBuilder/ManagedSessionBuilderTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

132 lines
5.3 KiB
C#

// ------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License (MIT). See License.txt in the repo root for license information.
// ------------------------------------------------------------
using System;
using NUnit.Framework;
using Opc.Ua.Tests;
namespace Opc.Ua.Client.Tests.ClientBuilder
{
[TestFixture]
[Category("Client")]
[Category("ClientBuilder")]
[SetCulture("en-us")]
[SetUICulture("en-us")]
[Parallelizable]
public sealed class ManagedSessionBuilderTests
{
private static ApplicationConfiguration CreateConfig(ITelemetryContext telemetry)
{
return new ApplicationConfiguration(telemetry)
{
ApplicationUri = "urn:test:client",
ApplicationName = "test",
ClientConfiguration = new ClientConfiguration()
};
}
[Test]
public void BuildReturnsDefaultsWhenNotConfigured()
{
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
var builder = new ManagedSessionBuilder(CreateConfig(telemetry), telemetry);
ManagedSessionOptions opts = builder.Build();
Assert.That(opts, Is.Not.Null);
Assert.That(opts.SessionName, Is.EqualTo("ManagedSession"));
Assert.That(opts.SessionTimeout, Is.EqualTo(TimeSpan.FromSeconds(60)));
Assert.That(opts.CheckDomain, Is.False);
Assert.That(opts.EnableServerRedundancy, Is.False);
Assert.That(opts.ReconnectPolicy.Strategy, Is.EqualTo(BackoffStrategy.Exponential));
Assert.That(opts.Endpoint, Is.Null);
Assert.That(opts.SubscriptionEngineFactory, Is.Null);
}
[Test]
public void WithMethodsCaptureValuesIntoSnapshot()
{
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
var endpoint = new ConfiguredEndpoint(null, new EndpointDescription
{
EndpointUrl = "opc.tcp://localhost:4840"
}, configuration: null);
ManagedSessionBuilder builder = new ManagedSessionBuilder(CreateConfig(telemetry), telemetry)
.UseEndpoint(endpoint)
.WithSessionName("Custom")
.WithSessionTimeout(TimeSpan.FromSeconds(30))
.WithPreferredLocales("en-US", "de-DE")
.WithCheckDomain()
.WithReconnectPolicy(p => p with
{
Strategy = BackoffStrategy.Linear,
MaxRetries = 5
})
.WithServerRedundancy();
ManagedSessionOptions opts = builder.Build();
Assert.That(opts.Endpoint, Is.SameAs(endpoint));
Assert.That(opts.SessionName, Is.EqualTo("Custom"));
Assert.That(opts.SessionTimeout, Is.EqualTo(TimeSpan.FromSeconds(30)));
Assert.That(opts.PreferredLocales, Is.EquivalentTo(["en-US", "de-DE"]));
Assert.That(opts.CheckDomain, Is.True);
Assert.That(opts.ReconnectPolicy.Strategy, Is.EqualTo(BackoffStrategy.Linear));
Assert.That(opts.ReconnectPolicy.MaxRetries, Is.EqualTo(5));
Assert.That(opts.EnableServerRedundancy, Is.True);
}
[Test]
public void ConnectAsyncWithoutEndpointThrows()
{
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
var builder = new ManagedSessionBuilder(CreateConfig(telemetry), telemetry);
Assert.That(() => builder.ConnectAsync().GetAwaiter().GetResult(),
Throws.InvalidOperationException);
}
[Test]
public void NullArgumentsThrow()
{
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
Assert.That(() => new ManagedSessionBuilder(null!, telemetry),
Throws.ArgumentNullException);
Assert.That(() => new ManagedSessionBuilder(CreateConfig(telemetry), null!),
Throws.ArgumentNullException);
var builder = new ManagedSessionBuilder(CreateConfig(telemetry), telemetry);
#pragma warning disable IDE0004 // Remove Unnecessary Cast
Assert.That(() => builder.UseEndpoint((ConfiguredEndpoint)null!),
Throws.ArgumentNullException);
#pragma warning restore IDE0004 // Remove Unnecessary Cast
Assert.That(() => builder.UseEndpoint((string)null!),
Throws.ArgumentNullException);
Assert.That(() => builder.WithSessionName(string.Empty),
Throws.ArgumentException);
Assert.That(() => builder.WithSessionTimeout(TimeSpan.Zero),
Throws.InstanceOf<ArgumentOutOfRangeException>());
}
[Test]
public void ReconnectPolicyOptionsBackedReconnectPolicy()
{
var options = new ReconnectPolicyOptions
{
Strategy = BackoffStrategy.Linear,
MaxRetries = 3,
JitterFactor = 0
};
var policy = new ReconnectPolicy(options);
Assert.That(policy.Strategy, Is.EqualTo(BackoffStrategy.Linear));
Assert.That(policy.MaxRetries, Is.EqualTo(3));
Assert.That(policy.JitterFactor, Is.Zero);
}
}
}