Files
UA-.NETStandard/tests/Opc.Ua.Client.Tests/Session/DefaultSubscriptionEngineTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

417 lines
14 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Threading;
using System.Threading.Tasks;
using Moq;
using NUnit.Framework;
using Opc.Ua.Client.Subscriptions;
using Opc.Ua.Client.Subscriptions.Engine;
using Opc.Ua.Tests;
// CA2000: test code; many disposables are ownership-transferred to test fixtures or short-lived,
// making CA2000 noisy without a real leak risk. Disabled file-level for the suite (the existing
// narrow-scope pragma below at line ~163 predates the file-level decision).
#pragma warning disable CA2000
namespace Opc.Ua.Client.Tests
{
[TestFixture]
[Parallelizable]
[Category("Client")]
[Category("DefaultSubscriptionEngine")]
public class DefaultSubscriptionEngineTests
{
private ITelemetryContext m_telemetry;
private Mock<ISubscriptionEngineContext> m_mockContext;
[SetUp]
public void SetUp()
{
m_telemetry = NUnitTelemetryContext.Create();
m_mockContext = new Mock<ISubscriptionEngineContext>();
m_mockContext
.Setup(c => c.SessionId)
.Returns(new NodeId(1));
m_mockContext
.Setup(c => c.Disposed)
.Returns(false);
m_mockContext
.Setup(c => c.Reconnecting)
.Returns(false);
m_mockContext
.Setup(c => c.Connected)
.Returns(false);
m_mockContext
.Setup(c => c.Closing)
.Returns(false);
m_mockContext
.Setup(c => c.Telemetry)
.Returns(m_telemetry);
m_mockContext
.Setup(c => c.OperationTimeout)
.Returns(60000);
m_mockContext
.Setup(c => c.ReturnDiagnostics)
.Returns(DiagnosticsMasks.None);
m_mockContext
.Setup(c => c.ReconnectLock)
.Returns(new SemaphoreSlim(1, 1));
m_mockContext
.Setup(c => c.GoodPublishRequestCount)
.Returns(0);
#if OPCUA_V1_CLIENT
m_mockContext
.Setup(c => c.Subscriptions)
.Returns(new List<Subscription>());
#endif
}
[Test]
public void FactoryCreateReturnsV2Engine()
{
ISubscriptionEngine engine =
DefaultSubscriptionEngineFactory.Instance.Create(
m_mockContext.Object);
Assert.That(engine, Is.Not.Null);
Assert.That(
engine,
Is.InstanceOf<DefaultSubscriptionEngine>());
engine.Dispose();
}
[Test]
public void FactoryInstanceIsSingleton()
{
DefaultSubscriptionEngineFactory first =
DefaultSubscriptionEngineFactory.Instance;
DefaultSubscriptionEngineFactory second =
DefaultSubscriptionEngineFactory.Instance;
Assert.That(first, Is.SameAs(second));
}
[Test]
public void ConstructorThrowsOnNullContext()
{
Assert.That(
() => new DefaultSubscriptionEngine(null!),
Throws.TypeOf<ArgumentNullException>());
}
[Test]
public void SubscriptionContextReportsRevisedSessionTimeout()
{
m_mockContext
.Setup(c => c.OperationTimeout)
.Returns(120000);
m_mockContext
.Setup(c => c.SessionTimeout)
.Returns(60000);
var context =
new DefaultSubscriptionEngine.SubscriptionContextAdapter(
m_mockContext.Object);
Assert.That(
context.SessionTimeout,
Is.EqualTo(TimeSpan.FromSeconds(60)));
}
[TestCase(0.0)]
[TestCase(-1.0)]
[TestCase(double.NaN)]
[TestCase(double.PositiveInfinity)]
[TestCase(1e300)]
public void SubscriptionContextReportsZeroForUnusableSessionTimeout(
double sessionTimeout)
{
m_mockContext
.Setup(c => c.SessionTimeout)
.Returns(sessionTimeout);
var context =
new DefaultSubscriptionEngine.SubscriptionContextAdapter(
m_mockContext.Object);
Assert.That(context.SessionTimeout, Is.EqualTo(TimeSpan.Zero));
}
[Test]
public void StartPublishingDoesNotThrow()
{
using var engine =
new DefaultSubscriptionEngine(m_mockContext.Object);
Assert.That(
() => engine.StartPublishing(timeout: 5000, fullQueue: false),
Throws.Nothing);
}
[Test]
public void PauseAndResumeDoNotThrow()
{
using var engine =
new DefaultSubscriptionEngine(m_mockContext.Object);
Assert.That(engine.PausePublishing, Throws.Nothing);
Assert.That(engine.ResumePublishing, Throws.Nothing);
}
[Test]
public async Task StopPublishingDisposesCleanlyAsync()
{
using var engine =
new DefaultSubscriptionEngine(m_mockContext.Object);
await engine.StopPublishingAsync(CancellationToken.None)
.ConfigureAwait(false);
}
[Test]
public void DisposeIsIdempotent()
{
#pragma warning disable CA2000 // Dispose objects before losing scope
var engine =
new DefaultSubscriptionEngine(m_mockContext.Object);
#pragma warning restore CA2000 // Dispose objects before losing scope
Assert.That(engine.Dispose, Throws.Nothing);
Assert.That(engine.Dispose, Throws.Nothing);
}
[Test]
public void NotifySubscriptionsChangedDoesNotThrow()
{
using var engine =
new DefaultSubscriptionEngine(m_mockContext.Object);
Assert.That(
engine.NotifySubscriptionsChanged,
Throws.Nothing);
}
[Test]
public void GoodPublishRequestCountDefaultsToZero()
{
using var engine =
new DefaultSubscriptionEngine(m_mockContext.Object);
Assert.That(
engine.GoodPublishRequestCount, Is.Zero);
}
[Test]
public void BadPublishRequestCountDefaultsToZero()
{
using var engine =
new DefaultSubscriptionEngine(m_mockContext.Object);
Assert.That(
engine.BadPublishRequestCount, Is.Zero);
}
[Test]
public void MinMaxPublishRequestCountCanBeSet()
{
using var engine =
new DefaultSubscriptionEngine(m_mockContext.Object);
engine.MinPublishRequestCount = 3;
engine.MaxPublishRequestCount = 20;
Assert.That(
engine.MinPublishRequestCount, Is.EqualTo(3));
Assert.That(
engine.MaxPublishRequestCount, Is.EqualTo(20));
}
[Test]
public void BridgeConstructorThrowsOnNullSink()
{
Assert.That(
() => new SubscriptionBridge(null!),
Throws.TypeOf<ArgumentNullException>());
}
[Test]
public void BridgeCanBeInstantiated()
{
var sink = new RecordingSubscriptionMessageSink();
var bridge = new SubscriptionBridge(sink);
Assert.That(bridge, Is.Not.Null);
}
[Test]
public async Task BridgeOnKeepAliveForwardsToCacheSinkAsync()
{
var sink = new RecordingSubscriptionMessageSink();
var bridge = new SubscriptionBridge(sink);
var mockSubscription = new Mock<ISubscription>();
await bridge.OnKeepAliveNotificationAsync(
mockSubscription.Object,
sequenceNumber: 1,
publishTime: DateTime.UtcNow,
publishStateMask: PublishState.None)
.ConfigureAwait(false);
Assert.That(sink.Calls, Has.Count.EqualTo(1));
Assert.That(sink.Calls[0].Message.SequenceNumber, Is.EqualTo(1u));
}
[Test]
public async Task BridgeOnDataChangeForwardsToCacheSinkAsync()
{
var sink = new RecordingSubscriptionMessageSink();
var bridge = new SubscriptionBridge(sink);
var mockSubscription = new Mock<ISubscription>();
var changes = new DataValueChange[]
{
new(
MonitoredItem: null,
Value: new DataValue(new Variant(42)),
DiagnosticInfo: null)
};
await bridge.OnDataChangeNotificationAsync(
mockSubscription.Object,
sequenceNumber: 5,
publishTime: DateTime.UtcNow,
notification: changes.AsMemory(),
publishStateMask: PublishState.None,
stringTable: [])
.ConfigureAwait(false);
Assert.That(sink.Calls, Has.Count.EqualTo(1));
Assert.That(sink.Calls[0].Message.SequenceNumber, Is.EqualTo(5u));
}
[Test]
public async Task BridgeOnEventNotificationForwardsToCacheSinkAsync()
{
var sink = new RecordingSubscriptionMessageSink();
var bridge = new SubscriptionBridge(sink);
var mockSubscription = new Mock<ISubscription>();
var events = new EventNotification[]
{
new(
MonitoredItem: null,
Fields: new ArrayOf<Variant>(
new[] { new Variant("event-data") }))
};
await bridge.OnEventDataNotificationAsync(
mockSubscription.Object,
sequenceNumber: 10,
publishTime: DateTime.UtcNow,
notification: events.AsMemory(),
publishStateMask: PublishState.None,
stringTable: ["ns-entry"])
.ConfigureAwait(false);
Assert.That(sink.Calls, Has.Count.EqualTo(1));
Assert.That(sink.Calls[0].Message.SequenceNumber, Is.EqualTo(10u));
}
[Test]
public async Task BridgeDataChangeWithDiagnosticsPreservesDiagnosticInfoAsync()
{
var sink = new RecordingSubscriptionMessageSink();
var bridge = new SubscriptionBridge(sink);
var mockSubscription = new Mock<ISubscription>();
var diag = new DiagnosticInfo
{
AdditionalInfo = "test-diag"
};
var changes = new DataValueChange[]
{
new(
MonitoredItem: null,
Value: new DataValue(new Variant(1)),
DiagnosticInfo: diag)
};
await bridge.OnDataChangeNotificationAsync(
mockSubscription.Object,
sequenceNumber: 7,
publishTime: DateTime.UtcNow,
notification: changes.AsMemory(),
publishStateMask: PublishState.None,
stringTable: [])
.ConfigureAwait(false);
Assert.That(sink.Calls, Has.Count.EqualTo(1));
NotificationMessage captured = sink.Calls[0].Message;
Assert.That(
captured.NotificationData.Count, Is.EqualTo(1));
ExtensionObject ext = captured.NotificationData[0];
Assert.That(
ext.TryGetValue(
out DataChangeNotification? dcn),
Is.True);
Assert.That(
dcn!.DiagnosticInfos.Count, Is.EqualTo(1));
Assert.That(
dcn.DiagnosticInfos[0].AdditionalInfo,
Is.EqualTo("test-diag"));
}
/// <summary>
/// Hand-rolled fake for <see cref="ISubscriptionMessageSink"/>
/// (internal interface) that records every <c>SaveMessageInCache</c>
/// call. Replaces a Moq-driven mock so that the test assembly does
/// not need <c>InternalsVisibleTo("DynamicProxyGenAssembly2")</c>
/// on the production assembly.
/// </summary>
private sealed class RecordingSubscriptionMessageSink
: ISubscriptionMessageSink
{
public List<(ArrayOf<uint> AvailableSequenceNumbers, NotificationMessage Message)> Calls { get; } = [];
public void SaveMessageInCache(
ArrayOf<uint> availableSequenceNumbers,
NotificationMessage message)
{
Calls.Add((availableSequenceNumbers, message));
}
}
}
}