mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-20 16:52:07 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
469 lines
17 KiB
C#
469 lines
17 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Reflection;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Tests;
|
|
|
|
#pragma warning disable CA2000, CA2007
|
|
|
|
namespace Opc.Ua.Client.Tests
|
|
{
|
|
[TestFixture]
|
|
[Parallelizable]
|
|
[Category("Client")]
|
|
[Category("SessionEngineContext")]
|
|
public sealed class SessionEngineContextTests
|
|
{
|
|
[Test]
|
|
public void CapturedContextExposesSessionStateAndServices()
|
|
{
|
|
using TestSessionScope scope = CreateSessionScope();
|
|
|
|
ISubscriptionEngineContext context = scope.Context;
|
|
|
|
Assert.Multiple(() =>
|
|
{
|
|
Assert.That(context.Connected, Is.False);
|
|
Assert.That(context.Reconnecting, Is.False);
|
|
Assert.That(context.Closing, Is.False);
|
|
Assert.That(context.Disposed, Is.False);
|
|
Assert.That(context.DeleteSubscriptionsOnClose, Is.True);
|
|
Assert.That(context.OperationTimeout, Is.Zero);
|
|
Assert.That(context.SessionTimeout, Is.EqualTo(scope.Session.SessionTimeout));
|
|
Assert.That(context.ServerState, Is.EqualTo(ServerState.Running));
|
|
Assert.That(context.ReturnDiagnostics, Is.EqualTo(DiagnosticsMasks.None));
|
|
Assert.That(context.Telemetry, Is.SameAs(scope.Telemetry));
|
|
Assert.That(context.Subscriptions, Is.Empty);
|
|
Assert.That(context.ReconnectLock, Is.Not.Null);
|
|
Assert.That(context.GoodPublishRequestCount, Is.Zero);
|
|
Assert.That(context.SubscriptionServiceSet, Is.SameAs(scope.Session));
|
|
Assert.That(context.MonitoredItemServiceSet, Is.SameAs(scope.Session));
|
|
Assert.That(context.MethodServiceSet, Is.SameAs(scope.Session));
|
|
});
|
|
}
|
|
|
|
[Test]
|
|
public void KeepAliveCallbacksAreForwardedToSessionEvents()
|
|
{
|
|
using TestSessionScope scope = CreateSessionScope();
|
|
DateTime timestamp = DateTime.UtcNow;
|
|
KeepAliveEventArgs? keepAliveArgs = null;
|
|
|
|
scope.Session.KeepAlive += (_, e) => keepAliveArgs = e;
|
|
|
|
scope.Context.OnKeepAlive(ServerState.Running, timestamp);
|
|
|
|
Assert.That(keepAliveArgs, Is.Not.Null);
|
|
Assert.Multiple(() =>
|
|
{
|
|
Assert.That(keepAliveArgs!.CurrentState, Is.EqualTo(ServerState.Running));
|
|
Assert.That(keepAliveArgs.CurrentTime, Is.EqualTo(timestamp));
|
|
Assert.That(scope.Context.ServerState, Is.EqualTo(ServerState.Running));
|
|
});
|
|
}
|
|
|
|
[Test]
|
|
public void KeepAliveErrorsAreForwardedToSessionEvents()
|
|
{
|
|
using TestSessionScope scope = CreateSessionScope();
|
|
KeepAliveEventArgs? keepAliveArgs = null;
|
|
|
|
scope.Session.KeepAlive += (_, e) => keepAliveArgs = e;
|
|
|
|
scope.Context.OnKeepAliveError(new ServiceResult(StatusCodes.BadTimeout));
|
|
|
|
Assert.That(keepAliveArgs, Is.Not.Null);
|
|
ServiceResult status = keepAliveArgs!.Status!;
|
|
Assert.That(status.StatusCode, Is.EqualTo(StatusCodes.BadTimeout));
|
|
}
|
|
|
|
[Test]
|
|
public void PublishErrorsAreForwardedToSessionEvents()
|
|
{
|
|
using TestSessionScope scope = CreateSessionScope();
|
|
PublishErrorEventArgs? publishErrorArgs = null;
|
|
|
|
scope.Session.PublishError += (_, e) => publishErrorArgs = e;
|
|
|
|
scope.Context.OnPublishError(
|
|
new ServiceResult(StatusCodes.BadNoSubscription),
|
|
subscriptionId: 123,
|
|
sequenceNumber: 456);
|
|
|
|
Assert.That(publishErrorArgs, Is.Not.Null);
|
|
Assert.Multiple(() =>
|
|
{
|
|
Assert.That(publishErrorArgs!.Status.StatusCode, Is.EqualTo(StatusCodes.BadNoSubscription));
|
|
Assert.That(publishErrorArgs.SubscriptionId, Is.EqualTo(123u));
|
|
Assert.That(publishErrorArgs.SequenceNumber, Is.EqualTo(456u));
|
|
});
|
|
}
|
|
|
|
[Test]
|
|
public void PrepareAcknowledgementsWithoutCallbackSendsAllAcknowledgements()
|
|
{
|
|
using TestSessionScope scope = CreateSessionScope();
|
|
var acknowledgements = new List<SubscriptionAcknowledgement>
|
|
{
|
|
new()
|
|
{
|
|
SubscriptionId = 1,
|
|
SequenceNumber = 2
|
|
}
|
|
};
|
|
|
|
(List<SubscriptionAcknowledgement> toSend, List<SubscriptionAcknowledgement> updatedPending) =
|
|
scope.Context.PrepareAcknowledgementsToSend(acknowledgements);
|
|
|
|
Assert.Multiple(() =>
|
|
{
|
|
Assert.That(toSend, Is.SameAs(acknowledgements));
|
|
Assert.That(updatedPending, Is.Empty);
|
|
});
|
|
}
|
|
|
|
[Test]
|
|
public void PrepareAcknowledgementsCallbackCanDeferAcknowledgements()
|
|
{
|
|
using TestSessionScope scope = CreateSessionScope();
|
|
var acknowledgement = new SubscriptionAcknowledgement
|
|
{
|
|
SubscriptionId = 1,
|
|
SequenceNumber = 2
|
|
};
|
|
var acknowledgements = new List<SubscriptionAcknowledgement>
|
|
{
|
|
acknowledgement
|
|
};
|
|
|
|
scope.Session.PublishSequenceNumbersToAcknowledge += (_, e) =>
|
|
{
|
|
e.AcknowledgementsToSend.Remove(acknowledgement);
|
|
e.DeferredAcknowledgementsToSend.Add(acknowledgement);
|
|
};
|
|
|
|
(List<SubscriptionAcknowledgement> toSend, List<SubscriptionAcknowledgement> updatedPending) =
|
|
scope.Context.PrepareAcknowledgementsToSend(acknowledgements);
|
|
|
|
Assert.Multiple(() =>
|
|
{
|
|
Assert.That(toSend, Is.SameAs(acknowledgements));
|
|
Assert.That(toSend, Is.Empty);
|
|
Assert.That(updatedPending, Has.Count.EqualTo(1));
|
|
Assert.That(updatedPending[0], Is.SameAs(acknowledgement));
|
|
});
|
|
}
|
|
|
|
[Test]
|
|
public void PrepareAcknowledgementsCallbackFailureFallsBackToSendingAllAcknowledgements()
|
|
{
|
|
using TestSessionScope scope = CreateSessionScope();
|
|
var acknowledgements = new List<SubscriptionAcknowledgement>
|
|
{
|
|
new()
|
|
{
|
|
SubscriptionId = 1,
|
|
SequenceNumber = 2
|
|
}
|
|
};
|
|
|
|
scope.Session.PublishSequenceNumbersToAcknowledge += (_, _) => throw new InvalidOperationException();
|
|
|
|
(List<SubscriptionAcknowledgement> toSend, List<SubscriptionAcknowledgement> updatedPending) =
|
|
scope.Context.PrepareAcknowledgementsToSend(acknowledgements);
|
|
|
|
Assert.Multiple(() =>
|
|
{
|
|
Assert.That(toSend, Is.SameAs(acknowledgements));
|
|
Assert.That(updatedPending, Is.Empty);
|
|
});
|
|
}
|
|
|
|
[Test]
|
|
public void PublishNotificationsAreForwardedAsynchronously()
|
|
{
|
|
using TestSessionScope scope = CreateSessionScope();
|
|
using var received = new ManualResetEventSlim();
|
|
NotificationEventArgs? receivedArgs = null;
|
|
var subscription = new Subscription(scope.Telemetry);
|
|
SetSubscriptionId(subscription, 42);
|
|
var args = new NotificationEventArgs(
|
|
subscription,
|
|
new NotificationMessage(),
|
|
new ArrayOf<string>());
|
|
|
|
scope.Session.Notification += (_, e) =>
|
|
{
|
|
receivedArgs = e;
|
|
received.Set();
|
|
};
|
|
|
|
scope.Context.OnPublishNotification(subscription, args);
|
|
|
|
Assert.That(received.Wait(TimeSpan.FromSeconds(5)), Is.True);
|
|
Assert.That(receivedArgs, Is.SameAs(args));
|
|
}
|
|
|
|
[Test]
|
|
public void PublishNotificationHandlerFailureIsSwallowed()
|
|
{
|
|
using TestSessionScope scope = CreateSessionScope();
|
|
var subscription = new Subscription(scope.Telemetry);
|
|
SetSubscriptionId(subscription, 42);
|
|
var args = new NotificationEventArgs(
|
|
subscription,
|
|
new NotificationMessage(),
|
|
new ArrayOf<string>());
|
|
|
|
scope.Session.Notification += (_, _) => throw new InvalidOperationException();
|
|
|
|
Assert.That(
|
|
() => scope.Context.OnPublishNotification(subscription, args),
|
|
Throws.Nothing);
|
|
}
|
|
|
|
[Test]
|
|
public async Task ServiceMethodsDelegateToSessionAsync()
|
|
{
|
|
using TestSessionScope scope = CreateSessionScope();
|
|
|
|
Assert.That(
|
|
async () => await scope.Context.PublishAsync(
|
|
new RequestHeader(),
|
|
new ArrayOf<SubscriptionAcknowledgement>(),
|
|
CancellationToken.None).ConfigureAwait(false),
|
|
Throws.TypeOf<ServiceResultException>());
|
|
Assert.That(
|
|
async () => await scope.Context.TransferSubscriptionsAsync(
|
|
null,
|
|
new ArrayOf<uint>(new uint[] { 1 }),
|
|
sendInitialValues: true,
|
|
CancellationToken.None).ConfigureAwait(false),
|
|
Throws.TypeOf<ServiceResultException>());
|
|
Assert.That(
|
|
async () => await scope.Context.DeleteSubscriptionsAsync(
|
|
null,
|
|
new ArrayOf<uint>(new uint[] { 1 }),
|
|
CancellationToken.None).ConfigureAwait(false),
|
|
Throws.TypeOf<ServiceResultException>());
|
|
Assert.That(
|
|
async () => await scope.Context.DeleteOrphanedSubscriptionAsync(1).ConfigureAwait(false),
|
|
Throws.Nothing);
|
|
|
|
await Task.CompletedTask.ConfigureAwait(false);
|
|
}
|
|
|
|
[Test]
|
|
public void AsyncRequestTrackingDelegatesToSession()
|
|
{
|
|
using TestSessionScope scope = CreateSessionScope();
|
|
Task task = Task.CompletedTask;
|
|
|
|
Assert.That(
|
|
() => scope.Context.AsyncRequestStarted(
|
|
task,
|
|
activity: null,
|
|
requestHandle: 1,
|
|
requestTypeId: DataTypes.PublishRequest),
|
|
Throws.Nothing);
|
|
Assert.That(
|
|
() => scope.Context.AsyncRequestCompleted(
|
|
task,
|
|
requestHandle: 1,
|
|
requestTypeId: DataTypes.PublishRequest),
|
|
Throws.Nothing);
|
|
}
|
|
|
|
private static TestSessionScope CreateSessionScope()
|
|
{
|
|
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
|
|
ApplicationConfiguration configuration = CreateClientConfiguration(telemetry);
|
|
IServiceMessageContext messageContext = configuration.CreateMessageContext();
|
|
var channel = new Mock<ITransportChannel>();
|
|
channel.SetupGet(c => c.MessageContext).Returns(messageContext);
|
|
|
|
var engineFactory = new CapturingEngineFactory();
|
|
var session = new Session(
|
|
channel.Object,
|
|
configuration,
|
|
CreateEndpoint(),
|
|
engineFactory: engineFactory);
|
|
|
|
return new TestSessionScope(session, engineFactory.Context!, telemetry);
|
|
}
|
|
|
|
private static ApplicationConfiguration CreateClientConfiguration(
|
|
ITelemetryContext telemetry)
|
|
{
|
|
return new ApplicationConfiguration(telemetry)
|
|
{
|
|
ApplicationName = "SessionEngineContextTests",
|
|
ApplicationType = ApplicationType.Client,
|
|
ApplicationUri = "urn:localhost:SessionEngineContextTests",
|
|
ProductUri = "urn:localhost:SessionEngineContextTests",
|
|
ClientConfiguration = new ClientConfiguration
|
|
{
|
|
DefaultSessionTimeout = 60000,
|
|
MinSubscriptionLifetime = 10000
|
|
},
|
|
SecurityConfiguration = new SecurityConfiguration
|
|
{
|
|
ApplicationCertificate = new CertificateIdentifier()
|
|
},
|
|
TransportQuotas = new TransportQuotas
|
|
{
|
|
OperationTimeout = 6000
|
|
}
|
|
};
|
|
}
|
|
|
|
private static ConfiguredEndpoint CreateEndpoint()
|
|
{
|
|
var description = new EndpointDescription
|
|
{
|
|
EndpointUrl = "opc.tcp://localhost:4840",
|
|
SecurityMode = MessageSecurityMode.None,
|
|
SecurityPolicyUri = SecurityPolicies.None,
|
|
TransportProfileUri = Profiles.UaTcpTransport,
|
|
UserIdentityTokens =
|
|
[
|
|
new UserTokenPolicy
|
|
{
|
|
PolicyId = "anonymous",
|
|
TokenType = UserTokenType.Anonymous,
|
|
SecurityPolicyUri = SecurityPolicies.None
|
|
}
|
|
]
|
|
};
|
|
description.Server.ApplicationUri = description.EndpointUrl;
|
|
description.Server.ApplicationType = ApplicationType.Server;
|
|
|
|
return new ConfiguredEndpoint(
|
|
null,
|
|
description,
|
|
new EndpointConfiguration { OperationTimeout = 6000 })
|
|
{
|
|
UpdateBeforeConnect = false
|
|
};
|
|
}
|
|
|
|
private static void SetSubscriptionId(Subscription subscription, uint id)
|
|
{
|
|
PropertyInfo idProperty = typeof(Subscription).GetProperty(nameof(Subscription.Id))!;
|
|
idProperty.SetValue(subscription, id);
|
|
}
|
|
|
|
private sealed class TestSessionScope : IDisposable
|
|
{
|
|
public TestSessionScope(
|
|
Session session,
|
|
ISubscriptionEngineContext context,
|
|
ITelemetryContext telemetry)
|
|
{
|
|
Session = session;
|
|
Context = context;
|
|
Telemetry = telemetry;
|
|
}
|
|
|
|
public Session Session { get; }
|
|
|
|
public ISubscriptionEngineContext Context { get; }
|
|
|
|
public ITelemetryContext Telemetry { get; }
|
|
|
|
public void Dispose()
|
|
{
|
|
Session.Dispose();
|
|
}
|
|
}
|
|
|
|
private sealed class CapturingEngineFactory : ISubscriptionEngineFactory
|
|
{
|
|
public ISubscriptionEngineContext? Context { get; private set; }
|
|
|
|
public ISubscriptionEngine Create(ISubscriptionEngineContext context)
|
|
{
|
|
Context = context;
|
|
return new NoOpSubscriptionEngine();
|
|
}
|
|
}
|
|
|
|
private sealed class NoOpSubscriptionEngine : ISubscriptionEngine
|
|
{
|
|
public int GoodPublishRequestCount => 0;
|
|
|
|
public int BadPublishRequestCount => 0;
|
|
|
|
public int PublishWorkerCount => 0;
|
|
|
|
public int MinPublishRequestCount { get; set; } = 1;
|
|
|
|
public int MaxPublishRequestCount { get; set; } = ushort.MaxValue;
|
|
|
|
public void Dispose()
|
|
{
|
|
}
|
|
|
|
public void NotifySubscriptionsChanged()
|
|
{
|
|
}
|
|
|
|
public void PausePublishing()
|
|
{
|
|
}
|
|
|
|
public ValueTask RecreateSubscriptionsAsync(
|
|
NodeId? previousSessionId,
|
|
CancellationToken ct = default)
|
|
{
|
|
return default;
|
|
}
|
|
|
|
public void ResumePublishing()
|
|
{
|
|
}
|
|
|
|
public void StartPublishing(int timeout, bool fullQueue)
|
|
{
|
|
}
|
|
|
|
public ValueTask StopPublishingAsync(CancellationToken ct = default)
|
|
{
|
|
return default;
|
|
}
|
|
}
|
|
}
|
|
}
|