mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-20 16:52:07 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
335 lines
12 KiB
C#
335 lines
12 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System.Collections.Generic;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Tests;
|
|
|
|
namespace Opc.Ua.Client.Tests
|
|
{
|
|
[TestFixture]
|
|
[Category("Client")]
|
|
[Category("Session")]
|
|
[SetCulture("en-us")]
|
|
[SetUICulture("en-us")]
|
|
public sealed class SessionExtensionsTests
|
|
{
|
|
private Mock<ISession> m_session;
|
|
|
|
[SetUp]
|
|
public void SetUp()
|
|
{
|
|
m_session = new Mock<ISession>(MockBehavior.Strict);
|
|
}
|
|
|
|
[TearDown]
|
|
public void TearDown()
|
|
{
|
|
m_session.Verify();
|
|
}
|
|
|
|
[Test]
|
|
public async Task OpenAsyncWithNameAndIdentityForwardsToFullOverloadAsync()
|
|
{
|
|
var identity = new UserIdentity();
|
|
// ultimately calling the 7-param ISession.OpenAsync
|
|
m_session
|
|
.Setup(s => s.OpenAsync(
|
|
"TestSession",
|
|
0u,
|
|
identity,
|
|
It.IsAny<ArrayOf<string>>(),
|
|
true,
|
|
true,
|
|
It.IsAny<CancellationToken>()))
|
|
.Returns(Task.CompletedTask)
|
|
.Verifiable();
|
|
|
|
await m_session.Object.OpenAsync("TestSession", identity).ConfigureAwait(false);
|
|
|
|
m_session.Verify(s => s.OpenAsync(
|
|
"TestSession",
|
|
0u,
|
|
identity,
|
|
It.IsAny<ArrayOf<string>>(),
|
|
true,
|
|
true,
|
|
It.IsAny<CancellationToken>()), Times.Once);
|
|
}
|
|
|
|
[Test]
|
|
public async Task OpenAsyncWithTimeoutForwardsToFullOverloadAsync()
|
|
{
|
|
var identity = new UserIdentity();
|
|
ArrayOf<string> locales = ["en", "de"];
|
|
|
|
m_session
|
|
.Setup(s => s.OpenAsync(
|
|
"TestSession",
|
|
60000u,
|
|
identity,
|
|
It.IsAny<ArrayOf<string>>(),
|
|
true,
|
|
true,
|
|
It.IsAny<CancellationToken>()))
|
|
.Returns(Task.CompletedTask)
|
|
.Verifiable();
|
|
|
|
await m_session.Object.OpenAsync("TestSession", 60000u, identity, locales).ConfigureAwait(false);
|
|
|
|
m_session.Verify(s => s.OpenAsync(
|
|
"TestSession",
|
|
60000u,
|
|
identity,
|
|
It.IsAny<ArrayOf<string>>(),
|
|
true,
|
|
true,
|
|
It.IsAny<CancellationToken>()), Times.Once);
|
|
}
|
|
|
|
[Test]
|
|
public async Task OpenAsyncWithCheckDomainForwardsToFullOverloadAsync()
|
|
{
|
|
var identity = new UserIdentity();
|
|
ArrayOf<string> locales = ["en"];
|
|
|
|
m_session
|
|
.Setup(s => s.OpenAsync(
|
|
"TestSession",
|
|
30000u,
|
|
identity,
|
|
It.IsAny<ArrayOf<string>>(),
|
|
false,
|
|
true,
|
|
It.IsAny<CancellationToken>()))
|
|
.Returns(Task.CompletedTask)
|
|
.Verifiable();
|
|
|
|
await m_session.Object.OpenAsync("TestSession", 30000u, identity, locales, false).ConfigureAwait(false);
|
|
|
|
m_session.Verify(s => s.OpenAsync(
|
|
"TestSession",
|
|
30000u,
|
|
identity,
|
|
It.IsAny<ArrayOf<string>>(),
|
|
false,
|
|
true,
|
|
It.IsAny<CancellationToken>()), Times.Once);
|
|
}
|
|
|
|
[Test]
|
|
public async Task ReconnectAsyncWithNoArgsForwardsCorrectlyAsync()
|
|
{
|
|
m_session
|
|
.Setup(s => s.ReconnectAsync(null, null, It.IsAny<CancellationToken>()))
|
|
.Returns(Task.CompletedTask)
|
|
.Verifiable();
|
|
|
|
await m_session.Object.ReconnectAsync().ConfigureAwait(false);
|
|
|
|
m_session.Verify(s => s.ReconnectAsync(
|
|
null, null, It.IsAny<CancellationToken>()), Times.Once);
|
|
}
|
|
|
|
[Test]
|
|
public async Task ReconnectAsyncWithConnectionForwardsCorrectlyAsync()
|
|
{
|
|
var connection = new Mock<ITransportWaitingConnection>();
|
|
|
|
m_session
|
|
.Setup(s => s.ReconnectAsync(connection.Object, null, It.IsAny<CancellationToken>()))
|
|
.Returns(Task.CompletedTask)
|
|
.Verifiable();
|
|
|
|
await m_session.Object.ReconnectAsync(connection.Object).ConfigureAwait(false);
|
|
|
|
m_session.Verify(s => s.ReconnectAsync(
|
|
connection.Object, null, It.IsAny<CancellationToken>()), Times.Once);
|
|
}
|
|
|
|
[Test]
|
|
public async Task ReconnectAsyncWithChannelForwardsCorrectlyAsync()
|
|
{
|
|
var channel = new Mock<ITransportChannel>();
|
|
|
|
m_session
|
|
.Setup(s => s.ReconnectAsync(null, channel.Object, It.IsAny<CancellationToken>()))
|
|
.Returns(Task.CompletedTask)
|
|
.Verifiable();
|
|
|
|
await m_session.Object.ReconnectAsync(channel.Object).ConfigureAwait(false);
|
|
|
|
m_session.Verify(s => s.ReconnectAsync(
|
|
null, channel.Object, It.IsAny<CancellationToken>()), Times.Once);
|
|
}
|
|
|
|
[Test]
|
|
public async Task CloseAsyncWithCloseChannelForwardsCorrectlyAsync()
|
|
{
|
|
m_session
|
|
.SetupGet(s => s.KeepAliveInterval)
|
|
.Returns(5000);
|
|
|
|
m_session
|
|
.Setup(s => s.CloseAsync(5000, true, It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(StatusCodes.Good)
|
|
.Verifiable();
|
|
|
|
StatusCode result = await m_session.Object.CloseAsync(true).ConfigureAwait(false);
|
|
|
|
Assert.That(result, Is.EqualTo(StatusCodes.Good));
|
|
}
|
|
|
|
[Test]
|
|
public async Task CloseAsyncWithCloseChannelFalseForwardsCorrectlyAsync()
|
|
{
|
|
m_session
|
|
.SetupGet(s => s.KeepAliveInterval)
|
|
.Returns(10000);
|
|
|
|
m_session
|
|
.Setup(s => s.CloseAsync(10000, false, It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(StatusCodes.Good)
|
|
.Verifiable();
|
|
|
|
StatusCode result = await m_session.Object.CloseAsync(false).ConfigureAwait(false);
|
|
|
|
Assert.That(result, Is.EqualTo(StatusCodes.Good));
|
|
}
|
|
|
|
[Test]
|
|
public async Task CloseAsyncWithTimeoutForwardsCorrectlyAsync()
|
|
{
|
|
m_session
|
|
.Setup(s => s.CloseAsync(3000, true, It.IsAny<CancellationToken>()))
|
|
.ReturnsAsync(StatusCodes.Good)
|
|
.Verifiable();
|
|
|
|
StatusCode result = await m_session.Object.CloseAsync(3000).ConfigureAwait(false);
|
|
|
|
Assert.That(result, Is.EqualTo(StatusCodes.Good));
|
|
}
|
|
|
|
[Test]
|
|
public void SaveWithSubscriptionsForwardsToStreamSave()
|
|
{
|
|
Subscription[] subscriptions = [];
|
|
m_session
|
|
.SetupGet(s => s.Subscriptions)
|
|
.Returns(subscriptions);
|
|
|
|
// The Save(filePath) extension calls Save(filePath, session.Subscriptions, null)
|
|
// which creates a FileStream. We test that it reads Subscriptions.
|
|
Assert.That(m_session.Object.Subscriptions, Is.SameAs(subscriptions));
|
|
}
|
|
|
|
[Test]
|
|
public void ReadByteStringInChunksAsyncThrowsWhenNoLimitIsKnown()
|
|
{
|
|
var capabilities = new ServerCapabilities { MaxByteStringLength = 0 };
|
|
m_session
|
|
.SetupGet(s => s.ServerCapabilities)
|
|
.Returns(capabilities);
|
|
SetupMessageContext(maxByteStringLength: 0);
|
|
|
|
Assert.ThrowsAsync<ServiceResultException>(async () =>
|
|
await m_session.Object.ReadByteStringInChunksAsync(new NodeId(1)).ConfigureAwait(false));
|
|
}
|
|
|
|
[Test]
|
|
public void ReadByteStringInChunksAsyncThrowsWhenMaxByteStringLengthIsOne()
|
|
{
|
|
var capabilities = new ServerCapabilities { MaxByteStringLength = 1 };
|
|
m_session
|
|
.SetupGet(s => s.ServerCapabilities)
|
|
.Returns(capabilities);
|
|
SetupMessageContext(maxByteStringLength: 1024);
|
|
|
|
Assert.ThrowsAsync<ServiceResultException>(async () =>
|
|
await m_session.Object.ReadByteStringInChunksAsync(new NodeId(1)).ConfigureAwait(false));
|
|
}
|
|
|
|
/// <summary>
|
|
/// A server that does not provide MaxByteStringLength (0) or reports a
|
|
/// value beyond int range is read in chunks of the client limit (L3-6).
|
|
/// </summary>
|
|
[TestCase(0u)]
|
|
[TestCase(3_000_000_000u)]
|
|
public async Task ReadByteStringInChunksAsyncUsesClientLimitWhenServerLimitUnknownAsync(
|
|
uint serverLimit)
|
|
{
|
|
var capabilities = new ServerCapabilities { MaxByteStringLength = serverLimit };
|
|
m_session
|
|
.SetupGet(s => s.ServerCapabilities)
|
|
.Returns(capabilities);
|
|
SetupMessageContext(maxByteStringLength: 4);
|
|
var ranges = new List<string>();
|
|
m_session
|
|
.Setup(s => s.ReadAsync(
|
|
It.IsAny<RequestHeader>(),
|
|
It.IsAny<double>(),
|
|
It.IsAny<TimestampsToReturn>(),
|
|
It.IsAny<ArrayOf<ReadValueId>>(),
|
|
It.IsAny<CancellationToken>()))
|
|
.Returns<RequestHeader, double, TimestampsToReturn, ArrayOf<ReadValueId>, CancellationToken>(
|
|
(_, _, _, ids, _) =>
|
|
{
|
|
ranges.Add(ids[0].IndexRange!);
|
|
byte[] chunk = ranges.Count == 1 ? [1, 2, 3, 4] : [5];
|
|
return new ValueTask<ReadResponse>(new ReadResponse
|
|
{
|
|
ResponseHeader = new ResponseHeader(),
|
|
Results = [new DataValue(new Variant(ByteString.From(chunk)))],
|
|
DiagnosticInfos = []
|
|
});
|
|
});
|
|
|
|
ByteString result = await m_session.Object
|
|
.ReadByteStringInChunksAsync(new NodeId(1))
|
|
.ConfigureAwait(false);
|
|
|
|
Assert.That(result.ToArray(), Is.EqualTo(new byte[] { 1, 2, 3, 4, 5 }));
|
|
string[] expectedRanges = ["0:3", "4:7"];
|
|
Assert.That(ranges, Is.EqualTo(expectedRanges));
|
|
}
|
|
|
|
private void SetupMessageContext(int maxByteStringLength)
|
|
{
|
|
var messageContext = ServiceMessageContext.Create(NUnitTelemetryContext.Create());
|
|
messageContext.MaxByteStringLength = maxByteStringLength;
|
|
m_session
|
|
.SetupGet(s => s.MessageContext)
|
|
.Returns(messageContext);
|
|
}
|
|
}
|
|
}
|