Files
UA-.NETStandard/tests/Opc.Ua.Configuration.Tests/OpcUaApplicationConfigurationProviderTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

499 lines
20 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.IO;
using System.Threading.Tasks;
using Microsoft.Extensions.DependencyInjection;
using NUnit.Framework;
using Opc.Ua.Tests;
namespace Opc.Ua.Configuration.Tests
{
[TestFixture]
[Category("ApplicationConfigurationBuilder")]
[SetCulture("en-us")]
[SetUICulture("en-us")]
[Parallelizable]
public sealed class OpcUaApplicationConfigurationProviderTests
{
[Test]
public void ConfigureApplicationThrowsForNullArguments()
{
Assert.That(
() => OpcUaConfigurationServiceCollectionExtensions.ConfigureApplication(
null!,
_ => { }),
Throws.ArgumentNullException);
var services = new ServiceCollection();
IOpcUaBuilder builder = services.AddOpcUa();
Assert.That(
() => builder.ConfigureApplication(null!),
Throws.ArgumentNullException);
}
[Test]
public async Task ConfigureApplicationRegistersOptionsAndProviderAsync()
{
string pkiRoot = CreatePkiRoot();
var services = new ServiceCollection();
IOpcUaBuilder builder = services.AddOpcUa();
IOpcUaBuilder returned = builder.ConfigureApplication(options =>
{
options.ApplicationName = "ConfiguredClient";
options.ApplicationUri = "urn:localhost:ConfiguredClient";
options.ProductUri = "uri:opcfoundation.org:ConfiguredClient";
options.PkiRoot = pkiRoot;
});
services.AddSingleton<IOpcUaApplicationConfigurationFeature>(
new ClientFeature());
ServiceProvider provider = services.BuildServiceProvider();
try
{
Assert.That(returned, Is.SameAs(builder));
OpcUaApplicationOptions options =
provider.GetRequiredService<OpcUaApplicationOptions>();
Assert.That(options.ApplicationName, Is.EqualTo("ConfiguredClient"));
Assert.That(
provider.GetRequiredService<IOpcUaApplicationConfigurationProvider>(),
Is.InstanceOf<OpcUaApplicationConfigurationProvider>());
}
finally
{
await provider.DisposeAsync().ConfigureAwait(false);
DeletePkiRoot(pkiRoot);
}
}
[Test]
public async Task ProviderBuildsOneCombinedConfigurationAsync()
{
string pkiRoot = CreatePkiRoot();
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
using var certificateManager = new CertificateManager(telemetry);
var provider = new OpcUaApplicationConfigurationProvider(
new OpcUaApplicationOptions
{
ApplicationName = "CombinedApplication",
ApplicationUri = "urn:localhost:CombinedApplication",
ProductUri = "uri:opcfoundation.org:CombinedApplication",
PkiRoot = pkiRoot,
AutoAcceptUntrustedCertificates = true
},
new TestApplicationInstanceFactory(),
telemetry,
[new ClientFeature(), new ServerFeature()],
certificateManager);
try
{
Assert.That(provider.Application.ApplicationType,
Is.EqualTo(ApplicationType.ClientAndServer));
Assert.That(provider.Configuration.ApplicationType,
Is.EqualTo(ApplicationType.ClientAndServer));
Assert.That(provider.Configuration.ClientConfiguration, Is.Not.Null);
Assert.That(provider.Configuration.ServerConfiguration, Is.Not.Null);
ApplicationConfiguration configuration = await provider
.GetAsync()
.ConfigureAwait(false);
Assert.That(configuration, Is.SameAs(provider.Configuration));
Assert.That(
configuration.CertificateManager,
Is.SameAs(certificateManager));
Assert.That(
((ApplicationInstance)provider.Application).CertificateManager,
Is.SameAs(certificateManager));
Assert.That(
configuration.SecurityConfiguration.AutoAcceptUntrustedCertificates,
Is.True);
}
finally
{
await provider.DisposeAsync().ConfigureAwait(false);
DeletePkiRoot(pkiRoot);
}
}
[Test]
public async Task ProviderEnsuresClientApplicationCertificateAsync()
{
string pkiRoot = CreatePkiRoot();
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
var provider = new OpcUaApplicationConfigurationProvider(
new OpcUaApplicationOptions
{
ApplicationName = "ClientApplication",
ApplicationUri = "urn:localhost:ClientApplication",
ProductUri = "uri:opcfoundation.org:ClientApplication",
PkiRoot = pkiRoot
},
new TestApplicationInstanceFactory(),
telemetry,
[new ClientFeature()]);
try
{
await provider.GetAsync().ConfigureAwait(false);
Assert.That(
((ApplicationInstance)provider.Application).CertificateManager,
Is.Not.Null);
}
finally
{
await provider.DisposeAsync().ConfigureAwait(false);
DeletePkiRoot(pkiRoot);
}
}
[Test]
public async Task GetAsyncThrowsObjectDisposedExceptionAfterDisposeAsync()
{
string pkiRoot = CreatePkiRoot();
var provider = new OpcUaApplicationConfigurationProvider(
new OpcUaApplicationOptions
{
ApplicationName = "DisposedProvider",
ApplicationUri = "urn:localhost:DisposedProvider",
ProductUri = "uri:opcfoundation.org:DisposedProvider",
PkiRoot = pkiRoot
},
new TestApplicationInstanceFactory(),
NUnitTelemetryContext.Create(),
[new ClientFeature()]);
await provider.DisposeAsync().ConfigureAwait(false);
try
{
Assert.ThrowsAsync<ObjectDisposedException>(
async () => await provider.GetAsync().ConfigureAwait(false));
}
finally
{
DeletePkiRoot(pkiRoot);
}
}
[Test]
public void ConstructorThrowsForNullOptions()
{
Assert.That(
() => new OpcUaApplicationConfigurationProvider(
null!,
new TestApplicationInstanceFactory(),
NUnitTelemetryContext.Create(),
[new ClientFeature()]),
Throws.ArgumentNullException.With.Property(nameof(ArgumentNullException.ParamName))
.EqualTo("options"));
}
[Test]
public void ConstructorThrowsForNullApplicationFactory()
{
Assert.That(
() => new OpcUaApplicationConfigurationProvider(
new OpcUaApplicationOptions { ApplicationName = "NullFactory" },
null!,
NUnitTelemetryContext.Create(),
[new ClientFeature()]),
Throws.ArgumentNullException.With.Property(nameof(ArgumentNullException.ParamName))
.EqualTo("applicationFactory"));
}
[Test]
public void ConstructorThrowsForNullTelemetry()
{
Assert.That(
() => new OpcUaApplicationConfigurationProvider(
new OpcUaApplicationOptions { ApplicationName = "NullTelemetry" },
new TestApplicationInstanceFactory(),
null!,
[new ClientFeature()]),
Throws.ArgumentNullException.With.Property(nameof(ArgumentNullException.ParamName))
.EqualTo("telemetry"));
}
[Test]
public void ConstructorThrowsForNullFeatures()
{
Assert.That(
() => new OpcUaApplicationConfigurationProvider(
new OpcUaApplicationOptions { ApplicationName = "NullFeatures" },
new TestApplicationInstanceFactory(),
NUnitTelemetryContext.Create(),
ArrayOf<IOpcUaApplicationConfigurationFeature>.Null),
Throws.ArgumentNullException.With.Property(nameof(ArgumentNullException.ParamName))
.EqualTo("features"));
}
[Test]
public void ConstructorThrowsForEmptyFeatures()
{
Assert.That(
() => new OpcUaApplicationConfigurationProvider(
new OpcUaApplicationOptions { ApplicationName = "EmptyFeatures" },
new TestApplicationInstanceFactory(),
NUnitTelemetryContext.Create(),
ArrayOf<IOpcUaApplicationConfigurationFeature>.Empty),
Throws.InvalidOperationException.With.Message.Contains("AddClient, AddServer"));
}
[Test]
public void ConstructorThrowsForMissingApplicationName()
{
Assert.That(
() => new OpcUaApplicationConfigurationProvider(
new OpcUaApplicationOptions(),
new TestApplicationInstanceFactory(),
NUnitTelemetryContext.Create(),
[new ClientFeature()]),
Throws.InvalidOperationException.With.Message.Contains("ApplicationName is required"));
}
[Test]
public void ConstructorThrowsWhenNoFeatureSelectsSecurityBuilder()
{
Assert.That(
() => new OpcUaApplicationConfigurationProvider(
new OpcUaApplicationOptions { ApplicationName = "NoBuilderSelected" },
new TestApplicationInstanceFactory(),
NUnitTelemetryContext.Create(),
[new NonSelectingFeature()]),
Throws.InvalidOperationException.With.Message.Contains(
"No application configuration feature selected"));
}
[Test]
public void ConstructorUsesDefaultPkiRootAndSubjectNameWhenNotSet()
{
var provider = new OpcUaApplicationConfigurationProvider(
new OpcUaApplicationOptions
{
ApplicationName = "DefaultPkiAndSubject-" + Guid.NewGuid().ToString("N"),
ApplicationUri = "urn:localhost:DefaultPkiAndSubject",
ProductUri = "uri:opcfoundation.org:DefaultPkiAndSubject"
},
new TestApplicationInstanceFactory(),
NUnitTelemetryContext.Create(),
[new ClientFeature()]);
try
{
string expectedPkiSegment = Path.Combine("OPC Foundation", provider.Application.ApplicationName!);
Assert.That(
provider.Configuration.SecurityConfiguration.ApplicationCertificates[0].StorePath,
Does.Contain(expectedPkiSegment));
Assert.That(
provider.Configuration.SecurityConfiguration.ApplicationCertificates[0].StorePath,
Does.Not.StartWith(Path.GetTempPath()));
Assert.That(
provider.Configuration.SecurityConfiguration.ApplicationCertificates[0].SubjectName,
Does.Contain("CN=" + provider.Application.ApplicationName));
}
finally
{
provider.DisposeAsync().AsTask().GetAwaiter().GetResult();
DeletePkiRoot(Path.GetDirectoryName(
DefaultPkiRoot.Get(
provider.Application.ApplicationName!))!);
}
}
[Test]
public async Task ConstructorAppliesRejectSha1AndMinimumKeySizeWhenSetAsync()
{
string pkiRoot = CreatePkiRoot();
var provider = new OpcUaApplicationConfigurationProvider(
new OpcUaApplicationOptions
{
ApplicationName = "ExplicitSecurityOptions",
ApplicationUri = "urn:localhost:ExplicitSecurityOptions",
ProductUri = "uri:opcfoundation.org:ExplicitSecurityOptions",
PkiRoot = pkiRoot,
RejectSHA1SignedCertificates = false,
MinimumCertificateKeySize = 3072
},
new TestApplicationInstanceFactory(),
NUnitTelemetryContext.Create(),
[new ClientFeature()]);
try
{
await provider.GetAsync().ConfigureAwait(false);
Assert.That(
provider.Configuration.SecurityConfiguration.RejectSHA1SignedCertificates,
Is.False);
Assert.That(
provider.Configuration.SecurityConfiguration.MinimumCertificateKeySize,
Is.EqualTo(3072));
}
finally
{
await provider.DisposeAsync().ConfigureAwait(false);
DeletePkiRoot(pkiRoot);
}
}
[Test]
public async Task ConfigureSecurityRunsOnceAfterFirstClassOptionsForCombinedConfigurationAsync()
{
string pkiRoot = CreatePkiRoot();
int invocationCount = 0;
var provider = new OpcUaApplicationConfigurationProvider(
new OpcUaApplicationOptions
{
ApplicationName = "AdvancedSecurityOptions",
ApplicationUri = "urn:localhost:AdvancedSecurityOptions",
ProductUri = "uri:opcfoundation.org:AdvancedSecurityOptions",
PkiRoot = pkiRoot,
AutoAcceptUntrustedCertificates = true,
RejectSHA1SignedCertificates = true,
MinimumCertificateKeySize = 2048,
ConfigureSecurity = security =>
{
invocationCount++;
security
.SetMaxRejectedCertificates(17)
.SetAutoAcceptUntrustedCertificates(false)
.SetAddAppCertToTrustedStore(true)
.SetRejectSHA1SignedCertificates(false)
.SetRejectUnknownRevocationStatus(false)
.SetUseValidatedCertificates(true)
.SetSuppressNonceValidationErrors(true)
.SetSendCertificateChain(false)
.SetMinimumCertificateKeySize(3072);
}
},
new TestApplicationInstanceFactory(),
NUnitTelemetryContext.Create(),
[new ClientFeature(), new ServerFeature()]);
try
{
ApplicationConfiguration configuration = await provider
.GetAsync()
.ConfigureAwait(false);
Assert.That(invocationCount, Is.EqualTo(1));
Assert.That(configuration.ApplicationType, Is.EqualTo(ApplicationType.ClientAndServer));
Assert.That(configuration.SecurityConfiguration.MaxRejectedCertificates, Is.EqualTo(17));
Assert.That(
configuration.SecurityConfiguration.AutoAcceptUntrustedCertificates,
Is.False);
Assert.That(configuration.SecurityConfiguration.AddAppCertToTrustedStore, Is.True);
Assert.That(configuration.SecurityConfiguration.RejectSHA1SignedCertificates, Is.False);
Assert.That(configuration.SecurityConfiguration.RejectUnknownRevocationStatus, Is.False);
Assert.That(configuration.SecurityConfiguration.UseValidatedCertificates, Is.True);
Assert.That(configuration.SecurityConfiguration.SuppressNonceValidationErrors, Is.True);
Assert.That(configuration.SecurityConfiguration.SendCertificateChain, Is.False);
Assert.That(
configuration.SecurityConfiguration.MinimumCertificateKeySize,
Is.EqualTo(3072));
}
finally
{
await provider.DisposeAsync().ConfigureAwait(false);
DeletePkiRoot(pkiRoot);
}
}
private static string CreatePkiRoot()
{
return Path.Combine(
Path.GetTempPath(),
nameof(OpcUaApplicationConfigurationProviderTests),
Guid.NewGuid().ToString("N"));
}
private static void DeletePkiRoot(string pkiRoot)
{
if (Directory.Exists(pkiRoot))
{
Directory.Delete(pkiRoot, recursive: true);
}
}
private sealed class ClientFeature : IOpcUaApplicationConfigurationFeature
{
public void ApplyDefaults(OpcUaApplicationOptions options)
{
}
public IApplicationConfigurationBuilderSecurity Configure(
IApplicationConfigurationBuilderTypes builder)
{
return builder.AsClient();
}
}
private sealed class NonSelectingFeature : IOpcUaApplicationConfigurationFeature
{
public void ApplyDefaults(OpcUaApplicationOptions options)
{
}
public IApplicationConfigurationBuilderSecurity Configure(
IApplicationConfigurationBuilderTypes builder)
{
return null!;
}
}
private sealed class ServerFeature : IOpcUaApplicationConfigurationFeature
{
public void ApplyDefaults(OpcUaApplicationOptions options)
{
}
public IApplicationConfigurationBuilderSecurity Configure(
IApplicationConfigurationBuilderTypes builder)
{
return builder
.AsServer(["opc.tcp://localhost:4840/CombinedApplication"])
.AddUnsecurePolicyNone();
}
}
private sealed class TestApplicationInstanceFactory : IApplicationInstanceFactory
{
public IApplicationInstance Create(ITelemetryContext telemetry)
{
return new ApplicationInstance(telemetry);
}
}
}
}