Files
UA-.NETStandard/tests/Opc.Ua.Core.Diagnostics.Tests/Models/CaptureSourceKindExtensionsTests.cs
Marc Schier 80db326567 Fix MCP diagnostics tool contracts and capture failures (#4241)
# Description

Fix the MCP packet-diagnostics tool contract and the capture failures
reported in #4238.

- Accept and emit canonical hyphenated capture source and format names
while preserving CLR-name and integer compatibility.
- Restore typed enum constraints in generated MCP schemas and surface
actionable diagnostics errors to MCP clients.
- Stop `list_interfaces` from reading `LinkType` on unopened SharpPcap
devices.
- Close failed SharpPcap handles before retrying NIC opens and report
permission failures immediately.
- Normalize capture roots, remove duplicated path segments, and use a
lazy secure per-user or atomic temporary fallback.
- Align MCP/diagnostics documentation and interop-agent guidance.

## Related Issues

- Fixes #4238

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [x] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

---------

Copilot-Session: 641a4356-aa8d-45e6-9077-eeb50b9b7e0a
2026-08-12 10:33:56 +02:00

72 lines
3.0 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using NUnit.Framework;
using Opc.Ua.Pcap.Models;
namespace Opc.Ua.Pcap.Tests.Models
{
[TestFixture]
public sealed class CaptureSourceKindExtensionsTests
{
[TestCase("nic", CaptureSourceKind.Nic)]
[TestCase("inproc-client", CaptureSourceKind.InProcessClient)]
[TestCase("InProcessClient", CaptureSourceKind.InProcessClient)]
[TestCase("in-process-client", CaptureSourceKind.InProcessClient)]
[TestCase("inproc-server", CaptureSourceKind.InProcessServer)]
[TestCase("InProcessServer", CaptureSourceKind.InProcessServer)]
[TestCase("replay", CaptureSourceKind.Replay)]
public void TryParseAcceptsCanonicalAndAliasNames(
string input,
CaptureSourceKind expected)
{
bool parsed = input.TryParse(out CaptureSourceKind actual);
Assert.That(parsed, Is.True);
Assert.That(actual, Is.EqualTo(expected));
}
[TestCase(CaptureSourceKind.Nic, "nic")]
[TestCase(CaptureSourceKind.InProcessClient, "inproc-client")]
[TestCase(CaptureSourceKind.InProcessServer, "inproc-server")]
[TestCase(CaptureSourceKind.Replay, "replay")]
public void ToWireNameReturnsCanonicalName(CaptureSourceKind kind, string expected)
{
Assert.That(kind.ToWireName(), Is.EqualTo(expected));
}
[TestCase("")]
[TestCase("unknown")]
public void TryParseRejectsUnknownNames(string input)
{
Assert.That(input.TryParse(out _), Is.False);
}
}
}