mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-20 00:31:32 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
372 lines
15 KiB
C#
372 lines
15 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.IO;
|
|
using System.Linq;
|
|
using System.Text;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Core.TestFramework;
|
|
|
|
namespace Opc.Ua.Core.Encoders.Tests
|
|
{
|
|
/// <summary>
|
|
/// Tests for the IEncodeable classes.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("EncodeableTypes")]
|
|
[SetCulture("en-us")]
|
|
[SetUICulture("en-us")]
|
|
[Parallelizable]
|
|
public class EncodeableTypesTests : EncoderCommon
|
|
{
|
|
[DatapointSource]
|
|
public Type[] TypeArray =
|
|
[
|
|
.. typeof(BaseObjectState).Assembly
|
|
.GetExportedTypes()
|
|
.Where(IsEncodeableType)
|
|
.Where(PublishesStructureMetadata)
|
|
];
|
|
|
|
/// <summary>
|
|
/// Excludes the encodeable types that are not ordinary Structures.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// Every assertion below assumes a generated Structure: that the type
|
|
/// has its own binary and XML encoding Objects distinct from its
|
|
/// DataType, and that the standard factory can resolve it from an
|
|
/// encoding id. OPC 10000-6 5.1.10 defines <see cref="Opc.Ua.Decimal"/>
|
|
/// as the exception - its ExtensionObject TypeId is "the identifier for
|
|
/// the Decimal DataType" itself, it "is like a built-in type and a
|
|
/// DevelopmentPlatform has to have hardcoded knowledge of the type",
|
|
/// and "No Structure metadata is published for this type". So it has no
|
|
/// separate encoding Objects to be distinct from, and this suite's
|
|
/// premise does not apply to it. Its own encoding is covered end to end
|
|
/// by DecimalEncodingTests across binary, XML and JSON.
|
|
/// </remarks>
|
|
private static bool PublishesStructureMetadata(Type systemType)
|
|
{
|
|
return systemType != typeof(Opc.Ua.Decimal);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Verify encode and decode of an encodeable type.
|
|
/// </summary>
|
|
[Theory]
|
|
[Category("EncodeableTypes")]
|
|
public void ActivateEncodeableType(
|
|
[ValueSource(
|
|
nameof(EncodingTypesJsonBinaryXmlAndJsonCompact))] EncodingTypeGroup encoderTypeGroup,
|
|
MemoryStreamType memoryStreamType,
|
|
Type systemType)
|
|
{
|
|
EncodingType encoderType = encoderTypeGroup.EncoderType;
|
|
JsonEncodingType jsonEncodingType = encoderTypeGroup.JsonEncodingType;
|
|
bool useXmlParser = encoderTypeGroup.UseXmlParser;
|
|
var testObject = CreateDefaultEncodeableType(systemType) as IEncodeable;
|
|
Assert.That(testObject, Is.Not.Null);
|
|
|
|
if (testObject.BinaryEncodingId.IsNull)
|
|
{
|
|
return;
|
|
}
|
|
|
|
Assert.That(testObject.BinaryEncodingId.IsNull, Is.False);
|
|
Assert.That(testObject.TypeId.IsNull, Is.False);
|
|
Assert.That(testObject.XmlEncodingId.IsNull, Is.False);
|
|
Assert.That(testObject.BinaryEncodingId, Is.Not.EqualTo(testObject.TypeId));
|
|
Assert.That(testObject.XmlEncodingId, Is.Not.EqualTo(testObject.TypeId));
|
|
Assert.That(testObject.XmlEncodingId, Is.Not.EqualTo(testObject.BinaryEncodingId));
|
|
EncodeDecode(
|
|
encoderType,
|
|
jsonEncodingType,
|
|
useXmlParser,
|
|
BuiltInType.ExtensionObject,
|
|
memoryStreamType,
|
|
new ExtensionObject(testObject));
|
|
}
|
|
|
|
[Theory]
|
|
[Category("EncodeableTypes")]
|
|
public void ActivateEncodeableTypeArray(
|
|
[ValueSource(
|
|
nameof(EncodingTypesJsonBinaryXmlAndJsonCompact))] EncodingTypeGroup encoderTypeGroup,
|
|
MemoryStreamType memoryStreamType,
|
|
Type systemType)
|
|
{
|
|
EncodingType encoderType = encoderTypeGroup.EncoderType;
|
|
JsonEncodingType jsonEncodingType = encoderTypeGroup.JsonEncodingType;
|
|
bool useXmlParser = encoderTypeGroup.UseXmlParser;
|
|
int arrayLength = DataGenerator.GetRandomByte();
|
|
var array = new ExtensionObject[arrayLength];
|
|
ExpandedNodeId dataTypeId = NodeId.Null;
|
|
for (int i = 0; i < array.Length; i++)
|
|
{
|
|
var testObject = CreateDefaultEncodeableType(systemType) as IEncodeable;
|
|
array[i] = new ExtensionObject(testObject!);
|
|
if (dataTypeId.IsNull)
|
|
{
|
|
dataTypeId = testObject!.TypeId;
|
|
}
|
|
}
|
|
var expected = Variant.From(array);
|
|
const string objectName = "Array";
|
|
|
|
byte[] buffer;
|
|
using (MemoryStream encoderStream = CreateEncoderMemoryStream(memoryStreamType))
|
|
{
|
|
using (
|
|
IEncoder encoder = CreateEncoder(
|
|
encoderType,
|
|
Context,
|
|
encoderStream,
|
|
systemType,
|
|
jsonEncodingType))
|
|
{
|
|
encoder.PushNamespace("urn:This:is:another:namespace");
|
|
encoder.WriteVariantValue(objectName, expected);
|
|
encoder.PopNamespace();
|
|
}
|
|
buffer = encoderStream.ToArray();
|
|
}
|
|
|
|
switch (encoderType)
|
|
{
|
|
case EncodingType.Json:
|
|
PrettifyAndValidateJson(Encoding.UTF8.GetString(buffer));
|
|
break;
|
|
case EncodingType.Xml:
|
|
string xml = Encoding.UTF8.GetString(buffer);
|
|
Assert.That(
|
|
xml.Contains(
|
|
"<Array xmlns=\"urn:This:is:another:namespace\">",
|
|
StringComparison.Ordinal),
|
|
Is.True);
|
|
break;
|
|
case EncodingType.Binary:
|
|
break;
|
|
default:
|
|
Assert.Fail($"Encoder type {encoderType} not supported.");
|
|
break;
|
|
}
|
|
|
|
Variant result;
|
|
using (var decoderStream = new MemoryStream(buffer))
|
|
using (IDecoder decoder = CreateDecoder(
|
|
encoderType,
|
|
useXmlParser,
|
|
Context,
|
|
decoderStream,
|
|
systemType))
|
|
{
|
|
decoder.PushNamespace("urn:This:is:another:namespace");
|
|
result = decoder.ReadVariantValue(objectName, expected.TypeInfo);
|
|
decoder.PopNamespace();
|
|
}
|
|
|
|
TestOutput.WriteLine("Result:");
|
|
TestOutput.WriteLine(result);
|
|
|
|
string encodeInfo =
|
|
$"Encoder: {encoderType} Type: Array of {systemType}. Expected is different from result.";
|
|
Assert.That(result, Is.EqualTo(expected), encodeInfo);
|
|
}
|
|
|
|
[Theory]
|
|
[Category("EncodeableTypes")]
|
|
public void ActivateEncodeableTypeMatrix(
|
|
[ValueSource(
|
|
nameof(EncodingTypesJsonBinaryXmlAndJsonCompact))] EncodingTypeGroup encoderTypeGroup,
|
|
MemoryStreamType memoryStreamType,
|
|
Type systemType)
|
|
{
|
|
EncodingType encoderType = encoderTypeGroup.EncoderType;
|
|
JsonEncodingType jsonEncodingType = encoderTypeGroup.JsonEncodingType;
|
|
bool useXmlParser = encoderTypeGroup.UseXmlParser;
|
|
int matrixDimension = RandomSource.NextInt32(2) + 2;
|
|
int[] dimensions = new int[matrixDimension];
|
|
SetMatrixDimensions(dimensions);
|
|
int elementsCount = ElementsFromDimension(dimensions);
|
|
var array = new ExtensionObject[elementsCount];
|
|
|
|
ExpandedNodeId dataTypeId = NodeId.Null;
|
|
for (int i = 0; i < array.Length; i++)
|
|
{
|
|
var testObject = CreateDefaultEncodeableType(systemType) as IEncodeable;
|
|
array[i] = new ExtensionObject(testObject!);
|
|
if (dataTypeId.IsNull)
|
|
{
|
|
dataTypeId = testObject!.TypeId;
|
|
}
|
|
}
|
|
|
|
var expected = Variant.From(array);
|
|
const string objectName = "Matrix";
|
|
|
|
byte[] buffer;
|
|
using (MemoryStream encoderStream = CreateEncoderMemoryStream(memoryStreamType))
|
|
{
|
|
using (
|
|
IEncoder encoder = CreateEncoder(
|
|
encoderType,
|
|
Context,
|
|
encoderStream,
|
|
systemType,
|
|
jsonEncodingType))
|
|
{
|
|
encoder.WriteVariantValue(objectName, expected);
|
|
}
|
|
buffer = encoderStream.ToArray();
|
|
}
|
|
|
|
if (encoderType == EncodingType.Json)
|
|
{
|
|
PrettifyAndValidateJson(Encoding.UTF8.GetString(buffer));
|
|
}
|
|
|
|
Variant result;
|
|
using (var decoderStream = new MemoryStream(buffer))
|
|
using (IDecoder decoder = CreateDecoder(
|
|
encoderType,
|
|
useXmlParser,
|
|
Context,
|
|
decoderStream,
|
|
systemType))
|
|
{
|
|
result = decoder.ReadVariantValue(objectName, expected.TypeInfo);
|
|
}
|
|
|
|
TestOutput.WriteLine("Result:");
|
|
TestOutput.WriteLine(result);
|
|
|
|
Assert.That(
|
|
result,
|
|
Is.EqualTo(expected),
|
|
$"Encoder: {encoderType} Type: Matrix of {systemType}. Expected is different from result.");
|
|
}
|
|
|
|
/// <summary>
|
|
/// Create an instance of an encodeable type with default values.
|
|
/// </summary>
|
|
/// <param name="systemType">The type to create</param>
|
|
private static object CreateDefaultEncodeableType(Type systemType)
|
|
{
|
|
object instance = Activator.CreateInstance(systemType)!;
|
|
SetDefaultEncodeableType(instance!);
|
|
return instance;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Set encodeable type properties recursively
|
|
/// to expected default values.
|
|
/// </summary>
|
|
/// <exception cref="ServiceResultException"></exception>
|
|
private static void SetDefaultEncodeableType(object typeInstance)
|
|
{
|
|
foreach (System.Reflection.PropertyInfo property in typeInstance.GetType()
|
|
.GetProperties())
|
|
{
|
|
if (property.CanWrite)
|
|
{
|
|
var typeInfo = TypeInfo.Construct(property.PropertyType);
|
|
switch (typeInfo.BuiltInType)
|
|
{
|
|
case BuiltInType.ExtensionObject:
|
|
object? propertyObject = property.GetValue(typeInstance);
|
|
if (propertyObject == null &&
|
|
property.PropertyType.IsAssignableFrom(typeof(ExtensionObject)))
|
|
{
|
|
property.SetValue(typeInstance, ExtensionObject.Null);
|
|
}
|
|
else if (propertyObject is not null and IEncodeable)
|
|
{
|
|
SetDefaultEncodeableType(propertyObject);
|
|
}
|
|
break;
|
|
case BuiltInType.Null:
|
|
break;
|
|
case BuiltInType.DataValue:
|
|
if (property.GetValue(typeInstance) == null)
|
|
{
|
|
property.SetValue(typeInstance, new DataValue());
|
|
}
|
|
break;
|
|
case BuiltInType.NodeId:
|
|
if (property.GetValue(typeInstance) == null)
|
|
{
|
|
property.SetValue(typeInstance, NodeId.Null);
|
|
}
|
|
break;
|
|
case BuiltInType.ExpandedNodeId:
|
|
if (property.GetValue(typeInstance) == null)
|
|
{
|
|
property.SetValue(typeInstance, ExpandedNodeId.Null);
|
|
}
|
|
break;
|
|
case BuiltInType.DiagnosticInfo:
|
|
if (property.GetValue(typeInstance) == null)
|
|
{
|
|
if (typeInfo.ValueRank == ValueRanks.Scalar)
|
|
{
|
|
property.SetValue(typeInstance, new DiagnosticInfo());
|
|
}
|
|
else
|
|
{
|
|
property.SetValue(typeInstance, Array.Empty<DiagnosticInfo>());
|
|
}
|
|
}
|
|
break;
|
|
case BuiltInType.Enumeration:
|
|
if (typeInfo.ValueRank == ValueRanks.Scalar)
|
|
{
|
|
foreach (object ii in Enum.GetValues(property.PropertyType))
|
|
{
|
|
property.SetValue(typeInstance, ii);
|
|
break;
|
|
}
|
|
}
|
|
break;
|
|
case >= BuiltInType.Null and <= BuiltInType.Enumeration:
|
|
if (typeInfo.ValueRank == ValueRanks.Scalar)
|
|
{
|
|
object value = TypeInfo.GetDefaultValue(typeInfo.BuiltInType)!;
|
|
property.SetValue(typeInstance, value);
|
|
}
|
|
break;
|
|
default:
|
|
throw ServiceResultException.Unexpected(
|
|
$"Unexpected BuiltInType {typeInfo.BuiltInType}");
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|