Files
UA-.NETStandard/tests/Opc.Ua.Core.Tests/LeakDetectionSetup.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

186 lines
8.1 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.Linq;
using NUnit.Framework;
using NUnit.Framework.Interfaces;
using Opc.Ua.Security.Certificates;
using Opc.Ua.Tests;
// Apply leak tracking action to all test fixtures in the assembly.
[assembly: Opc.Ua.Core.Tests.CoreLeakDetectionFixtureAction]
namespace Opc.Ua.Core.Tests
{
/// <summary>
/// Assembly-level setup/teardown that verifies no Certificate
/// instances are leaked during the test run.
/// </summary>
[SetUpFixture]
public class CoreLeakDetectionSetup
{
private static readonly System.Collections.Concurrent.ConcurrentDictionary<string, (long created, long disposed)>
s_fixtureLeaks = new();
[OneTimeSetUp]
public void GlobalSetup()
{
Certificate.ResetLeakCounters();
}
[OneTimeTearDown]
public void GlobalTeardown()
{
// The certificate leak count is driven by explicit Dispose, not by
// finalizers, so it needs no forced GC/finalizer sweep (a no-op for
// the count that can hang on unrelated server/socket finalizers).
// A positive count is re-checked over a short bounded poll first so
// an in-flight background disposal is not misreported as a leak.
long leaked = LeakDetectionHelpers.WaitForOutstandingDisposals();
string summary = $"CoreLeakDetectionSetup: tracked {s_fixtureLeaks.Count} fixtures, " +
$"created={Certificate.InstancesCreated}, " +
$"disposed={Certificate.InstancesDisposed}, leaked={leaked}";
Console.WriteLine(summary);
try
{
string path = System.IO.Path.Combine(System.IO.Path.GetTempPath(), "core-leak-summary.txt");
System.IO.File.AppendAllText(path, summary + "\n");
// Dump ALL fixtures sorted by net delta (positive first, negative last).
System.IO.File.AppendAllText(path, "\nALL FIXTURES (positive net first):\n");
foreach (KeyValuePair<string, (long created, long disposed)> kv in s_fixtureLeaks
.OrderByDescending(kv => kv.Value.created - kv.Value.disposed))
{
long net = kv.Value.created - kv.Value.disposed;
System.IO.File.AppendAllText(path,
$" net={net,4} created={kv.Value.created,4} disposed={kv.Value.disposed,4} {kv.Key}\n");
}
if (Certificate.LeakTrackingEnabled)
{
System.IO.File.AppendAllText(path, "\nLIVE LEAKED CERTIFICATES:\n");
foreach ((
string thumbprint,
int refCount,
DateTime createdAt,
string stackTrace,
string? fixtureName) in
Certificate.EnumerateLiveCertificates())
{
System.IO.File.AppendAllText(path,
$"\n Thumbprint={thumbprint}, RefCount={refCount}, " +
$"CreatedAt={createdAt:O}, Fixture={fixtureName ?? "(unattributed)"}\n" +
$" StackTrace:\n{stackTrace}\n");
}
System.IO.File.AppendAllText(path, "\nUNREACHABLE UNDISPOSED CERTIFICATES:\n");
foreach ((DateTime createdAt, string stackTrace, string? fixtureName) in
Certificate.EnumerateUnreachableUndisposedCertificates())
{
System.IO.File.AppendAllText(path,
$"\n CreatedAt={createdAt:O}, " +
$"Fixture={fixtureName ?? "(unattributed)"}\n" +
$" StackTrace:\n{stackTrace}\n");
}
}
}
catch
{
// ignore
}
if (leaked > 0)
{
string details = string.Join("\n",
s_fixtureLeaks
.Where(kv => kv.Value.created > kv.Value.disposed)
.OrderByDescending(kv => kv.Value.created - kv.Value.disposed)
.Select(kv => $" {kv.Key}: leaked={kv.Value.created - kv.Value.disposed} (created={kv.Value.created}, disposed={kv.Value.disposed})"));
Assert.Fail(
$"Certificate leak detected: {leaked} instance(s) created " +
$"but not disposed (created={Certificate.InstancesCreated}, " +
$"disposed={Certificate.InstancesDisposed}).\n" +
$"Per-fixture breakdown:\n{details}");
}
}
/// <summary>
/// Records the certificate creation/disposal delta for a fixture.
/// </summary>
public static void RecordFixture(string fixtureName, long created, long disposed)
{
s_fixtureLeaks.AddOrUpdate(
fixtureName,
(created, disposed),
(_, prev) => (prev.created + created, prev.disposed + disposed));
}
}
/// <summary>
/// Records Certificate counter deltas per individual test so leaks can
/// be attributed to a specific fixture or test. Lightweight: no per-
/// test GC; the global teardown is responsible for the final GC.
/// </summary>
[AttributeUsage(AttributeTargets.Assembly | AttributeTargets.Class | AttributeTargets.Method)]
public sealed class CoreLeakDetectionFixtureActionAttribute : Attribute, ITestAction
{
private static readonly System.Threading.AsyncLocal<(long created, long disposed, string name)> s_baseline
= new();
public ActionTargets Targets => ActionTargets.Test;
public void BeforeTest(ITest test)
{
if (!test.IsSuite)
{
string parent = test.Parent?.FullName ?? test.FullName;
s_baseline.Value = (
Certificate.InstancesCreated,
Certificate.InstancesDisposed,
parent);
}
}
public void AfterTest(ITest test)
{
if (!test.IsSuite)
{
long createdDelta = Certificate.InstancesCreated - s_baseline.Value.created;
long disposedDelta = Certificate.InstancesDisposed - s_baseline.Value.disposed;
if (createdDelta > 0 || disposedDelta > 0)
{
CoreLeakDetectionSetup.RecordFixture(
s_baseline.Value.name,
createdDelta,
disposedDelta);
}
}
}
}
}