mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-26 04:19:53 +08:00
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
234 lines
9.0 KiB
C#
234 lines
9.0 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Security.Cryptography;
|
|
using BenchmarkDotNet.Attributes;
|
|
using NUnit.Framework;
|
|
|
|
namespace Opc.Ua.Core.Tests.Security.Crypto
|
|
{
|
|
/// <summary>
|
|
/// Measures the per-chunk symmetric crypto the secure channel performs, in
|
|
/// isolation from the network.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// Every other benchmark in the suite measures a full round trip, where the
|
|
/// network dominates and a change of a few hundred nanoseconds is invisible.
|
|
/// This one is what makes a claim about the cost of the per message path
|
|
/// checkable: it is the only place the symmetric encrypt and sign work is
|
|
/// measured on its own.
|
|
/// <para>
|
|
/// Run with:
|
|
/// <c>dotnet run -c Release -f net10.0 -- --filter '*SymmetricChannelCryptoBenchmarks*'</c>
|
|
/// </para>
|
|
/// <para>
|
|
/// The methods double as NUnit tests so the measured code stays correct and
|
|
/// compiled even when nobody runs the benchmark.
|
|
/// </para>
|
|
/// </remarks>
|
|
[TestFixture]
|
|
[Category("CryptoProvider")]
|
|
[Category("Benchmark")]
|
|
[SetCulture("en-us")]
|
|
[SetUICulture("en-us")]
|
|
[MemoryDiagnoser]
|
|
[BenchmarkCategory("SymmetricChannelCrypto")]
|
|
[NonParallelizable]
|
|
public class SymmetricChannelCryptoBenchmarks
|
|
{
|
|
/// <summary>
|
|
/// The size of the message body, in bytes.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// [Params(1024, 8192, 65536)]
|
|
/// </remarks>
|
|
public int PayloadSize { get; set; } = 8192;
|
|
|
|
/// <summary>
|
|
/// The security policy whose algorithms are measured.
|
|
/// </summary>
|
|
public string SecurityPolicyUri { get; set; } = SecurityPolicies.Basic256Sha256;
|
|
|
|
[SetUp]
|
|
[GlobalSetup]
|
|
public void Setup()
|
|
{
|
|
m_policy = SecurityPolicies.Default.GetInfo(SecurityPolicyUri)
|
|
?? throw new InvalidOperationException(
|
|
$"{SecurityPolicyUri} is not supported on this platform.");
|
|
|
|
m_encryptingKey = new byte[m_policy.SymmetricEncryptionKeyLength];
|
|
m_signingKey = new byte[m_policy.DerivedSignatureKeyLength];
|
|
m_iv = new byte[m_policy.InitializationVectorLength];
|
|
|
|
using var rng = RandomNumberGenerator.Create();
|
|
rng.GetBytes(m_encryptingKey);
|
|
rng.GetBytes(m_signingKey);
|
|
rng.GetBytes(m_iv);
|
|
|
|
m_hmac = m_policy.CreateSignatureHmac(m_signingKey)!;
|
|
|
|
// Leave room for padding and the signature, as the channel does.
|
|
m_buffer = new byte[PayloadSize + 512];
|
|
rng.GetBytes(m_buffer);
|
|
}
|
|
|
|
[TearDown]
|
|
[GlobalCleanup]
|
|
public void Cleanup()
|
|
{
|
|
m_hmac?.Dispose();
|
|
m_hmac = null!;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Encrypt and sign one chunk, which is what the channel does per message.
|
|
/// </summary>
|
|
[Benchmark(Baseline = true)]
|
|
[Test]
|
|
public void EncryptAndSign()
|
|
{
|
|
var data = new ArraySegment<byte>(m_buffer, HeaderSize, PayloadSize);
|
|
|
|
ArraySegment<byte> result = CryptoUtils.SymmetricEncryptAndSign(
|
|
data, m_policy, m_encryptingKey, m_iv, m_signingKey, m_hmac);
|
|
|
|
Assert.That(result, Is.Not.Empty);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Sign only, which is what a channel in Sign mode does per message.
|
|
/// </summary>
|
|
[Benchmark]
|
|
[Test]
|
|
public void SignOnly()
|
|
{
|
|
var data = new ArraySegment<byte>(m_buffer, HeaderSize, PayloadSize);
|
|
|
|
ArraySegment<byte> result = CryptoUtils.SymmetricEncryptAndSign(
|
|
data, m_policy, m_encryptingKey, m_iv, m_signingKey, m_hmac, signOnly: true);
|
|
|
|
Assert.That(result, Is.Not.Empty);
|
|
}
|
|
|
|
/// <summary>
|
|
/// A round trip, which is what a request and its response cost together.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// The decrypt side is given the pre-allocated HMAC, which is what the
|
|
/// channel does: it keeps one per token rather than building one per
|
|
/// chunk.
|
|
/// </remarks>
|
|
[Benchmark]
|
|
[Test]
|
|
public void EncryptSignThenDecryptVerify()
|
|
{
|
|
var data = new ArraySegment<byte>(m_buffer, HeaderSize, PayloadSize);
|
|
|
|
ArraySegment<byte> protectedData = CryptoUtils.SymmetricEncryptAndSign(
|
|
data, m_policy, m_encryptingKey, m_iv, m_signingKey, m_hmac);
|
|
|
|
var toVerify = new ArraySegment<byte>(
|
|
protectedData.Array!, HeaderSize, protectedData.Count - HeaderSize);
|
|
|
|
ArraySegment<byte> plain = CryptoUtils.SymmetricDecryptAndVerify(
|
|
toVerify, m_policy, m_encryptingKey, m_iv, m_signingKey,
|
|
signOnly: false, tokenId: 0, lastSequenceNumber: 0, hmac: m_hmac);
|
|
|
|
Assert.That(plain, Is.Not.Empty);
|
|
}
|
|
|
|
/// <summary>
|
|
/// The same round trip without a caller supplied HMAC, which is the
|
|
/// fallback path for callers outside the channel.
|
|
/// </summary>
|
|
[Benchmark]
|
|
[Test]
|
|
public void EncryptSignThenDecryptVerifyWithoutSharedHmac()
|
|
{
|
|
var data = new ArraySegment<byte>(m_buffer, HeaderSize, PayloadSize);
|
|
|
|
ArraySegment<byte> protectedData = CryptoUtils.SymmetricEncryptAndSign(
|
|
data, m_policy, m_encryptingKey, m_iv, m_signingKey, m_hmac);
|
|
|
|
var toVerify = new ArraySegment<byte>(
|
|
protectedData.Array!, HeaderSize, protectedData.Count - HeaderSize);
|
|
|
|
ArraySegment<byte> plain = CryptoUtils.SymmetricDecryptAndVerify(
|
|
toVerify, m_policy, m_encryptingKey, m_iv, m_signingKey);
|
|
|
|
Assert.That(plain, Is.Not.Empty);
|
|
}
|
|
|
|
/// <summary>
|
|
/// The same round trip through a registered symmetric provider, which is
|
|
/// what a deployment running a validated module pays.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// This is the measurement the seam is gated on. The benchmark above is
|
|
/// the baseline: the difference between the two is the whole cost of the
|
|
/// indirection, and it is only paid by a deployment that asked for it —
|
|
/// resolution yields nothing when no provider is registered, so the
|
|
/// default configuration takes the path measured above with no interface
|
|
/// dispatch at all.
|
|
/// </remarks>
|
|
[Benchmark]
|
|
[Test]
|
|
public void EncryptSignThenDecryptVerifyThroughProvider()
|
|
{
|
|
var data = new ArraySegment<byte>(m_buffer, HeaderSize, PayloadSize);
|
|
|
|
ArraySegment<byte> protectedData = CryptoUtils.SymmetricEncryptAndSign(
|
|
data, m_policy, m_encryptingKey, m_iv, m_signingKey, null,
|
|
signOnly: false, tokenId: 0, lastSequenceNumber: 0,
|
|
provider: PlatformSymmetricCryptoProvider.Instance);
|
|
|
|
var toVerify = new ArraySegment<byte>(
|
|
protectedData.Array!, HeaderSize, protectedData.Count - HeaderSize);
|
|
|
|
ArraySegment<byte> plain = CryptoUtils.SymmetricDecryptAndVerify(
|
|
toVerify, m_policy, m_encryptingKey, m_iv, m_signingKey,
|
|
signOnly: false, tokenId: 0, lastSequenceNumber: 0, hmac: null,
|
|
provider: PlatformSymmetricCryptoProvider.Instance);
|
|
|
|
Assert.That(plain, Is.Not.Empty);
|
|
}
|
|
|
|
private const int HeaderSize = 24;
|
|
|
|
private SecurityPolicyInfo m_policy;
|
|
private byte[] m_buffer;
|
|
private byte[] m_encryptingKey;
|
|
private byte[] m_signingKey;
|
|
private byte[] m_iv;
|
|
private HMAC m_hmac;
|
|
}
|
|
}
|