Files
UA-.NETStandard/tests/Opc.Ua.Core.Tests/Security/Identity/IssuedIdentityTokenHandlerTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

255 lines
12 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Security.Cryptography;
using System.Security.Cryptography.X509Certificates;
using System.Threading.Tasks;
using NUnit.Framework;
using Opc.Ua.Security.Certificates;
using Opc.Ua.Tests;
namespace Opc.Ua.Core.Tests.Security.Identity
{
[TestFixture]
[Category("Identity")]
[Parallelizable]
public sealed class IssuedIdentityTokenHandlerTests
{
[TestCase(Namespaces.OpcUa + "UserToken#GenericWSS", IssuedTokenType.GenericWSS, "Generic WSS Token")]
[TestCase(Namespaces.OpcUa + "UserToken#SAML", IssuedTokenType.SAML, "SAML Token")]
[TestCase(Profiles.JwtUserToken, IssuedTokenType.JWT, "JWT")]
[TestCase(Namespaces.OpcUa + "UserToken#KerberosBinary", IssuedTokenType.KerberosBinary, "Kerberos Token")]
[TestCase("urn:custom", IssuedTokenType.Unknown, "Issued Token")]
public void IssuedTokenTypeAndDisplayNameFollowProfileUri(
string profileUri,
IssuedTokenType expectedType,
string expectedDisplayName)
{
var handler = new IssuedIdentityTokenHandler(profileUri, [1, 2, 3]);
Assert.That(handler.TokenType, Is.EqualTo(UserTokenType.IssuedToken));
Assert.That(handler.IssuedTokenType, Is.EqualTo(expectedType));
Assert.That(handler.DisplayName, Is.EqualTo(expectedDisplayName));
Assert.That(handler.IssuedTokenTypeProfileUri, Is.EqualTo(profileUri));
}
[Test]
public void ConstructorDefaultsPolicyIdToJwtProfile()
{
var token = new IssuedIdentityToken();
var handler = new IssuedIdentityTokenHandler(token);
Assert.That(handler.IssuedTokenType, Is.EqualTo(IssuedTokenType.JWT));
Assert.That(token.PolicyId, Is.EqualTo(Profiles.JwtUserToken));
}
[Test]
public void DecryptedTokenDataUsesDefensiveCopiesAndClearsPreviousValue()
{
byte[] original = [1, 2, 3];
var handler = new IssuedIdentityTokenHandler(Profiles.JwtUserToken, original);
byte[] firstCopy = handler.DecryptedTokenData!;
firstCopy![0] = 99;
handler.DecryptedTokenData = [4, 5];
Assert.That(handler.DecryptedTokenData, Is.EqualTo(new byte[] { 4, 5 }));
Assert.That(firstCopy, Is.EqualTo(new byte[] { 99, 2, 3 }));
handler.DecryptedTokenData = null;
Assert.That(handler.DecryptedTokenData, Is.Null);
}
[Test]
public async Task EncryptAndDecryptWithSecurityNoneRoundTripsTokenDataAsync()
{
var handler = new IssuedIdentityTokenHandler(Profiles.JwtUserToken, [0x10, 0x20, 0x30]);
IServiceMessageContext context = ServiceMessageContext.Create(NUnitTelemetryContext.Create());
await handler.EncryptAsync(null!, [], SecurityPolicies.None, context).ConfigureAwait(false);
Assert.That(((IssuedIdentityToken)handler.Token).EncryptionAlgorithm, Is.EqualTo(string.Empty));
Assert.That(((IssuedIdentityToken)handler.Token).TokenData.ToArray(), Is.EqualTo(new byte[] { 0x10, 0x20, 0x30 }));
var encryptedToken = new IssuedIdentityToken
{
PolicyId = Profiles.JwtUserToken,
TokenData = new byte[] { 0x10, 0x20, 0x30 }.ToByteString()
};
handler = new IssuedIdentityTokenHandler(encryptedToken);
await handler.DecryptAsync(null!, null!, SecurityPolicies.None, context).ConfigureAwait(false);
Assert.That(handler.DecryptedTokenData, Is.EqualTo(new byte[] { 0x10, 0x20, 0x30 }));
}
[Test]
public async Task EccEncryptionReleasesTemporaryNonceAndIssuerHandlesAsync(
[Values] bool missingTokenData,
[Values] bool rsaDh)
{
string policyUri = rsaDh ? SecurityPolicies.RSA_DH_AesGcm : SecurityPolicies.ECC_nistP256;
SecurityPolicyInfo? policy = SecurityPolicies.Default.GetInfo(policyUri);
IServiceMessageContext context = ServiceMessageContext.Create(NUnitTelemetryContext.Create());
if (policy == null)
{
var unsupported = new IssuedIdentityTokenHandler(Profiles.JwtUserToken, [1, 2, 3]);
ServiceResultException error = Assert.ThrowsAsync<ServiceResultException>(
async () => await unsupported.EncryptAsync(null!, [], policyUri, context).ConfigureAwait(false));
Assert.That(error.StatusCode, Is.EqualTo(StatusCodes.BadSecurityPolicyRejected));
return;
}
using Certificate sender = CreateSigningCertificate("CN=Issued Token Sender", rsaDh);
using Certificate receiver = CreateSigningCertificate("CN=Issued Token Receiver", rsaDh);
using Certificate issuerTemplate = CreateSigningCertificate("CN=Issued Token Issuer", rsaDh, ca: true);
X509Certificate2 issuerNative = issuerTemplate.AsX509Certificate2();
using var issuer = Certificate.From(issuerNative);
using var chain = new CertificateCollection { sender, issuer };
using var receiverKey = Nonce.CreateNonce(policy);
using var temporarySenderKey = Nonce.CreateNonce(policy);
byte[] expected = [0x10, 0x20, 0x30];
byte[] nonce = Nonce.CreateRandomNonceData(32);
var handler = new IssuedIdentityTokenHandler(
new IssuedIdentityToken { PolicyId = Profiles.JwtUserToken },
null,
_ => temporarySenderKey)
{
DecryptedTokenData = missingTokenData ? null : expected
};
if (missingTokenData)
{
ServiceResultException error = Assert.ThrowsAsync<ServiceResultException>(
async () => await handler.EncryptAsync(
receiver, nonce, policyUri, context, receiverKey, sender, chain, true).ConfigureAwait(false));
Assert.That(error.StatusCode, Is.EqualTo(StatusCodes.BadIdentityTokenInvalid));
}
else
{
await handler.EncryptAsync(
receiver, nonce, policyUri, context, receiverKey, sender, chain, true).ConfigureAwait(false);
using var decryptor = EncryptedSecret.CreateForEcc(
context, policyUri, chain, receiver, receiverKey, sender, null!);
(bool success, byte[]? secret) = await decryptor.TryDecryptAsync(
((IssuedIdentityToken)handler.Token).TokenData.ToArray(), nonce).ConfigureAwait(false);
Assert.That(success, Is.True);
Assert.That(secret, Is.EqualTo(expected));
CryptoUtils.ZeroMemory(secret);
}
Assert.That(chain, Has.Count.EqualTo(2));
Assert.That(chain[1].Thumbprint, Is.EqualTo(issuer.Thumbprint));
chain.Dispose();
issuer.Dispose();
byte[] retainedSecret = temporarySenderKey.GenerateSecret(receiverKey, null)!;
try
{
Assert.Multiple(() =>
{
Assert.That(retainedSecret?.Length, Is.Null,
"The temporary sender agreement key must be released.");
Assert.That(issuerNative.Handle, Is.EqualTo(IntPtr.Zero),
"The filtered issuer collection must not retain an extra owning handle.");
Assert.That(sender.HasPrivateKey, Is.True);
Assert.That(receiver.HasPrivateKey, Is.True);
});
}
finally
{
if (retainedSecret != null)
{
CryptoUtils.ZeroMemory(retainedSecret);
}
}
}
[Test]
public void UpdatePolicyChangesPolicyAndProfile()
{
var handler = new IssuedIdentityTokenHandler(Profiles.JwtUserToken, [1]);
var policy = new UserTokenPolicy
{
PolicyId = "issued",
IssuedTokenType = Namespaces.OpcUa + "UserToken#SAML"
};
handler.UpdatePolicy(policy);
Assert.That(handler.Token.PolicyId, Is.EqualTo("issued"));
Assert.That(handler.IssuedTokenTypeProfileUri, Is.EqualTo(policy.IssuedTokenType));
Assert.That(handler.IssuedTokenType, Is.EqualTo(IssuedTokenType.SAML));
}
[Test]
public async Task SignAndVerifyAreNoOpsForIssuedTokensAsync()
{
var handler = new IssuedIdentityTokenHandler(Profiles.JwtUserToken, [1]);
SignatureData signature = await handler
.SignAsync([1, 2, 3], SecurityPolicies.None)
.ConfigureAwait(false);
bool verified = await handler
.VerifyAsync([1, 2, 3], signature, SecurityPolicies.None)
.ConfigureAwait(false);
Assert.That(signature, Is.Null);
Assert.That(verified, Is.True);
}
[Test]
public void CloneCopiesTokenAndEqualsComparesTokenData()
{
var handler = new IssuedIdentityTokenHandler(Profiles.JwtUserToken, [7, 8, 9])
{
DecryptedTokenData = [7, 8, 9]
};
var clone = (IssuedIdentityTokenHandler)handler.Clone();
Assert.That(clone, Is.Not.SameAs(handler));
Assert.That(clone.IssuedTokenTypeProfileUri, Is.EqualTo(handler.IssuedTokenTypeProfileUri));
Assert.That(clone.DecryptedTokenData, Is.EqualTo(handler.DecryptedTokenData));
bool equalsClone = handler.Equals(clone);
bool equalsOtherHandler = handler.Equals(new UserNameIdentityTokenHandler("user", [1]));
Assert.That(equalsClone, Is.True);
Assert.That(equalsOtherHandler, Is.False);
}
private static Certificate CreateSigningCertificate(string subject, bool rsa, bool ca = false)
{
ICertificateBuilder builder = CertificateBuilder.Create(subject);
if (ca)
{
builder.SetCAConstraint();
}
return rsa ? builder.CreateForRSA() : builder.SetECCurve(ECCurve.NamedCurves.nistP256).CreateForECDsa();
}
}
}