Files
UA-.NETStandard/tests/Opc.Ua.Features.Tests/RoleManagementIntegrationTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

426 lines
18 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Threading.Tasks;
using NUnit.Framework;
using Opc.Ua.Client.Roles;
using Opc.Ua.Client.TestFramework;
using Opc.Ua.Server.TestFramework;
using Opc.Ua.Tests;
using Quickstarts.ReferenceServer;
using ISession = Opc.Ua.Client.ISession;
namespace Opc.Ua.Features.Tests
{
/// <summary>
/// End-to-end tests that exercise the client-side
/// <see cref="RoleManagementClient"/> against a real
/// <see cref="ReferenceServer"/> over an encrypted secure channel.
/// </summary>
/// <remarks>
/// <para>
/// The reference server seeds <c>sysadmin/demo</c> with
/// <c>Role.SecurityAdmin + Role.AuthenticatedUser</c> in its
/// <see cref="LinqUserDatabase"/> bootstrap, so these tests can drive
/// the SecurityAdmin-only RoleSet methods directly without further
/// configuration. Tests use <c>SecurityPolicies.Basic256Sha256</c> so
/// the channel SecurityMode is <c>SignAndEncrypt</c> as required by
/// the <see cref="Server.RoleAuthorizationGate"/>.
/// </para>
/// <para>
/// Each test is fully isolated — a fresh <c>ServerFixture</c> +
/// <c>ClientFixture</c> is built in <c>[SetUp]</c> so role-manager
/// state never leaks between tests.
/// </para>
/// </remarks>
[TestFixture]
[Category("Client")]
[Category("Roles")]
[Category("Integration")]
[SetCulture("en-us")]
[SetUICulture("en-us")]
public class RoleManagementIntegrationTests
{
private const string SysAdminUser = "sysadmin";
private ServerFixture<ReferenceServer> m_serverFixture = null!;
private ClientFixture m_clientFixture = null!;
private ReferenceServer m_server = null!;
private ISession m_session = null!;
private string m_pkiRoot = null!;
private ITelemetryContext m_telemetry = null!;
[SetUp]
public async Task SetUpAsync()
{
m_telemetry = NUnitTelemetryContext.Create();
m_pkiRoot = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());
m_serverFixture = new ServerFixture<ReferenceServer>(t => new ReferenceServer(t))
{
UriScheme = Utils.UriSchemeOpcTcp,
SecurityNone = true,
AutoAccept = true,
AllNodeManagers = false,
OperationLimits = true
};
await m_serverFixture.LoadConfigurationAsync(m_pkiRoot).ConfigureAwait(false);
// Add UserName token policies for the SignAndEncrypt channel so
// the server accepts the sysadmin/demo USERNAME identity over a
// secure channel. The default reference-server configuration
// ships with no explicit user-token policies in some templates.
m_serverFixture.Config.ServerConfiguration!.UserTokenPolicies +=
new UserTokenPolicy(UserTokenType.UserName);
m_serverFixture.Config.ServerConfiguration!.UserTokenPolicies +=
new UserTokenPolicy(UserTokenType.UserName)
{
SecurityPolicyUri = SecurityPolicies.Basic256Sha256
};
m_server = await m_serverFixture.StartAsync().ConfigureAwait(false);
Assert.That(m_server, Is.Not.Null);
m_clientFixture = new ClientFixture(false, false, m_telemetry);
await m_clientFixture.LoadClientConfigurationAsync(m_pkiRoot).ConfigureAwait(false);
string url = $"{Utils.UriSchemeOpcTcp}://localhost:{m_serverFixture.Port}";
var sysAdminIdentity = new UserIdentity(SysAdminUser, "demo"u8);
m_session = await m_clientFixture
.ConnectAsync(new Uri(url), SecurityPolicies.Basic256Sha256, userIdentity: sysAdminIdentity)
.ConfigureAwait(false);
}
[TearDown]
public async Task TearDownAsync()
{
try
{
if (m_session != null)
{
await m_session.CloseAsync().ConfigureAwait(false);
m_session.Dispose();
}
}
catch
{
}
if (m_serverFixture != null)
{
await m_serverFixture.StopAsync().ConfigureAwait(false);
}
m_clientFixture?.Dispose();
TryDeleteDirectory(m_pkiRoot);
}
private static void TryDeleteDirectory(string path)
{
try
{
if (!string.IsNullOrEmpty(path) && Directory.Exists(path))
{
Directory.Delete(path, recursive: true);
}
}
catch
{
}
}
// ----------------------------------------------------------------
// Browse / read
// ----------------------------------------------------------------
[Test]
public async Task ListRolesAsync_ReturnsAllWellKnownRolesAsync()
{
var client = new RoleManagementClient(m_session);
IReadOnlyList<RoleInfo> roles = await client.ListRolesAsync().ConfigureAwait(false);
// Part 3 §4.9 defines nine well-known roles which the server's
// default RoleManager pre-populates.
string[] expectedNames =
[
BrowseNames.WellKnownRole_Anonymous,
BrowseNames.WellKnownRole_AuthenticatedUser,
BrowseNames.WellKnownRole_Observer,
BrowseNames.WellKnownRole_Operator,
BrowseNames.WellKnownRole_Engineer,
BrowseNames.WellKnownRole_Supervisor,
BrowseNames.WellKnownRole_ConfigureAdmin,
BrowseNames.WellKnownRole_SecurityAdmin,
BrowseNames.WellKnownRole_TrustedApplication
];
foreach (string expected in expectedNames)
{
Assert.That(roles.Any(r => string.Equals(r.BrowseName.Name, expected, StringComparison.Ordinal)),
Is.True,
$"ListRoles must include the well-known role {expected}.");
}
}
[Test]
public async Task ReadRoleAsync_SecurityAdminRole_ReturnsExpectedNodeIdsAsync()
{
var client = new RoleManagementClient(m_session);
RoleInfo info = await client.ReadRoleAsync(ObjectIds.WellKnownRole_SecurityAdmin)
.ConfigureAwait(false);
Assert.That(info, Is.Not.Null);
Assert.That(info.RoleId, Is.EqualTo(ObjectIds.WellKnownRole_SecurityAdmin));
Assert.That(info.BrowseName.Name,
Is.EqualTo(BrowseNames.WellKnownRole_SecurityAdmin));
}
// ----------------------------------------------------------------
// Identity mutations under SecurityAdmin + SignAndEncrypt
// ----------------------------------------------------------------
[Test]
public async Task AddIdentityAsync_Authorised_SucceedsAsync()
{
var client = new RoleManagementClient(m_session);
await client.AddIdentityAsync(
ObjectIds.WellKnownRole_Observer,
new IdentityMappingRuleType
{
CriteriaType = IdentityCriteriaType.UserName,
Criteria = "alice"
}).ConfigureAwait(false);
// No exception ⇒ the typed AddIdentity call succeeded over the
// wire and the server's RoleManager state was mutated.
RoleInfo refreshed = await client.ReadRoleAsync(ObjectIds.WellKnownRole_Observer)
.ConfigureAwait(false);
Assert.That(refreshed.Identities.Any(r =>
r.CriteriaType == IdentityCriteriaType.UserName &&
string.Equals(r.Criteria, "alice", StringComparison.Ordinal)),
Is.True,
"The persisted IdentityMappingRule should be visible on subsequent reads.");
}
[Test]
public async Task RemoveIdentityAsync_Authorised_DropsMappingAsync()
{
var client = new RoleManagementClient(m_session);
var rule = new IdentityMappingRuleType
{
CriteriaType = IdentityCriteriaType.UserName,
Criteria = "bob"
};
await client.AddIdentityAsync(ObjectIds.WellKnownRole_Operator, rule)
.ConfigureAwait(false);
await client.RemoveIdentityAsync(ObjectIds.WellKnownRole_Operator, rule)
.ConfigureAwait(false);
RoleInfo refreshed = await client.ReadRoleAsync(ObjectIds.WellKnownRole_Operator)
.ConfigureAwait(false);
Assert.That(refreshed.Identities.Any(r =>
r.CriteriaType == IdentityCriteriaType.UserName &&
string.Equals(r.Criteria, "bob", StringComparison.Ordinal)),
Is.False,
"RemoveIdentity should drop the rule from the role manager.");
}
// ----------------------------------------------------------------
// Application / exclude flag
// ----------------------------------------------------------------
[Test]
public async Task AddApplicationAsync_Authorised_AddsAppUriAsync()
{
var client = new RoleManagementClient(m_session);
await client.AddApplicationAsync(
ObjectIds.WellKnownRole_Observer,
"urn:test:role-management:app").ConfigureAwait(false);
RoleInfo refreshed = await client.ReadRoleAsync(ObjectIds.WellKnownRole_Observer)
.ConfigureAwait(false);
// Applications is an ArrayOf<string> snapshot; convert to a
// local list for assertion clarity.
var apps = new List<string>();
apps.AddRange(refreshed.Applications);
Assert.That(apps, Has.Member("urn:test:role-management:app"),
"The added ApplicationUri should be visible on subsequent reads.");
}
[Test]
public async Task SetApplicationsExcludeAsync_Authorised_PersistsAsync()
{
var client = new RoleManagementClient(m_session);
await client.SetApplicationsExcludeAsync(
ObjectIds.WellKnownRole_Observer, true).ConfigureAwait(false);
RoleInfo refreshed = await client.ReadRoleAsync(ObjectIds.WellKnownRole_Observer)
.ConfigureAwait(false);
Assert.That(refreshed.ApplicationsExclude, Is.True);
// Toggle back and verify.
await client.SetApplicationsExcludeAsync(
ObjectIds.WellKnownRole_Observer, false).ConfigureAwait(false);
refreshed = await client.ReadRoleAsync(ObjectIds.WellKnownRole_Observer)
.ConfigureAwait(false);
Assert.That(refreshed.ApplicationsExclude, Is.False);
}
// ----------------------------------------------------------------
// Dynamic role materialization
// ----------------------------------------------------------------
[Test]
public async Task AddRoleAsync_Authorised_MaterializesRoleAndIsBrowseableAsync()
{
var client = new RoleManagementClient(m_session);
NodeId newRoleId = await client.AddRoleAsync(
"IntegrationTestRole_Add",
namespaceUri: null).ConfigureAwait(false);
Assert.That(newRoleId.IsNull, Is.False,
"AddRole should return the allocated NodeId.");
// The new role must show up in ListRoles immediately — proves
// the dynamic materialization landed in the address space.
IReadOnlyList<RoleInfo> roles = await client.ListRolesAsync()
.ConfigureAwait(false);
Assert.That(roles.Any(r => r.RoleId == newRoleId), Is.True,
"ListRoles must include the newly added role.");
// And we should be able to call AddIdentity on it via the same
// typed proxy chain.
await client.AddIdentityAsync(
newRoleId,
new IdentityMappingRuleType
{
CriteriaType = IdentityCriteriaType.UserName,
Criteria = "carol"
}).ConfigureAwait(false);
RoleInfo refreshed = await client.ReadRoleAsync(newRoleId)
.ConfigureAwait(false);
Assert.That(refreshed.Identities.Any(r =>
r.CriteriaType == IdentityCriteriaType.UserName &&
string.Equals(r.Criteria, "carol", StringComparison.Ordinal)),
Is.True,
"AddIdentity on a dynamically-added role must persist via the role manager.");
}
[Test]
public async Task AddRoleAsync_ModelNamespaceUri_QualifiesTheBrowseNameOnlyAsync()
{
// Per Part 18 §4.2.2 the NamespaceUri argument names the namespace
// of the new role's BrowseName. The NodeId stays server-assigned:
// allocating it in the caller's namespace lets a SecurityAdmin hand
// out identifiers that already belong to a node manager's model and
// replace its nodes.
string modelNamespaceUri = Quickstarts.ReferenceServer.Namespaces.ReferenceServer;
var modelNamespaceIndex = (ushort)m_session.NamespaceUris.GetIndex(modelNamespaceUri);
Assume.That(modelNamespaceIndex, Is.GreaterThan(0),
"The reference server must expose its model namespace.");
var client = new RoleManagementClient(m_session);
NodeId newRoleId = await client.AddRoleAsync(
"IntegrationTestRole_ModelNamespace",
modelNamespaceUri).ConfigureAwait(false);
Assert.That(newRoleId.NamespaceIndex, Is.Not.EqualTo(modelNamespaceIndex),
"The role NodeId must not be allocated in the model's namespace.");
RoleInfo role = await client.ReadRoleAsync(newRoleId).ConfigureAwait(false);
Assert.That(role.BrowseName.Name, Is.EqualTo("IntegrationTestRole_ModelNamespace"));
Assert.That(role.BrowseName.NamespaceIndex, Is.EqualTo(modelNamespaceIndex),
"NamespaceUri must qualify the BrowseName of the new role.");
IReadOnlyList<RoleInfo> roles = await client.ListRolesAsync().ConfigureAwait(false);
Assert.That(roles.Any(r => r.RoleId == newRoleId), Is.True,
"The new role must be browsable under the RoleSet.");
}
[Test]
public async Task RemoveRoleAsync_Authorised_DropsRoleFromAddressSpaceAsync()
{
var client = new RoleManagementClient(m_session);
NodeId newRoleId = await client.AddRoleAsync(
"IntegrationTestRole_Remove", namespaceUri: null).ConfigureAwait(false);
Assume.That(newRoleId.IsNull, Is.False);
await client.RemoveRoleAsync(newRoleId).ConfigureAwait(false);
IReadOnlyList<RoleInfo> roles = await client.ListRolesAsync()
.ConfigureAwait(false);
Assert.That(roles.Any(r => r.RoleId == newRoleId), Is.False,
"ListRoles must no longer include the removed role.");
}
// ----------------------------------------------------------------
// Reserved role enforcement
// ----------------------------------------------------------------
[Test]
public void AddIdentityAsync_AnonymousReservedRole_RejectedByServer()
{
var client = new RoleManagementClient(m_session);
// Per Part 3 §4.9 the Anonymous role's identity mapping is
// immutable. The standard nodeset doesn't materialize an
// AddIdentity method on Anonymous, so the client gets either
// BadNoMatch when resolving the child or BadInvalidArgument /
// BadInvalidState if a reserved-role guard hits first. Any of
// these proves the reserved role can't be mutated.
ServiceResultException? ex = Assert.ThrowsAsync<ServiceResultException>(async () =>
await client.AddIdentityAsync(
ObjectIds.WellKnownRole_Anonymous,
new IdentityMappingRuleType
{
CriteriaType = IdentityCriteriaType.UserName,
Criteria = "should-not-stick"
}).ConfigureAwait(false));
Assert.That(ex!.StatusCode,
Is.EqualTo(StatusCodes.BadInvalidArgument)
.Or.EqualTo(StatusCodes.BadInvalidState)
.Or.EqualTo(StatusCodes.BadNoMatch),
"Reserved-role AddIdentity must be rejected.");
}
}
}