mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-22 09:37:12 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
356 lines
16 KiB
C#
356 lines
16 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
using System;
|
|
using System.Linq;
|
|
using System.Security.Cryptography;
|
|
using System.Text;
|
|
using System.Text.Json;
|
|
using System.Threading.Tasks;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Client.TestFramework;
|
|
using Opc.Ua.Gds.Server;
|
|
using Opc.Ua.Gds.Server.Hosting;
|
|
using Opc.Ua.Gds.Server.Identity;
|
|
using Opc.Ua.Security.Certificates;
|
|
using Opc.Ua.Tests;
|
|
|
|
namespace Opc.Ua.Gds.Tests.AuthorizationService
|
|
{
|
|
[TestFixture]
|
|
[Category("AuthorizationService")]
|
|
[SetCulture("en-us")]
|
|
[SetUICulture("en-us")]
|
|
[Parallelizable]
|
|
public sealed class InMemoryAccessTokenProviderRefreshTests
|
|
{
|
|
private const string Issuer = "urn:opcua:test:gds";
|
|
private const string Audience = "urn:opcua:test:server";
|
|
private static readonly string[] s_authenticatedUserRole = ["AuthenticatedUser"];
|
|
|
|
[Test]
|
|
public async Task RefreshTokenAsyncReturnsNewAccessAndRefreshToken()
|
|
{
|
|
using Certificate certificate = CreateCertificate();
|
|
using var certificateProvider = new InProcessCertificateProvider(certificate);
|
|
AuthorizationServiceOptions options = CreateOptions(certificate);
|
|
InMemoryAccessTokenProvider provider = CreateProvider(certificateProvider, options);
|
|
|
|
AccessTokenResult original = await IssueTokenAsync(provider).ConfigureAwait(false);
|
|
AccessTokenResult refreshed = await provider
|
|
.RefreshTokenAsync(Audience, original.RefreshToken!)
|
|
.ConfigureAwait(false);
|
|
|
|
Assert.That(refreshed.AccessToken, Does.Contain("."));
|
|
Assert.That(refreshed.AccessTokenExpiryTime, Is.GreaterThan(DateTime.UtcNow));
|
|
Assert.That(refreshed.RefreshToken, Is.Not.Null.And.Not.Empty);
|
|
Assert.That(refreshed.RefreshToken, Is.Not.EqualTo(original.RefreshToken));
|
|
Assert.That(refreshed.RefreshTokenExpiryTime, Is.GreaterThan(DateTime.UtcNow));
|
|
}
|
|
|
|
[Test]
|
|
public async Task RefreshTokenAsyncRotatesRefreshTokenSoOldOneIsRevoked()
|
|
{
|
|
using Certificate certificate = CreateCertificate();
|
|
using var certificateProvider = new InProcessCertificateProvider(certificate);
|
|
AuthorizationServiceOptions options = CreateOptions(certificate);
|
|
InMemoryAccessTokenProvider provider = CreateProvider(certificateProvider, options);
|
|
|
|
AccessTokenResult original = await IssueTokenAsync(provider).ConfigureAwait(false);
|
|
await provider.RefreshTokenAsync(Audience, original.RefreshToken!).ConfigureAwait(false);
|
|
|
|
await AssertServiceResultAsync(
|
|
() => provider.RefreshTokenAsync(Audience, original.RefreshToken!),
|
|
StatusCodes.BadIdentityTokenRejected,
|
|
"already been used").ConfigureAwait(false);
|
|
}
|
|
|
|
[Test]
|
|
public async Task RefreshTokenAsyncRejectsUnknownToken()
|
|
{
|
|
using Certificate certificate = CreateCertificate();
|
|
using var certificateProvider = new InProcessCertificateProvider(certificate);
|
|
AuthorizationServiceOptions options = CreateOptions(certificate);
|
|
InMemoryAccessTokenProvider provider = CreateProvider(certificateProvider, options);
|
|
|
|
await AssertServiceResultAsync(
|
|
() => provider.RefreshTokenAsync(Audience, new string('A', 64)),
|
|
StatusCodes.BadIdentityTokenRejected,
|
|
"Unknown refresh token").ConfigureAwait(false);
|
|
}
|
|
|
|
[Test]
|
|
public async Task RefreshTokenAsyncRejectsExpiredToken()
|
|
{
|
|
using Certificate certificate = CreateCertificate();
|
|
using var certificateProvider = new InProcessCertificateProvider(certificate);
|
|
AuthorizationServiceOptions options = CreateOptions(certificate);
|
|
options.DefaultRefreshTokenLifetime = TimeSpan.FromMilliseconds(50);
|
|
InMemoryAccessTokenProvider provider = CreateProvider(certificateProvider, options);
|
|
|
|
AccessTokenResult original = await IssueTokenAsync(provider).ConfigureAwait(false);
|
|
await Task.Delay(150).ConfigureAwait(false);
|
|
|
|
await AssertServiceResultAsync(
|
|
() => provider.RefreshTokenAsync(Audience, original.RefreshToken!),
|
|
StatusCodes.BadTimeout,
|
|
"expired").ConfigureAwait(false);
|
|
}
|
|
|
|
[Test]
|
|
public async Task RefreshTokenAsyncRejectsResourceIdMismatch()
|
|
{
|
|
using Certificate certificate = CreateCertificate();
|
|
using var certificateProvider = new InProcessCertificateProvider(certificate);
|
|
AuthorizationServiceOptions options = CreateOptions(certificate);
|
|
InMemoryAccessTokenProvider provider = CreateProvider(certificateProvider, options);
|
|
|
|
AccessTokenResult original = await IssueTokenAsync(provider, "urn:resource:A").ConfigureAwait(false);
|
|
|
|
await AssertServiceResultAsync(
|
|
() => provider.RefreshTokenAsync("urn:resource:B", original.RefreshToken!),
|
|
StatusCodes.BadInvalidArgument,
|
|
"different resource").ConfigureAwait(false);
|
|
}
|
|
|
|
[Test]
|
|
public async Task RefreshTokenAsyncRejectsEmptyInputs()
|
|
{
|
|
using Certificate certificate = CreateCertificate();
|
|
using var certificateProvider = new InProcessCertificateProvider(certificate);
|
|
AuthorizationServiceOptions options = CreateOptions(certificate);
|
|
InMemoryAccessTokenProvider provider = CreateProvider(certificateProvider, options);
|
|
|
|
await AssertServiceResultAsync(
|
|
() => provider.RefreshTokenAsync(string.Empty, new string('A', 64)),
|
|
StatusCodes.BadInvalidArgument,
|
|
"Resource id is required").ConfigureAwait(false);
|
|
|
|
await AssertServiceResultAsync(
|
|
() => provider.RefreshTokenAsync(Audience, string.Empty),
|
|
StatusCodes.BadInvalidArgument,
|
|
"Refresh token is required").ConfigureAwait(false);
|
|
}
|
|
|
|
[Test]
|
|
public async Task RefreshTokenAsyncDisabledFlagThrowsBadNotSupported()
|
|
{
|
|
using Certificate certificate = CreateCertificate();
|
|
using var certificateProvider = new InProcessCertificateProvider(certificate);
|
|
AuthorizationServiceOptions options = CreateOptions(certificate);
|
|
options.EnableRefreshTokens = false;
|
|
InMemoryAccessTokenProvider provider = CreateProvider(certificateProvider, options);
|
|
|
|
AccessTokenResult original = await IssueTokenAsync(provider).ConfigureAwait(false);
|
|
|
|
Assert.That(original.RefreshToken, Is.Null);
|
|
Assert.That(original.RefreshTokenExpiryTime, Is.EqualTo(DateTime.MinValue));
|
|
|
|
await AssertServiceResultAsync(
|
|
() => provider.RefreshTokenAsync(Audience, new string('A', 64)),
|
|
StatusCodes.BadNotSupported,
|
|
"disabled").ConfigureAwait(false);
|
|
}
|
|
|
|
[Test]
|
|
public async Task RefreshTokenAsyncDoesNotWidenScopesOrRoles()
|
|
{
|
|
using Certificate certificate = CreateCertificate();
|
|
using var certificateProvider = new InProcessCertificateProvider(certificate);
|
|
AuthorizationServiceOptions options = CreateOptions(certificate);
|
|
options.DefaultScopes.Add("write");
|
|
InMemoryAccessTokenProvider provider = CreateProvider(certificateProvider, options);
|
|
|
|
AccessTokenResult original = await IssueTokenAsync(
|
|
provider,
|
|
Audience,
|
|
["read"],
|
|
["AuthenticatedUser"]).ConfigureAwait(false);
|
|
AccessTokenResult refreshed = await provider
|
|
.RefreshTokenAsync(Audience, original.RefreshToken!)
|
|
.ConfigureAwait(false);
|
|
|
|
using var payload = JsonDocument.Parse(Base64UrlDecode(refreshed.AccessToken.Split('.')[1]));
|
|
JsonElement root = payload.RootElement;
|
|
Assert.That(root.GetProperty("scope").GetString(), Is.EqualTo("read"));
|
|
string[] roles = [.. root.GetProperty("roles")
|
|
.EnumerateArray()
|
|
.Select(role => role.GetString() ?? string.Empty)];
|
|
Assert.That(roles, Is.EqualTo(s_authenticatedUserRole));
|
|
}
|
|
|
|
[Test]
|
|
public async Task RefreshTokenAsyncIsThreadSafe()
|
|
{
|
|
using Certificate certificate = CreateCertificate();
|
|
using var certificateProvider = new InProcessCertificateProvider(certificate);
|
|
AuthorizationServiceOptions options = CreateOptions(certificate);
|
|
InMemoryAccessTokenProvider provider = CreateProvider(certificateProvider, options);
|
|
|
|
AccessTokenResult original = await IssueTokenAsync(provider).ConfigureAwait(false);
|
|
Task<AccessTokenResult>[] tasks = [.. Enumerable.Range(0, 8)
|
|
.Select(_ => Task.Run(async () => await provider
|
|
.RefreshTokenAsync(Audience, original.RefreshToken!)
|
|
.ConfigureAwait(false)))];
|
|
|
|
try
|
|
{
|
|
await Task.WhenAll(tasks).ConfigureAwait(false);
|
|
}
|
|
catch (ServiceResultException)
|
|
{
|
|
}
|
|
|
|
Assert.That(tasks.Count(task => task.Status == TaskStatus.RanToCompletion), Is.EqualTo(1));
|
|
Assert.That(tasks.Count(IsRejectedReplay), Is.EqualTo(7));
|
|
}
|
|
|
|
/// <summary>
|
|
/// OPC 10000-12 §9.6.6: unused request ids are cleaned up; a client
|
|
/// that never calls FinishRequestToken cannot grow the table forever.
|
|
/// </summary>
|
|
[Test]
|
|
public async Task StartRequestTokenAsyncLimitsPendingRequests()
|
|
{
|
|
using Certificate certificate = CreateCertificate();
|
|
using var certificateProvider = new InProcessCertificateProvider(certificate);
|
|
AuthorizationServiceOptions options = CreateOptions(certificate);
|
|
InMemoryAccessTokenProvider provider = CreateProvider(certificateProvider, options);
|
|
|
|
for (int ii = 0; ii < InMemoryAccessTokenProvider.MaxPendingRequests; ii++)
|
|
{
|
|
await provider
|
|
.StartRequestTokenAsync(Audience, "jwt", ByteString.Empty)
|
|
.ConfigureAwait(false);
|
|
}
|
|
|
|
Assert.That(provider.PendingRequestCount, Is.EqualTo(InMemoryAccessTokenProvider.MaxPendingRequests));
|
|
ServiceResultException ex = Assert.ThrowsAsync<ServiceResultException>(
|
|
async () => await provider
|
|
.StartRequestTokenAsync(Audience, "jwt", ByteString.Empty)
|
|
.ConfigureAwait(false));
|
|
Assert.That(ex!.StatusCode, Is.EqualTo(StatusCodes.BadTooManyOperations));
|
|
}
|
|
|
|
private static Certificate CreateCertificate()
|
|
{
|
|
return CertificateBuilder
|
|
.Create("CN=GDS JWT Signing, O=OPC Foundation")
|
|
.SetECCurve(ECCurve.NamedCurves.nistP256)
|
|
.CreateForECDsa();
|
|
}
|
|
|
|
private static AuthorizationServiceOptions CreateOptions(Certificate certificate)
|
|
{
|
|
return new AuthorizationServiceOptions
|
|
{
|
|
IssuerUri = Issuer,
|
|
SigningCertificate = new CertificateIdentifier { Thumbprint = certificate.Thumbprint },
|
|
// These tests exercise refresh mechanics, so the operator authorizes
|
|
// the requested roles; the fail-closed default (no roles) is covered
|
|
// by StartRequestTokenTests.
|
|
AuthorizeRoles = (identity, audience, requestedRoles) => requestedRoles
|
|
};
|
|
}
|
|
|
|
private static InMemoryAccessTokenProvider CreateProvider(
|
|
InProcessCertificateProvider certificateProvider,
|
|
AuthorizationServiceOptions options)
|
|
{
|
|
var issuer = new CertificateJwtIssuer(options, certificateProvider, NUnitTelemetryContext.Create());
|
|
return new InMemoryAccessTokenProvider(issuer, options);
|
|
}
|
|
|
|
private static async Task<AccessTokenResult> IssueTokenAsync(
|
|
InMemoryAccessTokenProvider provider,
|
|
string resourceId = Audience,
|
|
string[]? scopes = null,
|
|
string[]? roles = null)
|
|
{
|
|
scopes ??= ["read", "write"];
|
|
roles ??= ["operator"];
|
|
(_, Guid requestId) = await provider
|
|
.StartRequestTokenAsync(
|
|
resourceId,
|
|
"jwt",
|
|
ByteString.From(Encoding.UTF8.GetBytes(string.Join(" ", scopes))),
|
|
new UserIdentity("sysadmin", []))
|
|
.ConfigureAwait(false);
|
|
|
|
return await provider
|
|
.FinishRequestTokenAsync(
|
|
requestId,
|
|
roles.ToArrayOf(),
|
|
new UserNameIdentityToken { UserName = "sysadmin" },
|
|
new SignatureData())
|
|
.ConfigureAwait(false);
|
|
}
|
|
|
|
private static Task<ServiceResultException> AssertServiceResultAsync(
|
|
Func<ValueTask<AccessTokenResult>> action,
|
|
StatusCode statusCode,
|
|
string message)
|
|
{
|
|
ServiceResultException ex = Assert.ThrowsAsync<ServiceResultException>(
|
|
async () => await action().ConfigureAwait(false));
|
|
Assert.That(ex, Is.Not.Null);
|
|
Assert.That(ex!.StatusCode, Is.EqualTo(statusCode));
|
|
Assert.That(ex.Message, Does.Contain(message));
|
|
return Task.FromResult(ex);
|
|
}
|
|
|
|
private static bool IsRejectedReplay(Task<AccessTokenResult> task)
|
|
{
|
|
if (!task.IsFaulted || task.Exception == null)
|
|
{
|
|
return false;
|
|
}
|
|
|
|
return task.Exception.Flatten().InnerExceptions.Any(
|
|
ex => ex is ServiceResultException sre &&
|
|
sre.StatusCode == StatusCodes.BadIdentityTokenRejected);
|
|
}
|
|
|
|
private static byte[] Base64UrlDecode(string value)
|
|
{
|
|
string padded = value.Replace('-', '+').Replace('_', '/');
|
|
switch (padded.Length % 4)
|
|
{
|
|
case 2:
|
|
padded += "==";
|
|
break;
|
|
case 3:
|
|
padded += "=";
|
|
break;
|
|
}
|
|
return Convert.FromBase64String(padded);
|
|
}
|
|
}
|
|
}
|