Files
UA-.NETStandard/tests/Opc.Ua.Redundancy.Client.Tests/Raft/InProcessRaftConsensusTests.cs
Marc SchierandCopilot da7412c429 Add native xRegistry events and distinct Resource versions (#4396)
## Summary

- support the xRegistry 0.6.0 distinct Resource/Version hierarchy:
  `Registry -> Group -> Resource -> Versions -> Version`
- instantiate stable logical Resource nodes separately from exact
Version nodes
  while preserving existing Version NodeIds
- delegate logical Resource FileType operations and Version-view
metadata to the
selected default Version with handle pinning and shared writer
reservations
- make Resource and Version delete behavior role-stable and use
`MetaEpoch` /
  `Epoch` respectively
- use stable Resource SourceNodes, exact Version SourceNodes and the
  `Server -> Registry -> Group -> Resource -> Version` notifier chain
- keep a model-metadata-gated client fallback for 0.5 flat Servers; 0.6
Servers
  expose no legacy aliases
- target `HasWoTProjection` at the real stable logical Resource node
- use `AsyncCustomNodeManager` for the registration, fast-path, and
federation managers,
  with awaited lifecycle, node mutations, event delivery, and cleanup
- handle startup rollback, reentrant deletion callbacks, undisclosed
file handles,
  and retryable cleanup without blocking unrelated file operations

## Authoritative dependencies

- companion specification: OPCF-Members/spec-drafts#32 at
  `d3399fca025025a73e5a6b599f850a81d985c060`
- OPC UA binding: xregistry/spec#568
- xRegistry event semantics: xregistry/spec#563, merged as
  `66ee31e47fbadff6ab982ae1516f7d9065e46b64`
- companion NodeSet SHA-256:
  `369f5f3f1814b333e4eeb52bfb4b6a730cdff372505a5f91a54c94f0016ac4cf`

## Review feedback

- keep the WoT Connectivity information-model designation at `1.1`;
draft revisions update the publication date without changing the model
version
- eliminate all 198 unique CA1861 diagnostics across 54 files and remove
seven obsolete project suppressions
- fix the analyzer-clean touched-path CA1307 and the hierarchy follow-up
CA1846/CA1851 diagnostics without dropping legacy-TFM compatibility

- recover the reconcile queue after callback faults/cancellation and
continue accepted pending changes
- remove migration guidance for the xRegistry managers, which are new in
2.0

## Compatibility

- public WoT Connectivity model designation remains `1.1`
- generated event-record ABI, constructors, options, NodeIds, and stored
documents remain compatible
- the generic xRegistry managers are new in 2.0 and implement
`IAsyncNodeManager`;
use `IAsyncNodeManagerFactory` and the async lifecycle hooks (see
`docs\XRegistry.md`)
- persistence schema and document blobs remain compatible unless noted
below

## Validation

- merge validation at `980422f76` with upstream `e8bec27d5`: 454
targeted WoT/materialization/model/registry cases and all 327 XRegistry
cases passed on both net10.0 and net48; all 29 net10 aggregation sample
cases passed
- feedback regressions at `308e8ba74`: 55 targeted queue and live
registry event/projection/lifecycle cases passed on each of net10.0 and
net48
- prior CI: all 266 checks passed at `6489a0908`; the unchanged Ubuntu
Core certificate-counter test and dependent jobs passed on the one-time
retry ([run 34117304035, attempt
2](https://github.com/OPCFoundation/UA-.NETStandard/actions/runs/34117304035/attempts/2))
- `Opc.Ua.XRegistry.Tests` — 327 passed on net10.0 and net48 for
migration commit `32c914aaf`
- `Opc.Ua.WotCon.Tests` net10.0 — 1348 passed
- `Opc.Ua.WotCon.Bindings.Tests` net10.0 — 683 passed
- `Opc.Ua.SourceGeneration.Core.Tests` net10.0 — 3807 passed, 8 skipped
- `Opc.Ua.SourceGeneration.Tests` net10.0 — 145 passed
- `Opc.Ua.SourceGeneration.Stack.Tests` net10.0 — 94 passed
- affected XRegistry and WoT client/server projects build successfully
- xRegistry NodeSet is byte-identical to the companion artifact
- repository-wide CA1861 inventory — 198 unique diagnostics across 54
files reduced to zero
- targeted changed-fixture validation — 1,098 passed, 3 skipped, 0
failed
- constrained full `UA.slnx` net10.0 Release build — CA1861 = 0
- `Opc.Ua.XRegistry.Client` net472 and netstandard2.1 builds — 0
warnings, 0 errors
- independent shared-array safety review — no significant issues
- `git diff --check`

The final review regressions cover concurrent reconcile/open, synthetic
logical
handle collisions across default switches, cross-session Close
isolation,
shared writer reservations, logical FileType property/change
propagation,
logical Labels delegation, role-fixed deletion, event sources,
model-version
gating, and stable `HasWoTProjection` targets.

The companion specification and protocol binding are reviewed in the
linked PRs above.

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 5c79a1ed-6dab-4522-a9fc-6548caa78ad5
Copilot-Session: b605797f-a97a-4cd0-8f12-016d33c2fd88
Copilot-Session: 7ef369a5-2307-4f71-8a11-15af0e72f240
Copilot-Session: e716d455-8397-4d22-9c5a-398847ab7317
2026-09-08 04:46:40 +00:00

251 lines
10 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
// IDE0230: byte-array literals below are opaque binary test vectors, not text; a
// UTF-8 "..."u8 literal would misrepresent their intent, so keep the explicit byte arrays.
#pragma warning disable IDE0230 // Use UTF-8 string literal
// CA2000: system-under-test disposables are created per test and released at teardown;
// there is no cross-test resource leak. Suppressed file-level for the suite.
#pragma warning disable CA2000 // Dispose objects before losing scope
// CA2007: tests run without a SynchronizationContext; ConfigureAwait(false)
// adds noise without a behavioural benefit. Disabled file-level for the suite.
#pragma warning disable CA2007
using System;
using System.Collections.Generic;
using System.Threading;
using System.Threading.Tasks;
using NUnit.Framework;
using Opc.Ua.Redundancy;
namespace Opc.Ua.Client.Redundancy.Tests
{
/// <summary>
/// Coverage for the in-process consensus backend (<see cref="InProcessRaftConsensus"/>) and its shared
/// <see cref="InProcessRaftCluster"/> coordinator: leadership, log broadcast, failover, and disposal.
/// </summary>
[TestFixture]
[Category("ClientRedundancy")]
public sealed class InProcessRaftConsensusTests
{
[Test]
public async Task SingleNodeBecomesLeaderOnStartAsync()
{
await using var node = new InProcessRaftConsensus();
var transitions = new List<bool>();
node.LeadershipChanged += transitions.Add;
Assert.That(node.IsLeader, Is.False, "a node is not the leader before it starts");
Assert.That(node.NodeId, Is.EqualTo(1), "the default node id is 1");
await node.StartAsync().ConfigureAwait(false);
Assert.That(node.IsLeader, Is.True);
Assert.That(transitions, Is.EqualTo([true]));
}
[Test]
public async Task StartIsIdempotentAsync()
{
await using var node = new InProcessRaftConsensus();
var transitions = new List<bool>();
node.LeadershipChanged += transitions.Add;
await node.StartAsync().ConfigureAwait(false);
await node.StartAsync().ConfigureAwait(false);
Assert.That(node.IsLeader, Is.True);
Assert.That(transitions, Is.EqualTo([true]), "a second start must not re-raise leadership");
}
[Test]
public async Task ProposeDeliversToCommittedInLogOrderAsync()
{
await using var node = new InProcessRaftConsensus();
await node.StartAsync().ConfigureAwait(false);
await node.ProposeAsync(new byte[] { 1 }).ConfigureAwait(false);
await node.ProposeAsync(new byte[] { 2 }).ConfigureAwait(false);
await node.ProposeAsync(new byte[] { 3 }).ConfigureAwait(false);
IReadOnlyList<byte[]> committed = await ReadCommittedAsync(node, 3).ConfigureAwait(false);
Assert.That(committed[0], Is.EqualTo(new byte[] { 1 }));
Assert.That(committed[1], Is.EqualTo(new byte[] { 2 }));
Assert.That(committed[2], Is.EqualTo(new byte[] { 3 }));
}
[Test]
public async Task CampaignIsANoOpForDeterministicLeadershipAsync()
{
await using var node = new InProcessRaftConsensus();
await node.StartAsync().ConfigureAwait(false);
await node.CampaignAsync().ConfigureAwait(false);
Assert.That(node.IsLeader, Is.True, "campaigning does not change deterministic in-process leadership");
}
[Test]
public void NullClusterConstructorThrows()
{
Assert.That(() => new InProcessRaftConsensus(null!, 1), Throws.TypeOf<ArgumentNullException>());
}
[Test]
public async Task StartWithCanceledTokenThrowsAsync()
{
await using var node = new InProcessRaftConsensus();
using var cts = new CancellationTokenSource();
cts.Cancel();
Assert.That(
async () => await node.StartAsync(cts.Token).ConfigureAwait(false),
Throws.InstanceOf<OperationCanceledException>());
}
[Test]
public async Task ProposeWithCanceledTokenThrowsAsync()
{
await using var node = new InProcessRaftConsensus();
await node.StartAsync().ConfigureAwait(false);
using var cts = new CancellationTokenSource();
cts.Cancel();
Assert.That(
async () => await node.ProposeAsync(new byte[] { 1 }, cts.Token).ConfigureAwait(false),
Throws.InstanceOf<OperationCanceledException>());
}
[Test]
public async Task ClusterLowestIdIsLeaderAsync()
{
var cluster = new InProcessRaftCluster();
await using InProcessRaftConsensus node1 = cluster.CreateNode(1);
await using InProcessRaftConsensus node2 = cluster.CreateNode(2);
await node1.StartAsync().ConfigureAwait(false);
await node2.StartAsync().ConfigureAwait(false);
Assert.That(node1.IsLeader, Is.True, "the lowest live id is the leader");
Assert.That(node2.IsLeader, Is.False);
}
[Test]
public async Task ClusterProposeBroadcastsToAllMembersInSameOrderAsync()
{
var cluster = new InProcessRaftCluster();
await using InProcessRaftConsensus node1 = cluster.CreateNode(1);
await using InProcessRaftConsensus node2 = cluster.CreateNode(2);
await node1.StartAsync().ConfigureAwait(false);
await node2.StartAsync().ConfigureAwait(false);
await node1.ProposeAsync(new byte[] { 0xA }).ConfigureAwait(false);
await node2.ProposeAsync(new byte[] { 0xB }).ConfigureAwait(false);
IReadOnlyList<byte[]> seenBy1 = await ReadCommittedAsync(node1, 2).ConfigureAwait(false);
IReadOnlyList<byte[]> seenBy2 = await ReadCommittedAsync(node2, 2).ConfigureAwait(false);
Assert.That(seenBy1[0], Is.EqualTo(new byte[] { 0xA }));
Assert.That(seenBy1[1], Is.EqualTo(new byte[] { 0xB }));
Assert.That(seenBy2[0], Is.EqualTo(new byte[] { 0xA }));
Assert.That(seenBy2[1], Is.EqualTo(new byte[] { 0xB }));
}
[Test]
public async Task DisposingLeaderReelectsNextLowestAsync()
{
var cluster = new InProcessRaftCluster();
InProcessRaftConsensus node1 = cluster.CreateNode(1);
await using InProcessRaftConsensus node2 = cluster.CreateNode(2);
var node2Transitions = new List<bool>();
node2.LeadershipChanged += node2Transitions.Add;
await node1.StartAsync().ConfigureAwait(false);
await node2.StartAsync().ConfigureAwait(false);
Assert.That(node2.IsLeader, Is.False);
await node1.DisposeAsync().ConfigureAwait(false);
Assert.That(node2.IsLeader, Is.True, "the next-lowest live id takes over when the leader leaves");
Assert.That(node2Transitions, Is.EqualTo([true]));
}
[Test]
public async Task ProposeAfterDisposeThrowsAsync()
{
var node = new InProcessRaftConsensus();
await node.StartAsync().ConfigureAwait(false);
await node.DisposeAsync().ConfigureAwait(false);
Assert.That(
async () => await node.ProposeAsync(new byte[] { 1 }).ConfigureAwait(false),
Throws.TypeOf<ObjectDisposedException>());
}
[Test]
public async Task CampaignAfterDisposeThrowsAsync()
{
var node = new InProcessRaftConsensus();
await node.StartAsync().ConfigureAwait(false);
await node.DisposeAsync().ConfigureAwait(false);
Assert.That(
async () => await node.CampaignAsync().ConfigureAwait(false),
Throws.TypeOf<ObjectDisposedException>());
}
[Test]
public async Task DisposeIsIdempotentAsync()
{
var node = new InProcessRaftConsensus();
await node.StartAsync().ConfigureAwait(false);
await node.DisposeAsync().ConfigureAwait(false);
Assert.That(async () => await node.DisposeAsync().ConfigureAwait(false), Throws.Nothing);
}
private static async Task<IReadOnlyList<byte[]>> ReadCommittedAsync(InProcessRaftConsensus node, int count)
{
using var cts = new CancellationTokenSource(TimeSpan.FromSeconds(10));
var result = new List<byte[]>(count);
for (int ii = 0; ii < count; ii++)
{
ReadOnlyMemory<byte> command = await node.Committed.ReadAsync(cts.Token).ConfigureAwait(false);
result.Add(command.ToArray());
}
return result;
}
}
}