mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-21 09:06:37 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
375 lines
15 KiB
C#
375 lines
15 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
// CA2000: system-under-test disposables are created per test and released at teardown;
|
|
// there is no cross-test resource leak. Suppressed file-level for the suite.
|
|
#pragma warning disable CA2000 // Dispose objects before losing scope
|
|
|
|
// CA2007: tests run without a SynchronizationContext; ConfigureAwait(false)
|
|
// adds noise without a behavioural benefit. Disabled file-level for the suite.
|
|
#pragma warning disable CA2007
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using System.Runtime.CompilerServices;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Redundancy;
|
|
using Opc.Ua.Redundancy.Client;
|
|
using Opc.Ua.Tests;
|
|
|
|
namespace Opc.Ua.Client.Redundancy.Tests
|
|
{
|
|
/// <summary>
|
|
/// Unit tests for the transparent redundant client session facade.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("ClientRedundancy")]
|
|
public sealed class RedundantClientSessionTests
|
|
{
|
|
private ITelemetryContext m_telemetry = null!;
|
|
|
|
[SetUp]
|
|
public void SetUp()
|
|
{
|
|
m_telemetry = NUnitTelemetryContext.Create();
|
|
}
|
|
|
|
[Test]
|
|
public async Task AsyncCallBlocksUntilLeadershipHasLiveSessionAsync()
|
|
{
|
|
ISession? current = null;
|
|
using var store = new InMemorySharedKeyValueStore();
|
|
var coordinator = new ClientReplicaCoordinator(
|
|
new ClientReplicaOptions { CreateSessionAsync = _ => default },
|
|
new StaticLeaderElection(true),
|
|
store,
|
|
NullRecordProtector.Instance,
|
|
m_telemetry
|
|
);
|
|
await using var facade = new RedundantClientSession(coordinator, () => current);
|
|
var response = new ReadResponse();
|
|
var session = new Mock<ISession>(MockBehavior.Strict);
|
|
session
|
|
.Setup(s =>
|
|
s.ReadAsync(
|
|
null,
|
|
0,
|
|
TimestampsToReturn.Neither,
|
|
It.IsAny<ArrayOf<ReadValueId>>(),
|
|
It.IsAny<CancellationToken>()
|
|
)
|
|
)
|
|
.Returns(new ValueTask<ReadResponse>(response));
|
|
|
|
Task<ReadResponse> readTask = facade
|
|
.ReadAsync(null, 0, TimestampsToReturn.Neither, [], CancellationToken.None)
|
|
.AsTask();
|
|
Assert.That(readTask.IsCompleted, Is.False);
|
|
|
|
current = session.Object;
|
|
facade.RefreshActiveSessionForTesting();
|
|
|
|
Assert.That(await readTask.ConfigureAwait(false), Is.SameAs(response));
|
|
session.VerifyAll();
|
|
}
|
|
|
|
[Test]
|
|
public async Task ConcurrentAsyncCallsUseNewSessionAfterLiveSwapAsync()
|
|
{
|
|
ISession? current = null;
|
|
using var store = new InMemorySharedKeyValueStore();
|
|
var coordinator = new ClientReplicaCoordinator(
|
|
new ClientReplicaOptions { CreateSessionAsync = _ => default },
|
|
new StaticLeaderElection(true),
|
|
store,
|
|
NullRecordProtector.Instance,
|
|
m_telemetry);
|
|
var first = new Mock<ISession>();
|
|
var second = new Mock<ISession>();
|
|
var response = new ReadResponse();
|
|
second
|
|
.Setup(session => session.ReadAsync(
|
|
null,
|
|
0,
|
|
TimestampsToReturn.Neither,
|
|
It.IsAny<ArrayOf<ReadValueId>>(),
|
|
It.IsAny<CancellationToken>()))
|
|
.Returns(new ValueTask<ReadResponse>(response));
|
|
current = first.Object;
|
|
await using var facade = new RedundantClientSession(coordinator, () => current);
|
|
|
|
current = second.Object;
|
|
facade.RefreshActiveSessionForTesting();
|
|
using var cts = new CancellationTokenSource(TimeSpan.FromSeconds(10));
|
|
Task<ReadResponse>[] calls = Enumerable.Range(0, 16)
|
|
.Select(_ => Task.Run(
|
|
async () => await facade
|
|
.ReadAsync(null, 0, TimestampsToReturn.Neither, [], cts.Token)
|
|
.ConfigureAwait(false)))
|
|
.ToArray();
|
|
ReadResponse[] results = await Task.WhenAll(calls).ConfigureAwait(false);
|
|
|
|
Assert.That(results, Is.All.SameAs(response));
|
|
second.Verify(
|
|
session => session.ReadAsync(
|
|
null,
|
|
0,
|
|
TimestampsToReturn.Neither,
|
|
It.IsAny<ArrayOf<ReadValueId>>(),
|
|
It.IsAny<CancellationToken>()),
|
|
Times.Exactly(calls.Length));
|
|
first.Verify(
|
|
session => session.ReadAsync(
|
|
It.IsAny<RequestHeader>(),
|
|
It.IsAny<double>(),
|
|
It.IsAny<TimestampsToReturn>(),
|
|
It.IsAny<ArrayOf<ReadValueId>>(),
|
|
It.IsAny<CancellationToken>()),
|
|
Times.Never);
|
|
}
|
|
|
|
[Test]
|
|
public async Task FailedRememberedValueApplicationKeepsPreviousSessionAsync()
|
|
{
|
|
using var store = new InMemorySharedKeyValueStore();
|
|
var coordinator = new ClientReplicaCoordinator(
|
|
new ClientReplicaOptions { CreateSessionAsync = _ => default },
|
|
new StaticLeaderElection(true),
|
|
store,
|
|
NullRecordProtector.Instance,
|
|
m_telemetry);
|
|
var first = new Mock<ISession>();
|
|
var second = new Mock<ISession>();
|
|
var response = new ReadResponse();
|
|
first
|
|
.Setup(session => session.ReadAsync(
|
|
null,
|
|
0,
|
|
TimestampsToReturn.Neither,
|
|
It.IsAny<ArrayOf<ReadValueId>>(),
|
|
It.IsAny<CancellationToken>()))
|
|
.Returns(new ValueTask<ReadResponse>(response));
|
|
second
|
|
.SetupSet(session => session.DeleteSubscriptionsOnClose = true)
|
|
.Throws(new InvalidOperationException("remembered value failed"));
|
|
ISession? current = first.Object;
|
|
await using var facade = new RedundantClientSession(coordinator, () => current);
|
|
facade.DeleteSubscriptionsOnClose = true;
|
|
|
|
current = second.Object;
|
|
InvalidOperationException? exception = Assert.Throws<InvalidOperationException>(
|
|
facade.RefreshActiveSessionForTesting);
|
|
ReadResponse result = await facade
|
|
.ReadAsync(null, 0, TimestampsToReturn.Neither, [], CancellationToken.None)
|
|
.ConfigureAwait(false);
|
|
|
|
Assert.That(exception!.Message, Is.EqualTo("remembered value failed"));
|
|
Assert.That(facade.Current, Is.SameAs(first.Object));
|
|
Assert.That(result, Is.SameAs(response));
|
|
}
|
|
|
|
[Test]
|
|
public async Task EarlierConcurrentRefreshCannotReplaceLaterAppliedSessionAsync()
|
|
{
|
|
using var store = new InMemorySharedKeyValueStore();
|
|
var coordinator = new ClientReplicaCoordinator(
|
|
new ClientReplicaOptions { CreateSessionAsync = _ => default },
|
|
new StaticLeaderElection(true),
|
|
store,
|
|
NullRecordProtector.Instance,
|
|
m_telemetry);
|
|
var first = new Mock<ISession>();
|
|
var second = new Mock<ISession>();
|
|
ISession? current = first.Object;
|
|
using var staleObserved = new ManualResetEventSlim();
|
|
using var releaseStale = new ManualResetEventSlim();
|
|
int blockNextRefresh = 0;
|
|
ISession? AccessCurrent()
|
|
{
|
|
ISession? observed = current;
|
|
if (Interlocked.Exchange(ref blockNextRefresh, 0) == 1)
|
|
{
|
|
staleObserved.Set();
|
|
if (!releaseStale.Wait(TimeSpan.FromSeconds(10)))
|
|
{
|
|
throw new TimeoutException("The stale refresh was not released.");
|
|
}
|
|
}
|
|
return observed;
|
|
}
|
|
|
|
await using var facade = new RedundantClientSession(coordinator, AccessCurrent);
|
|
Volatile.Write(ref blockNextRefresh, 1);
|
|
Task staleRefresh = Task.Run(facade.RefreshActiveSessionForTesting);
|
|
Assert.That(staleObserved.Wait(TimeSpan.FromSeconds(10)), Is.True);
|
|
|
|
current = second.Object;
|
|
facade.RefreshActiveSessionForTesting();
|
|
releaseStale.Set();
|
|
await staleRefresh.ConfigureAwait(false);
|
|
|
|
Assert.That(facade.Current, Is.SameAs(second.Object));
|
|
}
|
|
|
|
[Test]
|
|
public async Task SyncMemberThrowsBadInvalidStateBeforeLeadershipAsync()
|
|
{
|
|
using var store = new InMemorySharedKeyValueStore();
|
|
var coordinator = new ClientReplicaCoordinator(
|
|
new ClientReplicaOptions { CreateSessionAsync = _ => default },
|
|
new StaticLeaderElection(false),
|
|
store,
|
|
NullRecordProtector.Instance,
|
|
m_telemetry
|
|
);
|
|
await using var facade = new RedundantClientSession(coordinator, () => null);
|
|
|
|
ServiceResultException ex = Assert.Throws<ServiceResultException>(() => _ = facade.SessionName)!;
|
|
Assert.That(ex.StatusCode, Is.EqualTo(StatusCodes.BadInvalidState));
|
|
}
|
|
|
|
[Test]
|
|
public async Task AddRedundantClientSessionResolvesIsessionAndDisposesCoordinatorAsync()
|
|
{
|
|
var election = new DisposableLeaderElection(false);
|
|
var services = new ServiceCollection();
|
|
services.AddSingleton(m_telemetry);
|
|
services.AddSingleton<ISharedKeyValueStore>(_ => new InMemorySharedKeyValueStore());
|
|
services.AddSingleton<ILeaderElection>(election);
|
|
services.AddRedundantClientSession(options =>
|
|
{
|
|
options.NodeId = "replica-a";
|
|
options.CreateSessionAsync = _ => default;
|
|
});
|
|
|
|
await using ServiceProvider provider = services.BuildServiceProvider();
|
|
ISession session = provider.GetRequiredService<ISession>();
|
|
|
|
Assert.That(session, Is.InstanceOf<RedundantClientSession>());
|
|
await provider.DisposeAsync().ConfigureAwait(false);
|
|
Assert.That(election.Disposed, Is.True);
|
|
}
|
|
|
|
[Test]
|
|
public void AddRedundantClientSessionSurfacesFailClosedProtectorRequirement()
|
|
{
|
|
var services = new ServiceCollection();
|
|
services.AddSingleton(m_telemetry);
|
|
services.AddSingleton<ISharedKeyValueStore>(new FakeNetworkedStore());
|
|
services.AddSingleton<ILeaderElection>(new StaticLeaderElection(false));
|
|
services.AddRedundantClientSession(options => options.CreateSessionAsync = _ => default);
|
|
|
|
using ServiceProvider provider = services.BuildServiceProvider();
|
|
|
|
Assert.That(() => provider.GetRequiredService<RedundantClientSession>(), Throws.InvalidOperationException);
|
|
}
|
|
|
|
private sealed class DisposableLeaderElection : ILeaderElection
|
|
{
|
|
public DisposableLeaderElection(bool isLeader)
|
|
{
|
|
IsLeader = isLeader;
|
|
}
|
|
|
|
public bool IsLeader { get; }
|
|
|
|
public bool Disposed { get; private set; }
|
|
|
|
public event Action<bool>? LeadershipChanged;
|
|
|
|
public void Start()
|
|
{
|
|
LeadershipChanged?.Invoke(IsLeader);
|
|
}
|
|
|
|
public ValueTask<bool> TryAcquireOrRenewAsync(CancellationToken ct = default)
|
|
{
|
|
return new(IsLeader);
|
|
}
|
|
|
|
public ValueTask DisposeAsync()
|
|
{
|
|
Disposed = true;
|
|
return default;
|
|
}
|
|
}
|
|
|
|
private sealed class FakeNetworkedStore : ISharedKeyValueStore
|
|
{
|
|
public ValueTask<(bool Found, ByteString Value)> TryGetAsync(string key, CancellationToken ct = default)
|
|
{
|
|
return new((false, default));
|
|
}
|
|
|
|
public ValueTask SetAsync(string key, ByteString value, CancellationToken ct = default)
|
|
{
|
|
return default;
|
|
}
|
|
|
|
public ValueTask<bool> CompareAndSwapAsync(
|
|
string key,
|
|
ByteString expected,
|
|
ByteString value,
|
|
CancellationToken ct = default
|
|
)
|
|
{
|
|
return new(true);
|
|
}
|
|
|
|
public ValueTask<bool> DeleteAsync(string key, CancellationToken ct = default)
|
|
{
|
|
return new(true);
|
|
}
|
|
|
|
public async IAsyncEnumerable<KeyValuePair<string, ByteString>> ScanAsync(
|
|
string keyPrefix,
|
|
[EnumeratorCancellation] CancellationToken ct = default
|
|
)
|
|
{
|
|
await Task.CompletedTask.ConfigureAwait(false);
|
|
yield break;
|
|
}
|
|
|
|
public async IAsyncEnumerable<KeyValueChange> WatchAsync(
|
|
string keyPrefix,
|
|
[EnumeratorCancellation] CancellationToken ct = default
|
|
)
|
|
{
|
|
await Task.CompletedTask.ConfigureAwait(false);
|
|
yield break;
|
|
}
|
|
}
|
|
}
|
|
}
|