Files
UA-.NETStandard/tests/Opc.Ua.Redundancy.PubSub.Tests/SharedStorePubSubSecurityKeyStoreTests.cs
romanettandClaude Opus 5.5 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

321 lines
14 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2026 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using System.Threading.Tasks;
using NUnit.Framework;
using Opc.Ua.PubSub.Security;
using Opc.Ua.PubSub.Security.Sks;
using Opc.Ua.Redundancy;
namespace Opc.Ua.PubSub.Redundancy.Tests
{
/// <summary>
/// Unit tests for the shared-store PubSub SKS key store.
/// </summary>
[TestFixture]
public class SharedStorePubSubSecurityKeyStoreTests
{
[Test]
public async Task SaveThenGetRoundTripsEverySecurityGroupFieldAsync()
{
using var sharedStore = new InMemorySharedKeyValueStore();
using AesCbcHmacRecordProtector protector = CreateProtector();
SharedStorePubSubSecurityKeyStore keyStore = CreateKeyStore(sharedStore, protector);
SksSecurityGroup expected = CreateGroup("group-a");
await keyStore.SaveSecurityGroupAsync(expected).ConfigureAwait(false);
SksSecurityGroup actual = (await keyStore.GetSecurityGroupAsync("group-a").ConfigureAwait(false))!;
Assert.That(actual, Is.Not.Null);
AssertGroupsEqual(actual, expected);
}
[Test]
public async Task GetSecurityGroupIdsReflectsSavedGroupsAsync()
{
using var sharedStore = new InMemorySharedKeyValueStore();
using AesCbcHmacRecordProtector protector = CreateProtector();
SharedStorePubSubSecurityKeyStore keyStore = CreateKeyStore(sharedStore, protector);
await keyStore.SaveSecurityGroupAsync(CreateGroup("group-a")).ConfigureAwait(false);
await keyStore.SaveSecurityGroupAsync(CreateGroup("group-b")).ConfigureAwait(false);
ArrayOf<string> groupIds = await keyStore.GetSecurityGroupIdsAsync().ConfigureAwait(false);
Assert.That(groupIds.ToArray(), Is.EquivalentTo(s_groupIds));
}
[Test]
public async Task RemoveSecurityGroupDeletesGroupAsync()
{
using var sharedStore = new InMemorySharedKeyValueStore();
using AesCbcHmacRecordProtector protector = CreateProtector();
SharedStorePubSubSecurityKeyStore keyStore = CreateKeyStore(sharedStore, protector);
await keyStore.SaveSecurityGroupAsync(CreateGroup("group-a")).ConfigureAwait(false);
bool removed = await keyStore.RemoveSecurityGroupAsync("group-a").ConfigureAwait(false);
SksSecurityGroup? actual = await keyStore.GetSecurityGroupAsync("group-a").ConfigureAwait(false);
Assert.That(removed, Is.True);
Assert.That(actual, Is.Null);
}
[Test]
public async Task GetSecurityGroupReturnsNullForUnknownGroupAsync()
{
using var sharedStore = new InMemorySharedKeyValueStore();
using AesCbcHmacRecordProtector protector = CreateProtector();
SharedStorePubSubSecurityKeyStore keyStore = CreateKeyStore(sharedStore, protector);
SksSecurityGroup? actual = await keyStore.GetSecurityGroupAsync("missing").ConfigureAwait(false);
Assert.That(actual, Is.Null);
}
[Test]
public async Task SaveSecurityGroupStoresProtectedBytesAsync()
{
using var sharedStore = new InMemorySharedKeyValueStore();
using AesCbcHmacRecordProtector protector = CreateProtector();
SharedStorePubSubSecurityKeyStore keyStore = CreateKeyStore(sharedStore, protector);
await keyStore.SaveSecurityGroupAsync(CreateGroup("group-a")).ConfigureAwait(false);
(bool found, ByteString stored) = await sharedStore
.TryGetAsync(PubSubRedundancyStoreKeys.SecurityKeyPrefix + "group-a")
.ConfigureAwait(false);
bool unprotected = protector.TryUnprotect(
RecordProtectionContext.Create(
"pubsub-security-group", PubSubRedundancyStoreKeys.SecurityKeyPrefix + "group-a"),
stored, out ByteString plaintext);
Assert.That(found, Is.True);
Assert.That(unprotected, Is.True);
Assert.That(stored.ToArray(), Is.Not.EqualTo(plaintext.ToArray()));
}
[Test]
public async Task GetSecurityGroupReturnsNullWhenStoredRecordCannotBeUnprotectedAsync()
{
using var sharedStore = new InMemorySharedKeyValueStore();
using AesCbcHmacRecordProtector protector = CreateProtector();
SharedStorePubSubSecurityKeyStore keyStore = CreateKeyStore(sharedStore, protector);
await sharedStore.SetAsync(
PubSubRedundancyStoreKeys.SecurityKeyPrefix + "group-a",
ByteString.From(new byte[] { 0x01, 0x02, 0x03, 0x04 })).ConfigureAwait(false);
SksSecurityGroup? group = await keyStore.GetSecurityGroupAsync("group-a").ConfigureAwait(false);
Assert.That(group, Is.Null);
}
[Test]
public async Task SaveSecurityGroupRejectsStaleFencingTokenAsync()
{
using var sharedStore = new InMemorySharedKeyValueStore();
using AesCbcHmacRecordProtector protector = CreateProtector();
SharedStorePubSubSecurityKeyStore keyStore = CreateKeyStore(sharedStore, protector);
SksSecurityGroup original = CreateGroup("group-a");
SksSecurityGroup replacement = CreateGroup("group-a", maxFutureKeyCount: 7);
await keyStore.SaveSecurityGroupAsync(original, 10).ConfigureAwait(false);
Assert.That(
async () => await keyStore.SaveSecurityGroupAsync(
replacement,
9).ConfigureAwait(false),
Throws.InvalidOperationException);
SksSecurityGroup actual = (await keyStore.GetSecurityGroupAsync("group-a").ConfigureAwait(false))!;
Assert.That(actual, Is.Not.Null);
AssertGroupsEqual(actual, original);
}
[TestCase(false)]
[TestCase(true)]
public async Task TransplantedSecurityGroupFailsClosedAsync(bool fenced)
{
using var sharedStore = new InMemorySharedKeyValueStore();
using AesCbcHmacRecordProtector protector = CreateProtector();
SharedStorePubSubSecurityKeyStore keyStore = CreateKeyStore(sharedStore, protector);
SksSecurityGroup expected = CreateGroup("source");
if (fenced)
{
await keyStore.SaveSecurityGroupAsync(expected, 10).ConfigureAwait(false);
}
else
{
await keyStore.SaveSecurityGroupAsync(expected).ConfigureAwait(false);
}
(bool found, ByteString record) = await sharedStore.TryGetAsync(
PubSubRedundancyStoreKeys.SecurityKeyPrefix + "source").ConfigureAwait(false);
Assert.That(found, Is.True);
await sharedStore.SetAsync(PubSubRedundancyStoreKeys.SecurityKeyPrefix + "target", record)
.ConfigureAwait(false);
Assert.That(await keyStore.GetSecurityGroupAsync("target").ConfigureAwait(false), Is.Null);
SksSecurityGroup retained = (await keyStore.GetSecurityGroupAsync("source").ConfigureAwait(false))!;
Assert.That(retained, Is.Not.Null);
AssertGroupsEqual(retained, expected);
}
[TestCase(false)]
[TestCase(true)]
public async Task SecurityGroupRejectsEmptyContextOrTamperingAsync(bool emptyContext)
{
using var sharedStore = new InMemorySharedKeyValueStore();
using AesCbcHmacRecordProtector protector = CreateProtector();
SharedStorePubSubSecurityKeyStore keyStore = CreateKeyStore(sharedStore, protector);
await keyStore.SaveSecurityGroupAsync(CreateGroup("source")).ConfigureAwait(false);
const string key = PubSubRedundancyStoreKeys.SecurityKeyPrefix + "source";
(_, ByteString record) = await sharedStore.TryGetAsync(key).ConfigureAwait(false);
ByteString invalid;
if (emptyContext)
{
Assert.That(protector.TryUnprotect(
RecordProtectionContext.Create("pubsub-security-group", key), record, out ByteString plaintext),
Is.True);
invalid = protector.Protect(default, plaintext);
}
else
{
byte[] tampered = record.ToArray();
tampered[^1] ^= 1;
invalid = ByteString.From(tampered);
}
await sharedStore.SetAsync(key, invalid).ConfigureAwait(false);
Assert.That(await keyStore.GetSecurityGroupAsync("source").ConfigureAwait(false), Is.Null);
(_, ByteString retained) = await sharedStore.TryGetAsync(key).ConfigureAwait(false);
Assert.That(retained, Is.EqualTo(invalid));
}
private static SharedStorePubSubSecurityKeyStore CreateKeyStore(
ISharedKeyValueStore sharedStore,
IRecordProtector protector)
{
return new SharedStorePubSubSecurityKeyStore(
sharedStore,
protector,
ServiceMessageContext.Create(null));
}
private static AesCbcHmacRecordProtector CreateProtector()
{
byte[] key = new byte[32];
for (int ii = 0; ii < key.Length; ii++)
{
key[ii] = (byte)(ii + 1);
}
return new AesCbcHmacRecordProtector(key);
}
private static SksSecurityGroup CreateGroup(string securityGroupId, int maxFutureKeyCount = 2)
{
return new SksSecurityGroup(
securityGroupId,
PubSubSecurityPolicyUri.PubSubAes128Ctr,
TimeSpan.FromMinutes(5),
maxFutureKeyCount,
1,
new ArrayOf<PubSubSecurityKey>(
new[]
{
CreateSecurityKey(1, 10),
CreateSecurityKey(2, 20)
}),
new ArrayOf<string>(s_authorizedCallers),
new ArrayOf<RolePermissionType>(
new[]
{
new RolePermissionType
{
RoleId = ObjectIds.WellKnownRole_SecurityAdmin,
Permissions = (uint)PermissionType.Call
}
}));
}
private static PubSubSecurityKey CreateSecurityKey(uint tokenId, byte seed)
{
return new PubSubSecurityKey(
tokenId,
CreateByteString(seed, 16),
CreateByteString((byte)(seed + 1), 16),
CreateByteString((byte)(seed + 2), 4),
new DateTimeUtc(2026, 1, (int)tokenId, 0, 0, 0),
TimeSpan.FromMinutes(5));
}
private static ByteString CreateByteString(byte seed, int length)
{
byte[] bytes = new byte[length];
for (int ii = 0; ii < bytes.Length; ii++)
{
bytes[ii] = (byte)(seed + ii);
}
return new ByteString(bytes);
}
private static void AssertGroupsEqual(SksSecurityGroup actual, SksSecurityGroup expected)
{
Assert.That(actual.SecurityGroupId, Is.EqualTo(expected.SecurityGroupId));
Assert.That(actual.SecurityPolicyUri, Is.EqualTo(expected.SecurityPolicyUri));
Assert.That(actual.KeyLifetime, Is.EqualTo(expected.KeyLifetime));
Assert.That(actual.MaxFutureKeyCount, Is.EqualTo(expected.MaxFutureKeyCount));
Assert.That(actual.MaxPastKeyCount, Is.EqualTo(expected.MaxPastKeyCount));
AssertSecurityKeysEqual(actual.Keys, expected.Keys);
Assert.That(actual.AuthorizedCallerIdentities, Is.EqualTo(expected.AuthorizedCallerIdentities));
Assert.That(actual.RolePermissions, Has.Count.EqualTo(expected.RolePermissions.Count));
Assert.That(actual.RolePermissions[0], Is.EqualTo(expected.RolePermissions[0]));
}
private static void AssertSecurityKeysEqual(
ArrayOf<PubSubSecurityKey> actual,
ArrayOf<PubSubSecurityKey> expected)
{
Assert.That(actual, Has.Count.EqualTo(expected.Count));
for (int ii = 0; ii < expected.Count; ii++)
{
Assert.That(actual[ii].TokenId, Is.EqualTo(expected[ii].TokenId));
Assert.That(actual[ii].SigningKey, Is.EqualTo(expected[ii].SigningKey));
Assert.That(actual[ii].EncryptingKey, Is.EqualTo(expected[ii].EncryptingKey));
Assert.That(actual[ii].KeyNonce, Is.EqualTo(expected[ii].KeyNonce));
Assert.That(actual[ii].IssuedAt, Is.EqualTo(expected[ii].IssuedAt));
Assert.That(actual[ii].Lifetime, Is.EqualTo(expected[ii].Lifetime));
}
}
private static readonly string[] s_groupIds = ["group-a", "group-b"];
private static readonly string[] s_authorizedCallers = ["publisher-a", "subscriber-b"];
}
}