Files
UA-.NETStandard/tests/Opc.Ua.Redundancy.Server.Tests/Redundancy/BandedServerDirectionPolicyTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

242 lines
10 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
// CA2007: tests run without a SynchronizationContext; ConfigureAwait(false)
// adds noise without a behavioural benefit. Disabled file-level for the suite.
#pragma warning disable CA2007
using System;
using System.Threading;
using System.Threading.Tasks;
using NUnit.Framework;
using Opc.Ua.Redundancy.Server;
namespace Opc.Ua.Server.Tests.Redundancy
{
/// <summary>
/// Unit tests for <see cref="BandedServerDirectionPolicy"/>.
/// </summary>
[TestFixture]
[Category("Distributed")]
[Parallelizable(ParallelScope.All)]
public class BandedServerDirectionPolicyTests
{
[Test]
public async Task ServesSelfWhenLocalIsLeastLoadedInTopTierAsync()
{
var policy = new BandedServerDirectionPolicy(
new FakeView([Peer("B", 255, 80)]), new LoadDirectionOptions(), _ => 0);
string? target = await policy.SelectTargetServerUriAsync("A", 255, 10).ConfigureAwait(false);
Assert.That(target, Is.Null, "the local Server is least-loaded among equally-healthy peers");
}
[Test]
public async Task RedirectsToLeastLoadedPeerInSameTierAsync()
{
var policy = new BandedServerDirectionPolicy(
new FakeView([Peer("B", 255, 10)]), new LoadDirectionOptions(), _ => 0);
string? target = await policy.SelectTargetServerUriAsync("A", 255, 80).ConfigureAwait(false);
Assert.That(target, Is.EqualTo("B"));
}
[Test]
public async Task RedirectsToHealthierPeerRegardlessOfLoadAsync()
{
// Active/passive: local standby is NoData, the active peer is Healthy.
var policy = new BandedServerDirectionPolicy(
new FakeView([Peer("B", 255, 200)]), new LoadDirectionOptions(), _ => 0);
string? target = await policy.SelectTargetServerUriAsync("A", ServiceLevels.NoData, 0).ConfigureAwait(false);
Assert.That(target, Is.EqualTo("B"), "a strictly-healthier peer wins even when heavily loaded");
}
[Test]
public async Task ServesSelfWhenLocalIsStrictlyHealthiestAsync()
{
var policy = new BandedServerDirectionPolicy(
new FakeView([Peer("B", 100, 0)]), new LoadDirectionOptions(), _ => 0);
string? target = await policy.SelectTargetServerUriAsync("A", 255, 90).ConfigureAwait(false);
Assert.That(target, Is.Null, "no peer is in a higher health tier than the healthy local Server");
}
[Test]
public async Task IgnoresLowerTierPeersForLoadBalancingAsync()
{
var policy = new BandedServerDirectionPolicy(
new FakeView([Peer("B", 255, 10), Peer("C", 100, 0)]), new LoadDirectionOptions(), _ => 0);
string? target = await policy.SelectTargetServerUriAsync("A", 255, 90).ConfigureAwait(false);
Assert.That(target, Is.EqualTo("B"), "only the top health tier participates; the degraded peer is ignored");
}
[Test]
public async Task RandomTieBreakSelectsWithinEqualLoadBandAsync()
{
ArrayOf<PeerDirectionRecord> peers = [Peer("B", 255, 0), Peer("C", 255, 5)];
var pickFirst = new BandedServerDirectionPolicy(new FakeView(peers), new LoadDirectionOptions(), _ => 0);
var pickSecond = new BandedServerDirectionPolicy(new FakeView(peers), new LoadDirectionOptions(), _ => 1);
string? first = await pickFirst.SelectTargetServerUriAsync("A", 255, 100).ConfigureAwait(false);
string? second = await pickSecond.SelectTargetServerUriAsync("A", 255, 100).ConfigureAwait(false);
Assert.That(first, Is.EqualTo("B"));
Assert.That(second, Is.EqualTo("C"), "B and C share the lowest load band; the selector breaks the tie");
}
[Test]
public async Task PeerWithUnknownLoadIsDeprioritizedAsync()
{
var policy = new BandedServerDirectionPolicy(
new FakeView([Peer("B", 255, load: null)]), new LoadDirectionOptions(), _ => 0);
string? target = await policy.SelectTargetServerUriAsync("A", 255, 50).ConfigureAwait(false);
Assert.That(target, Is.Null, "a peer with an unknown load must not be preferred over the known local load");
}
[Test]
public async Task EmptyViewServesSelfAsync()
{
var policy = new BandedServerDirectionPolicy(
new FakeView([]), new LoadDirectionOptions(), _ => 0);
string? target = await policy.SelectTargetServerUriAsync("A", 255, 0).ConfigureAwait(false);
Assert.That(target, Is.Null);
}
[Test]
public async Task ViewFailureServesSelfAsync()
{
var policy = new BandedServerDirectionPolicy(
new FakeView([], throwOnRead: true), new LoadDirectionOptions(), _ => 0);
string? target = await policy.SelectTargetServerUriAsync("A", 255, 0).ConfigureAwait(false);
Assert.That(target, Is.Null, "a stale/unreadable peer view must fail safe to the local Server");
}
[Test]
public async Task HealthSubBandsPreferHigherHealthySubBandAsync()
{
// Local (210) has a strictly higher raw ServiceLevel than peer B (205), but a heavier
// load. Without sub-banding both fall into the same coarse Healthy tier, so the tie is
// broken by load and B (unloaded) wins. With a sub-band size of 10, local's ServiceLevel
// (210) falls one sub-band above B's (205), so local becomes the strictly healthier
// member and is kept regardless of its higher load.
var withoutSubBands = new BandedServerDirectionPolicy(
new FakeView([Peer("B", 205, 0)]),
new LoadDirectionOptions { HealthSubBandSize = 0 },
_ => 0);
var withSubBands = new BandedServerDirectionPolicy(
new FakeView([Peer("B", 205, 0)]),
new LoadDirectionOptions { HealthSubBandSize = 10 },
_ => 0);
string? withoutSubBandsTarget = await withoutSubBands
.SelectTargetServerUriAsync("A", 210, 100)
.ConfigureAwait(false);
string? withSubBandsTarget = await withSubBands
.SelectTargetServerUriAsync("A", 210, 100)
.ConfigureAwait(false);
Assert.That(withoutSubBandsTarget, Is.EqualTo("B"), "without sub-bands the tie is broken by load, and B is unloaded");
Assert.That(withSubBandsTarget, Is.Null, "a higher healthy sub-band should keep traffic on the healthier local server");
}
[TestCase(0, 18, 17, Description = "load band size is clamped to one")]
[TestCase(1, 18, 17, Description = "load band size one keeps exact ordering")]
[TestCase(256, 18, 17, Description = "large load bands collapse nearby loads into one band")]
public async Task LoadBandSizeOptionsAreAppliedSafelyAsync(int loadBandSize, byte localLoad, byte peerLoad)
{
// localLoad (18) is strictly heavier than peerLoad (17): with an exact (or clamped-to-one)
// band size the peer is the truly least-loaded member and should be selected; a large band
// size collapses both into the same band, so the tie-break keeps traffic local.
var policy = new BandedServerDirectionPolicy(
new FakeView([Peer("B", 255, peerLoad)]),
new LoadDirectionOptions { LoadBandSize = loadBandSize },
_ => 0);
string? target = await policy
.SelectTargetServerUriAsync("A", 255, localLoad)
.ConfigureAwait(false);
if (loadBandSize > 1)
{
Assert.That(target, Is.Null, "equal load bands should keep traffic local when tie-breaking picks self");
}
else
{
Assert.That(target, Is.EqualTo("B"), "smaller load bands should still prefer the truly least-loaded peer");
}
}
private static PeerDirectionRecord Peer(string uri, byte level, byte? load = null)
{
return new PeerDirectionRecord
{
ServerUri = uri,
ServiceLevel = level,
LoadWeight = load ?? 0,
LoadKnown = load.HasValue
};
}
private sealed class FakeView : IPeerDirectionView
{
public FakeView(ArrayOf<PeerDirectionRecord> peers, bool throwOnRead = false)
{
m_peers = peers;
m_throw = throwOnRead;
}
public ValueTask<ArrayOf<PeerDirectionRecord>> GetPeersAsync(CancellationToken cancellationToken = default)
{
if (m_throw)
{
throw new InvalidOperationException("simulated store failure");
}
return new ValueTask<ArrayOf<PeerDirectionRecord>>(m_peers);
}
private readonly ArrayOf<PeerDirectionRecord> m_peers;
private readonly bool m_throw;
}
}
}