Files
UA-.NETStandard/tests/Opc.Ua.Redundancy.Server.Tests/Redundancy/LoadDirectionServerIntegrationTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

160 lines
7.2 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
// CA2007: tests run without a SynchronizationContext; ConfigureAwait(false)
// adds noise without a behavioural benefit. Disabled file-level for the suite.
#pragma warning disable CA2007
using System;
using System.Linq;
using System.Threading.Tasks;
using NUnit.Framework;
using Opc.Ua.Redundancy;
using Opc.Ua.Redundancy.Server;
using Opc.Ua.Server.TestFramework;
using Quickstarts.ReferenceServer;
namespace Opc.Ua.Server.Tests.Redundancy
{
/// <summary>
/// Integration test that drives a real, fully-started <see cref="StandardServer"/> whose
/// <see cref="StandardServer.GetEndpointsDirector"/> is a configured <see cref="ServerLoadDirector"/>, and verifies
/// end to end that a <c>GetEndpoints</c> request on the balancing URL is answered with a peer's endpoints while a
/// normal request serves the local server. Closes the seam-wiring gap the director unit tests cannot exercise.
/// </summary>
[TestFixture]
[Category("Distributed")]
[NonParallelizable]
public class LoadDirectionServerIntegrationTests
{
private const string BalancingUrl = "opc.tcp://balance.invalid:4840";
private InMemorySharedKeyValueStore m_kv = null!;
private LoadDirectionOptions m_options = null!;
private ServerLoadDirector m_director = null!;
private ServerFixture<StandardServer> m_fixture = null!;
private StandardServer m_server = null!;
[OneTimeSetUp]
public async Task OneTimeSetUpAsync()
{
m_kv = new InMemorySharedKeyValueStore();
m_options = new LoadDirectionOptions { BalancingEndpointUrl = BalancingUrl };
m_director = new ServerLoadDirector(
new ConstantServiceLevelProvider(100), // local is a Degraded standby
new ConstantLoadWeightProvider(200),
m_options);
m_fixture = new ServerFixture<StandardServer>(t => new ReferenceServer(t)
{
GetEndpointsDirector = m_director
});
m_server = await m_fixture.StartAsync().ConfigureAwait(false);
IServiceMessageContext context = m_server.CurrentInstance.MessageContext;
string localServerUri = m_server.CurrentInstance.ServerUris.ToArray()[0];
var view = new SharedPeerDirectionView(
m_kv, context, NullRecordProtector.Instance, m_options, TimeProvider.System);
var policy = new BandedServerDirectionPolicy(view, m_options, _ => 0);
var directory = new SharedPeerEndpointDirectory(m_kv, context, NullRecordProtector.Instance, m_options);
var publisher = new SharedPeerEndpointPublisher(
m_kv, context, NullRecordProtector.Instance, m_options, localServerUri);
m_director.Configure(policy, directory, publisher, localServerUri);
// Seed peer B: healthy, unloaded, with endpoints.
var bDirection = new SharedPeerDirectionPublisher(
m_kv, context, NullRecordProtector.Instance, m_options, TimeProvider.System, "urn:B");
await bDirection.PublishServiceLevelAsync(255).ConfigureAwait(false);
await bDirection.PublishLoadWeightAsync(0).ConfigureAwait(false);
var bEndpoints = new SharedPeerEndpointPublisher(
m_kv, context, NullRecordProtector.Instance, m_options, "urn:B");
await bEndpoints.PublishAsync([MakeEndpoint("opc.tcp://b.example:4840", "urn:B")]).ConfigureAwait(false);
}
[OneTimeTearDown]
public async Task OneTimeTearDownAsync()
{
if (m_fixture != null)
{
await m_fixture.StopAsync().ConfigureAwait(false);
}
m_kv?.Dispose();
}
[Test]
public async Task GetEndpointsOnBalancingUrlRedirectsToHealthierPeerAsync()
{
GetEndpointsResponse response = await m_server.GetEndpointsAsync(
CreateChannelContext(), new RequestHeader(), BalancingUrl, default, default, RequestLifetime.None).ConfigureAwait(false);
EndpointDescription[] endpoints = response.Endpoints.ToArray()!;
Assert.That(endpoints, Has.Length.EqualTo(1));
Assert.That(endpoints[0].Server?.ApplicationUri, Is.EqualTo("urn:B"));
}
[Test]
public async Task GetEndpointsOnNormalUrlServesLocalServerAsync()
{
string normalUrl = m_server.GetEndpoints().ToArray()![0].EndpointUrl!;
GetEndpointsResponse response = await m_server.GetEndpointsAsync(
CreateChannelContext(), new RequestHeader(), normalUrl, default, default, RequestLifetime.None).ConfigureAwait(false);
EndpointDescription[] endpoints = response.Endpoints.ToArray()!;
Assert.That(endpoints, Is.Not.Empty, "a normal request returns the local server's own endpoints");
Assert.That(
endpoints.Any(e => string.Equals(e.Server?.ApplicationUri, "urn:B", StringComparison.Ordinal)),
Is.False,
"a normal request must not be redirected to a peer");
}
private SecureChannelContext CreateChannelContext()
{
EndpointDescription endpoint = m_server.GetEndpoints().ToArray()![0];
return new SecureChannelContext("loaddir-test", endpoint, RequestEncoding.Binary, null, null, null);
}
private static EndpointDescription MakeEndpoint(string url, string serverUri)
{
return new EndpointDescription
{
EndpointUrl = url,
SecurityMode = MessageSecurityMode.None,
SecurityPolicyUri = SecurityPolicies.None,
Server = new ApplicationDescription
{
ApplicationUri = serverUri,
ApplicationType = ApplicationType.Server
}
};
}
}
}