Files
UA-.NETStandard/tests/Opc.Ua.Redundancy.Server.Tests/Redundancy/LoadDirectionStartupTaskTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

262 lines
11 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
// CA2007: tests run without a SynchronizationContext; ConfigureAwait(false)
// adds noise without a behavioural benefit. Disabled file-level for the suite.
#pragma warning disable CA2007
using System.Threading.Tasks;
using Microsoft.Extensions.Time.Testing;
using Moq;
using NUnit.Framework;
using Opc.Ua.Redundancy;
using Opc.Ua.Redundancy.Server;
using Opc.Ua.Tests;
namespace Opc.Ua.Server.Tests.Redundancy
{
/// <summary>
/// Unit tests for <see cref="LoadDirectionStartupTask"/>: constructor guards, the null-server and
/// missing-ServerUri no-op paths, and the happy path that activates the <see cref="ServerLoadDirector"/>
/// with the collaborators built from the populated server message context.
/// </summary>
[TestFixture]
[Category("Distributed")]
[Parallelizable(ParallelScope.All)]
public sealed class LoadDirectionStartupTaskTests
{
private const string BalancingUrl = "opc.tcp://balance:4840";
private const string LocalServerUri = "urn:A";
private const string PeerServerUri = "urn:B";
[Test]
public void ConstructorThrowsOnNullStore()
{
Assert.That(
() => new LoadDirectionStartupTask(
null!,
NullRecordProtector.Instance,
new LoadDirectionOptions(),
CreateDirector(),
new FakeTimeProvider()),
Throws.ArgumentNullException);
}
[Test]
public void ConstructorThrowsOnNullProtector()
{
using var store = new InMemorySharedKeyValueStore();
Assert.That(
() => new LoadDirectionStartupTask(
store,
null!,
new LoadDirectionOptions(),
CreateDirector(),
new FakeTimeProvider()),
Throws.ArgumentNullException);
}
[Test]
public void ConstructorThrowsOnNullOptions()
{
using var store = new InMemorySharedKeyValueStore();
Assert.That(
() => new LoadDirectionStartupTask(
store,
NullRecordProtector.Instance,
null!,
CreateDirector(),
new FakeTimeProvider()),
Throws.ArgumentNullException);
}
[Test]
public void ConstructorThrowsOnNullDirector()
{
using var store = new InMemorySharedKeyValueStore();
Assert.That(
() => new LoadDirectionStartupTask(
store,
NullRecordProtector.Instance,
new LoadDirectionOptions(),
null!,
new FakeTimeProvider()),
Throws.ArgumentNullException);
}
[Test]
public void ConstructorThrowsOnNullTimeProvider()
{
using var store = new InMemorySharedKeyValueStore();
Assert.That(
() => new LoadDirectionStartupTask(
store,
NullRecordProtector.Instance,
new LoadDirectionOptions(),
CreateDirector(),
null!),
Throws.ArgumentNullException);
}
[Test]
public void OnServerStartedThrowsOnNullServer()
{
using var store = new InMemorySharedKeyValueStore();
var task = new LoadDirectionStartupTask(
store,
NullRecordProtector.Instance,
new LoadDirectionOptions(),
CreateDirector(),
new FakeTimeProvider());
Assert.That(
async () => await task.OnServerStartedAsync(null!).ConfigureAwait(false),
Throws.ArgumentNullException);
}
[Test]
public async Task OnServerStartedNoOpsWhenLocalServerUriMissingAsync()
{
using var store = new InMemorySharedKeyValueStore();
var options = new LoadDirectionOptions { BalancingEndpointUrl = BalancingUrl };
ServerLoadDirector director = CreateDirector(localServiceLevel: 255, localLoad: 200);
var task = new LoadDirectionStartupTask(
store, NullRecordProtector.Instance, options, director, new FakeTimeProvider());
Mock<IServerInternal> server = CreateServer(hasServerUri: false, out _);
await task.OnServerStartedAsync(server.Object).ConfigureAwait(false);
// The director was never configured, so it fails safe to the local Server.
(bool redirect, _) = await director.TryGetDirectedEndpointsAsync(
BalancingUrl, LocalEndpoints(LocalServerUri)).ConfigureAwait(false);
Assert.That(redirect, Is.False, "an unconfigured director must serve locally");
}
[Test]
public async Task OnServerStartedConfiguresDirectorForRedirectionAsync()
{
using var store = new InMemorySharedKeyValueStore();
IServiceMessageContext context = CreateContext();
var options = new LoadDirectionOptions { BalancingEndpointUrl = BalancingUrl };
var time = new FakeTimeProvider();
// A healthier, idle peer is available in the shared store.
await PublishPeerAsync(store, context, options, time, PeerServerUri, serviceLevel: 255, load: 0).ConfigureAwait(false);
ServerLoadDirector director = CreateDirector(localServiceLevel: 255, localLoad: 200);
var task = new LoadDirectionStartupTask(store, NullRecordProtector.Instance, options, director, time);
Mock<IServerInternal> server = CreateServer(hasServerUri: true, out _, context);
await task.OnServerStartedAsync(server.Object).ConfigureAwait(false);
(bool redirect, ArrayOf<EndpointDescription> endpoints) =
await director.TryGetDirectedEndpointsAsync(BalancingUrl, LocalEndpoints(LocalServerUri)).ConfigureAwait(false);
Assert.That(redirect, Is.True, "the configured director redirects to the healthier idle peer");
Assert.That(endpoints.Count, Is.EqualTo(1));
Assert.That(endpoints[0]?.Server?.ApplicationUri, Is.EqualTo(PeerServerUri));
}
private static ServerLoadDirector CreateDirector(byte localServiceLevel = 255, byte localLoad = 0)
{
return new ServerLoadDirector(
new ConstantServiceLevelProvider(localServiceLevel),
new ConstantLoadWeightProvider(localLoad),
new LoadDirectionOptions { BalancingEndpointUrl = BalancingUrl });
}
private static Mock<IServerInternal> CreateServer(
bool hasServerUri,
out IServiceMessageContext context,
IServiceMessageContext? sharedContext = null)
{
ITelemetryContext telemetry = NUnitTelemetryContext.Create();
context = sharedContext ?? ServiceMessageContext.CreateEmpty(telemetry);
var serverUris = new StringTable();
if (hasServerUri)
{
serverUris.Append(LocalServerUri);
}
var server = new Mock<IServerInternal>();
server.Setup(s => s.Telemetry).Returns(telemetry);
server.Setup(s => s.ServerUris).Returns(serverUris);
server.Setup(s => s.MessageContext).Returns(context);
server.Setup(s => s.DefaultSystemContext).Returns(new ServerSystemContext(server.Object));
return server;
}
private static async Task PublishPeerAsync(
InMemorySharedKeyValueStore store,
IServiceMessageContext context,
LoadDirectionOptions options,
FakeTimeProvider time,
string serverUri,
byte serviceLevel,
byte load)
{
var directionPublisher = new SharedPeerDirectionPublisher(
store, context, NullRecordProtector.Instance, options, time, serverUri);
await directionPublisher.PublishServiceLevelAsync(serviceLevel).ConfigureAwait(false);
await directionPublisher.PublishLoadWeightAsync(load).ConfigureAwait(false);
var endpointPublisher = new SharedPeerEndpointPublisher(
store, context, NullRecordProtector.Instance, options, serverUri);
await endpointPublisher.PublishAsync(LocalEndpoints(serverUri)).ConfigureAwait(false);
}
private static ArrayOf<EndpointDescription> LocalEndpoints(string serverUri)
{
return
[
new EndpointDescription
{
EndpointUrl = "opc.tcp://" + serverUri + ":4840",
SecurityMode = MessageSecurityMode.None,
SecurityPolicyUri = SecurityPolicies.None,
Server = new ApplicationDescription
{
ApplicationUri = serverUri,
ApplicationType = ApplicationType.Server
}
}
];
}
private static ServiceMessageContext CreateContext()
{
return ServiceMessageContext.CreateEmpty(NUnitTelemetryContext.Create());
}
}
}