Files
UA-.NETStandard/tests/Opc.Ua.Redundancy.Server.Tests/Redundancy/PeerDirectionViewTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

234 lines
11 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
// IDE0230: byte-array literals below are opaque binary test vectors, not text; a
// UTF-8 "..."u8 literal would misrepresent their intent, so keep the explicit byte arrays.
#pragma warning disable IDE0230 // Use UTF-8 string literal
// CA2007: tests run without a SynchronizationContext; ConfigureAwait(false)
// adds noise without a behavioural benefit. Disabled file-level for the suite.
#pragma warning disable CA2007
using System;
using System.Linq;
using System.Security.Cryptography;
using System.Threading.Tasks;
using Microsoft.Extensions.Time.Testing;
using NUnit.Framework;
using Opc.Ua.Redundancy;
using Opc.Ua.Redundancy.Server;
using Opc.Ua.Tests;
namespace Opc.Ua.Server.Tests.Redundancy
{
/// <summary>
/// Unit tests for the GetEndpoints load-direction peer signal publish/view
/// (<see cref="SharedPeerDirectionPublisher"/> / <see cref="SharedPeerDirectionView"/>).
/// </summary>
[TestFixture]
[Category("Distributed")]
[Parallelizable(ParallelScope.All)]
public class PeerDirectionViewTests
{
[Test]
public async Task ProtectedPeerSignalsRejectCrossKeySubstitutionAsync()
{
using var store = new InMemorySharedKeyValueStore();
using var random = RandomNumberGenerator.Create();
byte[] key = new byte[32];
random.GetBytes(key);
using var protector = new AesCbcHmacRecordProtector(key);
IServiceMessageContext context = CreateContext();
var options = new LoadDirectionOptions
{
ServiceLevelKeyPrefix = "deployment/health/",
LoadKeyPrefix = "deployment/load/"
};
var time = new FakeTimeProvider();
var publisher = new SharedPeerDirectionPublisher(
store, context, protector, options, time, "urn:server:a");
var view = new SharedPeerDirectionView(store, context, protector, options, time);
await publisher.PublishServiceLevelAsync(200).ConfigureAwait(false);
await publisher.PublishLoadWeightAsync(30).ConfigureAwait(false);
ArrayOf<PeerDirectionRecord> original = await view.GetPeersAsync().ConfigureAwait(false);
Assert.That(original, Has.Count.EqualTo(1));
Assert.That(original[0].LoadKnown, Is.True);
Assert.That(original[0].LoadWeight, Is.EqualTo(30));
(bool found, ByteString health) = await store.TryGetAsync(
options.ServiceLevelKeyPrefix + "urn:server:a").ConfigureAwait(false);
Assert.That(found, Is.True);
await store.SetAsync(options.LoadKeyPrefix + "urn:server:a", health).ConfigureAwait(false);
ArrayOf<PeerDirectionRecord> peers = await view.GetPeersAsync().ConfigureAwait(false);
Assert.That(peers, Has.Count.EqualTo(1));
Assert.That(peers[0].ServerUri, Is.EqualTo("urn:server:a"));
Assert.That(peers[0].ServiceLevel, Is.EqualTo(200));
Assert.That(peers[0].LoadKnown, Is.False);
}
[Test]
public async Task PublishAndViewRoundTripReturnsFreshPeerAsync()
{
using var store = new InMemorySharedKeyValueStore();
IServiceMessageContext context = CreateContext();
var options = new LoadDirectionOptions();
var time = new FakeTimeProvider();
var publisher = new SharedPeerDirectionPublisher(
store, context, NullRecordProtector.Instance, options, time, "urn:server:a");
await publisher.PublishServiceLevelAsync(200).ConfigureAwait(false);
await publisher.PublishLoadWeightAsync(30).ConfigureAwait(false);
var view = new SharedPeerDirectionView(
store, context, NullRecordProtector.Instance, options, time);
PeerDirectionRecord[] peers = (await view.GetPeersAsync().ConfigureAwait(false)).ToArray()!;
Assert.That(peers, Has.Length.EqualTo(1));
Assert.That(peers[0].ServerUri, Is.EqualTo("urn:server:a"));
Assert.That(peers[0].ServiceLevel, Is.EqualTo((byte)200));
Assert.That(peers[0].LoadKnown, Is.True);
Assert.That(peers[0].LoadWeight, Is.EqualTo((byte)30));
}
[Test]
public async Task ViewExcludesStaleHealthRecordAsync()
{
using var store = new InMemorySharedKeyValueStore();
IServiceMessageContext context = CreateContext();
var options = new LoadDirectionOptions { StalenessWindow = TimeSpan.FromSeconds(15) };
var time = new FakeTimeProvider();
var publisher = new SharedPeerDirectionPublisher(
store, context, NullRecordProtector.Instance, options, time, "urn:server:a");
await publisher.PublishServiceLevelAsync(200).ConfigureAwait(false);
await publisher.PublishLoadWeightAsync(30).ConfigureAwait(false);
time.Advance(TimeSpan.FromSeconds(20));
var view = new SharedPeerDirectionView(
store, context, NullRecordProtector.Instance, options, time);
PeerDirectionRecord[] peers = (await view.GetPeersAsync().ConfigureAwait(false)).ToArray()!;
Assert.That(peers, Is.Empty, "a peer whose health record is stale must be aged out");
}
[Test]
public async Task ViewReportsLoadUnknownWhenLoadStaleButHealthFreshAsync()
{
using var store = new InMemorySharedKeyValueStore();
IServiceMessageContext context = CreateContext();
var options = new LoadDirectionOptions { StalenessWindow = TimeSpan.FromSeconds(15) };
var time = new FakeTimeProvider();
var publisher = new SharedPeerDirectionPublisher(
store, context, NullRecordProtector.Instance, options, time, "urn:server:a");
await publisher.PublishLoadWeightAsync(30).ConfigureAwait(false);
time.Advance(TimeSpan.FromSeconds(20));
await publisher.PublishServiceLevelAsync(200).ConfigureAwait(false);
var view = new SharedPeerDirectionView(
store, context, NullRecordProtector.Instance, options, time);
PeerDirectionRecord[] peers = (await view.GetPeersAsync().ConfigureAwait(false)).ToArray()!;
Assert.That(peers, Has.Length.EqualTo(1));
Assert.That(peers[0].ServiceLevel, Is.EqualTo((byte)200));
Assert.That(peers[0].LoadKnown, Is.False, "a stale load record must be reported as unknown");
Assert.That(peers[0].LoadWeight, Is.Zero);
}
[Test]
public async Task ViewDropsMalformedHealthRecordAsync()
{
using var store = new InMemorySharedKeyValueStore();
IServiceMessageContext context = CreateContext();
var options = new LoadDirectionOptions();
var time = new FakeTimeProvider();
await store.SetAsync("svc/urn:server:x", ByteString.From(new byte[] { 9, 9, 9 })).ConfigureAwait(false);
var view = new SharedPeerDirectionView(
store, context, NullRecordProtector.Instance, options, time);
PeerDirectionRecord[] peers = (await view.GetPeersAsync().ConfigureAwait(false)).ToArray()!;
Assert.That(peers, Is.Empty, "an undecodable record must be dropped (fail-closed)");
}
[Test]
public async Task ViewReturnsAllHealthyPeersAsync()
{
using var store = new InMemorySharedKeyValueStore();
IServiceMessageContext context = CreateContext();
var options = new LoadDirectionOptions();
var time = new FakeTimeProvider();
var a = new SharedPeerDirectionPublisher(
store, context, NullRecordProtector.Instance, options, time, "urn:server:a");
var b = new SharedPeerDirectionPublisher(
store, context, NullRecordProtector.Instance, options, time, "urn:server:b");
await a.PublishServiceLevelAsync(200).ConfigureAwait(false);
await b.PublishServiceLevelAsync(210).ConfigureAwait(false);
var view = new SharedPeerDirectionView(
store, context, NullRecordProtector.Instance, options, time);
PeerDirectionRecord[] peers = (await view.GetPeersAsync().ConfigureAwait(false)).ToArray()!;
Assert.That(peers!.Select(p => p.ServerUri), Is.EquivalentTo(["urn:server:a", "urn:server:b"]));
Assert.That(peers.Single(p => p.ServerUri == "urn:server:b").ServiceLevel, Is.EqualTo((byte)210));
}
[Test]
public async Task RepublishOverwritesPreviousSignalAsync()
{
using var store = new InMemorySharedKeyValueStore();
IServiceMessageContext context = CreateContext();
var options = new LoadDirectionOptions();
var time = new FakeTimeProvider();
var publisher = new SharedPeerDirectionPublisher(
store, context, NullRecordProtector.Instance, options, time, "urn:server:a");
await publisher.PublishServiceLevelAsync(200).ConfigureAwait(false);
time.Advance(TimeSpan.FromSeconds(1));
await publisher.PublishServiceLevelAsync(120).ConfigureAwait(false);
var view = new SharedPeerDirectionView(
store, context, NullRecordProtector.Instance, options, time);
PeerDirectionRecord[] peers = (await view.GetPeersAsync().ConfigureAwait(false)).ToArray()!;
Assert.That(peers, Has.Length.EqualTo(1));
Assert.That(peers[0].ServiceLevel, Is.EqualTo((byte)120), "the latest published health value must win");
}
private static ServiceMessageContext CreateContext()
{
return ServiceMessageContext.CreateEmpty(NUnitTelemetryContext.Create());
}
}
}