Files
UA-.NETStandard/tests/Opc.Ua.Redundancy.Server.Tests/Redundancy/ServerLoadDirectorTests.cs
romanett 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

219 lines
10 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
// CA2007: tests run without a SynchronizationContext; ConfigureAwait(false)
// adds noise without a behavioural benefit. Disabled file-level for the suite.
#pragma warning disable CA2007
using System.Threading.Tasks;
using Microsoft.Extensions.Time.Testing;
using NUnit.Framework;
using Opc.Ua.Redundancy;
using Opc.Ua.Redundancy.Server;
using Opc.Ua.Tests;
namespace Opc.Ua.Server.Tests.Redundancy
{
/// <summary>
/// Integration tests for <see cref="ServerLoadDirector"/> using an in-memory shared store shared by two Servers.
/// </summary>
[TestFixture]
[Category("Distributed")]
[Parallelizable(ParallelScope.All)]
public class ServerLoadDirectorTests
{
private const string BalancingUrl = "opc.tcp://balance:4840";
[Test]
public async Task RedirectsToLessLoadedPeerOnBalancingUrlAsync()
{
using var store = new InMemorySharedKeyValueStore();
IServiceMessageContext context = CreateContext();
var options = new LoadDirectionOptions { BalancingEndpointUrl = BalancingUrl };
var time = new FakeTimeProvider();
await PublishPeerAsync(store, context, options, time, "urn:B", serviceLevel: 255, load: 0).ConfigureAwait(false);
ServerLoadDirector director = CreateDirector(
store, context, options, time, "urn:A", localServiceLevel: 255, localLoad: 200);
(bool redirect, ArrayOf<EndpointDescription> endpoints) =
await director.TryGetDirectedEndpointsAsync(BalancingUrl, LocalEndpoints("urn:A")).ConfigureAwait(false);
Assert.That(redirect, Is.True);
EndpointDescription[] result = endpoints.ToArray()!;
Assert.That(result, Has.Length.EqualTo(1));
Assert.That(result[0].Server.ApplicationUri, Is.EqualTo("urn:B"));
}
[Test]
public async Task ServesLocalOnNormalUrlAndPublishesOwnEndpointsAsync()
{
using var store = new InMemorySharedKeyValueStore();
IServiceMessageContext context = CreateContext();
var options = new LoadDirectionOptions { BalancingEndpointUrl = BalancingUrl };
var time = new FakeTimeProvider();
ServerLoadDirector director = CreateDirector(
store, context, options, time, "urn:A", localServiceLevel: 255, localLoad: 0);
(bool redirect, _) = await director.TryGetDirectedEndpointsAsync(
"opc.tcp://a:4840", LocalEndpoints("urn:A")).ConfigureAwait(false);
Assert.That(redirect, Is.False, "a normal discovery request is served locally");
var directory = new SharedPeerEndpointDirectory(
store, context, NullRecordProtector.Instance, options);
EndpointDescription[] published = (await directory.GetEndpointsAsync("urn:A").ConfigureAwait(false)).ToArray()!;
Assert.That(published, Has.Length.EqualTo(1), "the local endpoints are published for peers");
Assert.That(published[0].Server.ApplicationUri, Is.EqualTo("urn:A"));
}
[Test]
public async Task RedirectsToHealthierActivePeerRegardlessOfLoadAsync()
{
using var store = new InMemorySharedKeyValueStore();
IServiceMessageContext context = CreateContext();
var options = new LoadDirectionOptions { BalancingEndpointUrl = BalancingUrl };
var time = new FakeTimeProvider();
await PublishPeerAsync(store, context, options, time, "urn:B", serviceLevel: 255, load: 250).ConfigureAwait(false);
// Local Server is a cold standby (NoData).
ServerLoadDirector director = CreateDirector(
store, context, options, time, "urn:A", localServiceLevel: ServiceLevels.NoData, localLoad: 0);
(bool redirect, ArrayOf<EndpointDescription> endpoints) =
await director.TryGetDirectedEndpointsAsync(BalancingUrl, LocalEndpoints("urn:A")).ConfigureAwait(false);
Assert.That(redirect, Is.True);
Assert.That(endpoints.ToArray()![0].Server.ApplicationUri, Is.EqualTo("urn:B"));
}
[Test]
public async Task ServesLocalWhenNotConfiguredAsync()
{
var options = new LoadDirectionOptions { BalancingEndpointUrl = BalancingUrl };
var director = new ServerLoadDirector(
new ConstantServiceLevelProvider(255), new ConstantLoadWeightProvider(0), options);
(bool redirect, _) = await director.TryGetDirectedEndpointsAsync(BalancingUrl, LocalEndpoints("urn:A")).ConfigureAwait(false);
Assert.That(redirect, Is.False, "an unconfigured director never redirects");
}
[Test]
public async Task ServesLocalWhenTargetEndpointsMissingAsync()
{
using var store = new InMemorySharedKeyValueStore();
IServiceMessageContext context = CreateContext();
var options = new LoadDirectionOptions { BalancingEndpointUrl = BalancingUrl };
var time = new FakeTimeProvider();
// B is the best target by health/load but never published its endpoints.
var directionPublisher = new SharedPeerDirectionPublisher(
store, context, NullRecordProtector.Instance, options, time, "urn:B");
await directionPublisher.PublishServiceLevelAsync(255).ConfigureAwait(false);
await directionPublisher.PublishLoadWeightAsync(0).ConfigureAwait(false);
ServerLoadDirector director = CreateDirector(
store, context, options, time, "urn:A", localServiceLevel: 255, localLoad: 200);
(bool redirect, _) = await director.TryGetDirectedEndpointsAsync(BalancingUrl, LocalEndpoints("urn:A")).ConfigureAwait(false);
Assert.That(redirect, Is.False, "without the target's endpoints the request fails safe to the local Server");
}
private static ServerLoadDirector CreateDirector(
InMemorySharedKeyValueStore store,
IServiceMessageContext context,
LoadDirectionOptions options,
FakeTimeProvider time,
string localServerUri,
byte localServiceLevel,
byte localLoad)
{
var view = new SharedPeerDirectionView(store, context, NullRecordProtector.Instance, options, time);
var policy = new BandedServerDirectionPolicy(view, options, _ => 0);
var directory = new SharedPeerEndpointDirectory(store, context, NullRecordProtector.Instance, options);
var endpointPublisher = new SharedPeerEndpointPublisher(
store, context, NullRecordProtector.Instance, options, localServerUri);
var director = new ServerLoadDirector(
new ConstantServiceLevelProvider(localServiceLevel),
new ConstantLoadWeightProvider(localLoad),
options);
director.Configure(policy, directory, endpointPublisher, localServerUri);
return director;
}
private static async Task PublishPeerAsync(
InMemorySharedKeyValueStore store,
IServiceMessageContext context,
LoadDirectionOptions options,
FakeTimeProvider time,
string serverUri,
byte serviceLevel,
byte load)
{
var directionPublisher = new SharedPeerDirectionPublisher(
store, context, NullRecordProtector.Instance, options, time, serverUri);
await directionPublisher.PublishServiceLevelAsync(serviceLevel).ConfigureAwait(false);
await directionPublisher.PublishLoadWeightAsync(load).ConfigureAwait(false);
var endpointPublisher = new SharedPeerEndpointPublisher(
store, context, NullRecordProtector.Instance, options, serverUri);
await endpointPublisher.PublishAsync(LocalEndpoints(serverUri)).ConfigureAwait(false);
}
private static ArrayOf<EndpointDescription> LocalEndpoints(string serverUri)
{
return
[
new EndpointDescription
{
EndpointUrl = "opc.tcp://" + serverUri + ":4840",
SecurityMode = MessageSecurityMode.None,
SecurityPolicyUri = SecurityPolicies.None,
Server = new ApplicationDescription
{
ApplicationUri = serverUri,
ApplicationType = ApplicationType.Server
}
}
];
}
private static ServiceMessageContext CreateContext()
{
return ServiceMessageContext.CreateEmpty(NUnitTelemetryContext.Create());
}
}
}