mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-22 09:37:12 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
282 lines
11 KiB
C#
282 lines
11 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
// CA2007: tests run without a SynchronizationContext; ConfigureAwait(false)
|
|
// adds noise without a behavioural benefit. Disabled file-level for the suite.
|
|
#pragma warning disable CA2007
|
|
|
|
using System;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Redundancy;
|
|
using Opc.Ua.Redundancy.Server;
|
|
|
|
namespace Opc.Ua.Server.Tests.Redundancy
|
|
{
|
|
/// <summary>
|
|
/// Unit tests for the service-level providers.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Distributed")]
|
|
[Parallelizable(ParallelScope.All)]
|
|
public class ServiceLevelProviderTests
|
|
{
|
|
[Test]
|
|
public void ConstantProviderReturnsConfiguredLevel()
|
|
{
|
|
Assert.That(new ConstantServiceLevelProvider().GetServiceLevel(), Is.EqualTo(ServiceLevels.Maximum));
|
|
Assert.That(new ConstantServiceLevelProvider(ServiceLevels.HealthyMinimum).GetServiceLevel(),
|
|
Is.EqualTo(ServiceLevels.HealthyMinimum));
|
|
}
|
|
|
|
[Test]
|
|
public async Task LeaderProviderReportsLeaderLevelWhenLeaderAsync()
|
|
{
|
|
await using var leaderElection = new StaticLeaderElection(true);
|
|
await using var standbyElection = new StaticLeaderElection(false);
|
|
using var leader = new LeaderServiceLevelProvider(leaderElection);
|
|
using var standby = new LeaderServiceLevelProvider(standbyElection);
|
|
|
|
Assert.That(leader.GetServiceLevel(), Is.EqualTo(ServiceLevels.Maximum));
|
|
Assert.That(standby.GetServiceLevel(), Is.EqualTo(ServiceLevels.DegradedMaximum));
|
|
}
|
|
|
|
[Test]
|
|
public async Task LeaderProviderMapsStandbySubrangeFromFailoverModeAsync()
|
|
{
|
|
await using var coldElection = new StaticLeaderElection(false);
|
|
await using var warmElection = new StaticLeaderElection(false);
|
|
await using var hotElection = new StaticLeaderElection(false);
|
|
using var cold = new LeaderServiceLevelProvider(coldElection, RedundancySupport.Cold);
|
|
using var warm = new LeaderServiceLevelProvider(warmElection, RedundancySupport.Warm);
|
|
using var hot = new LeaderServiceLevelProvider(hotElection, RedundancySupport.Hot);
|
|
|
|
Assert.That(cold.GetServiceLevel(), Is.EqualTo(ServiceLevels.NoData));
|
|
Assert.That(warm.GetServiceLevel(), Is.EqualTo(ServiceLevels.DegradedMaximum));
|
|
Assert.That(hot.GetServiceLevel(), Is.EqualTo(ServiceLevels.Maximum));
|
|
}
|
|
|
|
[Test]
|
|
public async Task LeaderProviderDecrementsHealthyLevelForLoadBalancingAsync()
|
|
{
|
|
await using var election = new StaticLeaderElection(true);
|
|
using var provider = new LeaderServiceLevelProvider(
|
|
election,
|
|
RedundancySupport.Hot,
|
|
getConnectedClientCount: () => 3);
|
|
|
|
Assert.That(provider.GetServiceLevel(), Is.EqualTo((byte)(ServiceLevels.Maximum - 3)));
|
|
}
|
|
|
|
[Test]
|
|
public async Task LeaderProviderAppliesHealthInputAsMaximumLevelAsync()
|
|
{
|
|
await using var election = new StaticLeaderElection(true);
|
|
using var provider = new LeaderServiceLevelProvider(
|
|
election,
|
|
RedundancySupport.Hot,
|
|
getHealthServiceLevel: () => ServiceLevels.DegradedMaximum);
|
|
|
|
Assert.That(provider.GetServiceLevel(), Is.EqualTo(ServiceLevels.DegradedMaximum));
|
|
}
|
|
|
|
[Test]
|
|
public async Task LeaderProviderRaisesServiceLevelChangedOnTransitionAsync()
|
|
{
|
|
await using var election = new MutableLeaderElection();
|
|
using var provider = new LeaderServiceLevelProvider(election, leaderLevel: 255, standbyLevel: 10);
|
|
byte? observed = null;
|
|
provider.ServiceLevelChanged += level => observed = level;
|
|
|
|
election.Set(true);
|
|
Assert.That(observed, Is.EqualTo(ServiceLevels.Maximum));
|
|
Assert.That(provider.GetServiceLevel(), Is.EqualTo(ServiceLevels.Maximum));
|
|
|
|
election.Set(false);
|
|
Assert.That(observed, Is.EqualTo((byte)10));
|
|
Assert.That(provider.GetServiceLevel(), Is.EqualTo((byte)10));
|
|
}
|
|
|
|
[Test]
|
|
public async Task LeaderProviderManualServiceLevelOverridesCurrentRoleAsync()
|
|
{
|
|
await using var election = new MutableLeaderElection();
|
|
using var provider = new LeaderServiceLevelProvider(election);
|
|
byte? observed = null;
|
|
provider.ServiceLevelChanged += level => observed = level;
|
|
|
|
provider.SetServiceLevel(ServiceLevels.Maintenance);
|
|
|
|
Assert.That(observed, Is.EqualTo(ServiceLevels.Maintenance));
|
|
Assert.That(provider.GetServiceLevel(), Is.EqualTo(ServiceLevels.Maintenance));
|
|
}
|
|
|
|
[Test]
|
|
public async Task LeaderProviderHotAndMirroredStandbyReportsMaximumAsync()
|
|
{
|
|
await using var election = new StaticLeaderElection(false);
|
|
using var provider = new LeaderServiceLevelProvider(
|
|
election,
|
|
RedundancySupport.HotAndMirrored);
|
|
|
|
Assert.That(provider.GetServiceLevel(), Is.EqualTo(ServiceLevels.Maximum));
|
|
}
|
|
|
|
[Test]
|
|
public async Task LeaderProviderHealthCapsLeaderLevelAsync()
|
|
{
|
|
await using var election = new StaticLeaderElection(true);
|
|
using var provider = new LeaderServiceLevelProvider(
|
|
election,
|
|
RedundancySupport.Hot,
|
|
getHealthServiceLevel: () => 200);
|
|
|
|
Assert.That(provider.GetServiceLevel(), Is.EqualTo(200));
|
|
}
|
|
|
|
[Test]
|
|
public async Task LeaderProviderLoadDecrementClampsToHealthyMinimumAsync()
|
|
{
|
|
await using var election = new StaticLeaderElection(true);
|
|
using var provider = new LeaderServiceLevelProvider(
|
|
election,
|
|
RedundancySupport.Hot,
|
|
getConnectedClientCount: () => 300);
|
|
|
|
byte result = provider.GetServiceLevel();
|
|
Assert.That(result, Is.EqualTo(ServiceLevels.HealthyMinimum));
|
|
}
|
|
|
|
[Test]
|
|
public async Task LeaderProviderDoesNotApplyLoadBalancingToDegradedLevelAsync()
|
|
{
|
|
await using var election = new StaticLeaderElection(true);
|
|
using var provider = new LeaderServiceLevelProvider(
|
|
election,
|
|
RedundancySupport.Hot,
|
|
getConnectedClientCount: () => 10,
|
|
getHealthServiceLevel: () => ServiceLevels.DegradedMaximum);
|
|
|
|
Assert.That(provider.GetServiceLevel(), Is.EqualTo(ServiceLevels.DegradedMaximum));
|
|
}
|
|
|
|
[Test]
|
|
public async Task LeaderProviderManualOverrideClearsOnTransitionAsync()
|
|
{
|
|
await using var election = new MutableLeaderElection();
|
|
using var provider = new LeaderServiceLevelProvider(election, leaderLevel: 255, standbyLevel: 200);
|
|
provider.SetServiceLevel(ServiceLevels.DegradedMaximum);
|
|
Assert.That(provider.GetServiceLevel(), Is.EqualTo(ServiceLevels.DegradedMaximum));
|
|
|
|
election.Set(true);
|
|
|
|
Assert.That(provider.GetServiceLevel(), Is.EqualTo(255));
|
|
}
|
|
|
|
[Test]
|
|
public async Task LeaderProviderConcurrentManualOverrideAndClearDoesNotProduceTornZero()
|
|
{
|
|
await using var election = new MutableLeaderElection();
|
|
election.Set(true);
|
|
using var provider = new LeaderServiceLevelProvider(election, leaderLevel: 255, standbyLevel: 200);
|
|
using var cts = new CancellationTokenSource();
|
|
int invalidLevel = -1;
|
|
|
|
var writer = Task.Run(() =>
|
|
{
|
|
while (!cts.IsCancellationRequested)
|
|
{
|
|
provider.SetServiceLevel(ServiceLevels.DegradedMaximum);
|
|
election.Set(true);
|
|
}
|
|
});
|
|
var reader = Task.Run(() =>
|
|
{
|
|
for (int ii = 0; ii < 100_000; ii++)
|
|
{
|
|
byte level = provider.GetServiceLevel();
|
|
if (level is not ServiceLevels.DegradedMaximum and not ServiceLevels.Maximum)
|
|
{
|
|
Volatile.Write(ref invalidLevel, level);
|
|
cts.Cancel();
|
|
break;
|
|
}
|
|
}
|
|
|
|
cts.Cancel();
|
|
});
|
|
|
|
await Task.WhenAll(writer, reader).ConfigureAwait(false);
|
|
|
|
Assert.That(
|
|
Volatile.Read(ref invalidLevel),
|
|
Is.EqualTo(-1),
|
|
"Concurrent SetServiceLevel/leadership clear must not expose torn ServiceLevel values.");
|
|
}
|
|
|
|
[Test]
|
|
public void ConstantProviderConstructorThrowsOnNullElection()
|
|
{
|
|
Assert.That(
|
|
() => new LeaderServiceLevelProvider(null!),
|
|
Throws.ArgumentNullException);
|
|
}
|
|
|
|
private sealed class MutableLeaderElection : ILeaderElection
|
|
{
|
|
public bool IsLeader => Volatile.Read(ref m_isLeader) != 0;
|
|
|
|
public event Action<bool>? LeadershipChanged;
|
|
|
|
public void Set(bool isLeader)
|
|
{
|
|
Volatile.Write(ref m_isLeader, isLeader ? 1 : 0);
|
|
LeadershipChanged?.Invoke(isLeader);
|
|
}
|
|
|
|
public ValueTask<bool> TryAcquireOrRenewAsync(CancellationToken ct = default)
|
|
{
|
|
return new ValueTask<bool>(IsLeader);
|
|
}
|
|
|
|
public void Start()
|
|
{
|
|
}
|
|
|
|
public ValueTask DisposeAsync()
|
|
{
|
|
return default;
|
|
}
|
|
|
|
private int m_isLeader;
|
|
}
|
|
}
|
|
}
|