mirror of
https://github.com/OPCFoundation/UA-.NETStandard.git
synced 2026-10-22 01:26:20 +08:00
9b034f8291
# Description Nullable reference types are now enabled once, in `common.props`, and every project in the repository builds warning-clean with them. **Configuration** - `<Nullable>enable</Nullable>` lives in `common.props`. All per-project `<Nullable>` settings are removed: 178 project files (enable, annotations, and the `disable` in the three Aot test projects). - 419 per-file `#nullable enable`/`restore` directives and the 4 `#nullable disable` directives are removed. - Kept on purpose: - The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`, `PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the project setting in generated code, so the directive is required there. - `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against the 1.5.378 packages and does not import the repository props. - `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now describe the central setting. **Migration** (the 43 unset and 13 annotations-only projects, roughly 10k diagnostics) - **Production code: annotated at the declarations.** Covers `tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the LDS sample. - Members, parameters and returns are nullable where null actually flows. - Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`, `IsMethodTypeDesign`). - `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take `params object?[]`. `Template.AddReplacement` takes `string?` (rendering already skips null replacements). - `IRegisteredServerStore.RegisterAsync` returns `Task<RegistrationEntry?>`: it returns null when a registration is removed. - Dereferences backed by an invariant (for example, the validated model) use `!`, so runtime behaviour is unchanged. - **Behavioural changes in production code** (small, deliberate): - `NodeSetToModelDesign` throws `InvalidOperationException` when the file is not a NodeSet. Before, it threw a NullReferenceException on the next line. - `ModelDesignValidator` starts its lookup tables empty instead of null. A redundant `if (m_nodes == null) return;` guard is gone. - **Test code: minimal annotations.** - `?` on values that can be null, `!` where the test asserts non-null. - `= null!` for fixture members assigned in SetUp. - `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the `IEncodeable` constraint. - A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`) folded into the adjacent `IsNull`/`Count` checks. **Notes for reviewers** - The diff is large (~1,500 files) but almost entirely mechanical: `?`, `!` and directive removal. The non-annotation changes are listed above. - Known follow-up, not done here: `IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay non-nullable even though the validator returns null before it loads a dictionary. Making them nullable would ripple through every generator call site. ## Related Issues - Fixes #4439 ## Checklist - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [x] I have added all necessary documentation. - [x] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received. The "no new warnings" box covers net10.0 and net48: full non-incremental builds of `UA.slnx`, `tools/SourceGeneration.slnx`, `tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0 warnings and 0 errors under the repository's warnings-as-errors settings. net9.0 and net8.0 also had no nullable diagnostics, but they were not rebuilt after the final fixes. Tests have not been run locally yet. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
306 lines
12 KiB
C#
306 lines
12 KiB
C#
/* ========================================================================
|
|
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
|
|
*
|
|
* OPC Foundation MIT License 1.00
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person
|
|
* obtaining a copy of this software and associated documentation
|
|
* files (the "Software"), to deal in the Software without
|
|
* restriction, including without limitation the rights to use,
|
|
* copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following
|
|
* conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be
|
|
* included in all copies or substantial portions of the Software.
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
|
|
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
|
|
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The complete license agreement can be found here:
|
|
* http://opcfoundation.org/License/MIT/1.00/
|
|
* ======================================================================*/
|
|
|
|
// IDE0230: byte-array literals below are opaque binary test vectors, not text; a
|
|
// UTF-8 "..."u8 literal would misrepresent their intent, so keep the explicit byte arrays.
|
|
#pragma warning disable IDE0230 // Use UTF-8 string literal
|
|
|
|
using System;
|
|
using NUnit.Framework;
|
|
using Opc.Ua.Redundancy;
|
|
|
|
namespace Opc.Ua.Server.Tests.Redundancy
|
|
{
|
|
/// <summary>
|
|
/// Unit tests for <see cref="AesCbcHmacRecordProtector"/> and
|
|
/// <see cref="NullRecordProtector"/>: authenticated-encryption round-trip
|
|
/// and fail-closed rejection of tampered, wrong-key, and malformed records.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Distributed")]
|
|
[Parallelizable(ParallelScope.All)]
|
|
public class RecordProtectorTests
|
|
{
|
|
private static byte[] MakeKey(byte seed)
|
|
{
|
|
byte[] key = new byte[32];
|
|
for (int i = 0; i < key.Length; i++)
|
|
{
|
|
key[i] = (byte)(seed + i);
|
|
}
|
|
return key;
|
|
}
|
|
|
|
[Test]
|
|
public void ProtectUnprotectRoundTrips()
|
|
{
|
|
using var protector = new AesCbcHmacRecordProtector(MakeKey(1));
|
|
var plaintext = ByteString.From(new byte[] { 10, 20, 30, 40, 50 });
|
|
|
|
ByteString sealed1 = protector.Protect(default, plaintext);
|
|
bool ok = protector.TryUnprotect(default, sealed1, out ByteString recovered);
|
|
|
|
Assert.That(ok, Is.True);
|
|
Assert.That(recovered.ToArray(), Is.EqualTo(plaintext.ToArray()));
|
|
Assert.That(sealed1.ToArray(), Is.Not.EqualTo(plaintext.ToArray()));
|
|
}
|
|
|
|
[Test]
|
|
public void EmptyPayloadRoundTrips()
|
|
{
|
|
using var protector = new AesCbcHmacRecordProtector(MakeKey(2));
|
|
var plaintext = ByteString.From(Array.Empty<byte>());
|
|
|
|
ByteString sealed1 = protector.Protect(default, plaintext);
|
|
bool ok = protector.TryUnprotect(default, sealed1, out ByteString recovered);
|
|
|
|
Assert.That(ok, Is.True);
|
|
Assert.That(recovered.ToArray(), Is.Empty);
|
|
}
|
|
|
|
[Test]
|
|
public void ProtectProducesDistinctCiphertextPerCall()
|
|
{
|
|
using var protector = new AesCbcHmacRecordProtector(MakeKey(3));
|
|
var plaintext = ByteString.From(new byte[] { 1, 2, 3 });
|
|
|
|
ByteString a = protector.Protect(default, plaintext);
|
|
ByteString b = protector.Protect(default, plaintext);
|
|
|
|
// Random IV per call => different envelopes for identical plaintext.
|
|
Assert.That(a.ToArray(), Is.Not.EqualTo(b.ToArray()));
|
|
}
|
|
|
|
[Test]
|
|
public void TamperedCiphertextIsRejected()
|
|
{
|
|
using var protector = new AesCbcHmacRecordProtector(MakeKey(4));
|
|
ByteString sealed1 = protector.Protect(default, ByteString.From(new byte[] { 7, 7, 7, 7 }));
|
|
|
|
byte[] tampered = sealed1.ToArray();
|
|
// Flip a byte inside the ciphertext region (after the 21-byte header).
|
|
tampered[25] ^= 0xFF;
|
|
|
|
bool ok = protector.TryUnprotect(default, ByteString.From(tampered), out ByteString recovered);
|
|
|
|
Assert.That(ok, Is.False);
|
|
Assert.That(recovered.IsNull, Is.True);
|
|
}
|
|
|
|
[Test]
|
|
public void TamperedTagIsRejected()
|
|
{
|
|
using var protector = new AesCbcHmacRecordProtector(MakeKey(5));
|
|
ByteString sealed1 = protector.Protect(default, ByteString.From(new byte[] { 9, 9 }));
|
|
|
|
byte[] tampered = sealed1.ToArray();
|
|
tampered[^1] ^= 0x01;
|
|
|
|
bool ok = protector.TryUnprotect(default, ByteString.From(tampered), out _);
|
|
|
|
Assert.That(ok, Is.False);
|
|
}
|
|
|
|
[Test]
|
|
public void TamperedIvIsRejected()
|
|
{
|
|
using var protector = new AesCbcHmacRecordProtector(MakeKey(6));
|
|
ByteString sealed1 = protector.Protect(default, ByteString.From(new byte[] { 4, 5, 6 }));
|
|
|
|
byte[] tampered = sealed1.ToArray();
|
|
// IV occupies bytes [5, 21); the MAC covers it, so a flip is caught.
|
|
tampered[6] ^= 0x80;
|
|
|
|
bool ok = protector.TryUnprotect(default, ByteString.From(tampered), out _);
|
|
|
|
Assert.That(ok, Is.False);
|
|
}
|
|
|
|
[Test]
|
|
public void WrongMasterKeyIsRejected()
|
|
{
|
|
using var writer = new AesCbcHmacRecordProtector(MakeKey(7));
|
|
using var reader = new AesCbcHmacRecordProtector(MakeKey(8));
|
|
ByteString sealed1 = writer.Protect(default, ByteString.From(new byte[] { 1, 1, 1, 1 }));
|
|
|
|
bool ok = reader.TryUnprotect(default, sealed1, out _);
|
|
|
|
Assert.That(ok, Is.False);
|
|
}
|
|
|
|
[Test]
|
|
public void ContextBindingRejectsCutAndPasteAcrossStoreKeys()
|
|
{
|
|
using var protector = new AesCbcHmacRecordProtector(MakeKey(11));
|
|
ByteString record = protector.Protect(
|
|
"trusted/cert/a",
|
|
ByteString.From(new byte[] { 8, 6, 7, 5 }));
|
|
|
|
Assert.That(
|
|
protector.TryUnprotect("rejected/cert/a", record, out _),
|
|
Is.False);
|
|
Assert.That(
|
|
protector.TryUnprotect("trusted/cert/a", record, out ByteString plaintext),
|
|
Is.True);
|
|
Assert.That(plaintext.ToArray(), Is.EqualTo(new byte[] { 8, 6, 7, 5 }));
|
|
}
|
|
|
|
[Test]
|
|
public void DifferentKeyIdIsRejected()
|
|
{
|
|
byte[] key = MakeKey(9);
|
|
using var writer = new AesCbcHmacRecordProtector(key, keyId: 1);
|
|
using var reader = new AesCbcHmacRecordProtector(key, keyId: 2);
|
|
ByteString sealed1 = writer.Protect(default, ByteString.From(new byte[] { 2, 2 }));
|
|
|
|
bool ok = reader.TryUnprotect(default, sealed1, out _);
|
|
|
|
Assert.That(ok, Is.False);
|
|
}
|
|
|
|
[Test]
|
|
public void MalformedOrNullEnvelopeIsRejected()
|
|
{
|
|
using var protector = new AesCbcHmacRecordProtector(MakeKey(10));
|
|
|
|
Assert.That(protector.TryUnprotect(default, default, out _), Is.False);
|
|
Assert.That(
|
|
protector.TryUnprotect(default, ByteString.From(new byte[] { 1, 2, 3 }), out _), Is.False);
|
|
}
|
|
|
|
[Test]
|
|
public void ConstructorRejectsShortMasterKey()
|
|
{
|
|
Assert.That(
|
|
() => new AesCbcHmacRecordProtector(new byte[16]),
|
|
Throws.ArgumentException);
|
|
}
|
|
|
|
[Test]
|
|
public void NullProtectorPassesThrough()
|
|
{
|
|
NullRecordProtector protector = NullRecordProtector.Instance;
|
|
var plaintext = ByteString.From(new byte[] { 3, 1, 4, 1, 5 });
|
|
|
|
ByteString sealed1 = protector.Protect(default, plaintext);
|
|
bool ok = protector.TryUnprotect(default, sealed1, out ByteString recovered);
|
|
|
|
Assert.That(ok, Is.True);
|
|
Assert.That(sealed1.ToArray(), Is.EqualTo(plaintext.ToArray()));
|
|
Assert.That(recovered.ToArray(), Is.EqualTo(plaintext.ToArray()));
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Unit tests for <see cref="KeyRingRecordProtector"/>: staged key rotation
|
|
/// where new writes use the active key while reads still verify against
|
|
/// retired keys.
|
|
/// </summary>
|
|
[TestFixture]
|
|
[Category("Distributed")]
|
|
[Parallelizable(ParallelScope.All)]
|
|
public class KeyRingRecordProtectorTests
|
|
{
|
|
private static byte[] MakeKey(byte seed)
|
|
{
|
|
byte[] key = new byte[32];
|
|
for (int i = 0; i < key.Length; i++)
|
|
{
|
|
key[i] = (byte)(seed + i);
|
|
}
|
|
return key;
|
|
}
|
|
|
|
[Test]
|
|
public void ActiveKeyRoundTrips()
|
|
{
|
|
using var active = new AesCbcHmacRecordProtector(MakeKey(30), keyId: 2);
|
|
using var ring = new KeyRingRecordProtector(active);
|
|
var plaintext = ByteString.From(new byte[] { 1, 2, 3 });
|
|
|
|
ByteString sealed1 = ring.Protect(default, plaintext);
|
|
bool ok = ring.TryUnprotect(default, sealed1, out ByteString recovered);
|
|
|
|
Assert.That(ok, Is.True);
|
|
Assert.That(recovered.ToArray(), Is.EqualTo(plaintext.ToArray()));
|
|
}
|
|
|
|
[Test]
|
|
public void RetiredKeyStillReadsAfterRotation()
|
|
{
|
|
using var oldKey = new AesCbcHmacRecordProtector(MakeKey(31), keyId: 1);
|
|
using var newKey = new AesCbcHmacRecordProtector(MakeKey(32), keyId: 2);
|
|
var plaintext = ByteString.From(new byte[] { 9, 9, 9 });
|
|
|
|
// A record written before rotation, under the old key.
|
|
ByteString legacyRecord = oldKey.Protect(default, plaintext);
|
|
|
|
// After rotation the ring writes under the new key but still reads
|
|
// records produced under the retired key.
|
|
using var ring = new KeyRingRecordProtector(newKey, oldKey);
|
|
bool ok = ring.TryUnprotect(default, legacyRecord, out ByteString recovered);
|
|
|
|
Assert.That(ok, Is.True);
|
|
Assert.That(recovered.ToArray(), Is.EqualTo(plaintext.ToArray()));
|
|
}
|
|
|
|
[Test]
|
|
public void NewWritesUseActiveKeyOnly()
|
|
{
|
|
using var oldKey = new AesCbcHmacRecordProtector(MakeKey(33), keyId: 1);
|
|
using var newKey = new AesCbcHmacRecordProtector(MakeKey(34), keyId: 2);
|
|
using var ring = new KeyRingRecordProtector(newKey, oldKey);
|
|
|
|
ByteString sealed1 = ring.Protect(default, ByteString.From(new byte[] { 5 }));
|
|
|
|
// The retired key alone must not be able to read a post-rotation record.
|
|
Assert.That(oldKey.TryUnprotect(default, sealed1, out _), Is.False);
|
|
Assert.That(newKey.TryUnprotect(default, sealed1, out _), Is.True);
|
|
}
|
|
|
|
[Test]
|
|
public void RecordOutsideRingIsRejected()
|
|
{
|
|
using var member = new AesCbcHmacRecordProtector(MakeKey(35), keyId: 1);
|
|
using var stranger = new AesCbcHmacRecordProtector(MakeKey(36), keyId: 9);
|
|
using var ring = new KeyRingRecordProtector(member);
|
|
|
|
ByteString foreignRecord = stranger.Protect(default, ByteString.From(new byte[] { 7, 7 }));
|
|
|
|
Assert.That(ring.TryUnprotect(default, foreignRecord, out _), Is.False);
|
|
}
|
|
|
|
[Test]
|
|
public void ConstructorRejectsNullActive()
|
|
{
|
|
Assert.That(() => new KeyRingRecordProtector(null!), Throws.ArgumentNullException);
|
|
}
|
|
}
|
|
}
|