Files
UA-.NETStandard/tests/Opc.Ua.Redundancy.Server.Tests/Sessions/ReplicatedSharedKeyValueStoreTests.cs
romanettandClaude Opus 5.5 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

206 lines
8.9 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
#pragma warning disable CA2007
using System;
using System.Net;
using System.Threading.Tasks;
using Crdt;
using Crdt.Transport;
using NUnit.Framework;
namespace Opc.Ua.Redundancy.Server.Tests
{
/// <summary>
/// Tests for the CRDT-backed <see cref="ReplicatedSharedKeyValueStore"/> used to
/// replicate mirrored session entries active/active.
/// </summary>
[TestFixture]
[Category("Distributed")]
public sealed class ReplicatedSharedKeyValueStoreTests
{
[Test]
public async Task ReplicatesSetAndDeleteAsync()
{
await using var network = new InMemoryNetwork();
await using ReplicatedSharedKeyValueStore storeA = CreateStore(network, 1);
await using ReplicatedSharedKeyValueStore storeB = CreateStore(network, 2);
// Warm up both transports so neither misses the other's broadcasts.
await storeA.TryGetAsync("warmup").ConfigureAwait(false);
await storeB.TryGetAsync("warmup").ConfigureAwait(false);
var value = new ByteString(new byte[] { 1, 2, 3, 4 });
await storeA.SetAsync("session/abc", value).ConfigureAwait(false);
await AssertEventuallyAsync(
async () =>
{
(bool found, ByteString stored) = await storeB.TryGetAsync("session/abc").ConfigureAwait(false);
return found && stored.ToArray().AsSpan().SequenceEqual(value.ToArray());
},
"a value set on A should replicate to B").ConfigureAwait(false);
await storeA.DeleteAsync("session/abc").ConfigureAwait(false);
await AssertEventuallyAsync(
async () =>
{
(bool found, _) = await storeB.TryGetAsync("session/abc").ConfigureAwait(false);
return !found;
},
"a delete on A should replicate to B").ConfigureAwait(false);
}
[Test]
public async Task CompareAndSwapThrowsNotSupportedAsync()
{
await using var network = new InMemoryNetwork();
await using ReplicatedSharedKeyValueStore store = CreateStore(network, 1);
Assert.That(
async () => await store.CompareAndSwapAsync("k", default, new ByteString(new byte[] { 1 })).ConfigureAwait(false),
Throws.TypeOf<NotSupportedException>(),
"CRDT stores cannot provide a linearizable compare-and-swap");
}
[Test]
public async Task ScanReturnsOnlyEntriesWithMatchingPrefixAsync()
{
await using var network = new InMemoryNetwork();
await using ReplicatedSharedKeyValueStore store = CreateStore(network, 1);
await store.SetAsync("session/a", new ByteString(new byte[] { 1 })).ConfigureAwait(false);
await store.SetAsync("session/b", new ByteString(new byte[] { 2 })).ConfigureAwait(false);
await store.SetAsync("other/c", new ByteString(new byte[] { 3 })).ConfigureAwait(false);
var found = new System.Collections.Generic.List<string>();
await foreach (System.Collections.Generic.KeyValuePair<string, ByteString> pair in
store.ScanAsync("session/"))
{
found.Add(pair.Key);
}
Assert.That(found, Is.EquivalentTo(s_sessionKeys));
}
[Test]
public async Task WatchThrowsNotSupported()
{
await using var network = new InMemoryNetwork();
await using ReplicatedSharedKeyValueStore store = CreateStore(network, 1);
Assert.That(() => store.WatchAsync("session/"), Throws.TypeOf<NotSupportedException>());
}
[Test]
public async Task ReplicatesOverRealTcpGossipAsync()
{
// Regression for the reported runtime failure: SetAsync mirrored through a real
// TcpGossipTransport threw "Frame length does not match the encoded body length"
// because the store sent a raw CRDT snapshot instead of a FrameCodec frame. The
// in-memory transport used by the other tests is a transparent passthrough and
// hid the bug. This test exercises two real TCP transports over loopback.
int portA = FreeTcpPort();
int portB = FreeTcpPort(portA);
var transportA = new TcpGossipTransport(
IPAddress.Loopback, portA, TimeSpan.FromMilliseconds(100));
var transportB = new TcpGossipTransport(
IPAddress.Loopback, portB, TimeSpan.FromMilliseconds(100));
transportA.AddPeer(new IPEndPoint(IPAddress.Loopback, portB));
transportB.AddPeer(new IPEndPoint(IPAddress.Loopback, portA));
await using var storeA = new ReplicatedSharedKeyValueStore(
ReplicaId.FromUInt64(1), transportA, TimeProvider.System, CrdtReaderOptions.Default);
await using var storeB = new ReplicatedSharedKeyValueStore(
ReplicaId.FromUInt64(2), transportB, TimeProvider.System, CrdtReaderOptions.Default);
// Warm up both transports so neither misses the other's broadcasts.
await storeA.TryGetAsync("warmup").ConfigureAwait(false);
await storeB.TryGetAsync("warmup").ConfigureAwait(false);
var value = new ByteString(new byte[] { 9, 8, 7, 6 });
await storeA.SetAsync("session/tcp", value).ConfigureAwait(false);
await AssertEventuallyAsync(
async () =>
{
(bool found, ByteString stored) = await storeB.TryGetAsync("session/tcp").ConfigureAwait(false);
return found && stored.ToArray().AsSpan().SequenceEqual(value.ToArray());
},
"a value set on A should replicate to B over real TCP gossip").ConfigureAwait(false);
}
private static ReplicatedSharedKeyValueStore CreateStore(InMemoryNetwork network, ulong replica)
{
return new ReplicatedSharedKeyValueStore(
ReplicaId.FromUInt64(replica),
network.CreateTransport(),
TimeProvider.System,
CrdtReaderOptions.Default);
}
private static async Task AssertEventuallyAsync(Func<Task<bool>> condition, string message)
{
// Generous deadline: CRDT convergence over the in-memory gossip network is normally
// sub-second, but background loops can be CPU-starved on a loaded CI runner.
DateTime deadline = DateTime.UtcNow + TimeSpan.FromSeconds(30);
while (DateTime.UtcNow < deadline)
{
if (await condition().ConfigureAwait(false))
{
return;
}
await Task.Delay(25).ConfigureAwait(false);
}
Assert.Fail(message);
}
private static readonly string[] s_sessionKeys = ["session/a", "session/b"];
private static int FreeTcpPort(int exclude = -1)
{
for (int attempt = 0; attempt < 20; attempt++)
{
var listener = new System.Net.Sockets.TcpListener(IPAddress.Loopback, 0);
listener.Start();
int port = ((IPEndPoint)listener.LocalEndpoint).Port;
listener.Stop();
if (port != exclude)
{
return port;
}
}
throw new InvalidOperationException("Could not find a free TCP port.");
}
}
}