Files
UA-.NETStandard/tests/Opc.Ua.Redundancy.Server.Tests/State/NodeStateStoreRegistryTests.cs
romanettandClaude Opus 5.5 9b034f8291 Enable nullable reference types centrally; migrate all unset and annotations-only projects (#4700)
# Description

Nullable reference types are now enabled once, in `common.props`, and
every project in the repository builds warning-clean with them.

**Configuration**
- `<Nullable>enable</Nullable>` lives in `common.props`. All per-project
`<Nullable>` settings are removed: 178 project files (enable,
annotations, and the `disable` in the three Aot test projects).
- 419 per-file `#nullable enable`/`restore` directives and the 4
`#nullable disable` directives are removed.
- Kept on purpose:
- The 5 `<auto-generated>` schema files (`UANodeSet.cs`, `UA Type
Dictionary.cs`, `OPCBinarySchema.cs`, `SecuredApplication.cs`,
`PInvokeHelper.cs`) keep `#nullable enable`. The compiler ignores the
project setting in generated code, so the directive is required there.
- `tests/Opc.Ua.Interop.LegacyPeer` keeps `disable`. It builds against
the 1.5.378 packages and does not import the repository props.
- `docs/DeveloperGuide.md` and `.github/copilot-instructions.md` now
describe the central setting.

**Migration** (the 43 unset and 13 annotations-only projects, roughly
10k diagnostics)
- **Production code: annotated at the declarations.** Covers
`tools/Opc.Ua.SourceGeneration.Core`, `src/Opc.Ua.Lds.Server` and the
LDS sample.
- Members, parameters and returns are nullable where null actually
flows.
- Null-check helpers carry `[NotNullWhen]` (`IsNull`, `IsValidXmlName`,
`IsMethodTypeDesign`).
- `CoreUtils.Format`, `Utils.Format`, `ITemplateWriter.WriteLine` take
`params object?[]`. `Template.AddReplacement` takes `string?` (rendering
already skips null replacements).
- `IRegisteredServerStore.RegisterAsync` returns
`Task<RegistrationEntry?>`: it returns null when a registration is
removed.
- Dereferences backed by an invariant (for example, the validated model)
use `!`, so runtime behaviour is unchanged.
- **Behavioural changes in production code** (small, deliberate):
- `NodeSetToModelDesign` throws `InvalidOperationException` when the
file is not a NodeSet. Before, it threw a NullReferenceException on the
next line.
- `ModelDesignValidator` starts its lookup tables empty instead of null.
A redundant `if (m_nodes == null) return;` guard is gone.
- **Test code: minimal annotations.**
  - `?` on values that can be null, `!` where the test asserts non-null.
  - `= null!` for fixture members assigned in SetUp.
- `TryGetStructure<T>(out T? x)` where the inferred `T?` broke the
`IEncodeable` constraint.
- A few redundant `== null` checks on structs (`NodeId`, `ArrayOf<T>`)
folded into the adjacent `IsNull`/`Count` checks.

**Notes for reviewers**
- The diff is large (~1,500 files) but almost entirely mechanical: `?`,
`!` and directive removal. The non-annotation changes are listed above.
- Known follow-up, not done here:
`IModelDesign.Namespaces/TargetNamespace/NamespaceUris` stay
non-nullable even though the validator returns null before it loads a
dictionary. Making them nullable would ripple through every generator
call site.

## Related Issues

- Fixes #4439

## Checklist

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [x] I have added all necessary documentation.
- [x] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.

The "no new warnings" box covers net10.0 and net48: full non-incremental
builds of `UA.slnx`, `tools/SourceGeneration.slnx`,
`tools/MigrationAnalyzer.slnx` and the Aot test projects finished with 0
warnings and 0 errors under the repository's warnings-as-errors
settings. net9.0 and net8.0 also had no nullable diagnostics, but they
were not rebuilt after the final fixes. Tests have not been run locally
yet.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:48:13 +02:00

312 lines
13 KiB
C#

/* ========================================================================
* Copyright (c) 2005-2025 The OPC Foundation, Inc. All rights reserved.
*
* OPC Foundation MIT License 1.00
*
* Permission is hereby granted, free of charge, to any person
* obtaining a copy of this software and associated documentation
* files (the "Software"), to deal in the Software without
* restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following
* conditions:
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
* OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
* HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* The complete license agreement can be found here:
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/
using System;
using Moq;
using NUnit.Framework;
namespace Opc.Ua.Redundancy.Server.Tests
{
/// <summary>
/// Unit tests for <see cref="NodeStateStoreRegistry"/>: the NodeId / namespace / default
/// binding precedence, unregistration bookkeeping, and disposal fan-out.
/// </summary>
[TestFixture]
[Category("Distributed")]
[Parallelizable(ParallelScope.All)]
public sealed class NodeStateStoreRegistryTests
{
[Test]
public void ConstructorThrowsOnNullNamespaceTable()
{
Assert.That(() => new NodeStateStoreRegistry(null!), Throws.ArgumentNullException);
}
[Test]
public void RegisterForNodeThrowsOnNullNodeId()
{
using var registry = new NodeStateStoreRegistry(new NamespaceTable());
Assert.That(
() => registry.RegisterForNode(NodeId.Null, Mock.Of<INodeStateStore>()),
Throws.ArgumentException);
}
[Test]
public void RegisterForNodeThrowsOnNullStore()
{
using var registry = new NodeStateStoreRegistry(new NamespaceTable());
Assert.That(
() => registry.RegisterForNode(new NodeId(1u), null!),
Throws.ArgumentNullException);
}
[Test]
public void RegisterForNamespaceThrowsOnEmptyUri()
{
using var registry = new NodeStateStoreRegistry(new NamespaceTable());
Assert.That(
() => registry.RegisterForNamespace(string.Empty, Mock.Of<INodeStateStore>()),
Throws.ArgumentException);
}
[Test]
public void RegisterForNamespaceThrowsOnNullStore()
{
using var registry = new NodeStateStoreRegistry(new NamespaceTable());
Assert.That(
() => registry.RegisterForNamespace("http://test/ns", null!),
Throws.ArgumentNullException);
}
[Test]
public void RegisterDefaultThrowsOnNullStore()
{
using var registry = new NodeStateStoreRegistry(new NamespaceTable());
Assert.That(() => registry.RegisterDefault(null!), Throws.ArgumentNullException);
}
[Test]
public void ResolveReturnsNullForNullNodeId()
{
using var registry = new NodeStateStoreRegistry(new NamespaceTable());
registry.RegisterDefault(Mock.Of<INodeStateStore>());
Assert.That(registry.Resolve(NodeId.Null), Is.Null);
}
[Test]
public void ResolveReturnsNodeScopedStore()
{
using var registry = new NodeStateStoreRegistry(new NamespaceTable());
INodeStateStore store = Mock.Of<INodeStateStore>();
var nodeId = new NodeId(42u);
registry.RegisterForNode(nodeId, store);
Assert.That(registry.Resolve(nodeId), Is.SameAs(store));
Assert.That(registry.Resolve(new NodeId(99u)), Is.Null, "an unbound node has no store");
}
[Test]
public void ResolveFallsBackToNamespaceScopedStore()
{
var namespaceTable = new NamespaceTable();
int nsIndex = namespaceTable.Append("http://test/ns");
using var registry = new NodeStateStoreRegistry(namespaceTable);
INodeStateStore store = Mock.Of<INodeStateStore>();
registry.RegisterForNamespace("http://test/ns", store);
Assert.That(registry.Resolve(new NodeId(7u, (ushort)nsIndex)), Is.SameAs(store));
}
[Test]
public void ResolveFallsBackToDefault()
{
using var registry = new NodeStateStoreRegistry(new NamespaceTable());
INodeStateStore store = Mock.Of<INodeStateStore>();
registry.RegisterDefault(store);
Assert.That(registry.Resolve(new NodeId(123u)), Is.SameAs(store));
}
[Test]
public void ResolvePrefersNodeThenNamespaceThenDefault()
{
var namespaceTable = new NamespaceTable();
int nsIndex = namespaceTable.Append("http://test/ns");
using var registry = new NodeStateStoreRegistry(namespaceTable);
INodeStateStore nodeStore = Mock.Of<INodeStateStore>();
INodeStateStore namespaceStore = Mock.Of<INodeStateStore>();
INodeStateStore defaultStore = Mock.Of<INodeStateStore>();
var boundNode = new NodeId(7u, (ushort)nsIndex);
registry.RegisterForNode(boundNode, nodeStore);
registry.RegisterForNamespace("http://test/ns", namespaceStore);
registry.RegisterDefault(defaultStore);
Assert.That(registry.Resolve(boundNode), Is.SameAs(nodeStore), "node binding wins");
Assert.That(
registry.Resolve(new NodeId(8u, (ushort)nsIndex)),
Is.SameAs(namespaceStore),
"namespace binding wins over default");
Assert.That(registry.Resolve(new NodeId(9u)), Is.SameAs(defaultStore), "default is the last resort");
}
[Test]
public void UnregisterForNodeRemovesBinding()
{
using var registry = new NodeStateStoreRegistry(new NamespaceTable());
INodeStateStore store = Mock.Of<INodeStateStore>();
var nodeId = new NodeId(42u);
registry.RegisterForNode(nodeId, store);
Assert.That(registry.UnregisterForNode(nodeId), Is.True);
Assert.That(registry.Resolve(nodeId), Is.Null);
Assert.That(registry.UnregisterForNode(nodeId), Is.False, "a second unregister is a no-op");
Assert.That(registry.UnregisterForNode(NodeId.Null), Is.False);
Assert.That(registry.Stores, Is.Empty, "the store is dropped when no binding references it");
}
[Test]
public void UnregisterForNamespaceRemovesBinding()
{
var namespaceTable = new NamespaceTable();
int nsIndex = namespaceTable.Append("http://test/ns");
using var registry = new NodeStateStoreRegistry(namespaceTable);
INodeStateStore store = Mock.Of<INodeStateStore>();
registry.RegisterForNamespace("http://test/ns", store);
Assert.That(registry.UnregisterForNamespace("http://test/ns"), Is.True);
Assert.That(registry.Resolve(new NodeId(7u, (ushort)nsIndex)), Is.Null);
Assert.That(registry.UnregisterForNamespace("http://test/ns"), Is.False);
Assert.That(registry.UnregisterForNamespace(string.Empty), Is.False);
}
[Test]
public void ClearDefaultRemovesDefault()
{
using var registry = new NodeStateStoreRegistry(new NamespaceTable());
INodeStateStore store = Mock.Of<INodeStateStore>();
registry.RegisterDefault(store);
registry.ClearDefault();
Assert.That(registry.Resolve(new NodeId(1u)), Is.Null);
Assert.That(registry.Stores, Is.Empty);
Assert.That(registry.ClearDefault, Throws.Nothing, "clearing an empty default is a no-op");
}
[Test]
public void StoresReflectsRegisteredStoresDeduplicated()
{
using var registry = new NodeStateStoreRegistry(new NamespaceTable());
INodeStateStore shared = Mock.Of<INodeStateStore>();
registry.RegisterForNode(new NodeId(1u), shared);
registry.RegisterDefault(shared);
Assert.That(registry.Stores, Has.Count.EqualTo(1), "the same store instance is tracked once");
Assert.That(registry.Stores, Contains.Item(shared));
}
[Test]
public void UnregisterKeepsStoreWhenStillReferencedElsewhere()
{
using var registry = new NodeStateStoreRegistry(new NamespaceTable());
INodeStateStore shared = Mock.Of<INodeStateStore>();
var nodeId = new NodeId(1u);
registry.RegisterForNode(nodeId, shared);
registry.RegisterDefault(shared);
Assert.That(registry.UnregisterForNode(nodeId), Is.True);
Assert.That(registry.Stores, Contains.Item(shared), "the store remains while the default still references it");
Assert.That(registry.Resolve(new NodeId(2u)), Is.SameAs(shared));
}
[Test]
public void UnregisterNamespaceKeepsStoreWhenReferencedByNode()
{
var namespaceTable = new NamespaceTable();
int nsIndex = namespaceTable.Append("http://test/ns");
using var registry = new NodeStateStoreRegistry(namespaceTable);
INodeStateStore shared = Mock.Of<INodeStateStore>();
var nodeId = new NodeId(1u);
registry.RegisterForNode(nodeId, shared);
registry.RegisterForNamespace("http://test/ns", shared);
Assert.That(registry.UnregisterForNamespace("http://test/ns"), Is.True);
Assert.That(
registry.Stores,
Contains.Item(shared),
"the store remains while a node binding still references it");
Assert.That(registry.Resolve(nodeId), Is.SameAs(shared));
Assert.That(registry.Resolve(new NodeId(2u, (ushort)nsIndex)), Is.Null);
}
[Test]
public void UnregisterNodeKeepsStoreWhenReferencedByNamespace()
{
var namespaceTable = new NamespaceTable();
int nsIndex = namespaceTable.Append("http://test/ns");
using var registry = new NodeStateStoreRegistry(namespaceTable);
INodeStateStore shared = Mock.Of<INodeStateStore>();
var nodeId = new NodeId(1u);
registry.RegisterForNode(nodeId, shared);
registry.RegisterForNamespace("http://test/ns", shared);
Assert.That(registry.UnregisterForNode(nodeId), Is.True);
Assert.That(
registry.Stores,
Contains.Item(shared),
"the store remains while a namespace binding still references it");
Assert.That(registry.Resolve(new NodeId(7u, (ushort)nsIndex)), Is.SameAs(shared));
}
[Test]
public void UnregisterNodeKeepsStoreWhenReferencedByAnotherNode()
{
using var registry = new NodeStateStoreRegistry(new NamespaceTable());
INodeStateStore shared = Mock.Of<INodeStateStore>();
var firstNode = new NodeId(1u);
var secondNode = new NodeId(2u);
registry.RegisterForNode(firstNode, shared);
registry.RegisterForNode(secondNode, shared);
Assert.That(registry.UnregisterForNode(firstNode), Is.True);
Assert.That(
registry.Stores,
Contains.Item(shared),
"the store remains while another node binding still references it");
Assert.That(registry.Resolve(secondNode), Is.SameAs(shared));
}
[Test]
public void DisposeDisposesDisposableStores()
{
var registry = new NodeStateStoreRegistry(new NamespaceTable());
var disposable = new Mock<INodeStateStore>();
Mock<IDisposable> disposer = disposable.As<IDisposable>();
INodeStateStore plain = Mock.Of<INodeStateStore>();
registry.RegisterDefault(disposable.Object);
registry.RegisterForNode(new NodeId(1u), plain);
registry.Dispose();
disposer.Verify(d => d.Dispose(), Times.Once);
Assert.That(registry.Stores, Is.Empty, "disposal clears all bindings");
}
}
}